embulk-output-td 0.1.4 → 0.1.5

data/src/main/java/com/treasuredata/api/TdApiExecutionInterruptedException.java

@@ -9,7 +9,8 @@ public class TdApiExecutionInterruptedException
     }
 
     @Override
-    public InterruptedException getCause() {
+    public InterruptedException getCause()
+    {
         return (InterruptedException) super.getCause();
     }
 }

data/src/main/java/com/treasuredata/api/TdApiExecutionTimeoutException.java

@@ -11,7 +11,8 @@ public class TdApiExecutionTimeoutException
     }
 
     @Override
-    public TimeoutException getCause() {
+    public TimeoutException getCause()
+    {
         return (TimeoutException) super.getCause();
     }
 }

data/src/main/java/com/treasuredata/api/model/TDArrayColumnType.java

@@ -20,7 +20,7 @@ public class TDArrayColumnType
     @Override
     public String toString()
     {
-        return "array<"+elementType+">";
+        return "array<" + elementType + ">";
     }
 
     @Override

data/src/main/java/com/treasuredata/api/model/TDBulkImportSession.java

@@ -143,13 +143,15 @@ public class TDBulkImportSession
 
     public String getErrorMessage()
     {
-        if (validRecords == 0)
+        if (validRecords == 0) {
             return "No record processed";
-        if (errorRecords > 0)
+        }
+        if (errorRecords > 0) {
             return String.format("%d invalid parts", errorParts);
-        if (errorRecords > 0)
+        }
+        if (errorRecords > 0) {
             return String.format("%d invalid records", errorRecords);
-
+        }
         return null;
     }
 }

data/src/main/java/com/treasuredata/api/model/TDColumn.java

@@ -43,13 +43,15 @@ public class TDColumn
                     TDColumnTypeDeserializer.parseColumnType(tuple[1]),
                     tuple[0].getBytes());
 
-        } else if (tuple != null && tuple.length == 3) {
+        }
+        else if (tuple != null && tuple.length == 3) {
             return new TDColumn(
                     tuple[0],
                     TDColumnTypeDeserializer.parseColumnType(tuple[1]),
                     tuple[2].getBytes());
 
-        } else {
+        }
+        else {
             throw new RuntimeJsonMappingException("Unexpected string tuple to deserialize TDColumn");
         }
     }

data/src/main/java/com/treasuredata/api/model/TDColumnTypeDeserializer.java

@@ -39,19 +39,24 @@ public class TDColumnTypeDeserializer
         if (p.scan("string")) {
             return TDPrimitiveColumnType.STRING;
 
-        } else if (p.scan("int")) {
+        }
+        else if (p.scan("int")) {
             return TDPrimitiveColumnType.INT;
 
-        } else if (p.scan("long")) {
+        }
+        else if (p.scan("long")) {
             return TDPrimitiveColumnType.LONG;
 
-        } else if (p.scan("double")) {
+        }
+        else if (p.scan("double")) {
             return TDPrimitiveColumnType.DOUBLE;
 
-        } else if (p.scan("float")) {
+        }
+        else if (p.scan("float")) {
             return TDPrimitiveColumnType.FLOAT;
 
-        } else if (p.scan("array")) {
+        }
+        else if (p.scan("array")) {
             if (!p.scan("<")) {
                 throw new IllegalArgumentException("Cannot parse type: expected '<' for array type: " + p.getString());
             }
@@ -61,7 +66,8 @@ public class TDColumnTypeDeserializer
             }
             return new TDArrayColumnType(elementType);
 
-        } else if (p.scan("map")) {
+        }
+        else if (p.scan("map")) {
             if (!p.scan("<")) {
                 throw new IllegalArgumentException("Cannot parse type: expected '<' for map type: " + p.getString());
             }
@@ -75,24 +81,29 @@ public class TDColumnTypeDeserializer
             }
             return new TDMapColumnType(keyType, valueType);
 
-        } else {
+        }
+        else {
             throw new IllegalArgumentException("Cannot parse type: " + p.getString());
         }
     }
 
-    private static class Parser {
+    private static class Parser
+    {
         private final String string;
         private int offset;
 
-        public Parser(String string) {
+        public Parser(String string)
+        {
             this.string = string;
         }
 
-        public String getString() {
+        public String getString()
+        {
             return string;
         }
 
-        public boolean scan(String s) {
+        public boolean scan(String s)
+        {
             skipSpaces();
             if (string.startsWith(s, offset)) {
                 offset += s.length();
@@ -101,12 +112,14 @@ public class TDColumnTypeDeserializer
             return false;
         }
 
-        public boolean eof() {
+        public boolean eof()
+        {
             skipSpaces();
             return string.length() <= offset;
         }
 
-        private void skipSpaces() {
+        private void skipSpaces()
+        {
             while (string.startsWith(" ", offset)) {
                 offset++;
             }

data/src/main/java/com/treasuredata/api/model/TDDatabase.java

@@ -22,7 +22,8 @@ public class TDDatabase
         return name;
     }
 
-    public boolean isWritable() {
+    public boolean isWritable()
+    {
         // TODO not implemented yet
         return true;
     }

data/src/main/java/com/treasuredata/api/model/TDMapColumnType.java

@@ -27,7 +27,7 @@ public class TDMapColumnType
     @Override
     public String toString()
     {
-        return "map<"+keyType+","+valueType+">";
+        return "map<" + keyType + "," + valueType + ">";
     }
 
     @Override

data/src/main/java/com/treasuredata/api/model/TDTablePermission.java

@@ -17,12 +17,14 @@ public class TDTablePermission
     }
 
     @JsonProperty("importable")
-    public boolean isImportable() {
+    public boolean isImportable()
+    {
         return importable;
     }
 
     @JsonProperty("queryable")
-    public boolean isQueryable() {
+    public boolean isQueryable()
+    {
         return queryable;
     }
 

data/src/main/java/com/treasuredata/api/model/TDTableType.java

@@ -21,7 +21,8 @@ public enum TDTableType
     {
         if ("log".equals(name)) {
             return LOG;
-        } else if ("item".equals(name)) {
+        }
+        else if ("item".equals(name)) {
             return ITEM;
         }
         throw new RuntimeJsonMappingException("Unexpected string tuple to deserialize TDTableType");

data/src/main/java/org/embulk/output/td/FinalizableExecutorService.java

@@ -17,7 +17,8 @@ public class FinalizableExecutorService
     {
         @Override
         public void close()
-                throws IOException {
+                throws IOException
+        {
             // ignore
         }
     }
@@ -25,58 +26,75 @@ public class FinalizableExecutorService
     protected ExecutorService threads;
     protected Queue<RunningTask> runningTasks;
 
-    public FinalizableExecutorService() {
+    public FinalizableExecutorService()
+    {
         this.threads = Executors.newCachedThreadPool();
         this.runningTasks = new LinkedList<>();
     }
 
-    private static class RunningTask {
+    private static class RunningTask
+    {
         private Future<Void> future;
         private Closeable finalizer;
 
-        RunningTask(Future<Void> future, Closeable finalizer) {
+        RunningTask(Future<Void> future, Closeable finalizer)
+        {
             this.future = future;
             this.finalizer = finalizer;
         }
 
-        public void join() throws IOException {
+        public void join()
+                throws IOException
+        {
             try {
                 future.get();
-            } catch (InterruptedException ex) {
-                throw new IOException(ex);
-            } catch (ExecutionException ex) {
-                throw new IOException(ex.getCause());
+            }
+            catch (InterruptedException e) {
+                throw new IOException(e);
+            }
+            catch (ExecutionException e) {
+                throw new IOException(e.getCause());
             }
             finalizer.close();
         }
 
-        public void abort() throws IOException {
+        public void abort()
+                throws IOException
+        {
             finalizer.close();
         }
     }
 
-    public void submit(Callable<Void> task, Closeable finalizer) {
+    public void submit(Callable<Void> task, Closeable finalizer)
+    {
         Future<Void> future = threads.submit(task);
         runningTasks.add(new RunningTask(future, finalizer));
     }
 
-    public void joinPartial(long upto) throws IOException {
-        while(runningTasks.size() > upto) {
+    public void joinPartial(long upto)
+            throws IOException
+    {
+        while (runningTasks.size() > upto) {
             runningTasks.peek().join();
             runningTasks.remove();
         }
     }
 
-    public void joinAll() throws IOException {
+    public void joinAll()
+            throws IOException
+    {
         joinPartial(0);
     }
 
-    public void shutdown() throws IOException {
+    public void shutdown()
+            throws IOException
+    {
         try {
             joinAll();
-        } finally {
+        }
+        finally {
             threads.shutdown();
-            for(RunningTask task : runningTasks) {
+            for (RunningTask task : runningTasks) {
                 task.abort();
             }
         }

data/src/main/java/org/embulk/output/td/MsgpackGZFileBuilder.java

@@ -1,6 +1,5 @@
 package org.embulk.output.td;
 
-import org.embulk.spi.Exec;
 import org.msgpack.MessagePack;
 import org.msgpack.packer.Packer;
 
@@ -18,29 +17,35 @@ import static com.google.common.base.Preconditions.checkNotNull;
 public class MsgpackGZFileBuilder
         implements Closeable
 {
-    static class DataSizeFilter extends FilterOutputStream {
+    static class DataSizeFilter
+            extends FilterOutputStream
+    {
         private long size = 0;
 
-        public DataSizeFilter(OutputStream out) {
+        public DataSizeFilter(OutputStream out)
+        {
             super(out);
         }
 
         @Override
-        public void write(int b) throws IOException
+        public void write(int b)
+                throws IOException
         {
             size += 1;
             super.write(b);
         }
 
         @Override
-        public void write(byte[] b, int off, int len) throws IOException
+        public void write(byte[] b, int off, int len)
+                throws IOException
         {
             size += len;
             super.write(b, off, len);
         }
 
         @Override
-        public void close() throws IOException
+        public void close()
+                throws IOException
         {
             super.close();
         }
@@ -94,7 +99,8 @@ public class MsgpackGZFileBuilder
     {
         try {
             packer.flush();
-        } finally {
+        }
+        finally {
             close();
         }
     }

data/src/main/java/org/embulk/output/td/RecordWriter.java

@@ -1,11 +1,12 @@
 package org.embulk.output.td;
 
-import com.google.common.base.Optional;
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Stopwatch;
 import com.google.common.base.Throwables;
 import com.treasuredata.api.TdApiClient;
 import org.embulk.config.CommitReport;
-import org.embulk.config.ConfigException;
+import org.embulk.output.td.writer.FieldWriter;
+import org.embulk.output.td.writer.FieldWriterSet;
 import org.embulk.spi.Column;
 import org.embulk.spi.ColumnVisitor;
 import org.embulk.spi.Exec;
@@ -13,16 +14,6 @@ import org.embulk.spi.Page;
 import org.embulk.spi.PageReader;
 import org.embulk.spi.Schema;
 import org.embulk.spi.TransactionalPageOutput;
-import org.embulk.spi.time.TimestampFormatter;
-import org.embulk.spi.type.BooleanType;
-import org.embulk.spi.type.DoubleType;
-import org.embulk.spi.type.LongType;
-import org.embulk.spi.type.StringType;
-import org.embulk.spi.type.TimestampType;
-import org.embulk.spi.type.Type;
-import org.embulk.spi.util.Timestamps;
-import org.joda.time.DateTimeZone;
-import org.jruby.embed.ScriptingContainer;
 import org.msgpack.MessagePack;
 import org.slf4j.Logger;
 
@@ -91,6 +82,12 @@ public class RecordWriter
         this.builder = new MsgpackGZFileBuilder(msgpack, tempFile);
     }
 
+    @VisibleForTesting
+    MsgpackGZFileBuilder getBuilder()
+    {
+        return builder;
+    }
+
     @Override
     public void add(final Page page)
     {
@@ -136,7 +133,8 @@ public class RecordWriter
                         FieldWriter fieldWriter = fieldWriters.getFieldWriter(column.getIndex());
                         try {
                             fieldWriter.writeKeyValue(builder, pageReader, column);
-                        } catch (IOException e) {
+                        }
+                        catch (IOException e) {
                             throw Throwables.propagate(e);
                         }
                     }
@@ -150,7 +148,8 @@ public class RecordWriter
                 }
             }
 
-        } catch (IOException e) {
+        }
+        catch (IOException e) {
             throw Throwables.propagate(e);
         }
     }
@@ -206,9 +205,11 @@ public class RecordWriter
     {
         try {
             flush();
-        } catch (IOException e) {
+        }
+        catch (IOException e) {
             throw Throwables.propagate(e);
-        } finally {
+        }
+        finally {
             close();
         }
     }
@@ -220,7 +221,8 @@ public class RecordWriter
             try {
                 executor.joinAll();
                 executor.shutdown(); // shutdown calls joinAll
-            } finally {
+            }
+            finally {
                 if (builder != null) {
                     builder.close();
                     builder.delete();
@@ -231,7 +233,8 @@ public class RecordWriter
                     client.close();
                 }
             }
-        } catch (IOException e) {
+        }
+        catch (IOException e) {
             throw Throwables.propagate(e);
         }
     }
@@ -249,368 +252,4 @@ public class RecordWriter
         //  TODO
         return report;
     }
-
-    static class FieldWriterSet
-    {
-        private enum ColumnWriterMode
-        {
-            PRIMARY_KEY,
-            SIMPLE_VALUE,
-            DUPLICATE_PRIMARY_KEY;
-        }
-
-        private final int fieldCount;
-        private final FieldWriter[] fieldWriters;
-
-        public FieldWriterSet(Logger log, TdOutputPlugin.PluginTask task, Schema schema)
-        {
-            Optional<String> userDefinedPrimaryKeySourceColumnName = task.getTimeColumn();
-            boolean hasPkWriter = false;
-            int duplicatePrimaryKeySourceIndex = -1;
-            int firstTimestampColumnIndex = -1;
-
-            int fc = 0;
-            fieldWriters = new FieldWriter[schema.size()];
-            TimestampFormatter[] timestampFormatters = Timestamps.newTimestampColumnFormatters(task, schema, task.getColumnOptions());
-
-            for (int i = 0; i < schema.size(); i++) {
-                String columnName = schema.getColumnName(i);
-                Type columnType = schema.getColumnType(i);
-
-                // choose the mode
-                final ColumnWriterMode mode;
-
-                if (userDefinedPrimaryKeySourceColumnName.isPresent() &&
-                        columnName.equals(userDefinedPrimaryKeySourceColumnName.get())) {
-                    // found time_column
-                    if ("time".equals(userDefinedPrimaryKeySourceColumnName.get())) {
-                        mode = ColumnWriterMode.PRIMARY_KEY;
-                    } else {
-                        mode = ColumnWriterMode.DUPLICATE_PRIMARY_KEY;
-                    }
-
-                } else if ("time".equals(columnName)) {
-                    // the column name is same with the primary key name.
-                    if (userDefinedPrimaryKeySourceColumnName.isPresent()) {
-                        columnName = newColumnUniqueName(columnName, schema);
-                        mode = ColumnWriterMode.SIMPLE_VALUE;
-                        log.warn("time_column '{}' is set but 'time' column also exists. The existent 'time' column is renamed to {}",
-                                userDefinedPrimaryKeySourceColumnName.get(), "time", "time", columnName);
-                    } else {
-                        mode = ColumnWriterMode.PRIMARY_KEY;
-                    }
-
-                } else {
-                    mode = ColumnWriterMode.SIMPLE_VALUE;
-                }
-
-                // create the fieldWriters writer depending on the mode
-                final FieldWriter writer;
-
-                switch (mode) {
-                    case PRIMARY_KEY:
-                        log.info("Using {}:{} column as the data partitioning key", columnName, columnType);
-                        if (columnType instanceof LongType) {
-                            if (task.getUnixTimestampUnit() != TdOutputPlugin.UnixTimestampUnit.SEC) {
-                                log.warn("time column is converted from {} to seconds", task.getUnixTimestampUnit());
-                            }
-                            writer = new UnixTimestampLongFieldWriter(columnName, task.getUnixTimestampUnit().getFractionUnit());
-                            hasPkWriter = true;
-                        } else if (columnType instanceof TimestampType) {
-                            writer = new TimestampLongFieldWriter(columnName);
-
-                            hasPkWriter = true;
-                        } else {
-                            throw new ConfigException(String.format("Type of '%s' column must be long or timestamp but got %s",
-                                    columnName, columnType));
-                        }
-                        break;
-
-                    case SIMPLE_VALUE:
-                        if (columnType instanceof BooleanType) {
-                            writer = new BooleanFieldWriter(columnName);
-                        } else if (columnType instanceof LongType) {
-                            writer = new LongFieldWriter(columnName);
-                        } else if (columnType instanceof DoubleType) {
-                            writer = new DoubleFieldWriter(columnName);
-                        } else if (columnType instanceof StringType) {
-                            writer = new StringFieldWriter(columnName);
-                        } else if (columnType instanceof TimestampType) {
-                            writer = new TimestampStringFieldWriter(timestampFormatters[i], columnName);
-                            if (firstTimestampColumnIndex < 0) {
-                                firstTimestampColumnIndex = i;
-                            }
-                        } else {
-                            throw new ConfigException("Unsupported type: " + columnType);
-                        }
-                        break;
-
-                    case DUPLICATE_PRIMARY_KEY:
-                        duplicatePrimaryKeySourceIndex = i;
-                        writer = null;  // handle later
-                        break;
-
-                    default:
-                        throw new AssertionError();
-                }
-
-                fieldWriters[i] = writer;
-                fc += 1;
-            }
-
-            if (!hasPkWriter) {
-                // PRIMARY_KEY was not found.
-                if (duplicatePrimaryKeySourceIndex < 0) {
-                    if (userDefinedPrimaryKeySourceColumnName.isPresent()) {
-                        throw new ConfigException(String.format("time_column '%s' does not exist", userDefinedPrimaryKeySourceColumnName.get()));
-                    } else if (firstTimestampColumnIndex >= 0) {
-                        // if time is not found, use the first timestamp column
-                        duplicatePrimaryKeySourceIndex = firstTimestampColumnIndex;
-                    } else {
-                        throw new ConfigException(String.format("TD output plugin requires at least one timestamp column, or a long column named 'time'"));
-                    }
-                }
-
-                String columnName = schema.getColumnName(duplicatePrimaryKeySourceIndex);
-                Type columnType = schema.getColumnType(duplicatePrimaryKeySourceIndex);
-
-                FieldWriter writer;
-                if (columnType instanceof LongType) {
-                    log.info("Duplicating {}:{} column (unix timestamp {}) to 'time' column as seconds for the data partitioning",
-                            columnName, columnType, task.getUnixTimestampUnit());
-                    writer = new UnixTimestampFieldDuplicator(columnName, "time", task.getUnixTimestampUnit().getFractionUnit());
-                } else if (columnType instanceof TimestampType) {
-                    log.info("Duplicating {}:{} column to 'time' column as seconds for the data partitioning",
-                            columnName, columnType);
-                    writer = new TimestampFieldLongDuplicator(timestampFormatters[duplicatePrimaryKeySourceIndex], columnName, "time");
-                } else {
-                    throw new ConfigException(String.format("Type of '%s' column must be long or timestamp but got %s",
-                            columnName, columnType));
-                }
-
-                // replace existint writer
-                fieldWriters[duplicatePrimaryKeySourceIndex] = writer;
-                fc += 1;
-            }
-
-            fieldCount = fc;
-        }
-
-        private static String newColumnUniqueName(String originalName, Schema schema)
-        {
-            String name = originalName;
-            do {
-                name += "_";
-            } while (containsColumnName(schema, name));
-            return name;
-        }
-
-        private static boolean containsColumnName(Schema schema, String name)
-        {
-            for (Column c : schema.getColumns()) {
-                if (c.getName().equals(name)) {
-                    return true;
-                }
-            }
-            return false;
-        }
-
-        public FieldWriter getFieldWriter(int index)
-        {
-            return fieldWriters[index];
-        }
-
-        public int getFieldCount()
-        {
-            return fieldCount;
-        }
-    }
-
-    static abstract class FieldWriter
-    {
-        private final String keyName;
-
-        protected FieldWriter(String keyName)
-        {
-            this.keyName = keyName;
-        }
-
-        public void writeKeyValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            writeKey(builder);
-            if (reader.isNull(column)) {
-                builder.writeNil();
-            } else {
-                writeValue(builder, reader, column);
-            }
-        }
-
-        private void writeKey(MsgpackGZFileBuilder builder)
-                throws IOException
-        {
-            builder.writeString(keyName);
-        }
-
-        protected abstract void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException;
-    }
-
-    static class DoubleFieldWriter
-            extends FieldWriter
-    {
-        public DoubleFieldWriter(String keyName)
-        {
-            super(keyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeDouble(reader.getDouble(column));
-        }
-    }
-
-    static class BooleanFieldWriter
-            extends FieldWriter
-    {
-        public BooleanFieldWriter(String keyName)
-        {
-            super(keyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeBoolean(reader.getBoolean(column));
-        }
-    }
-
-    static class LongFieldWriter
-            extends FieldWriter
-    {
-        LongFieldWriter(String keyName)
-        {
-            super(keyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeLong(reader.getLong(column));
-        }
-    }
-
-    static class UnixTimestampLongFieldWriter
-            extends FieldWriter
-    {
-        private final int fractionUnit;
-
-        UnixTimestampLongFieldWriter(String keyName, int fractionUnit)
-        {
-            super(keyName);
-            this.fractionUnit = fractionUnit;
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeLong(reader.getLong(column) / fractionUnit);
-        }
-    }
-
-    static class StringFieldWriter
-            extends FieldWriter
-    {
-        public StringFieldWriter(String keyName)
-        {
-            super(keyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeString(reader.getString(column));
-        }
-    }
-
-    static class TimestampStringFieldWriter
-            extends FieldWriter
-    {
-        private final TimestampFormatter formatter;
-
-        public TimestampStringFieldWriter(TimestampFormatter formatter, String keyName)
-        {
-            super(keyName);
-            this.formatter = formatter;
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeString(formatter.format(reader.getTimestamp(column)));
-        }
-    }
-
-    static class TimestampLongFieldWriter
-            extends FieldWriter
-    {
-        public TimestampLongFieldWriter(String keyName)
-        {
-            super(keyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            builder.writeLong(reader.getTimestamp(column).getEpochSecond());
-        }
-    }
-
-    static class UnixTimestampFieldDuplicator
-            extends LongFieldWriter
-    {
-        private final UnixTimestampLongFieldWriter timeFieldWriter;
-
-        public UnixTimestampFieldDuplicator(String keyName, String duplicateKeyName, int fractionUnit)
-        {
-            super(keyName);
-            timeFieldWriter = new UnixTimestampLongFieldWriter(duplicateKeyName, fractionUnit);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            super.writeValue(builder, reader, column);
-            timeFieldWriter.writeKeyValue(builder, reader, column);
-        }
-    }
-
-    static class TimestampFieldLongDuplicator
-            extends TimestampStringFieldWriter
-    {
-        private final TimestampLongFieldWriter timeFieldWriter;
-
-        public TimestampFieldLongDuplicator(TimestampFormatter formatter, String keyName, String longDuplicateKeyName)
-        {
-            super(formatter, keyName);
-            timeFieldWriter = new TimestampLongFieldWriter(longDuplicateKeyName);
-        }
-
-        @Override
-        public void writeValue(MsgpackGZFileBuilder builder, PageReader reader, Column column)
-                throws IOException
-        {
-            super.writeValue(builder, reader, column);
-            timeFieldWriter.writeKeyValue(builder, reader, column);
-        }
-    }
 }