embulk-output-oracle 0.2.4 → 0.3.0

data/src/main/java/org/embulk/output/OracleOutputPlugin.java

@@ -1,35 +1,29 @@
 package org.embulk.output;
 
+import java.util.List;
+import java.util.Properties;
 import java.io.IOException;
-import java.lang.UnsupportedOperationException;
+import java.nio.ByteBuffer;
 import java.sql.SQLException;
-import java.util.Properties;
-
+import com.google.common.base.Optional;
+import com.google.common.collect.ImmutableSet;
 import org.embulk.config.Config;
 import org.embulk.config.ConfigDefault;
-import org.embulk.config.ConfigException;
 import org.embulk.output.jdbc.AbstractJdbcOutputPlugin;
 import org.embulk.output.jdbc.BatchInsert;
 import org.embulk.output.jdbc.JdbcOutputConnection;
 import org.embulk.output.jdbc.JdbcOutputConnector;
 import org.embulk.output.jdbc.StandardBatchInsert;
-import org.embulk.output.jdbc.setter.ColumnSetterFactory;
 import org.embulk.output.oracle.DirectBatchInsert;
 import org.embulk.output.oracle.InsertMethod;
 import org.embulk.output.oracle.OracleCharset;
 import org.embulk.output.oracle.OracleOutputConnection;
 import org.embulk.output.oracle.OracleOutputConnector;
-import org.embulk.output.oracle.setter.OracleColumnSetterFactory;
 import org.embulk.spi.PageReader;
-import org.embulk.spi.time.TimestampFormatter;
-
-import com.google.common.base.Optional;
 
 public class OracleOutputPlugin
         extends AbstractJdbcOutputPlugin
 {
-    private static final int MAX_TABLE_NAME_LENGTH = 30;
-
     public interface OraclePluginTask
             extends PluginTask
     {
@@ -71,6 +65,15 @@ public class OracleOutputPlugin
         return OraclePluginTask.class;
     }
 
+    @Override
+    protected Features getFeatures(PluginTask task)
+    {
+        return new Features()
+            .setMaxTableNameLength(30)
+            .setSupportedModes(ImmutableSet.of(Mode.INSERT, Mode.INSERT_DIRECT, Mode.TRUNCATE_INSERT, Mode.REPLACE))
+            .setIgnoreMergeKeys(false);
+    }
+
     @Override
     protected OracleOutputConnector getConnector(PluginTask task, boolean retryableMetadataOperation)
     {
@@ -111,18 +114,20 @@ public class OracleOutputPlugin
         }
 
         Properties props = new Properties();
+        props.putAll(oracleTask.getOptions());
+
         props.setProperty("user", oracleTask.getUser());
+        logger.info("Connecting to {} options {}", url, props);
         props.setProperty("password", oracleTask.getPassword());
-        props.putAll(oracleTask.getOptions());
 
         return new OracleOutputConnector(url, props, oracleTask.getInsertMethod() == InsertMethod.direct);
     }
 
     @Override
-    protected BatchInsert newBatchInsert(PluginTask task) throws IOException, SQLException
+    protected BatchInsert newBatchInsert(PluginTask task, Optional<List<String>> mergeKeys) throws IOException, SQLException
     {
-        if (task.getMode().isMerge()) {
-            throw new UnsupportedOperationException("mode 'merge' is not implemented for this type");
+        if (mergeKeys.isPresent()) {
+            throw new UnsupportedOperationException("Oracle output plugin doesn't support 'merge_direct' mode.");
         }
 
         OraclePluginTask oracleTask = (OraclePluginTask) task;
@@ -131,7 +136,7 @@ public class OracleOutputPlugin
         if (oracleTask.getInsertMethod() == InsertMethod.oci) {
             OracleCharset charset;
             try (JdbcOutputConnection connection = connector.connect(true)) {
-                charset = ((OracleOutputConnection)connection).getCharset();
+                charset = ((OracleOutputConnection)connection).getOracleCharset();
             }
 
             return new DirectBatchInsert(
@@ -143,55 +148,6 @@ public class OracleOutputPlugin
                     oracleTask.getBatchSize());
         }
 
-        return new StandardBatchInsert(getConnector(task, true));
+        return new StandardBatchInsert(getConnector(task, true), mergeKeys);
     }
-
-    @Override
-    protected ColumnSetterFactory newColumnSetterFactory(BatchInsert batch, PageReader pageReader,
-            TimestampFormatter timestampFormatter)
-    {
-        return new OracleColumnSetterFactory(batch, pageReader, timestampFormatter);
-    }
-
-    @Override
-    protected String generateSwapTableName(PluginTask task) throws SQLException
-    {
-        return generateSwapTableName(task, "_bl_tmp", MAX_TABLE_NAME_LENGTH);
-    }
-
-    // TODO move this method to AbstractJdbcOutputPlugin
-    protected String generateSwapTableName(PluginTask task, String suffix, int maxTableNameLength) throws SQLException
-    {
-        String tableName = task.getTable();
-        String uniqueSuffix = getTransactionUniqueName() + suffix;
-
-        if (tableName.length() + uniqueSuffix.length() + 1 > maxTableNameLength) {  // + 1 for '_'
-            // truncate transaction unique name
-            int suffixLength = Math.max(maxTableNameLength - tableName.length() - 1, suffix.length() + 8);  // include 8 characters of the transaction name at least
-            uniqueSuffix = uniqueSuffix.substring(uniqueSuffix.length() - suffixLength);
-        }
-
-        if (tableName.length() + uniqueSuffix.length() + 1 > maxTableNameLength) {
-            // use truncated table name
-            int truncLength = maxTableNameLength - uniqueSuffix.length() - 1;
-            while (true) {
-                truncLength--;
-                if (truncLength <= 0) {
-                    throw new ConfigException("Table name is too long to generate temporary table name");
-                }
-                tableName = tableName.substring(0, truncLength);
-                //if (!connection.tableExists(tableName)) {
-                    // TODO this doesn't help. Rather than truncating more characters,
-                    //      here needs to replace characters with random characters. But
-                    //      to make the result deterministic. So, an idea is replacing
-                    //      the last character to the first (second, third, ... for each loop)
-                    //      of md5(original table name).
-                    return tableName + "_" + uniqueSuffix;
-                //}
-            }
-        }
-
-        return tableName + "_" + uniqueSuffix;
-    }
-
 }