embulk-input-mixpanel 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e5d08021cb9b3e4518546d44eeff78eab3a6e344
-  data.tar.gz: 55b1de01d58db4f50755996917f7f40fdc0fdd33
+  metadata.gz: f5341d3459ab9ebb11548c637781a2e56f8f827d
+  data.tar.gz: fddc31638fbfc95d804b140e91a79a880e2fd0c8
 SHA512:
-  metadata.gz: 10814321b400f21bfc54acb2005c671265e0fb5a803ab221c7fa5a9dbb02a513a18ea144a1e4dbf9fa92c964b71ca7655f86a2ff866c106df6a5079628b5d3d3
-  data.tar.gz: 85adb7eeac61dec517c2010300e8fa1a58eb0159c86fbe17d0b34ab12209e774fa15ce4bd425f79d495a087519554b46d0eb07627d03d8e601697b2fa212e275
+  metadata.gz: ddd3e72b06554148f5bf7e866823aa3e65004ef317f7a55df269c41499515f8b23b63f4571c565bbe0123871bb1cc0d9451fc25f36939f1f5974737699152730
+  data.tar.gz: c59a6e927cb172562d0ecead325d4f8c5359f6bec34f672673abdf9a061b9e7aeecc617f820f99beffed30171fa038a8fa25a917f9bf82e923a49cb9a7405ac8

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.5.4 - 2017-08-15
+* [bug] Fix a bug when `fetch_days` is 1 plugin will fetch 2 days instead of 1
+
 ## 0.5.3 - 2017-08-07
 * [enhancement] Allow user to choose to run incremental or not `incremental` option default to true [#50](https://github.com/treasure-data/embulk-input-mixpanel/pull/50)
 * [enhancement] Allow user to specify an `incremental_column`, which will be add to the where praramter is API requests[#50](https://github.com/treasure-data/embulk-input-mixpanel/pull/50)

data/embulk-input-mixpanel.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "embulk-input-mixpanel"
-  spec.version       = "0.5.3"
+  spec.version       = "0.5.4"
   spec.authors       = ["yoshihara", "uu59"]
   spec.summary       = "Mixpanel input plugin for Embulk"
   spec.description   = "Loads records from Mixpanel."

data/lib/embulk/input/mixpanel.rb

@@ -102,6 +102,7 @@ module Embulk
         if task[:incremental]
           task_report = task_reports.first
           next_to_date = Date.parse(task_report[:to_date])
+
           next_config_diff = {
             from_date: next_to_date.to_s,
             latest_fetched_time: task_report[:latest_fetched_time],

data/lib/range_generator.rb

@@ -47,7 +47,7 @@ class RangeGenerator
     end
 
     if fetch_days
-      from_date..(from_date + (fetch_days > 1? fetch_days - 1 : fetch_days))
+      from_date..(from_date + fetch_days - 1)
     else
       from_date..today
     end

data/test/embulk/input/test_mixpanel.rb

@@ -314,6 +314,13 @@ module Embulk
             Mixpanel.transaction(transaction_config(days), &control)
           end
 
+          def test_next_to_date
+            next_config_diff = Mixpanel.resume(transaction_task(1).merge(incremental: true), columns, 1) do
+              [{to_date: Date.today.to_s, latest_fetched_time: 1502707247000}]
+            end
+            assert_equal(Date.today.to_s, next_config_diff[:from_date])
+          end
+
           def test_valid_days_with_backfill
             days = 5
 

data/test/prepare_embulk.rb

@@ -1,3 +1,4 @@
+require "embulk"
 module PrepareEmbulk
   if Embulk.respond_to?(:home)
     # keep compatibility for Embulk 0.6.x
@@ -7,9 +8,7 @@ module PrepareEmbulk
       require File.join(classpath_dir, jar)
     end
     require "embulk/java/bootstrap"
-    require "embulk"
   else
-    require "embulk"
     Embulk.setup
   end
 end

data/test/test_range_generator.rb

@@ -30,6 +30,26 @@ class RangeGeneratorTest < Test::Unit::TestCase
       assert_equal(expected, actual)
     end
 
+    def test_1_fetch_day
+      days = 1
+      from = "2017-08-04"
+      expected_from = Date.parse(from)
+      expected_to = Date.parse("2017-08-04")
+      expected = (expected_from..expected_to).to_a.map {|date| date.to_s}
+      actual = RangeGenerator.new(from, days).generate_range
+      assert_equal(expected, actual)
+    end
+
+    def test_5_fetch_day
+      days = 5
+      from = "2017-08-04"
+      expected_from = Date.parse(from)
+      expected_to = Date.parse("2017-08-08")
+      expected = (expected_from..expected_to).to_a.map {|date| date.to_s}
+      actual = RangeGenerator.new(from, days).generate_range
+      assert_equal(expected, actual)
+    end
+
     class OverDaysTest < self
       def setup
         @from = Date.today - 5

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: embulk-input-mixpanel
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - yoshihara
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-08-07 00:00:00.000000000 Z
+date: 2017-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -224,7 +224,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.4.8
+rubygems_version: 2.6.12
 signing_key:
 specification_version: 4
 summary: Mixpanel input plugin for Embulk