embulk-input-marketo 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f71b3f65dab9d932934f09d2c5e9b47f9702613
-  data.tar.gz: d951b2cd6e46bedbbdf2f7ea4c25803c3f470d20
+  metadata.gz: 17a277c0df4feaded10161dcf1ed102720aec4e4
+  data.tar.gz: a80c7582a7c4fdd2becd1e4c34ae612b7379d7c7
 SHA512:
-  metadata.gz: dd33daed69356a087369dee73c6381dea6e61488227f5aaff52f705168241a97011bb77ed5c6b35ede7dbb3352dfcb03e7c206612f9b9b75dfb5d6ca81727c40
-  data.tar.gz: 02c17f9f3d72b8586a9479bed842b24fa2f2205a82b5a05b535ed291df84bf3b385a0e2d9638da3a924061e97b72db9533a47dd304466b9ebff65ac805772af7
+  metadata.gz: c613c70701ccc188deac206d407954804632353ab1fe11fd79bdf1294426e5cbc42b19a7b021d28345cfb93f810e6a7701163d65c6ec2604742fc3beafc9635b
+  data.tar.gz: af31cd4811d5e8bd3bb3e54977d52e80e295d7770fd7f3b3d0929a7ebe777d455d24714c6ef60f9b8d91e64f710911eb3acf22b03bd2b766247cca28fb6aabec

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.2.2 - 2015-09-08
+
+* [fixed] Fix handling for activity_date_time [#32](https://github.com/treasure-data/embulk-input-marketo/pull/32)
+
 ## 0.2.1 - 2015-09-01
 
 * [fixed] activity_log: Avoid to cast values unexpectedly [#29](https://github.com/treasure-data/embulk-input-marketo/pull/29)

data/embulk-input-marketo.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "embulk-input-marketo"
-  spec.version       = "0.2.1"
+  spec.version       = "0.2.2"
   spec.authors       = ["uu59", "yoshihara"]
   spec.summary       = "Marketo input plugin for Embulk"
   spec.description   = "Loads records from Marketo."

data/lib/embulk/input/marketo/activity_log.rb

@@ -39,7 +39,7 @@ module Embulk
               value = activity_log[name]
               next unless value
 
-              case column["type"]
+              case column["type"].to_s
               when "timestamp"
                 Time.parse(value)
               else

data/lib/embulk/input/marketo_api/soap/activity_log.rb

@@ -69,8 +69,7 @@ module Embulk
             activities.each do |activity|
               record = {
                 "id" => activity[:id],
-                # embulk can't treat DateTime
-                "activity_date_time" => Time.parse(activity[:activity_date_time]),
+                "activity_date_time" => activity[:activity_date_time],
                 "activity_type" => activity[:activity_type],
                 "mktg_asset_name" => activity[:mktg_asset_name],
                 "mkt_person_id" => activity[:mkt_person_id],

data/test/activity_log_fixtures.rb

@@ -31,7 +31,7 @@ module ActivityLogFixtures
       remaining_count: "1",
       new_start_position: {
         latest_created_at: true,
-        oldest_created_at: "2015-07-14T00:13:13+00:00",
+        oldest_created_at: "2015-07-14T00:13:13+0000",
         activity_created_at: true,
         offset: offset,
       },
@@ -39,7 +39,7 @@ module ActivityLogFixtures
         lead_change_record: [
           {
             id: "1",
-            activity_date_time: "2015-07-14T00:00:09+00:00",
+            activity_date_time: "2015-07-14T00:00:09+0000",
             activity_type: "at1",
             mktg_asset_name: "score1",
             activity_attributes: {
@@ -60,7 +60,7 @@ module ActivityLogFixtures
           },
           {
             id: "2",
-            activity_date_time: "2015-07-14T00:00:10+00:00",
+            activity_date_time: "2015-07-14T00:00:10+0000",
             activity_type: "at2",
             mktg_asset_name: "score2",
             activity_attributes: {
@@ -98,7 +98,7 @@ module ActivityLogFixtures
         lead_change_record: [
           {
             id: "3",
-            activity_date_time: "2015-07-14T00:00:11+00:00",
+            activity_date_time: "2015-07-14T00:00:11+0000",
             activity_type: "at3",
             mktg_asset_name: "score3",
             activity_attributes: {
@@ -126,7 +126,7 @@ module ActivityLogFixtures
     records = (1..15).map do |i|
       {
         id: i,
-        activity_date_time: "2015-07-14T00:00:11+00:00",
+        activity_date_time: "2015-07-14T00:00:11+0000",
         activity_type: "at#{i}",
         mktg_asset_name: "score#{i}",
         activity_attributes: {

data/test/embulk/input/marketo/test_activity_log.rb

@@ -102,9 +102,9 @@ module Embulk
               end
             end
 
-            mock(@page_builder).add(["1", Time.parse("2015-07-14 09:00:09 +0900"), "at1", "score1", "100", "Attribute1", "402"])
-            mock(@page_builder).add(["2", Time.parse("2015-07-14 09:00:10 +0900"), "at2", "score2", "90", "Attribute2", "403"])
-            mock(@page_builder).add(["3", Time.parse("2015-07-14 09:00:11 +0900"), "at3", "score3", "100", "Attribute3", "404"])
+            mock(@page_builder).add(["1", Time.parse("2015-07-14T00:00:09+0000"), "at1", "score1", "100", "Attribute1", "402"])
+            mock(@page_builder).add(["2", Time.parse("2015-07-14T00:00:10+0000"), "at2", "score2", "90", "Attribute2", "403"])
+            mock(@page_builder).add(["3", Time.parse("2015-07-14T00:00:11+0000"), "at3", "score3", "100", "Attribute3", "404"])
             mock(@page_builder).finish
 
             @plugin.run
@@ -134,7 +134,7 @@ module Embulk
             end
 
             1.upto(ActivityLog::PREVIEW_COUNT) do |count|
-              mock(@page_builder).add([count, Time.parse("2015-07-14 09:00:11 +0900"), "at#{count}", "score#{count}", "100", "Attribute#{count}", "404"])
+              mock(@page_builder).add([count, Time.parse("2015-07-14T00:00:11+0000"), "at#{count}", "score#{count}", "100", "Attribute#{count}", "404"])
             end
             mock(@page_builder).finish
 

data/test/embulk/input/marketo_api/soap/test_activity_log.rb

@@ -89,7 +89,7 @@ module Embulk
             def schema
               metadata = [
                 {index: 0, name: "id", type: :long},
-                {index: 1, name: "activity_date_time", type: :timestamp, format: "%Y-%m-%d %H:%M:%S %z"},
+                {index: 1, name: "activity_date_time", type: :timestamp, format: "%Y-%m-%dT%H:%M:%S%z"}, # NOTE: `format` is the same as-is response (e.g. "2015-07-14T00:00:11+0000" to "%Y-%m-%dT%H:%M:%S%z")
                 {index: 2, name: "activity_type", type: :string},
                 {index: 3, name: "mktg_asset_name", type: :string},
                 {index: 4, name: "mkt_person_id", type: :long},

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: embulk-input-marketo
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - uu59
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-09-01 00:00:00.000000000 Z
+date: 2015-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement