embulk-input-jdbc 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 266e103762b852c24503fb2a83616a78bd07a235
-  data.tar.gz: 01314fad5353c44cdf63c3cf59c5ae1f029c7c2f
+  metadata.gz: 04a66446f33cb93478fac400edddfde76fc16a3b
+  data.tar.gz: b8bcffe863fa757da3124c6a6d9b82b317d0662f
 SHA512:
-  metadata.gz: 3004de01d140d8920f8be786fc2e58f14bf3b9ddff09f1a9e59b5ebe4c8f4a5db582af57431193e9427b664de3c9fe660d78cea1de2fea66c8579ddd0c882c59
-  data.tar.gz: 30b3caa6cc8ac3a25f520d2386bb3134be88678d3a3287197fae630acaee6163e8ab84618e4d56341bd03428537122bec231b58d4c019e46022da1e20e2851be
+  metadata.gz: f20fedd3f5d22ac57067b83e4dbd6038c5f69acca74a810af84934e1a988dd5acc3ae16afe960324f929a37e2c7bbbd8e6194de4f1195632446001a5915d78ee
+  data.tar.gz: 4176be4dafda7373475ccd04e198ed27c809b1853590617ac10f3da1c058082ea61169bff33791f0f431ccdfb8ee46b564ebe96c312a22382877354ece647e04

data/src/main/java/org/embulk/input/jdbc/AbstractJdbcInputPlugin.java

@@ -4,6 +4,7 @@ import java.util.List;
 import java.util.Properties;
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import org.slf4j.Logger;
 import com.google.common.base.Optional;
 import com.google.common.base.Throwables;
 import com.google.common.collect.ImmutableList;
@@ -29,6 +30,8 @@ import org.embulk.input.jdbc.JdbcInputConnection.BatchSelect;
 public abstract class AbstractJdbcInputPlugin
         implements InputPlugin
 {
+    private final Logger logger = Exec.getLogger(getClass());
+
     public interface PluginTask extends Task
     {
         @Config("host")
@@ -145,7 +148,6 @@ public abstract class AbstractJdbcInputPlugin
         } catch (SQLException ex) {
             throw Throwables.propagate(ex);
         }
-        System.out.println("schema: "+schema);
 
         return buildNextConfigDiff(task, control.run(task.dump(), schema, 1));
     }
@@ -221,7 +223,6 @@ public abstract class AbstractJdbcInputPlugin
                     while (true) {
                         // TODO run fetch() in another thread asynchronously
                         // TODO retry fetch() if it failed (maybe order_by is required and unique_column(s) option is also required)
-                        System.out.println("fetch....");
                         boolean cont = fetch(cursor, getters, pageBuilder);
                         if (!cont) {
                             break;
@@ -261,17 +262,20 @@ public abstract class AbstractJdbcInputPlugin
             return false;
         }
 
-        System.out.println("res: "+result);
-
         List<Column> columns = pageBuilder.getSchema().getColumns();
+        long rows = 0;
+        long reportRows = 500;
         do {
-            System.out.println("record.");
             for (int i=0; i < getters.size(); i++) {
                 int index = i + 1;  // JDBC column index begins from 1
-                System.out.println("getters "+i+" "+getters.get(i));
                 getters.get(i).getAndSet(result, index, pageBuilder, columns.get(i));
             }
             pageBuilder.addRecord();
+            rows++;
+            if (rows % reportRows == 0) {
+                logger.info(String.format("Fetched %,d rows.", rows));
+                reportRows *= 2;
+            }
         } while (result.next());
         return true;
     }

data/src/main/java/org/embulk/input/jdbc/getter/ColumnGetters.java

@@ -86,14 +86,11 @@ public class ColumnGetters
         public void getAndSet(ResultSet from, int fromIndex,
                 PageBuilder to, Column toColumn) throws SQLException
         {
-            System.out.println("string column from "+fromIndex+" to "+toColumn);
             String v = from.getString(fromIndex);
             if (from.wasNull()) {
                 to.setNull(toColumn);
-                System.out.println("> was null");
             } else {
                 to.setString(toColumn, v);
-                System.out.println("> "+v);
             }
         }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: embulk-input-jdbc
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - FURUHASHI Sadayuki
@@ -26,7 +26,7 @@ files:
 - src/main/java/org/embulk/input/jdbc/getter/ColumnGetter.java
 - src/main/java/org/embulk/input/jdbc/getter/ColumnGetterFactory.java
 - src/main/java/org/embulk/input/jdbc/getter/ColumnGetters.java
-- classpath/embulk-input-jdbc-0.1.0.jar
+- classpath/embulk-input-jdbc-0.2.0.jar
 homepage: https://github.com/embulk/embulk-input-jdbc
 licenses:
 - Apache 2.0