embulk-input-google_analytics 0.1.9 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0cf6819cbdb38173f44900cba3223c59a9176d6e
-  data.tar.gz: 62e041ee887e632aad22de0375b395b42636d0ef
+  metadata.gz: d129766efe1174a97720a2c9f1d20d41ceade3a9
+  data.tar.gz: 20760966f3ec891bd9ed63230a3fd22c85fa36fb
 SHA512:
-  metadata.gz: 5b68652c6e70c2e5b281f7fa7b44d7e24da9c51ffe494915bd90992f0ab28b8bef924ae2d8129e9aae87829705c252d1910ac45498982504ff94d468a4800481
-  data.tar.gz: 57a3ee3ec80110c89f4b17cb6b87e8f2f80fae2da1f69862e11eece4bab571d1bbf5ca3e457488f31a9f96171bc7ff053e6e57f9837e19c156716e75ca36834b
+  metadata.gz: de1f2ef838245c407ad699ae49803f5991f51b7e1912adcd78339f030a1060728fa69e99cca40b17d13c5ce2c8972274ae49d30f84b6028059c5ebab474a7d5a
+  data.tar.gz: cd42caf65d6b2a8f7bc98e23d5b5bb22b393b4795b4d16089094f68f39a7794b845f6d9b14bd75f38d58881c556709cee1fbd578fe591db80af5d6ad70c2d6e4

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.1.10 - 2016-12-08
+* Logging unexpected time string [#17](https://github.com/treasure-data/embulk-input-google_analytics/pull/17)
+
 ## 0.1.9 - 2016-11-22
 * Support 'foobarXX' column names [#16](https://github.com/treasure-data/embulk-input-google_analytics/pull/16)
 

data/embulk-input-google_analytics.gemspec

@@ -1,7 +1,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "embulk-input-google_analytics"
-  spec.version       = "0.1.9"
+  spec.version       = "0.1.10"
   spec.authors       = ["uu59"]
   spec.summary       = "Google Analytics input plugin for Embulk"
   spec.description   = "Loads records from Google Analytics."

data/lib/embulk/input/google_analytics/client.rb

@@ -101,6 +101,10 @@ module Embulk
               "%Y%m%d"
             end
           parts = Date._strptime(time_string, date_format)
+          unless parts
+            # strptime was failed. Google API returns unexpected date string.
+            Embulk.logger.warn("Failed to parse #{task["time_series"]} data. The value is '#{time_string}'(#{time_string.class}) and it doesn't match with '#{date_format}'.")
+          end
 
           swap_time_zone do
             Time.zone.local(*parts.values_at(:year, :mon, :mday, :hour)).to_time

data/test/embulk/input/google_analytics/test_client.rb

@@ -172,6 +172,20 @@ module Embulk
               assert_equal Time.parse("2016-01-01 22:00:00 -08:00"), time
             end
 
+            sub_test_case "Logging invalid values" do
+              setup do
+                @logger = Logger.new(File::NULL)
+                stub(Embulk).logger { @logger }
+              end
+
+              test "empty" do
+                mock(@logger).warn(%Q|Failed to parse ga:dateHour data. The value is ''(String) and it doesn't match with '%Y%m%d%H'.|)
+                assert_raise do
+                  @client.time_parse_with_profile_timezone("")
+                end
+              end
+            end
+
             def time_series
               "ga:dateHour"
             end
@@ -192,6 +206,20 @@ module Embulk
               assert_equal Time.parse("2016-01-01 00:00:00 PST"), time
             end
 
+            sub_test_case "Logging invalid values" do
+              setup do
+                @logger = Logger.new(File::NULL)
+                stub(Embulk).logger { @logger }
+              end
+
+              test "empty" do
+                mock(@logger).warn(%Q|Failed to parse ga:date data. The value is ''(String) and it doesn't match with '%Y%m%d'.|)
+                assert_raise do
+                  @client.time_parse_with_profile_timezone("")
+                end
+              end
+            end
+
             def time_series
               "ga:date"
             end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-input-google_analytics
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors:
 - uu59
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-11-22 00:00:00.000000000 Z
+date: 2016-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement