embulk-filter-base58 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 00cfc6ad1057cdbf2dc12e61707eae5b5dbdcb6b
-  data.tar.gz: a0a1bbe1f72006006ecbbfd241691ddfaa485364
+  metadata.gz: 6f5608649f72f4f3f5aff5519f536738ada5b39f
+  data.tar.gz: 991a3136a80c49ca86b7bd38e75052fa74731d46
 SHA512:
-  metadata.gz: 5a2b21c12d7381b0ac0263ceaef7da002f65c36081b6f8cd628b715e8907ff37461a1808d01162b8207bb14d6fa3131818b37d4b105f1bc71d86ca66d3a24fe4
-  data.tar.gz: a95d96b3422597fa70a357081b67f885f3a9aa0622948a75c4888b859652c4c6f6f484083e641036bf9dc279579c3ff4c55c106ae78b8ba3f618a5834b64d9fb
+  metadata.gz: 75116c9073702c6afd9c7cd3120ff5dd408bfe9aee974a31fe0215723631d19aa10eb895b200e0656561e0aa2c1106dd98e808ecdd31fe2504a3cd3eabd919ca
+  data.tar.gz: 59a0b0fb1e295484db667b88c7dbf160ca395c22f0ca9ced0d9f19a79e4e916088155e624de130a205890a7af9e52dcf52783a8e7d4f8ab82a6690a06eebd1b4

data/README.md

@@ -1,5 +1,7 @@
 # Base58 filter plugin for Embulk
 
+[![Build Status](https://travis-ci.org/kfitzgerald/embulk-filter-base58.svg?branch=master)](https://travis-ci.org/kfitzgerald/embulk-filter-base58) [![Coverage Status](https://coveralls.io/repos/github/kfitzgerald/embulk-filter-base58/badge.svg?branch=master)](https://coveralls.io/github/kfitzgerald/embulk-filter-base58?branch=master)
+
 Embulk filter plugin to convert hex to base58 and vice versa.
 
 ## Overview

data/build.gradle

@@ -2,6 +2,8 @@ plugins {
     id "com.jfrog.bintray" version "1.1"
     id "com.github.jruby-gradle.base" version "0.1.5"
     id "java"
+    id "jacoco"
+    id "com.github.kt3k.coveralls" version "2.4.0"
 }
 import com.github.jrubygradle.JRubyExec
 repositories {
@@ -12,13 +14,22 @@ configurations {
     provided
 }
 
-version = "0.1.0"
+version = "0.1.1"
 
 dependencies {
-    compile  "org.embulk:embulk-core:0.8.8"
-    provided "org.embulk:embulk-core:0.8.8"
+    compile  "org.embulk:embulk-core:0.8.+"
+    provided "org.embulk:embulk-core:0.8.+"
     // compile "YOUR_JAR_DEPENDENCY_GROUP:YOUR_JAR_DEPENDENCY_MODULE:YOUR_JAR_DEPENDENCY_VERSION"
     testCompile "junit:junit:4.+"
+    testCompile "org.embulk:embulk-core:0.8.+:tests"
+    testCompile "org.embulk:embulk-standards:0.8.+"
+}
+
+jacocoTestReport {
+    reports {
+        xml.enabled = true // coveralls plugin depends on xml format report
+        html.enabled = true
+    }
 }
 
 task classpath(type: Copy, dependsOn: ["jar"]) {

data/src/main/java/org/embulk/filter/base58/Base58.java

@@ -2,27 +2,27 @@ package org.embulk.filter.base58;
 
 import java.math.BigInteger;
 
-public class Base58
+final class Base58
 {
     private Base58()
     {
     }
 
-    private static final String base58Chars = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"; // Base-58 char library
+    private static final String BASE_58_CHARS = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"; // Base-58 char library
+    private static final BigInteger ZERO = new BigInteger("0");
+    private static final BigInteger FIFTY_EIGHT = new BigInteger("58");
 
     public static String encode(String hex)
     {
         String originalHex = hex;
 
         BigInteger numeric = new BigInteger(hex, 16);
-        BigInteger zero = new BigInteger("0");
-        BigInteger fifty58 = new BigInteger("58");
         String output = "";
 
-        while (numeric.compareTo(zero) == 1) {
-            BigInteger remainder = numeric.mod(fifty58);
-            numeric = numeric.divide(fifty58);
-            output = base58Chars.charAt(Integer.parseInt(remainder.toString())) + output;
+        while (numeric.compareTo(ZERO) == 1) {
+            BigInteger remainder = numeric.mod(FIFTY_EIGHT);
+            numeric = numeric.divide(FIFTY_EIGHT);
+            output = BASE_58_CHARS.charAt(Integer.parseInt(remainder.toString())) + output;
         }
 
         //leading zeros
@@ -39,15 +39,14 @@ public class Base58
 
         // Ignore bogus base58 strings
         if (base58Value.matches("[^1-9A-HJ-NP-Za-km-z]")) {
-            return "";
+            return null;
         }
 
         BigInteger output = new BigInteger("0");
-        BigInteger fifty58 = new BigInteger("58");
 
         for (int i = 0; i < base58Value.length(); i++) {
-            int current = base58Chars.indexOf(base58Value.charAt(i));
-            output = output.multiply(fifty58).add(new BigInteger(current + ""));
+            int current = BASE_58_CHARS.indexOf(base58Value.charAt(i));
+            output = output.multiply(FIFTY_EIGHT).add(new BigInteger(current + ""));
         }
 
         String hex = output.toString(16);
@@ -71,6 +70,6 @@ public class Base58
 
     public static String decodeWithPrefix(String baseValue, String prefix)
     {
-        return decode(baseValue.substring(prefix.length()));
+        return decode(baseValue.replace(prefix, ""));
     }
 }

data/src/main/java/org/embulk/filter/base58/Base58FilterPlugin.java

@@ -1,7 +1,6 @@
 package org.embulk.filter.base58;
 
 import com.google.common.base.Optional;
-import com.google.common.base.Throwables;
 import com.google.common.collect.ImmutableList;
 import org.embulk.config.Config;
 import org.embulk.config.ConfigDefault;
@@ -42,7 +41,7 @@ public class Base58FilterPlugin implements FilterPlugin {
         Optional<Boolean> getIsEncode();
 
         @Config("prefix")
-        @ConfigDefault("")
+        @ConfigDefault("null")
         Optional<String> getPrefix();
 
         @Config("new_name")
@@ -52,8 +51,12 @@ public class Base58FilterPlugin implements FilterPlugin {
 
     @Override
     public void transaction(ConfigSource config, Schema inputSchema, FilterPlugin.Control control) {
-
         PluginTask task = config.loadConfig(PluginTask.class);
+        Schema outputSchema = buildOutputSchema(task, inputSchema);
+        control.run(task.dump(), outputSchema);
+    }
+
+    Schema buildOutputSchema(PluginTask task, Schema inputSchema) {
         ImmutableList.Builder<Column> builder = ImmutableList.builder();
 
         // Roll through original columns
@@ -75,8 +78,7 @@ public class Base58FilterPlugin implements FilterPlugin {
             }
         }
 
-        Schema outputSchema = new Schema(builder.build());
-        control.run(task.dump(), outputSchema);
+        return new Schema(builder.build());
     }
 
     @Override
@@ -95,110 +97,11 @@ public class Base58FilterPlugin implements FilterPlugin {
             public void add(Page page) {
                 reader.setPage(page);
                 while (reader.nextRecord()) {
-                    setValue();
+                    setValue(base58ColumnMap, outputColumnMap, reader, outputSchema, builder);
                     builder.addRecord();
                 }
             }
 
-            private void setValue() {
-
-                // Do base58 conversions ahead of iterating output columns
-                final Map<String, String> base58OutputMap = new HashMap<>();;
-                for (Base58Column column : base58ColumnMap.values()) {
-                    String inputValue, convertedValue = null;
-
-                    // If the original column is not a string, then forget about it (it should be hex)
-                    Column originalColumn = outputColumnMap.get(column.getName());
-                    if (Types.STRING.equals(originalColumn.getType())) {
-                        inputValue = reader.getString(originalColumn);
-                    } else {
-                        logger.error("cannot convert base58 value of non-string values. name: {}, type: {}, index: {}",
-                                originalColumn.getName(),
-                                originalColumn.getType(),
-                                originalColumn.getIndex());
-                        throw new DataException("Unexpected string type in column `"+originalColumn.getName()+"`. Got: " + originalColumn.getType());
-                    }
-
-                    // Convert the value
-                    try {
-                        convertedValue = convertValue(inputValue, column.getIsEncode().get(), column.getPrefix().get());
-                    } catch (Exception e) {
-                        // Failed to do the conversion. Probably misconfigured or malformed value
-                        logger.error("failed to encode/decode base58 column value. name: {}, type: {}, index: {}, value: {}, method: {}, prefix: {}, target_name: {}",
-                                originalColumn.getName(),
-                                originalColumn.getType(),
-                                originalColumn.getIndex(),
-                                inputValue,
-                                column.getIsEncode().get() ? "encode" : "decode",
-                                column.getPrefix(),
-                                column.getNewName().or(column.getName()));
-                        // Don't crash the import if a single value is screwed up. Just log it for now
-                    }
-
-                    // Add it to the output mappings
-                    if (column.getNewName().isPresent()) {
-                        base58OutputMap.put(column.getNewName().get(), convertedValue);
-                    } else {
-                        base58OutputMap.put(column.getName(), convertedValue);
-                    }
-                }
-
-                List<Column> columns = outputSchema.getColumns();
-                for (Column outputColumn : columns) {
-
-                    // Did we convert the value for this column?
-                    if (base58OutputMap.containsKey(outputColumn.getName())) {
-                        String value = base58OutputMap.get(outputColumn.getName());
-                        if (value == null) {
-                            builder.setNull(outputColumn);
-                        } else {
-                            builder.setString(outputColumn, base58OutputMap.get(outputColumn.getName()));
-                        }
-                        continue;
-                    }
-
-                    // No value?
-                    if (reader.isNull(outputColumn)) {
-                        builder.setNull(outputColumn);
-                        continue;
-                    }
-
-                    // Inherit value
-                    if (Types.STRING.equals(outputColumn.getType())) {
-                        builder.setString(outputColumn, reader.getString(outputColumn));
-                    }
-                    else if (Types.BOOLEAN.equals(outputColumn.getType())) {
-                        builder.setBoolean(outputColumn, reader.getBoolean(outputColumn));
-                    }
-                    else if (Types.DOUBLE.equals(outputColumn.getType())) {
-                        builder.setDouble(outputColumn, reader.getDouble(outputColumn));
-                    }
-                    else if (Types.LONG.equals(outputColumn.getType())) {
-                        builder.setLong(outputColumn, reader.getLong(outputColumn));
-                    }
-                    else if (Types.TIMESTAMP.equals(outputColumn.getType())) {
-                        builder.setTimestamp(outputColumn, reader.getTimestamp(outputColumn));
-                    }
-                    else if (Types.JSON.equals(outputColumn.getType())) {
-                        builder.setJson(outputColumn, reader.getJson(outputColumn));
-                    }
-                }
-            }
-
-            private String convertValue(String value, Boolean isEncode, String prefix) {
-                String result = null;
-                try {
-                    if (isEncode) {
-                        result = Base58.encodeWithPrefix(value, prefix);
-                    } else {
-                        result = Base58.decodeWithPrefix(value, prefix);
-                    }
-                } catch (Exception e) {
-                    Throwables.propagate(e);
-                }
-                return result;
-            }
-
             @Override
             public void finish() {
                 builder.finish();
@@ -211,7 +114,101 @@ public class Base58FilterPlugin implements FilterPlugin {
         };
     }
 
-    private static Map<String, Base58Column> convertBase58ColumnListToMap(List<Base58Column> base58Columns) {
+    void setValue(final Map<String, Base58Column> base58ColumnMap, final Map<String, Column> outputColumnMap, final PageReader reader, final Schema outputSchema, final PageBuilder builder) {
+
+        // Do base58 conversions ahead of iterating output columns
+        final Map<String, String> base58OutputMap = new HashMap<>();;
+        for (Base58Column column : base58ColumnMap.values()) {
+            String inputValue, convertedValue = null;
+
+            // If the original column is not a string, then forget about it (it should be hex)
+            Column originalColumn = outputColumnMap.get(column.getName());
+            if (Types.STRING.equals(originalColumn.getType())) {
+                inputValue = reader.getString(originalColumn);
+            } else {
+                logger.error("cannot convert base58 value of non-string values. name: {}, type: {}, index: {}",
+                        originalColumn.getName(),
+                        originalColumn.getType(),
+                        originalColumn.getIndex());
+                throw new DataException("Unexpected string type in column `"+originalColumn.getName()+"`. Got: " + originalColumn.getType());
+            }
+
+            // Convert the value
+            try {
+                convertedValue = convertValue(inputValue, column.getIsEncode().or(true), column.getPrefix().or(""));
+            } catch (Exception e) {
+                // Failed to do the conversion. Probably misconfigured or malformed value
+                logger.error("failed to encode/decode base58 column value. name: {}, type: {}, index: {}, value: {}, method: {}, prefix: {}, target_name: {}",
+                        originalColumn.getName(),
+                        originalColumn.getType(),
+                        originalColumn.getIndex(),
+                        inputValue,
+                        column.getIsEncode().get() ? "encode" : "decode",
+                        column.getPrefix(),
+                        column.getNewName().or(column.getName()));
+                logger.error("base58 conversion exception", e);
+                // Don't crash the import if a single value is screwed up. Just log it for now
+            }
+
+            // Add it to the output mappings
+            if (column.getNewName().isPresent()) {
+                base58OutputMap.put(column.getNewName().get(), convertedValue);
+            } else {
+                base58OutputMap.put(column.getName(), convertedValue);
+            }
+        }
+
+        List<Column> columns = outputSchema.getColumns();
+        for (Column outputColumn : columns) {
+
+            // Did we convert the value for this column?
+            if (base58OutputMap.containsKey(outputColumn.getName())) {
+                String value = base58OutputMap.get(outputColumn.getName());
+                if (value == null) {
+                    builder.setNull(outputColumn);
+                } else {
+                    builder.setString(outputColumn, base58OutputMap.get(outputColumn.getName()));
+                }
+                continue;
+            }
+
+            // No value?
+            if (reader.isNull(outputColumn)) {
+                builder.setNull(outputColumn);
+                continue;
+            }
+
+            // Inherit value
+            if (Types.STRING.equals(outputColumn.getType())) {
+                builder.setString(outputColumn, reader.getString(outputColumn));
+            }
+            else if (Types.BOOLEAN.equals(outputColumn.getType())) {
+                builder.setBoolean(outputColumn, reader.getBoolean(outputColumn));
+            }
+            else if (Types.DOUBLE.equals(outputColumn.getType())) {
+                builder.setDouble(outputColumn, reader.getDouble(outputColumn));
+            }
+            else if (Types.LONG.equals(outputColumn.getType())) {
+                builder.setLong(outputColumn, reader.getLong(outputColumn));
+            }
+            else if (Types.TIMESTAMP.equals(outputColumn.getType())) {
+                builder.setTimestamp(outputColumn, reader.getTimestamp(outputColumn));
+            }
+            else if (Types.JSON.equals(outputColumn.getType())) {
+                builder.setJson(outputColumn, reader.getJson(outputColumn));
+            }
+        }
+    }
+
+    String convertValue(String value, Boolean isEncode, String prefix) {
+        if (isEncode) {
+            return Base58.encodeWithPrefix(value, prefix);
+        } else {
+            return Base58.decodeWithPrefix(value, prefix);
+        }
+    }
+
+    static Map<String, Base58Column> convertBase58ColumnListToMap(List<Base58Column> base58Columns) {
         Map<String, Base58Column> result = new HashMap<>();
         for (Base58Column base58Column : base58Columns) {
             result.put(base58Column.getName(), base58Column);
@@ -219,7 +216,7 @@ public class Base58FilterPlugin implements FilterPlugin {
         return result;
     }
 
-    private static Map<String, Column> convertColumnListToMap(List<Column> columns) {
+    static Map<String, Column> convertColumnListToMap(List<Column> columns) {
         Map<String, Column> result = new HashMap<>();
         for (Column column : columns) {
             result.put(column.getName(), column);

data/src/test/java/org/embulk/filter/base58/TestBase58FilterImpl.java

@@ -0,0 +1,332 @@
+package org.embulk.filter.base58;
+
+import org.embulk.EmbulkTestRuntime;
+import org.embulk.filter.base58.Base58FilterPlugin.PluginTask;
+import org.embulk.config.ConfigLoader;
+import org.embulk.config.ConfigSource;
+import org.embulk.spi.*;
+import org.embulk.spi.TestPageBuilderReader.MockPageOutput;
+import org.embulk.spi.time.Timestamp;
+import org.embulk.spi.util.Pages;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.msgpack.value.ValueFactory;
+
+import static org.embulk.spi.type.Types.BOOLEAN;
+import static org.embulk.spi.type.Types.DOUBLE;
+import static org.embulk.spi.type.Types.JSON;
+import static org.embulk.spi.type.Types.LONG;
+import static org.embulk.spi.type.Types.STRING;
+import static org.embulk.spi.type.Types.TIMESTAMP;
+import static org.junit.Assert.assertEquals;
+
+import java.util.List;
+import java.util.Map;
+
+public class TestBase58FilterImpl {
+
+    @Rule
+    public EmbulkTestRuntime runtime = new EmbulkTestRuntime();
+
+    private Base58FilterPlugin plugin;
+
+    @Before
+    public void createResource()
+    {
+        plugin = new Base58FilterPlugin();
+    }
+
+    private PluginTask taskFromYamlString(String... lines)
+    {
+        StringBuilder builder = new StringBuilder();
+        for (String line : lines) {
+            builder.append(line).append("\n");
+        }
+        String yamlString = builder.toString();
+
+        ConfigLoader loader = new ConfigLoader(Exec.getModelManager());
+        ConfigSource config = loader.fromYamlString(yamlString);
+        return config.loadConfig(PluginTask.class);
+    }
+
+    private List<Object[]> filter(PluginTask task, Schema inputSchema, Object ... objects)
+    {
+        MockPageOutput output = new MockPageOutput();
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        PageBuilder pageBuilder = new PageBuilder(runtime.getBufferAllocator(), outputSchema, output);
+        PageReader pageReader = new PageReader(inputSchema);
+        final Map<String, Base58FilterPlugin.Base58Column> base58ColumnMap = Base58FilterPlugin.convertBase58ColumnListToMap(task.getColumns());
+        final Map<String, Column> outputColumnMap = Base58FilterPlugin.convertColumnListToMap(outputSchema.getColumns());
+
+        List<Page> pages = PageTestUtils.buildPage(runtime.getBufferAllocator(), inputSchema, objects);
+        for (Page page : pages) {
+            pageReader.setPage(page);
+
+            while (pageReader.nextRecord()) {
+                plugin.setValue(base58ColumnMap, outputColumnMap, pageReader, outputSchema, pageBuilder);
+                pageBuilder.addRecord();
+            }
+        }
+        pageBuilder.finish();
+        pageBuilder.close();
+        return Pages.toObjects(outputSchema, output.pages);
+    }
+
+    @Test
+    public void basicEncoding()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "54f5f8b37c158c2f12ee1c64");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals("2bzSwY8SCsogbNxZZ", record[0]);
+        }
+    }
+
+    @Test
+    public void basicDecoding()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "2bzSwY8SCsogbNxZZ");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals("54f5f8b37c158c2f12ee1c64", record[0]);
+        }
+    }
+
+
+
+    @Test
+    public void playsNiceWithOtherTypes()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .add("created", TIMESTAMP)
+                .add("updated", TIMESTAMP)
+                .add("is_dead", BOOLEAN)
+                .add("count", LONG)
+                .add("price", DOUBLE)
+                .add("meta", JSON)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "54f5f8b37c158c2f12ee1c64", Timestamp.ofEpochSecond(0), null, new Boolean(true), new Long(0), new Double(0.5), ValueFactory.newString("json"));
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(7, record.length);
+            assertEquals("2bzSwY8SCsogbNxZZ", record[0]);
+            assertEquals(Timestamp.ofEpochSecond(0), record[1]);
+            assertEquals(null, record[2]);
+            assertEquals(new Boolean(true), record[3]);
+            assertEquals(new Long(0), record[4]);
+            assertEquals(new Double(0.5), record[5]);
+            assertEquals(ValueFactory.newString("json"), record[6]);
+        }
+    }
+
+    @Test(expected = org.embulk.spi.DataException.class)
+    public void doesNotWorkOnNonStringColumn()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: not_id}");
+        Schema inputSchema = Schema.builder()
+                .add("not_id", BOOLEAN)
+                .build();
+
+        filter(task, inputSchema,
+                new Boolean(true));
+    }
+
+    @Test
+    public void basicEncodingWithPrefix()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id, prefix: obj_}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "54f5f8b37c158c2f12ee1c64");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals("obj_2bzSwY8SCsogbNxZZ", record[0]);
+        }
+    }
+
+    @Test
+    public void basicDecodingWithPrefix()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false, prefix: obj_}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "obj_2bzSwY8SCsogbNxZZ");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals("54f5f8b37c158c2f12ee1c64", record[0]);
+        }
+    }
+
+    @Test
+    public void basicEncodingWithPrefixAndNewName()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id, prefix: obj_, new_name: public_id}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "00f5f8b37c158c2f12ee1c64");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(2, record.length);
+            assertEquals("00f5f8b37c158c2f12ee1c64", record[0]);
+            assertEquals("obj_123zhNEUWPr5ogRQP", record[1]);
+        }
+    }
+
+    @Test
+    public void basicDecodingWithPrefixAndNewName()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false, prefix: obj_, new_name: _id}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "obj_123zhNEUWPr5ogRQP");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(2, record.length);
+            assertEquals("obj_123zhNEUWPr5ogRQP", record[0]);
+            assertEquals("00f5f8b37c158c2f12ee1c64", record[1]);
+        }
+    }
+
+    @Test
+    public void badBase58DecodeTurnsColumnValueNull()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "I");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals(null, record[0]);
+        }
+    }
+
+    @Test
+    public void badHexValueTurnsNull()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id, encode: true}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        List<Object[]> records = filter(task, inputSchema,
+                "nope");
+
+        assertEquals(1, records.size());
+
+        Object[] record;
+        {
+            record = records.get(0);
+            assertEquals(1, record.length);
+            assertEquals(null, record[0]);
+        }
+    }
+
+    @Test
+    public void base58EdgeCases()
+    {
+        assertEquals("00", Base58.decode(""));
+        assertEquals(null, Base58.decode("I"));
+        assertEquals("1", Base58.encode("00"));
+        assertEquals("2", Base58.encode("01"));
+    }
+
+}

data/src/test/java/org/embulk/filter/base58/TestBase58FilterPlugin.java

@@ -1,27 +1,177 @@
 package org.embulk.filter.base58;
 
-//import com.fasterxml.jackson.databind.ObjectMapper;
-//import com.google.inject.AbstractModule;
-//import com.google.inject.Guice;
-//import org.embulk.EmbulkEmbed;
-//import org.embulk.config.ConfigLoader;
-//import org.embulk.config.ModelManager;
-//import org.junit.Test;
-//
-//import java.io.File;
-//import java.io.IOException;
+import org.embulk.EmbulkTestRuntime;
+import org.embulk.filter.base58.Base58FilterPlugin.PluginTask;
+import org.embulk.config.ConfigLoader;
+import org.embulk.config.ConfigSource;
+import org.embulk.spi.Column;
+import org.embulk.spi.Exec;
+import org.embulk.spi.Schema;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import static org.embulk.spi.type.Types.STRING;
+import static org.junit.Assert.assertEquals;
 
 public class TestBase58FilterPlugin
 {
-//    @Test
-//    public void test() throws IOException {
-//        EmbulkEmbed embed = new EmbulkEmbed.Bootstrap().initialize();
-//        ConfigLoader loader = new ConfigLoader(new ModelManager(Guice.createInjector(new AbstractModule() {
-//            @Override
-//            protected void configure() {}
-//        }),
-//                new ObjectMapper()
-//        ));
-//        embed.run(loader.fromYamlFile(new File("./test.yml")));
-//    }
+    @Rule
+    public EmbulkTestRuntime runtime = new EmbulkTestRuntime();
+
+    private Base58FilterPlugin plugin;
+
+    @Before
+    public void createResource()
+    {
+        plugin = new Base58FilterPlugin();
+    }
+
+    private ConfigSource configFromYamlString(String... lines)
+    {
+        StringBuilder builder = new StringBuilder();
+        for (String line : lines) {
+            builder.append(line).append("\n");
+        }
+        String yamlString = builder.toString();
+
+        ConfigLoader loader = new ConfigLoader(Exec.getModelManager());
+        return loader.fromYamlString(yamlString);
+    }
+
+    private PluginTask taskFromYamlString(String... lines)
+    {
+        ConfigSource config = configFromYamlString(lines);
+        return config.loadConfig(PluginTask.class);
+    }
+
+    @Test
+    public void buildOutputSchema_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(1, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("_id", column.getName());
+        }
+    }
+
+    @Test
+    public void buildOutputSchemaDecode_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(1, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("public_id", column.getName());
+        }
+    }
+
+    @Test
+    public void buildOutputSchemaPrefix_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id, prefix: obj_}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(1, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("_id", column.getName());
+        }
+    }
+
+    @Test
+    public void buildOutputSchemaDecodePrefix_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false, prefix: obj_}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(1, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("public_id", column.getName());
+        }
+    }
+
+    @Test
+    public void buildOutputSchemaPrefixNewColumn_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: _id, prefix: obj_, new_name: public_id}");
+        Schema inputSchema = Schema.builder()
+                .add("_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(2, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("_id", column.getName());
+            column = outputSchema.getColumn(1);
+            assertEquals("public_id", column.getName());
+        }
+    }
+
+    @Test
+    public void buildOutputSchemaDecodePrefixNewColumn_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: base58",
+                "columns:",
+                "  - {name: public_id, encode: false, prefix: obj_, new_name: _id}");
+        Schema inputSchema = Schema.builder()
+                .add("public_id", STRING)
+                .build();
+
+        Schema outputSchema = plugin.buildOutputSchema(task, inputSchema);
+        assertEquals(2, outputSchema.size());
+
+        Column column;
+        {
+            column = outputSchema.getColumn(0);
+            assertEquals("public_id", column.getName());
+            column = outputSchema.getColumn(1);
+            assertEquals("_id", column.getName());
+        }
+    }
 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-filter-base58
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kevin Fitzgerald
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-07-16 00:00:00.000000000 Z
+date: 2016-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -57,8 +57,9 @@ files:
 - lib/embulk/filter/base58.rb
 - src/main/java/org/embulk/filter/base58/Base58.java
 - src/main/java/org/embulk/filter/base58/Base58FilterPlugin.java
+- src/test/java/org/embulk/filter/base58/TestBase58FilterImpl.java
 - src/test/java/org/embulk/filter/base58/TestBase58FilterPlugin.java
-- classpath/embulk-filter-base58-0.1.0.jar
+- classpath/embulk-filter-base58-0.1.1.jar
 homepage: https://github.com/kfitzgerald/embulk-filter-base58
 licenses:
 - MIT