ember-cli-rails 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f0547176e2856d0b34ef53d83724a6d5dbdb741
-  data.tar.gz: 5edaffcc86f429e1dcdc2085414fa4824b78b795
+  metadata.gz: d157a938817929f1ba712ece97d2d011589b9277
+  data.tar.gz: 2e813694b87a48835a810a87d7f6344f2f68b8d2
 SHA512:
-  metadata.gz: fec38204f90ffac056042df6d658a11e4099ff29b45b4702bfb48e002e7114818772d6ed6f4f6b92e57f159cebe1b96b8c0c7fbe28f20f831df31d94eb693a39
-  data.tar.gz: cc713397c80da2e9d4b1449666707fe5d247cc9ad282ff9fa41958b67e9abdf07736487663d06185de073853dd9a9300593b568ff2d74eb33d23704737fff612
+  metadata.gz: 081d7613d112ce8bd739a13f6fd236e4e921d7ee5d2dae204774415558271d528fdda723b7579414e65c7e3a6d3f0562424e6971b9682528155b6d08ef4bdeab
+  data.tar.gz: b37e4cba19eb651a5e4d4240a6c22ec365327c4604a99a7c5fc98616f58a63dfb46a833bfa310d465e588d5f19b2b1776fb12fbf81cffde5c77389b37af4d6e5

data/CHANGELOG.md

@@ -1,6 +1,20 @@
 master
 ------
 
+0.7.3
+-----
+
+* Stream output instead of waiting until subprocesses finish. [#423]
+* Update `ember-cli-rails-assets` dependency. [#422]
+* Only write errors to `STDERR`. [#421]
+* Remove dependency on `tee`. Fixes bug [#417]. [#420]
+
+[#423]: https://github.com/thoughtbot/ember-cli-rails/pull/423
+[#422]: https://github.com/thoughtbot/ember-cli-rails/pull/422
+[#421]: https://github.com/thoughtbot/ember-cli-rails/issues/421
+[#420]: https://github.com/thoughtbot/ember-cli-rails/issues/420
+[#417]: https://github.com/thoughtbot/ember-cli-rails/issues/417
+
 0.7.2
 -----
 

data/lib/ember_cli/app.rb

@@ -36,9 +36,10 @@ module EmberCli
     def compile
       @compiled ||= begin
         prepare
-        @shell.compile
+        exit_status = @shell.compile
         @build.check!
-        true
+
+        exit_status.success?
       end
     end
 
@@ -71,7 +72,7 @@ module EmberCli
     def test
       prepare
 
-      @shell.test
+      @shell.test.success?
     end
 
     def check_for_errors!

data/lib/ember_cli/command.rb

@@ -14,7 +14,7 @@ module EmberCli
     end
 
     def build(watch: false)
-      "#{ember_build(watch: watch)} | #{tee}"
+      ember_build(watch: watch)
     end
 
     private
@@ -25,12 +25,6 @@ module EmberCli
       options.fetch(:watcher) { EmberCli.configuration.watcher }
     end
 
-    def tee
-      Cocaine::CommandLine.
-        new(paths.tee, "-a :log").
-        command(log: paths.log)
-    end
-
     def ember_build(watch: false)
       line = Cocaine::CommandLine.new(paths.ember, [
         "build",

data/lib/ember_cli/runner.rb

@@ -2,35 +2,48 @@ require "open3"
 
 module EmberCli
   class Runner
-    def initialize(env: {}, out:, err:, options: {})
+    def initialize(out:, err:, env: {}, options: {})
       @env = env
-      @out = out
-      @err = err
+      @output_streams = Array(out)
+      @error_streams = Array(err)
       @options = options
+      @threads = []
     end
 
     def run(command)
-      output, status = Open3.capture2e(@env, command, @options)
+      Open3.popen3(env, command, options) do |stdin, stdout, stderr, process|
+        stdin.close
 
-      @out.write(output)
+        threads << redirect_stream_in_thread(stdout, write_to: output_streams)
+        threads << redirect_stream_in_thread(stderr, write_to: error_streams)
 
-      [output, status]
+        threads.each(&:join)
+        process.value
+      end
     end
 
     def run!(command)
-      output, status = run(command)
+      run(command).tap do |status|
+        unless status.success?
+          exit status.exitstatus
+        end
+      end
+    end
 
-      unless status.success?
-        @err.write <<-MSG.strip_heredoc
-          ERROR: Failed command: `#{command}`
-          OUTPUT:
-            #{output}
-        MSG
+    protected
 
-        exit status.exitstatus
-      end
+    attr_reader :env, :error_streams, :options, :output_streams, :threads
 
-      true
+    private
+
+    def redirect_stream_in_thread(stream, write_to:)
+      Thread.new do
+        Thread.current.abort_on_exception = true
+
+        while line = stream.gets
+          write_to.each { |redirection_stream| redirection_stream.puts(line) }
+        end
+      end
     end
   end
 end

data/lib/ember_cli/shell.rb

@@ -85,8 +85,8 @@ module EmberCli
     def runner
       Runner.new(
         options: { chdir: paths.root.to_s },
-        out: paths.log,
-        err: $stderr,
+        out: [$stdout, paths.log.open("a")],
+        err: [$stderr],
         env: env,
       )
     end

data/lib/ember_cli/version.rb

@@ -1,3 +1,3 @@
 module EmberCli
-  VERSION = "0.7.2".freeze
+  VERSION = "0.7.3".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ember-cli-rails
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Pavel Pravosud
@@ -10,22 +10,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-17 00:00:00.000000000 Z
+date: 2016-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ember-cli-rails-assets
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 0.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement