ember-cli-rails 0.14.2 → 0.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 205edc4e10aa3f203c8cd2f372ba62a3ce75890712207924b4a845dbbfd610d2
-  data.tar.gz: 20f5b025ff819827debf7c33d3ec396c206b1ccb2e61f26551c08638dbaa415c
+  metadata.gz: '079bc62bc3e35daf5eefbe6f36e1a220f05e8d8559ef5c54b650e88a4ee726fd'
+  data.tar.gz: 56d4b1cd987002f93bfcdbaf224577e9a22dda026c660dcea93dda3343f1943f
 SHA512:
-  metadata.gz: 42a1be898ab5343abb64fbecdea9146cfb0b28ece2a21071ef82abece673ea19bb524b5f1f501cc83619cb9d1189846cd87ce2a52607c3b0296dfd201af3f0f7
-  data.tar.gz: 894db060b527d318f5282cc81b72c447fb4452a0a94b23967a7b3fcb9a9ba31187ff2f82ae135245e5a50aa287af81898959339c7fe066cec7187ba7e134e47a
+  metadata.gz: 1211190b983441988945da00c600a61cc9b3404a89676e19eea0d4763a026f048b922dcf25bf6454103b306d73633c883b627f9066f76eb7b3d3274a5579ced8
+  data.tar.gz: 18fe7b423a12804bfd27c9562513df6295487029e80771a24e3e52dbe0d963a3c5ae36324a4d741f04292b93dda2a22ad145451d36f02222478ad1534ab69101

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+0.14.3
+------
+
+* Quote the paths of the executables `ember-cli-rails` runs (`ember`, `vite`,
+  `npm`, `yarn`, `pnpm`, `bower` and `bundler`) before handing their command
+  lines to the shell. An application, or an executable configured with an
+  option such as `npm_path`, under a directory whose name contained a space
+  or another character the shell treats specially failed to build or install
+* Stop passing `format: :html` to the route `mount_ember_app` draws. Rails
+  ignored a Symbol `format:` until rails/rails#59418, which makes it a
+  format requirement with `html` as the default. With it, the route's glob
+  swallowed the extension of an asset path such as `/assets/app.js`, so the
+  request was treated as HTML and answered with the application's
+  `index.html` instead of reaching the mounted assets
+
 0.14.2
 ------
 

data/lib/ember_cli/command.rb

@@ -1,3 +1,4 @@
+require "shellwords"
 require "terrapin"
 
 module EmberCli
@@ -8,7 +9,7 @@ module EmberCli
     end
 
     def test
-      line = Terrapin::CommandLine.new(paths.ember, "test --environment test")
+      line = Terrapin::CommandLine.new(executable(paths.ember), "test --environment test")
 
       line.command
     end
@@ -25,7 +26,7 @@ module EmberCli
     # Vite-based blueprint (`ember-cli >= 6.8`). This is what the blueprint's
     # own `npm start` script runs.
     def dev_server(host:, port:)
-      line = Terrapin::CommandLine.new(paths.vite, [
+      line = Terrapin::CommandLine.new(executable(paths.vite), [
         "--host :host",
         "--port :port",
         "--strictPort",
@@ -39,6 +40,13 @@ module EmberCli
 
     attr_reader :options, :paths
 
+    # Terrapin quotes the values it interpolates into a command line, but not
+    # the executable it starts with, so quote that before it reaches the
+    # shell.
+    def executable(path)
+      Shellwords.escape(path.to_s)
+    end
+
     def process_watcher
       options.fetch(:watcher) { EmberCli.configuration.watcher }
     end
@@ -67,7 +75,7 @@ module EmberCli
     # Ember application, where Vite leaves stale files in place unless asked
     # to clear them.
     def vite_build
-      line = Terrapin::CommandLine.new(paths.vite, [
+      line = Terrapin::CommandLine.new(executable(paths.vite), [
         "build",
         "--mode :mode",
         "--outDir :output_path",
@@ -90,7 +98,7 @@ module EmberCli
     # `--watcher` names the backend that watches, so it rides along only
     # when the build watches.
     def ember_build(watch: false)
-      line = Terrapin::CommandLine.new(paths.ember, [
+      line = Terrapin::CommandLine.new(executable(paths.ember), [
         "build",
         ("--watch" if watch),
         ("--watcher :watcher" if watch && process_watcher),

data/lib/ember_cli/route_helpers.rb

@@ -12,7 +12,6 @@ module ActionDispatch
         routing_options.reverse_merge!(
           controller: "ember_cli/ember",
           action: "index",
-          format: :html,
         )
 
         scope constraints: ::EmberCli::EmberConstraint.new do

data/lib/ember_cli/shell.rb

@@ -1,3 +1,5 @@
+require "shellwords"
+
 require "ember_cli/command"
 require "ember_cli/runner"
 
@@ -62,7 +64,7 @@ module EmberCli
 
     def install
       if paths.gemfile.exist?
-        run! "#{paths.bundler} install"
+        run! "#{executable(paths.bundler)} install"
       end
 
       if invalid_ember_dependencies?
@@ -71,15 +73,17 @@ module EmberCli
 
       case paths.package_manager
       when :yarn
-        run! "#{paths.yarn} install"
+        run! "#{executable(paths.yarn)} install"
       when :pnpm
-        run! "#{paths.pnpm} install"
+        run! "#{executable(paths.pnpm)} install"
       else
-        run! "#{paths.npm} prune && #{paths.npm} install"
+        npm = executable(paths.npm)
+        run! "#{npm} prune && #{npm} install"
       end
 
       if paths.bower_json.exist?
-        run! "#{paths.bower} prune && #{paths.bower} install"
+        bower = executable(paths.bower)
+        run! "#{bower} prune && #{bower} install"
       end
     end
 
@@ -94,8 +98,14 @@ module EmberCli
 
     delegate :run, :run!, to: :runner
 
+    # The executables come from configuration and the filesystem, so quote
+    # them before interpolating them into a command line for the shell.
+    def executable(path)
+      Shellwords.escape(path.to_s)
+    end
+
     def invalid_ember_dependencies?
-      !run("#{paths.ember} version").success?
+      !run("#{executable(paths.ember)} version").success?
     rescue DependencyError
       false
     end

data/lib/ember_cli/version.rb

@@ -1,3 +1,3 @@
 module EmberCli
-  VERSION = "0.14.2".freeze
+  VERSION = "0.14.3".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ember-cli-rails
 version: !ruby/object:Gem::Version
-  version: 0.14.2
+  version: 0.14.3
 platform: ruby
 authors:
 - Pavel Pravosud
@@ -216,7 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Integration between Ember CLI and Rails
 test_files: []