ember-cli-rails 0.10.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0e8e3eae43c6174217f04aa96d57a7396f6b1ba8
-  data.tar.gz: c8d43e9a2efd2b5a9367d6fa974fa3ccedd4bb69
+SHA256:
+  metadata.gz: ed137eea5bdc56c6a89bbfaca9ccb77aa477c7d2c15c7cc363aea86148e194a9
+  data.tar.gz: 5b87d3079ad0dba80afc777be24fa7c374ffc44f6b9d14095b08848af41535e7
 SHA512:
-  metadata.gz: c1f9f0227c30692510edba35b843344b25e839c003437c92df089312c20803246653f9c7e88fddd3ff08d7f684a5ee57c073af3709b64a98e3014ba886442d79
-  data.tar.gz: a0789e42c15df281a2cd76ce4e61b30688eb1d60e0a28cd7ab81b9b819b0927b525dbeb1b2b4e0c384e795390ef2f08c327bb6934277b0ccd38707502a70e2ea
+  metadata.gz: e013d35a791907b4df054156abf9d111e36dd68ac1f0e1da2173310940a2ab657112619a5edf05109e64a427846936004cdb39e22fd83bb373d981c3fba1b709
+  data.tar.gz: e19ea5bd822a38c5004f1f8de21a6d5cf2866626e87132cdf8d1bfe40a7402f7edd90a3c4420bf6337fd4c4788dad4f1fbccdac91d5abbcaae04a95606401220

data/CHANGELOG.md

@@ -1,6 +1,28 @@
 master
 ------
 
+0.12.0
+------
+
+* Redirecting with trailing slash with query parameters
+* Recognize Building notice as not an error
+* Use keyword argument for options
+* Add Ruby 2.7 & 3.0 into CI matrix
+* Add missing gems that removed from stdlibs in Ruby 3.0.0
+* Fix autoload deprecation in Rails 6
+* Drop support for Rails versions 4.2, 5.0, 5.1, and 5.2
+* Drop support for End-of-Lifed Ruby versions 2.3 and 2.4
+
+0.11.0
+------
+
+* Switch from TravisCI to GitHub Actions for Continuous Integration
+* Redirect Ember routes with paths that don't end in `/` to corresponding paths
+  that end in `/`.
+* Don't route requests to `/rails/active_storage` through the mounted Ember application.
+* Only support for Ruby versions >= 2.5
+* Only support for Rails versions >= 5.2
+
 0.10.0
 ------
 

data/README.md

@@ -421,7 +421,7 @@ To override this behavior, you can specify [any of Rails' routing options]
 For the sake of this example, override the `controller` and `action` options:
 
 ```rb
-# config/routes
+# config/routes.rb
 
 Rails.application.routes.draw do
   mount_ember_app :frontend, to: "/", controller: "application", action: "index"
@@ -660,8 +660,8 @@ This project supports:
 
 This project supports:
 
-* Ruby versions `>= 2.2.0`
-* Rails versions `>=4.2.x`.
+* Ruby versions `>= 2.5.0`
+* Rails versions `>=5.2.x`.
 
 To learn more about supported versions and upgrades, read the [upgrading guide].
 

data/lib/ember_cli/build_monitor.rb

@@ -42,7 +42,8 @@ module EmberCli
     def build_errors
       error_lines.
         reject { |line| is_blank_or_backtrace?(line) }.
-        reject { |line| is_deprecation_warning?(line) }
+        reject { |line| is_deprecation_warning?(line) }.
+        reject { |line| is_building_notice?(line) }
     end
 
     def has_build_errors?
@@ -57,6 +58,10 @@ module EmberCli
       line =~ /^(\e[^\s]+)?DEPRECATION:/
     end
 
+    def is_building_notice?(line)
+      line =~ /^(\e[^\s]+)?.\s(\e[^\s]+)?Building/
+    end
+
     def error_lines
       if error_file_exists?
         error_file.readlines

data/lib/ember_cli/command.rb

@@ -1,4 +1,4 @@
-require "cocaine"
+require "terrapin"
 
 module EmberCli
   class Command
@@ -8,7 +8,7 @@ module EmberCli
     end
 
     def test
-      line = Cocaine::CommandLine.new(paths.ember, "test --environment test")
+      line = Terrapin::CommandLine.new(paths.ember, "test --environment test")
 
       line.command
     end
@@ -30,7 +30,7 @@ module EmberCli
     end
 
     def ember_build(watch: false)
-      line = Cocaine::CommandLine.new(paths.ember, [
+      line = Terrapin::CommandLine.new(paths.ember, [
         "build",
         ("--watch" if watch),
         ("--watcher :watcher" if process_watcher),

data/lib/ember_cli/configuration.rb

@@ -8,7 +8,7 @@ module EmberCli
     attr_accessor :watcher
 
     def app(name, **options)
-      app = App.new(name, options)
+      app = App.new(name, **options)
       apps.store(name, app)
     end
 

data/lib/ember_cli/ember_constraint.rb

@@ -1,7 +1,9 @@
 module EmberCli
   class EmberConstraint
     def matches?(request)
-      html_request?(request) && !rails_info_request?(request)
+      html_request?(request) &&
+        !rails_info_request?(request) &&
+        !rails_active_storage_request?(request)
     end
 
     private
@@ -10,6 +12,10 @@ module EmberCli
       request.fullpath.start_with?("/rails/info", "/rails/mailers")
     end
 
+    def rails_active_storage_request?(request)
+      request.fullpath.start_with?("/rails/active_storage")
+    end
+
     def html_request?(request)
       request.format.html?
     end

data/lib/ember_cli/engine.rb

@@ -1,10 +1,7 @@
 module EmberCli
   class Engine < Rails::Engine
     initializer "ember-cli-rails.setup" do
-      require "ember_cli/ember_controller"
       require "ember_cli/route_helpers"
-
-      ActionController::Base.helper EmberRailsHelper
     end
   end
 end

data/lib/ember_cli/path_set.rb

@@ -92,7 +92,16 @@ module EmberCli
 
     def yarn
       if yarn?
-        @yarn ||= path_for_executable("yarn")
+        @yarn ||= path_for_executable("yarn").tap do |yarn|
+          unless File.executable?(yarn.to_s)
+            fail DependencyError.new(<<-MSG.strip_heredoc)
+                EmberCLI has been configured to install NodeJS dependencies with Yarn, but the Yarn executable is unavailable.
+
+                Install it by following the instructions at https://yarnpkg.com/lang/en/docs/install/
+
+            MSG
+          end
+        end
       end
     end
 

data/lib/ember_cli/route_helpers.rb

@@ -1,4 +1,5 @@
 require "ember_cli/ember_constraint"
+require "ember_cli/trailing_slash_constraint"
 
 module ActionDispatch
   module Routing
@@ -15,7 +16,15 @@ module ActionDispatch
         )
 
         scope constraints: ::EmberCli::EmberConstraint.new do
-          get("#{to}(*rest)", routing_options)
+          redirect_if_missing_trailing_slash = {
+            constraints: EmberCli::TrailingSlashConstraint.new,
+            to: redirect(-> (_, request) {
+              File.join(request.path, "/?#{request.query_parameters.to_query}")
+            }),
+          }
+
+          get(to, redirect_if_missing_trailing_slash)
+          get(File.join(to, "(*rest)"), routing_options)
         end
 
         mount_ember_assets(app_name, to: to)

data/lib/ember_cli/shell.rb

@@ -41,7 +41,7 @@ module EmberCli
         clean_ember_dependencies!
       end
 
-      if paths.yarn.present? && Pathname.new(paths.yarn).executable?
+      if paths.yarn
         run! "#{paths.yarn} install"
       else
         run! "#{paths.npm} prune && #{paths.npm} install"

data/lib/ember_cli/trailing_slash_constraint.rb

@@ -0,0 +1,7 @@
+module EmberCli
+  class TrailingSlashConstraint
+    def matches?(request)
+      !request.original_fullpath.to_s.split("?").first.end_with?("/")
+    end
+  end
+end

data/lib/ember_cli/version.rb

@@ -1,3 +1,3 @@
 module EmberCli
-  VERSION = "0.10.0".freeze
+  VERSION = "0.12.0".freeze
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: ember-cli-rails
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Pavel Pravosud
 - Jonathan Jackson
 - Sean Doyle
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-09-01 00:00:00.000000000 Z
+date: 2023-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ember-cli-rails-assets
@@ -32,28 +32,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
-  name: cocaine
+  name: terrapin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.8
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: html_page
   requirement: !ruby/object:Gem::Requirement
@@ -82,7 +82,49 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.0
-description: 
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.6.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.6.0
+- !ruby/object:Gem::Dependency
+  name: capybara-selenium
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+description:
 email:
 - pavel@pravosud.com
 - jonathan.jackson1@me.com
@@ -112,6 +154,7 @@ files:
 - lib/ember_cli/route_helpers.rb
 - lib/ember_cli/runner.rb
 - lib/ember_cli/shell.rb
+- lib/ember_cli/trailing_slash_constraint.rb
 - lib/ember_cli/version.rb
 - lib/generators/ember/heroku/USAGE
 - lib/generators/ember/heroku/heroku_generator.rb
@@ -125,7 +168,7 @@ homepage: https://github.com/thoughtbot/ember-cli-rails
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -133,16 +176,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.7.6.2
+signing_key:
 specification_version: 4
 summary: Integration between Ember CLI and Rails
 test_files: []