embedded_localization 0.2.2 → 0.2.3

data/README.textile

@@ -81,7 +81,7 @@ end
 
 h4. NOTE:
 
-EmbeddedLocalization implementations < 0.2.0 have the drawback that you can not do SQL queries on translated attributes.
+EmbeddedLocalization implementations < 0.2.0 had the drawback that you can not do SQL queries on translated attributes.
 
 To eliminate this limitation, you can now define any translated attribute as a first-class database column in your migration. If you define a translated attribute as a column, EmbeddedLocalization will store the attribute value for I18n.default_locale in that column, so you can search for it. After defining the column, and running the migration, you need to populate the column initially. It will auto-update every time you write while you are using I18n.default_locale .
 e.g.:
@@ -205,6 +205,9 @@ If your requirements are different, my approach might not work for you. In that
 
 h2. Changes
 
+h3. 0.2.3 (2012-03-02)
+* Issue #4 : bugfix for attr_writer - no longer updates attributes if value didn't change => timestamps don't change in that case 
+
 h3. 0.2.2 (2012-02-06)
 * bugfix for attr_writer
 

data/lib/embedded_localization/active_record/act_macro.rb

@@ -67,6 +67,12 @@ module EmbeddedLocalization
             # define the setter method
             #
             define_method(attr_name.to_s+ '=') do |new_translation|
+              # first check if nothing changed - then we can just return, so that timestamps and other records don't get touched
+              if self.i18n.class == Hash && (self.i18n[I18n.locale]) && (self.i18n[I18n.locale][attr_name.to_sym] == new_translation)
+                return if (I18n.locale != I18n.default_locale)
+                return if (I18n.locale == I18n.default_locale) && (read_attribute(attr_name) == new_translation) # both i18n and attr_name need to be equal to new_translation
+              end
+
               self.i18n_will_change!     # for ActiveModel Dirty tracking
               if self.attributes.has_key?(attr_name.to_s)  # if user has defined DB field with that name
                 write_attribute(attr_name , new_translation) if I18n.locale == I18n.default_locale

data/lib/embedded_localization/active_record/instance_methods.rb

@@ -17,6 +17,12 @@ module EmbeddedLocalization
       end
       
       def set_localized_attribute(attr_name, locale, new_translation)
+        # first check if nothing changed - then we can just return, so that timestamps and other records don't get touched
+        if self.i18n.class == Hash && (self.i18n[I18n.locale]) && (self.i18n[I18n.locale][attr_name.to_sym] == new_translation)
+          return if (I18n.locale != I18n.default_locale)
+          return if (I18n.locale == I18n.default_locale) && (read_attribute(attr_name) == new_translation) # both i18n and attr_name need to be equal to new_translation
+        end
+
         self.i18n_will_change!     # for ActiveModel Dirty tracking
         if self.attributes.has_key?(attr_name.to_s)  # if user has defined DB field with that name
           write_attribute(attr_name , new_translation) if locale == I18n.default_locale

data/lib/embedded_localization/version.rb

@@ -1,3 +1,3 @@
 module EmbeddedLocalization
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

metadata

@@ -2,7 +2,7 @@
 name: embedded_localization
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors: 
 - Tilo Sloboda
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-07 00:00:00 Z
+date: 2012-03-02 00:00:00 Z
 dependencies: []
 
 description: "Rails I18n: Embedded_Localization for ActiveRecord 3 is very lightweight, and allows you to transparently store translations of attributes right inside each record -- no extra database tables needed to store the localization data!"