emarsys 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc2e05dfded9bc3e85a484b0a100dd0bbee2c4c3
-  data.tar.gz: c6a286becd3fb612d9e379f794430e5f8fa6740c
+  metadata.gz: 6ae8a2be8a9eb47480f0dfa43f730039a5fc8129
+  data.tar.gz: 97ac47f4b22dc3eca4146573fb714aa7c7104280
 SHA512:
-  metadata.gz: a27a34fa7afd4d4e182dfa6e6d8948490f8d095cacca5c3fc018d1a45c699588e91ee75fe193ac395c88654f7876e23f73e9df3c0412150d2c5dce05c26556dd
-  data.tar.gz: c344e9354da2b659f2edb4243d9b5e8a8abce6a124b4b83886bd4ac210cfe2ae564038ef62e639d549529f38ce4988342dc5e414cd0091694d163e5f1314dd4d
+  metadata.gz: deb3b4aa58dad053e9bf7fb61e87146d118a83e9eee652f1d6076195a29935138b147982fb3a128bb65d7f3d03f59efee3acddb981fc337a31005d4a3c4c6545
+  data.tar.gz: 7022cdbe34e40380b0c17ff50860055acdd036a037435debb72d89c95b09eb2542a2ca93e691a7964629cc5d43dd8d75d8020d602739b95af2953d9253e4d866

data/README.md

@@ -208,6 +208,10 @@ Please refer to the code for detailed instructions of each method.
 
 ### HEAD (not yet released)
 
+### v0.2.3
+
+* Convert params when using the batch APIs ([#25](https://github.com/Absolventa/emarsys-rb/pull/25))
+
 ### v0.2.2
 
 * Allow batch updates to create missing contacts ([#22](https://github.com/Absolventa/emarsys-rb/pull/22))

data/lib/emarsys/data_objects/contact.rb

@@ -61,7 +61,10 @@ module Emarsys
       #
       # TODO params should be parameterized with field mappings
       def create_batch(key_id, params = [])
-        post "contact", {'key_id' => transform_key_id(key_id), 'contacts' => params}
+        converted_params = params.map do |p|
+          Emarsys::ParamsConverter.new(p).convert_to_ids
+        end
+        post "contact", {'key_id' => transform_key_id(key_id), 'contacts' => converted_params}
       end
 
       # Batch update of contacts.
@@ -77,10 +80,12 @@ module Emarsys
       #     true
       #   )
       #
-      # TODO params should be parameterized with field mappings
       def update_batch(key_id, params = [], create_if_not_exists = false)
         path = "contact#{create_if_not_exists ? '/?create_if_not_exists=1' : ''}"
-        put path, {'key_id' => transform_key_id(key_id), 'contacts' => params}
+        converted_params = params.map do |p|
+          Emarsys::ParamsConverter.new(p).convert_to_ids
+        end
+        put path, {'key_id' => transform_key_id(key_id), 'contacts' => converted_params}
       end
 
       # Get list of emails send to a contact

data/lib/emarsys/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Emarsys
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/emarsys/data_objects/contact_spec.rb

@@ -40,6 +40,13 @@ describe Emarsys::Contact do
       Emarsys::Contact.create_batch(3, stub_params)
       expect(stub).to have_been_requested.once
     end
+    it "transforms identifiers to IDs for each contact parameter set" do
+      given_params = [{'_firstname' => 'Jane', '_lastname' => "Doe"}, {'_firstname' => 'Paul', '_lastname' => 'Tester'}]
+      expected_params = [{1 => 'Jane', 2 => "Doe"}, {1 => 'Paul', 2 => 'Tester'}]
+      stub = stub_request(:post, "https://api.emarsys.net/api/v2/contact").with(:body => {'key_id' => 3, 'contacts' => expected_params}.to_json).to_return(standard_return_body)
+      Emarsys::Contact.create_batch('_email', given_params)
+      expect(stub).to have_been_requested.once
+    end
   end
 
   describe ".update_batch" do
@@ -49,6 +56,13 @@ describe Emarsys::Contact do
       Emarsys::Contact.update_batch(3, stub_params)
       expect(stub).to have_been_requested.once
     end
+    it "transforms identifiers to IDs for each contact parameter set" do
+      given_params = [{'_firstname' => 'Jane', '_lastname' => "Doe"}, {'_firstname' => 'Paul', '_lastname' => 'Tester'}]
+      expected_params = [{1 => 'Jane', 2 => "Doe"}, {1 => 'Paul', 2 => 'Tester'}]
+      stub = stub_request(:put, "https://api.emarsys.net/api/v2/contact").with(:body => {'key_id' => 3, 'contacts' => expected_params}.to_json).to_return(standard_return_body)
+      Emarsys::Contact.update_batch('_email', given_params)
+      expect(stub).to have_been_requested.once
+    end
     it "may create non-existing contacts" do
       stub_params = [{1 => 'Jane', 2 => "Doe"}, {1 => 'Paul', 2 => 'Tester'}]
       stub = stub_request(:put, "https://api.emarsys.net/api/v2/contact/?create_if_not_exists=1").with(:body => {'key_id' => 3, 'contacts' => stub_params}.to_json).to_return(standard_return_body)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: emarsys
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Daniel Schoppmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-13 00:00:00.000000000 Z
+date: 2017-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client