email_reply_parser 0.5.6 → 0.5.7

data/email_reply_parser.gemspec

@@ -76,6 +76,7 @@ Gem::Specification.new do |s|
     test/emails/email_1_5.txt
     test/emails/email_1_6.txt
     test/emails/email_1_7.txt
+    test/emails/email_1_8.txt
     test/emails/email_2_1.txt
     test/emails/email_2_2.txt
     test/emails/email_BlackBerry.txt

data/lib/email_reply_parser.rb

@@ -30,7 +30,7 @@ require 'strscan'
 #
 # [mail]: https://github.com/mikel/mail
 class EmailReplyParser
-  VERSION = "0.5.6"
+  VERSION = "0.5.7"
 
   # Public: Splits an email body into a list of Fragments.
   #
@@ -84,7 +84,7 @@ class EmailReplyParser
 
       # Check for multi-line reply headers. Some clients break up
       # the "On DATE, NAME <EMAIL> wrote:" line into multiple lines.
-      if text =~ /^(On\s(.+)wrote:)$/nm
+      if text =~ /^(On\s(.+?)wrote:)$/nm
         # Remove all new lines from the reply header.
         text.gsub! $1, $1.gsub("\n", " ")
       end

data/test/email_reply_parser_test.rb

@@ -63,6 +63,26 @@ I am currently using the Java HTTP API.\n", reply.fragments[0].to_s
     assert_match /^_/, reply.fragments[5].to_s
   end
 
+  def test_reads_inline_replies
+    reply = email(:email_1_8)
+    assert_equal 7, reply.fragments.size
+
+    assert_equal [true, false, true, false, true, false, false],
+      reply.fragments.map { |f| f.quoted? }
+    assert_equal [false, false, false, false, false, false, true],
+      reply.fragments.map { |f| f.signature? }
+    assert_equal [false, false, false, false, true, true, true],
+      reply.fragments.map { |f| f.hidden? }
+
+    assert_match /^On [^\:]+\:/, reply.fragments[0].to_s
+    assert_match /^I will reply/, reply.fragments[1].to_s
+    assert_match "okay?", reply.fragments[2].to_s
+    assert_match /^and under this./, reply.fragments[3].to_s
+    assert_match /inline/, reply.fragments[4].to_s
+    assert_equal "\n", reply.fragments[5].to_s
+    assert_equal "--\nHey there, this is my signature\n", reply.fragments[6].to_s
+  end
+
   def test_recognizes_date_string_above_quote
     reply = email :email_1_4
 

data/test/emails/email_1_8.txt

@@ -0,0 +1,37 @@
+On Tue, Apr 29, 2014 at 4:22 PM, Example Dev <sugar@example.com>wrote:
+
+> okay.  Well, here's some stuff I can write.
+>
+> And if I write a 2 second line you and maybe reply under this?
+>
+> Or if you didn't really feel like it, you could reply under this line.Or
+> if you didn't really feel like it, you could reply under this line. Or if
+> you didn't really feel like it, you could reply under this line. Or if you
+> didn't really feel like it, you could reply under this line.
+>
+
+I will reply under this one
+
+>
+> okay?
+>
+
+and under this.
+
+>
+> -- Tim
+>
+> On Tue, April 29, 2014 at 4:21 PM, Tim Haines <tmhaines@example.com> wrote:
+> > hi there
+> >
+> > After you reply to this I'm going to send you some inline responses.
+> >
+> > --
+> > Hey there, this is my signature
+>
+>
+>
+
+
+--
+Hey there, this is my signature

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: email_reply_parser
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.5.7
   prerelease: 
 platform: ruby
 authors:
@@ -33,6 +33,7 @@ files:
 - test/emails/email_1_5.txt
 - test/emails/email_1_6.txt
 - test/emails/email_1_7.txt
+- test/emails/email_1_8.txt
 - test/emails/email_2_1.txt
 - test/emails/email_2_2.txt
 - test/emails/email_BlackBerry.txt