email_repair 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d81deac964185bcd7e75e10d32bb25af1e591250
-  data.tar.gz: d8001888aac57df3008c145e4c5ea344fa760efa
+  metadata.gz: a87714cd558a4ce9a5ffe176b2dcfc379f2b771b
+  data.tar.gz: 8322e71366d7e121483b368cdfa83e235d413560
 SHA512:
-  metadata.gz: ab4bce6136b84fae7ea1ab9c3cc8ca95b7e5dfc6e7053286cdc93b5eed6a26668c9ea6d1d9188024aceb7fd5e578327452e3cc91ec07f720dd0e56e16cce9a68
-  data.tar.gz: cd70ccc7af7c13ec14628a58c36c0d964679b7a3ed8f5f4a08fb2f7273085d00935d27501af85a83c99017a38de66721a051848dfbda239c47ed0fe2f9555b49
+  metadata.gz: 8771c5ce3aa48dec34961e30285df05f14b1d99711772248f94306b23d573c5f5d4bc00ca8c1f9a5d50a2fa927b3504f55656176fb8664937a26249ecc6e93f7
+  data.tar.gz: 1c8f55a9e3e83df59cbb22d1994977455d904645701c2b685b48107985654e14a4a592d6ae3e518b04e56f5161334f6de279bd8cd1a89dd0c28be20d3dc153d5

data/lib/email_repair/mechanic.rb

@@ -42,10 +42,10 @@ module EmailRepair
     class CommonMistakeRepair
       def self.repair(email)
         email.downcase
-          .gsub(/\s/, '')
-          .sub(/@+/, '@')
-          .sub(/\.c0m$/, '.com')
-          .sub(/,[a-z]{2,24}$/) { |m| m.sub(',', '.') }
+             .gsub(/\s/, '')
+             .sub(/@+/, '@')
+             .sub(/\.c0m$/, '.com')
+             .sub(/,[a-z]{2,24}$/) { |m| m.sub(',', '.') }
       end
     end
 
@@ -58,7 +58,7 @@ module EmailRepair
 
     class CommonDomainRepair
       def self.repair(*)
-        fail 'not implemented'
+        raise 'not implemented'
       end
 
       def self.common_domains
@@ -78,7 +78,7 @@ module EmailRepair
     class CommonDomainSuffixRepair < CommonDomainRepair
       def self.repair(email)
         common_domains.each do |name, suffix|
-          email = "#{email}.#{suffix}" if email.match(/#{name}$/)
+          email = "#{email}.#{suffix}" if email.match?(/#{name}$/)
         end
         email
       end
@@ -100,7 +100,7 @@ module EmailRepair
           punc_regex = /[.#-]#{name}.#{suffix}$/
           if email.match(punc_regex)
             email = email.sub(punc_regex, "@#{name}.#{suffix}")
-          elsif email.match(/[^@]#{name}.#{suffix}$/)
+          elsif email.match?(/[^@]#{name}.#{suffix}$/)
             email = email.sub(/#{name}.#{suffix}$/, "@#{name}.#{suffix}")
           end
         end

data/lib/email_repair/version.rb

@@ -1,3 +1,3 @@
 module EmailRepair
-  VERSION = '0.2.0'
+  VERSION = '1.0.0'.freeze
 end

data/spec/lib/email_repair/mechanic_spec.rb

@@ -2,12 +2,11 @@ require 'spec_helper'
 
 module EmailRepair
   describe Mechanic, '#repair_all' do
-
     it 'sanitizes an array of emails and returns bulk results' do
       mechanic = Mechanic.new
-      salvageable_emails = %w(One@@two.com three@four.com one@twO.com)
-      sanitized_emails = %w(one@two.com three@four.com)
-      bad_emails = %w(bleep@blop plooooooop plooOOooop)
+      salvageable_emails = %w[One@@two.com three@four.com one@twO.com]
+      sanitized_emails = %w[one@two.com three@four.com]
+      bad_emails = %w[bleep@blop plooooooop plooOOooop]
 
       result = mechanic.repair_all(salvageable_emails + bad_emails)
       expect(result.sanitized_emails).to match_array sanitized_emails
@@ -23,7 +22,6 @@ module EmailRepair
       expect(result.sanitized_emails).to eq ['bleep@bloop.com']
       expect(result.invalid_emails).to eq []
     end
-
   end
 
   describe Mechanic, '#repair' do
@@ -34,7 +32,7 @@ module EmailRepair
       # http://www.stuffaboutcode.com/2013/02/validating-email-address-bloody.html
       # List of longest TLDs
       # https://jasontucker.blog/8945/what-is-the-longest-tld-you-can-get-for-a-domain-name
-      good_emails = %w(
+      good_emails = %w[
         b@b.com
         lobatifricha@gmail.com
         mrspicy+whocares@whatevs.com
@@ -43,7 +41,7 @@ module EmailRepair
         b@mps.school
         b@kickstarter.engineering
         b@joyful.christmas
-      )
+      ]
 
       good_emails.each do |good_email|
         expect(mechanic.repair(good_email)).to eq good_email
@@ -73,7 +71,7 @@ module EmailRepair
     end
 
     it 'adds missing .com' do
-      no_com_mails = %w(blah@gmail bloo@yahoo blee@hotmail)
+      no_com_mails = %w[blah@gmail bloo@yahoo blee@hotmail]
       no_com_mails.each do |no_com_mail|
         expect(mechanic.repair(no_com_mail)).to eq "#{no_com_mail}.com"
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: email_repair
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Holman Gao
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-03 00:00:00.000000000 Z
+date: 2018-03-28 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -47,7 +47,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Library to fix invalid emails