email_format_validator 1.0.0 → 1.0.1

data/README.md

@@ -22,9 +22,18 @@ You can turn on RFC 822 compliant email verification by passing on:
 
 Be aware that this is disabled by default as websites will often need a less permissive email check than the RFC one (check out tests for more details).
 
-You can also modify the default message if validation fails:
+You can also modify the default message ("is improperly formatted") if validation fails:
 
-    validates :email, :email_format => { :message => "is not formatted properly" }
+    validates :email, :email_format => { :message => "is not well formatted" }
+
+I18n
+----
+
+If you use I18n, the default key to translate is :improperly_formatted. So if you add to your User model:
+
+    validates :email, :email_format => true
+
+You can translate (or overload) the default message via for e.g. (in english): "en.activerecord.errors.models.user.attributes.email.improperly_formatted"
 
 Tests
 -----

data/email_format_validator.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "email_format_validator"
-  s.version     = "1.0.0"
+  s.version     = "1.0.1"
   s.authors     = ["Axel Vergult"]
   s.email       = ["axel.vergult@gmail.com"]
   s.homepage    = "https://github.com/episko/email_format_validator"

data/lib/email_format_validator.rb

@@ -23,7 +23,7 @@ class EmailFormatValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     pattern_choosed = options[:rfc] ? Patterns::EMAIL : Patterns::LESS_RFC_COMPLIANT_EMAIL
     unless value =~ pattern_choosed
-      record.errors.add(attribute, options[:message] || :invalid)
+      record.errors.add(attribute, options[:message] || I18n.t(:improperly_formatted, :default => "is improperly formatted"))
     end
   end
 

data/test/email_format_validator_test.rb

@@ -19,7 +19,7 @@ class TestUserAllowsNilToFalse < TestModel
 end
 
 class TestUserWithMessage < TestModel
-  validates :email, :email_format => { :message => 'is not formatted properly' }
+  validates :email, :email_format => { :message => 'is not well formatted' }
 end
 
 class TestEmailFormatValidator < MiniTest::Unit::TestCase
@@ -172,13 +172,13 @@ class TestEmailFormatValidator < MiniTest::Unit::TestCase
   def test_default_message_on_error
     test_user = TestUser.new(:email => "invalid_email@")
     refute test_user.valid?
-    assert test_user.errors[:email].include?("is invalid")
+    assert test_user.errors[:email].include?("is improperly formatted")
   end
 
   def test_custom_message_on_error
     test_user = TestUserWithMessage.new(:email => "invalid_email@")
     refute test_user.valid?
-    assert test_user.errors[:email].include?("is not formatted properly")
+    assert test_user.errors[:email].include?("is not well formatted")
   end
 
   def test_nil_email_when_allow_nil_option_is_not_set

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: email_format_validator
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-10 00:00:00.000000000Z
+date: 2011-11-14 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70274998467980 !ruby/object:Gem::Requirement
+  requirement: &70357299095340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70274998467980
+  version_requirements: *70357299095340
 description: A Rails 3 email format validator with RFC 822 compliant option
 email:
 - axel.vergult@gmail.com