email_address 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57afc3d96aad109de1df3904de39a5abe068363f
-  data.tar.gz: 968572e1c29c8c0f71b14a8e449da7314e83c3c6
+  metadata.gz: 86863c7db99499852dc1d4176ecef8a8a372124c
+  data.tar.gz: e646a1808a0ca57048be6bcdb945c3621cfd053c
 SHA512:
-  metadata.gz: 0c0381813f1572a9071db541f353dc135b807359f1dc217d7f6e87096079c61074763697955f849dc6b1cf3d0b279744172a0d41a78c15408123431085921ed8
-  data.tar.gz: ec0f98df2a8b9a177ff3514f752d49bef6f7160c751d75325de58e4429b74062a2205df1a477ac3ef5d37974bf5fe2744138511dbc1f91a64d930ba946cf9d95
+  metadata.gz: 51c31c52963534e41a74cb87ead583be88ddaa08e630fd3ebe8540acbf015d50d63418893ac84f540b39067db00ab37d0a0de17a20604a3ae6dd3dafe93c42cf
+  data.tar.gz: d356139bb7776f3dc82449f6b27240dd99ec7fe4ab704d2be0177bce9dc7b8a71924944b0340742eb050a85c4b1aa2b28786f1a13e882f48e818bfa906680472

data/README.md

@@ -26,6 +26,41 @@ want to continue using with your current version.
 
 Requires Ruby 2.0 or later.
 
+## Quick Start
+
+To quickly validate email addresses, use the valid? and error helpers.
+`valid?` returns a boolean, and `error` returns nil if valid, otherwise
+a basic error message.
+
+    EmailAddress.valid? "allen@google.com" #=> true
+    EmailAddress.error "allen@bad-d0main.com" #=> "Invalid Host/Domain Name"
+
+`EmailAddress` deeply validates your email addresses. It checks:
+
+* Host name format and DNS setup
+* Mailbox format according to "conventional" form. This matches most used user
+  email accounts, but is a subset of the RFC specification.
+
+It does not check:
+
+* The mail server is configured to accept connections
+* The mailbox is valid and accepts email.
+
+By default, MX records are required in DNS. MX or "mail exchanger" records
+tell where to deliver email for the domain. Many domains run their
+website on one provider (ISP, Heroku, etc.), and email on a different
+provider (such as Google Apps).  Note that `example.com`, while
+a valid domain name, does not have MX records.
+
+    EmailAddress.valid? "allen@example.com" #=> false
+    EmailAddress.valid? "allen@example.com", dns_lookup: :off #=> true
+
+Most mail servers do not yet support Unicode mailboxes, so the default here is ASCII.
+
+    EmailAddress.error "Pelé@google.com" #=> "Invalid Recipient/Mailbox"
+    EmailAddress.valid? "Pelé@google.com", local_encoding: :unicode #=> true
+
+
 ## Background
 
 The email address specification is complex and often not what you want

data/email_address.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest",     "~> 5.8.3"
   spec.add_development_dependency "bundler",      "~> 1.3"
-  spec.add_development_dependency "activerecord", "~> 5.0.1"         if RUBY_PLATFORM != 'java'
+  spec.add_development_dependency "activerecord", "~> 5.1.3"         if RUBY_PLATFORM != 'java'
   spec.add_development_dependency "activerecord", "~> 4.2.5"         if RUBY_PLATFORM == 'java'
   spec.add_development_dependency "sqlite3"                          if RUBY_PLATFORM != 'java'
   spec.add_development_dependency "activerecord-jdbcsqlite3-adapter" if RUBY_PLATFORM == 'java'

data/lib/email_address/host.rb

@@ -144,7 +144,11 @@ module EmailAddress
 
     def host_name=(name)
       @host_name = name = name.strip.downcase.gsub(' ', '').gsub(/\(.*\)/, '')
-      @dns_name  = ::SimpleIDN.to_ascii(self.host_name)
+      if host_name =~ /[^[:ascii:]]/
+        @dns_name  = ::SimpleIDN.to_ascii(self.host_name)
+      else
+        @dns_name  = self.host_name
+      end
 
       # Subdomain only (root@localhost)
       if name.index('.').nil?
@@ -166,6 +170,9 @@ module EmailAddress
         end
         self.domain_name = self.registration_name + '.' + self.tld2
         self.find_provider
+      else # Bad format
+        self.subdomains = self.tld = self.tld2 = ""
+        self.domain_name = self.registration_name = name
       end
     end
 
@@ -356,9 +363,7 @@ module EmailAddress
 
     # Returns true if the host name is valid according to the current configuration
     def valid?(rule=@config[:dns_lookup]||:mx)
-      if self.provider != :default # well known
-        true
-      elsif self.ip_address
+      if self.ip_address
         @config[:host_allow_ip] && self.valid_ip?
       elsif rule == :mx
         self.exchangers.mx_ips.size > 0
@@ -378,9 +383,9 @@ module EmailAddress
       if self.ip_address.nil?
         false
       elsif self.ip_address.include?(":")
-        self.ip_address =~ Resolv::IPv6::Regex
+        self.ip_address =~ Resolv::IPv6::Regex ? true : false
       elsif self.ip_address.include?(".")
-        self.ip_address =~ Resolv::IPv4::Regex
+        self.ip_address =~ Resolv::IPv4::Regex ? true : false
       end
     end
 

data/lib/email_address/local.rb

@@ -122,10 +122,10 @@ module EmailAddress
       if raw =~ /\A\"(.*)\"\z/ # Quoted
         raw = $1
         raw.gsub!(/\\(.)/, '\1') # Unescape
-      elsif @config[:local_fix]
+      elsif @config[:local_fix] && @config[:local_format] != :standard
         raw.gsub!(' ','')
         raw.gsub!(',','.')
-        raw.gsub!(/([^\p{L}\p{N}]{2,10})/) {|s| s[0] } # Stutter punctuation typo
+        #raw.gsub!(/([^\p{L}\p{N}]{2,10})/) {|s| s[0] } # Stutter punctuation typo
       end
       raw, comment = self.parse_comment(raw)
       mailbox, tag = self.parse_tag(raw)
@@ -314,7 +314,7 @@ module EmailAddress
 
     def valid_encoding?(enc=@config[:local_encoding]||:ascii)
       return false if enc == :ascii && self.unicode?
-      return false if enc == :unicode && self.ascii?
+      #return false if enc == :unicode && self.ascii?
       true
     end
 

data/lib/email_address/version.rb

@@ -1,3 +1,3 @@
 module EmailAddress
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/email_address/test_address.rb

@@ -92,4 +92,10 @@ class TestAddress < Minitest::Test
     assert true, EmailAddress.valid?("first_last@hotmail.com") # #8
   end
 
+  def test_issue9
+    assert ! EmailAddress.valid?('example.user@foo.')
+    assert ! EmailAddress.valid?('ogog@sss.c')
+    assert ! EmailAddress.valid?('example.user@foo.com/')
+  end
+
 end

data/test/email_address/test_host.rb

@@ -101,4 +101,12 @@ class TestHost < MiniTest::Test
     assert EmailAddress.valid?('test@jiff.com', dns_lookup: :mx)
     assert ! EmailAddress.valid?('test@gmail.com', dns_lookup: :mx)
   end
+
+  def test_yahoo_bad_tld
+    assert ! EmailAddress.valid?('test@yahoo.badtld')
+  end
+
+  def test_bad_formats
+    #assert EmailAddress::Host.new('example.com:w').registration_name
+  end
 end

data/test/email_address/test_local.rb

@@ -48,6 +48,7 @@ class TestLocal < MiniTest::Test
   def test_unicode
     assert ! EmailAddress::Local.new("üñîçøðé1", local_encoding: :ascii).standard?, "not üñîçøðé1"
     assert EmailAddress::Local.new("üñîçøðé2", local_encoding: :unicode).standard?, "üñîçøðé2"
+    assert EmailAddress::Local.new("test", local_encoding: :unicode).valid?, "unicode should include ascii"
     assert ! EmailAddress::Local.new("üñîçøðé3").valid?, "üñîçøðé3 valid"
   end
 

data/test/test_email_address.rb

@@ -37,7 +37,7 @@ class TestEmailAddress < MiniTest::Test
   end
 
   def test_cases
-    %w( miles.o'brien@yahoo.com first..last@gmail.com a-b.c_d+e@f.gx
+    %w( miles.o'brien@yahoo.com first.last@gmail.com a-b.c_d+e@f.gx
     ).each do |address|
       assert EmailAddress.valid?(address, dns_lookup: :off), "valid?(#{address})"
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: email_address
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Allen Fair
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-10 00:00:00.000000000 Z
+date: 2017-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 5.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 5.1.3
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -175,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: This gem provides a ruby language library for working with and validating