email-authentication 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b11e4a16c57918633e14bd1410c5a59fb9d1d21
-  data.tar.gz: e25d67af3ceeae586863ad791653513befc8ab7c
+  metadata.gz: ddb0630ec5b87bbab71968a26df1a4c883caee26
+  data.tar.gz: b806b6540c3b104d86961379944b8b5a0c913239
 SHA512:
-  metadata.gz: 193b7265a1d2e2e8e1a1a98c5d6b737ded02c84872dd1371ebd615d4e9b4f2225a665c717e5f46491f193ce205565f7fa06615b49998f9ee1a690e23958010d5
-  data.tar.gz: 4c64f777edc06a9897f915ad1693baeae4a2fcc06542b51209ee8ff128ef1b224e3b192454adcca971fc826192db28abc676a93286f7c2c384f8f4775ccbd175
+  metadata.gz: 3a75a3e97e638d0a4a4a9e4f8c6fb50d5d3a628fa1d868fa79313bf7b8bf8ddbcf56aa1a10d3bc64c89584b55c67eb6337bec22ba8b7a6399547555c35cf63fc
+  data.tar.gz: d4abdf831492b3711a415ff9e6abab9e32f8641a74931ffe4abdcd3de17b66a9eaebc91178465a059d02f2fa9983b4ba6a564a66058c67b13aa019ec8462f945

data/Gemfile.lock

@@ -2,12 +2,14 @@ PATH
   remote: .
   specs:
     email-authentication (0.1.0)
+      dnsruby
 
 GEM
   remote: https://rubygems.org/
   specs:
     codeclimate-test-reporter (0.1.1)
       simplecov (>= 0.7.1, < 1.0.0)
+    dnsruby (1.54)
     minitest (5.0.8)
     multi_json (1.8.0)
     simplecov (0.7.1)

data/lib/email-authentication/base.rb

@@ -1,12 +1,12 @@
 require 'rubygems'
-#require 'dnsruby'
-#include Dnsruby
+require 'dnsruby'
+include Dnsruby
 
 # Use the system configured nameservers to run a query
 
 module EmailAuthentication
   class Base
-    attr_accessor :address, :mx, :message
+    attr_accessor :address, :mx, :message, :domain
   def debug
     true
   end
@@ -16,25 +16,53 @@ module EmailAuthentication
     self.address=address.to_s
     @flag=true
   end
+  # this needs work.  Anyone who can improve the regex i would be happy
   def check_format
-   [true,"format ok"]
+    @@email_regex = /^(([A-Za-z0-9]+_+)|([A-Za-z0-9]+\-+)|([A-Za-z0-9]+\.+)|([A-Za-z0-9]+\++))*[A-Z‌​a-z0-9]+@((\w+\-+)|(\w+\.))*\w{1,63}\.[a-zA-Z]{2,6}$/i
+    res=(@address =~ @@email_regex)
+    puts " res is #{res}"
+    if res
+      [true,"format ok"]
+    else
+      [false,"format failed"]
+    end
   end
-  
+  # cache the dns resolver
   def resolver
-    @resolver = String.new('fred') if @resolver==nil
-  #  @resolver = Dnsruby::Resolver.new if @resolver==nil
+    @resolver = Dnsruby::Resolver.new if @resolver==nil
     @resolver
   end
-  
+  # check the mx domain
   def check_mx
-    
-    ret = self.resolver.query("google.com", Types.MX)
-    [true,"mx ok"]
+    domain=self.address.split('@')
+    @domain = domain[1]
+    puts "domain is #{domain}"
+    flag=false
+    if @domain!=nil
+          begin
+           ret = self.resolver.query(@domain, Types.MX)
+            if ret.answer!=nil and ret.rcode=='NOERROR'
+              @mx=ret.answer.first.exchange.to_s if ret.answer!=nil
+              msg= "mx record #{self.mx}"
+              puts msg
+              flag=true
+            end
+           rescue Dnsruby::NXDomain 
+             msg="non existing domain #{@domain}"
+             puts msg
+           end
+        
+    else
+      msg="nil domain"
+    end
+    puts "ret is #{ret.inspect}"
+    [flag,msg]
   end
-  
+  # need to think about this and check the domain via telnet
   def check_smtp
      [true,"smtp ok"]
    end
+   # run all the checks
   def check(address)
     self.set_address(address)
     @message=[]

data/test/coverage/index.html

@@ -14,7 +14,7 @@
       <img src="./assets/0.7.1/loading.gif" alt="loading"/>
     </div>
     <div id="wrapper" style="display:none;">
-      <div class="timestamp">Generated <abbr class="timeago" title="2013-10-20T11:25:07+08:00">2013-10-20T11:25:07+08:00</abbr></div>
+      <div class="timestamp">Generated <abbr class="timeago" title="2013-10-20T15:28:45+08:00">2013-10-20T15:28:45+08:00</abbr></div>
       <ul class="group_tabs"></ul>
 
       <div id="content">

data/test/test_address.rb

@@ -31,10 +31,9 @@ class EmailAuthenticationTest <  Minitest::Test
 
     end
   
-    def test_success
+    def test_goodemail
           success,msg= @f.check(@success)
-          assert success,"check did not succeed"
-
+          assert success,"check did not succeed #{msg}"
       end
         def test_resolver_onlyonce
               res=@f.resolver
@@ -43,16 +42,20 @@ class EmailAuthenticationTest <  Minitest::Test
 
           end
       #check a particular format
-      def test_success
+      def test_checkformat_good
             @f.set_address(@success)
             success,msg= @f.check_format
             assert success,"check did not succeed"
 
         end
-    
-    
-  
- 
+         def test_bademails
+             ['test','test#sed', 'test@jack'].each { |e| 
+                @f.set_address(e)
+                success,msg= @f.check_format
+                assert !success,"check did  succeed but it should not for #{e}"
+              }
+
+            end
  
 
 end

data/test/test_mx_records.rb

@@ -0,0 +1,40 @@
+puts File.dirname(__FILE__)
+require File.dirname(__FILE__) + '/test_helper.rb' 
+
+
+class EmailMXAuthenticationTest <  Minitest::Test
+
+  def setup
+    @f=EmailAuthentication::Base.new
+    @success='scott.sproule@ficonab.com'
+    @failruntimeerror=[nil,""]
+    
+  end
+  
+  def test_good_domain
+        @f.set_address(@success)
+        success,msg= @f.check_mx
+        assert success,"check did not succeed"
+        assert @f.mx!=nil, "mx should be set"
+
+    end
+    
+    def test_bad_domain
+          @f.set_address('test@baddomainxx23345.com')
+          success,msg= @f.check_mx
+          assert !success,"check did not succeed"
+
+      end
+      def test_bad_domain2
+            @f.set_address('test@baddom  ainxx23345.com')
+            success,msg= @f.check_mx
+            assert !success,"check did not succeed"
+
+        end
+ 
+    
+  
+ 
+ 
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: email-authentication
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Scott Sproule
@@ -77,7 +77,7 @@ files:
 - test/coverage/index.html
 - test/test_address.rb
 - test/test_helper.rb
-- test/test_normal.rb
+- test/test_mx_records.rb
 - bin/emailcheck.rb
 - Gemfile
 - Gemfile.lock

data/test/test_normal.rb

@@ -1,59 +0,0 @@
-puts File.dirname(__FILE__)
-require File.dirname(__FILE__) + '/test_helper.rb' 
-
-
-class NormalTest <  Minitest::Test
-
-  def setup
-    @f=Randprize::Base.new
-    @pm=Randprize::ManagePrizes.new
-    @headstails={ "T"=> {'odds'=> 2,'name'=>'win tails','value'=>0},"H"=> {'odds'=> 2,'name'=>'win heads','value'=>1}}
-    @dice={}
-    1.upto(6) {|i| @dice[i.to_s]= {'odds'=> 6,'name'=>"rolled #{i}",'value'=>1} }
-    @large={ "GP"=> {'odds'=> 100,'name'=>'grandprize','value'=>50000},"H"=> {'odds'=> 'REMAINING','name'=>'win heads','value'=>1}}
-     @exlarge={ "GP"=> {'odds'=> 50000,'name'=>'grandprize','value'=>50000},"2nd"=> {'odds'=> 5000,'name'=>'2ndprize','value'=>50000},"H"=> {'odds'=> 'REMAINING','name'=>'win heads','value'=>0}}
-    
-  end
-  
-  
-   def test_randomprize_forrandom
-       steps=5000
-       count=0
-       1.upto(steps)  do
-        @pm.prize_list(@headstails)
-        prizes=[]
-        @pm.myprizelist.each {|k| #puts "K is #{k}"
-                             prizes << k[1]}
-        aprize=@pm.random_prize
-        assert prizes.include?(aprize), "prize should be from the list"    
-        #puts  "count #{count} aprize #{aprize}"
-        count=aprize['value']+count     
-        end
-       ratio=(count.to_f/steps)*100
-       assert (49..51).include?(ratio.round), "ratio wrong #{ratio.round} count #{count}"
-    end
-     def test_dize
-         steps=5000
-         count=0
-          hcount={}
-         1.upto(6)  {|i| hcount["rolled #{i}"]=0}
-        
-         1.upto(steps)  do
-          @pm.prize_list(@dice)
-          prizes=[]
-          @pm.myprizelist.each {|k| #puts "K is #{k}"
-                               prizes << k[1]}
-          aprize=@pm.random_prize
-          assert prizes.include?(aprize), "prize should be from the list"    
-          #puts  "count #{count} aprize #{aprize}"
-          hcount[aprize['name']]=hcount[aprize['name']]+1     
-          end
-        # ratio=(count.to_f/steps)*100
-        # assert (49..51).include?(ratio.round), "ratio wrong #{ratio.round} count #{count}"
-      end
-    
-  
- 
- 
-
-end