em-http-request-samesite 1.1.7

data/spec/middleware/oauth2_spec.rb

@@ -0,0 +1,15 @@
+describe EventMachine::Middleware::OAuth2 do
+  it "should add an access token to a URI with no query parameters" do
+    middleware = EventMachine::Middleware::OAuth2.new(:access_token => "fedcba9876543210")
+    uri = Addressable::URI.parse("https://graph.facebook.com/me")
+    middleware.update_uri! uri
+    uri.to_s.should == "https://graph.facebook.com/me?access_token=fedcba9876543210"
+  end
+
+  it "should add an access token to a URI with query parameters" do
+    middleware = EventMachine::Middleware::OAuth2.new(:access_token => "fedcba9876543210")
+    uri = Addressable::URI.parse("https://graph.facebook.com/me?fields=photo")
+    middleware.update_uri! uri
+    uri.to_s.should == "https://graph.facebook.com/me?fields=photo&access_token=fedcba9876543210"
+  end
+end

data/spec/middleware_spec.rb

@@ -0,0 +1,143 @@
+require 'helper'
+
+describe EventMachine::HttpRequest do
+
+  class EmptyMiddleware; end
+
+  class GlobalMiddleware
+    def response(resp)
+      resp.response_header['X-Global'] = 'middleware'
+    end
+  end
+
+  it "should accept middleware" do
+    EventMachine.run {
+      lambda {
+        conn = EM::HttpRequest.new('http://127.0.0.1:8090')
+        conn.use ResponseMiddleware
+        conn.use EmptyMiddleware
+
+        EM.stop
+      }.should_not raise_error
+    }
+  end
+
+  context "configuration" do
+    class ConfigurableMiddleware
+      def initialize(conf, &block)
+        @conf = conf
+        @block = block
+      end
+
+      def response(resp)
+        resp.response_header['X-Conf'] = @conf
+        resp.response_header['X-Block'] = @block.call
+      end
+    end
+
+    it "should accept middleware initialization parameters" do
+      EventMachine.run {
+        conn = EM::HttpRequest.new('http://127.0.0.1:8090')
+        conn.use ConfigurableMiddleware, 'conf-value' do
+          'block-value'
+        end
+
+        req = conn.get
+        req.callback {
+          req.response_header['X-Conf'].should match('conf-value')
+          req.response_header['X-Block'].should match('block-value')
+          EM.stop
+        }
+      }
+    end
+  end
+
+  context "request" do
+    class ResponseMiddleware
+      def response(resp)
+        resp.response_header['X-Header'] = 'middleware'
+        resp.response = 'Hello, Middleware!'
+      end
+    end
+
+    it "should execute response middleware before user callbacks" do
+      EventMachine.run {
+        conn = EM::HttpRequest.new('http://127.0.0.1:8090')
+        conn.use ResponseMiddleware
+
+        req = conn.get
+        req.callback {
+          req.response_header['X-Header'].should match('middleware')
+          req.response.should match('Hello, Middleware!')
+          EM.stop
+        }
+      }
+    end
+
+    it "should execute global response middleware before user callbacks" do
+      EventMachine.run {
+        EM::HttpRequest.use GlobalMiddleware
+
+        conn = EM::HttpRequest.new('http://127.0.0.1:8090')
+
+        req = conn.get
+        req.callback {
+          req.response_header['X-Global'].should match('middleware')
+          EM.stop
+        }
+      }
+    end
+  end
+
+  context "request" do
+    class RequestMiddleware
+      def request(client, head, body)
+        head['X-Middleware'] = 'middleware'   # insert new header
+        body += ' modified'                   # modify post body
+
+        [head, body]
+      end
+    end
+
+    it "should execute request middleware before dispatching request" do
+      EventMachine.run {
+        conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/')
+        conn.use RequestMiddleware
+
+        req = conn.post :body => "data"
+        req.callback {
+          req.response_header.status.should == 200
+          req.response.should match(/data modified/)
+          EventMachine.stop
+        }
+      }
+    end
+  end
+
+  context "jsonify" do
+    class JSONify
+      def request(client, head, body)
+        [head, MultiJson.dump(body)]
+      end
+
+      def response(resp)
+        resp.response = MultiJson.load(resp.response)
+      end
+    end
+
+    it "should use middleware to JSON encode and JSON decode the body" do
+      EventMachine.run {
+        conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/')
+        conn.use JSONify
+
+        req = conn.post :body => {:ruby => :hash}
+        req.callback {
+          req.response_header.status.should == 200
+          req.response.should == {"ruby" => "hash"}
+          EventMachine.stop
+        }
+      }
+    end
+  end
+
+end

data/spec/multi_spec.rb

@@ -0,0 +1,104 @@
+require 'helper'
+require 'stallion'
+
+describe EventMachine::MultiRequest do
+
+  let(:multi) { EventMachine::MultiRequest.new }
+  let(:url)   { 'http://127.0.0.1:8090/' }
+
+  it "should submit multiple requests in parallel and return once all of them are complete" do
+    EventMachine.run {
+      multi.add :a, EventMachine::HttpRequest.new(url).get
+      multi.add :b, EventMachine::HttpRequest.new(url).post
+      multi.add :c, EventMachine::HttpRequest.new(url).head
+      multi.add :d, EventMachine::HttpRequest.new(url).delete
+      multi.add :e, EventMachine::HttpRequest.new(url).put
+
+      multi.callback {
+        multi.responses[:callback].size.should == 5
+        multi.responses[:callback].each { |name, response|
+          [ :a, :b, :c, :d, :e ].should include(name)
+          response.response_header.status.should == 200
+        }
+        multi.responses[:errback].size.should == 0
+
+        EventMachine.stop
+      }
+    }
+  end
+
+  it "should require unique keys for each deferrable" do
+    lambda do
+      multi.add :df1, EM::DefaultDeferrable.new
+      multi.add :df1, EM::DefaultDeferrable.new
+    end.should raise_error("Duplicate Multi key")
+  end
+
+
+  describe "#requests" do
+    it "should return the added requests" do
+      request1 = double('request1', :callback => nil, :errback => nil)
+      request2 = double('request2', :callback => nil, :errback => nil)
+
+      multi.add :a, request1
+      multi.add :b, request2
+
+      multi.requests.should == {:a => request1, :b => request2}
+    end
+  end
+
+  describe "#responses" do
+    it "should have an empty :callback hash" do
+      multi.responses[:callback].should be_a(Hash)
+      multi.responses[:callback].size.should == 0
+    end
+
+    it "should have an empty :errback hash" do
+      multi.responses[:errback].should be_a(Hash)
+      multi.responses[:errback].size.should == 0
+    end
+
+    it "should provide access to the requests by name" do
+      EventMachine.run {
+        request1 = EventMachine::HttpRequest.new(url).get
+        request2 = EventMachine::HttpRequest.new(url).post
+        multi.add :a, request1
+        multi.add :b, request2
+
+        multi.callback {
+          multi.responses[:callback][:a].should equal(request1)
+          multi.responses[:callback][:b].should equal(request2)
+
+          EventMachine.stop
+        }
+      }
+    end
+  end
+
+  describe "#finished?" do
+    it "should be true when no requests have been added" do
+      multi.should be_finished
+    end
+
+    it "should be false while the requests are not finished" do
+      EventMachine.run {
+        multi.add :a, EventMachine::HttpRequest.new(url).get
+        multi.should_not be_finished
+
+        EventMachine.stop
+      }
+    end
+
+    it "should be finished when all requests are finished" do
+      EventMachine.run {
+        multi.add :a, EventMachine::HttpRequest.new(url).get
+        multi.callback {
+          multi.should be_finished
+
+          EventMachine.stop
+        }
+      }
+    end
+  end
+
+end

data/spec/pipelining_spec.rb

@@ -0,0 +1,66 @@
+require 'helper'
+
+requires_connection do
+
+  describe EventMachine::HttpRequest do
+
+    it "should perform successful pipelined GETs" do
+      EventMachine.run do
+
+        # Mongrel doesn't support pipelined requests - bah!
+        conn = EventMachine::HttpRequest.new('http://www.bing.com/')
+
+        pipe1 = conn.get :keepalive => true
+        pipe2 = conn.get :path => '/news', :keepalive => true
+
+        processed = 0
+        stop = proc { EM.stop if processed == 2}
+
+        pipe1.errback { failed(conn) }
+        pipe1.callback {
+          processed += 1
+          pipe1.response_header.status.should == 200
+          stop.call
+        }
+
+        pipe2.errback { failed(conn) }
+        pipe2.callback {
+          processed += 1
+          pipe2.response_header.status.should == 200
+          pipe2.response.should match(/html/i)
+          stop.call
+        }
+
+      end
+    end
+
+    it "should perform successful pipelined HEAD requests" do
+      EventMachine.run do
+        conn = EventMachine::HttpRequest.new('http://www.bing.com/')
+
+        pipe1 = conn.head :keepalive => true
+        pipe2 = conn.head :path => '/news', :keepalive => true
+
+        processed = 0
+        stop = proc { EM.stop if processed == 2}
+
+        pipe1.errback { failed(conn) }
+        pipe1.callback {
+          processed += 1
+          pipe1.response_header.status.should == 200
+          stop.call
+        }
+
+        pipe2.errback { failed(conn) }
+        pipe2.callback {
+          processed += 1
+          pipe2.response_header.status.should == 200
+          stop.call
+        }
+
+      end
+
+    end
+  end
+
+end

data/spec/redirect_spec.rb

@@ -0,0 +1,430 @@
+require 'helper'
+
+class RedirectMiddleware
+  attr_reader :call_count
+
+  def initialize
+    @call_count = 0
+  end
+
+  def request(c, h, r)
+    @call_count += 1
+    [h.merge({'EM-Middleware' => @call_count.to_s}), r]
+  end
+end
+
+class PickyRedirectMiddleware < RedirectMiddleware
+  def response(r)
+    if r.redirect? && r.response_header['LOCATION'][-1].chr == '3'
+      # set redirects to 0 to avoid further processing
+      r.req.redirects = 0
+    end
+  end
+end
+
+describe EventMachine::HttpRequest do
+
+  it "should follow location redirects" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect').get :redirects => 1
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.response_header["CONTENT_ENCODING"].should == "gzip"
+        http.response.should == "compressed"
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/gzip'
+        http.redirects.should == 1
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should not follow redirects on created" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/created').get :redirects => 1
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 201
+        http.response.should match(/Hello/)
+        EM.stop
+      }
+    }
+  end
+
+  it "should not forward cookies across domains with http redirect" do
+
+    expires  = (Date.today + 2).strftime('%a, %d %b %Y %T GMT')
+    response =<<-HTTP.gsub(/^ +/, '')
+      HTTP/1.1 301 MOVED PERMANENTLY
+      Location: http://localhost:8071/
+      Set-Cookie: foo=bar; expires=#{expires}; path=/; HttpOnly
+
+    HTTP
+
+    EventMachine.run do
+      @stub = StubServer.new(:host => '127.0.0.1', :port => 8070, :response => response)
+      @echo = StubServer.new(:host => 'localhost', :port => 8071, :echo     => true)
+
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8070/').get :redirects => 1
+
+      http.errback  { failed(http) }
+      http.callback do
+        http.response.should_not match(/Cookie/)
+        @stub.stop
+        @echo.stop
+        EM.stop
+      end
+    end
+  end
+
+  it "should forward valid cookies across domains with http redirect" do
+
+    expires  = (Date.today + 2).strftime('%a, %d %b %Y %T GMT')
+    response =<<-HTTP.gsub(/^ +/, '')
+      HTTP/1.1 301 MOVED PERMANENTLY
+      Location: http://127.0.0.1:8071/
+      Set-Cookie: foo=bar; expires=#{expires}; path=/; HttpOnly
+
+    HTTP
+
+    EventMachine.run do
+      @stub = StubServer.new(:host => '127.0.0.1', :port => 8070, :response => response)
+      @echo = StubServer.new(:host => '127.0.0.1', :port => 8071, :echo     => true)
+
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8070/').get :redirects => 1
+
+      http.errback  { failed(http) }
+      http.callback do
+        http.response.should match(/Cookie/)
+        @stub.stop
+        @echo.stop
+        EM.stop
+      end
+    end
+  end
+
+
+  it "should normalize path and forward valid cookies across domains" do
+
+    expires  = (Date.today + 2).strftime('%a, %d %b %Y %T GMT')
+    response =<<-HTTP.gsub(/^ +/, '')
+      HTTP/1.1 301 MOVED PERMANENTLY
+      Location: http://127.0.0.1:8071?omg=ponies
+      Set-Cookie: foo=bar; expires=#{expires}; path=/; HttpOnly
+
+    HTTP
+
+    EventMachine.run do
+      @stub = StubServer.new(:host => '127.0.0.1', :port => 8070, :response => response)
+      @echo = StubServer.new(:host => '127.0.0.1', :port => 8071, :echo     => true)
+
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8070/').get :redirects => 1
+
+      http.errback  { failed(http) }
+      http.callback do
+        http.response.should match(/Cookie/)
+        @stub.stop
+        @echo.stop
+        EM.stop
+      end
+    end
+  end
+
+  it "should redirect with missing content-length" do
+    EventMachine.run {
+      response = "HTTP/1.0 301 MOVED PERMANENTLY\r\nlocation: http://127.0.0.1:8090/redirect\r\n\r\n"
+      @stub = StubServer.new(:host => '127.0.0.1', :port => 8070, :response => response)
+
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8070/').get :redirects => 3
+      http.errback { failed(http) }
+
+      http.callback {
+        http.response_header.status.should == 200
+        http.response_header["CONTENT_ENCODING"].should == "gzip"
+        http.response.should == "compressed"
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/gzip'
+        http.redirects.should == 3
+
+        @stub.stop
+        EM.stop
+      }
+    }
+  end
+
+  it "should follow redirects on HEAD method" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/head').head :redirects => 1
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/'
+        EM.stop
+      }
+    }
+  end
+
+  it "should report last_effective_url" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/').get
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/'
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should default to 0 redirects" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect').get
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 301
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/redirect'
+        http.redirects.should == 0
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should not invoke redirect logic on failed(http) connections" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8070/', :connect_timeout => 0.1).get :redirects => 5
+      http.callback { failed(http) }
+      http.errback {
+        http.redirects.should == 0
+        EM.stop
+      }
+    }
+  end
+
+  it "should normalize redirect urls" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/bad').get :redirects => 1
+      http.errback { failed(http) }
+      http.callback {
+        http.last_effective_url.to_s.should match('http://127.0.0.1:8090/')
+        http.response.should match('Hello, World!')
+        EM.stop
+      }
+    }
+  end
+
+  it "should fail gracefully on a missing host in absolute Location header" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/nohost').get :redirects => 1
+      http.callback { failed(http) }
+      http.errback {
+        http.error.should == 'Location header format error'
+        EM.stop
+      }
+    }
+  end
+
+  it "should apply timeout settings on redirects" do
+    EventMachine.run {
+      t = Time.now.to_i
+      EventMachine.heartbeat_interval = 0.1
+
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/timeout', :inactivity_timeout => 0.1)
+      http = conn.get :redirects => 1
+      http.callback { failed(http) }
+      http.errback {
+        (Time.now.to_i - t).should <= 1
+        EM.stop
+      }
+    }
+  end
+
+  it "should capture and pass cookies on redirect and pass_cookies by default" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/multiple-with-cookie').get :redirects => 2, :head => {'cookie' => 'id=2;'}
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.response_header["CONTENT_ENCODING"].should == "gzip"
+        http.response.should == "compressed"
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/gzip'
+        http.redirects.should == 2
+        http.cookies.should include("id=2;")
+        http.cookies.should include("another_id=1")
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should capture and not pass cookies on redirect if passing is disabled via pass_cookies" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/multiple-with-cookie').get :redirects => 2, :pass_cookies => false, :head => {'cookie' => 'id=2;'}
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.response_header["CONTENT_ENCODING"].should == "gzip"
+        http.response.should == "compressed"
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/gzip'
+        http.redirects.should == 2
+        http.cookies.should include("id=2;")
+        http.cookies.should_not include("another_id=1; expires=Sat, 09 Aug 2031 17:53:39 GMT; path=/;")
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should follow location redirects with path" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect').get :path => '/redirect', :redirects => 1
+      http.errback { failed(http) }
+      http.callback {
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/gzip'
+        http.response_header.status.should == 200
+        http.redirects.should == 1
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should call middleware each time it redirects" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/middleware_redirects_1')
+      conn.use RedirectMiddleware
+      http = conn.get :redirects => 3
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 200
+        http.response_header['EM_MIDDLEWARE'].to_i.should == 3
+        EM.stop
+      }
+    }
+  end
+
+  it "should call middleware which may reject a redirection" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/middleware_redirects_1')
+      conn.use PickyRedirectMiddleware
+      http = conn.get :redirects => 3
+      http.errback { failed(http) }
+      http.callback {
+        http.response_header.status.should == 301
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/redirect/middleware_redirects_2'
+        EM.stop
+      }
+    }
+  end
+
+  it "should not add default http port to redirect url that don't include it" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/http_no_port')
+      http = conn.get :redirects => 1
+      http.errback {
+        http.last_effective_url.to_s.should == 'http://host/'
+        EM.stop
+      }
+    }
+  end
+
+  it "should not add default https port to redirect url that don't include it" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/https_no_port')
+      http = conn.get :redirects => 1
+      http.errback {
+        http.last_effective_url.to_s.should == 'https://host/'
+        EM.stop
+      }
+    }
+  end
+
+  it "should keep default http port in redirect url that include it" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/http_with_port')
+      http = conn.get :redirects => 1
+      http.errback {
+        http.last_effective_url.to_s.should == 'http://host:80/'
+        EM.stop
+      }
+    }
+  end
+
+  it "should keep default https port in redirect url that include it" do
+    EventMachine.run {
+      conn = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/https_with_port')
+      http = conn.get :redirects => 1
+      http.errback {
+        http.last_effective_url.to_s.should == 'https://host:443/'
+        EM.stop
+      }
+    }
+  end
+
+  it "should ignore query option when redirecting" do
+    EventMachine.run {
+      http = EventMachine::HttpRequest.new('http://127.0.0.1:8090/redirect/ignore_query_option').get :redirects => 1, :query => 'ignore=1'
+      http.errback { failed(http) }
+      http.callback {
+        http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/redirect/url'
+        http.redirects.should == 1
+
+        redirect_url = http.response
+        redirect_url.should == http.last_effective_url.to_s
+
+        EM.stop
+      }
+    }
+  end
+
+  it "should work with keep-alive connections with cross-origin redirect" do
+    Timeout.timeout(1) {
+      EventMachine.run {
+        response =<<-HTTP.gsub(/^ +/, '')
+          HTTP/1.1 301 MOVED PERMANENTLY
+          Location: http://127.0.0.1:8090/
+          Content-Length: 0
+
+        HTTP
+
+        stub_server = StubServer.new(:host => '127.0.0.1', :port => 8070, :keepalive => true, :response => response)
+        conn = EventMachine::HttpRequest.new('http://127.0.0.1:8070/', :inactivity_timeout => 60)
+        http = conn.get :redirects => 1, :keepalive => true
+        http.errback { failed(http) }
+        http.callback {
+          http.last_effective_url.to_s.should == 'http://127.0.0.1:8090/'
+          http.redirects.should == 1
+
+          stub_server.stop
+          EM.stop
+        }
+      }
+    }
+  end
+
+  it "should work with keep-alive connections with same-origin redirect" do
+    Timeout.timeout(1) {
+      EventMachine.run {
+        response =<<-HTTP.gsub(/^ +/, '')
+          HTTP/1.1 301 MOVED PERMANENTLY
+          Location: http://127.0.0.1:8070/
+          Content-Length: 0
+
+        HTTP
+
+        stub_server = StubServer.new(:host => '127.0.0.1', :port => 8070, :keepalive => true, :response => response)
+        conn = EventMachine::HttpRequest.new('http://127.0.0.1:8070/', :inactivity_timeout => 60)
+        http = conn.get :redirects => 1, :keepalive => true
+        http.errback { failed(http) }
+        http.callback {
+          http.last_effective_url.to_s.should == 'http://127.0.0.1:8070/'
+          http.redirects.should == 1
+
+          stub_server.stop
+          EM.stop
+        }
+      }
+    }
+  end
+end