elmas 2.6.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b4840a3f199ef30c829409b92a207b39fde8cdb1
-  data.tar.gz: 95aa8f2d9383565fbd3cca3199a1e983635830ed
+SHA256:
+  metadata.gz: 9bf17c014442114f64d14b2cc50b88279eba0b6249c7b08f5d9e7611cce0f078
+  data.tar.gz: 526d26398ef1c5fdfdbdd6f7430ae37d0530ef01d09cbfb78365ac44f2945120
 SHA512:
-  metadata.gz: 77744d31e6373970e4e8cb92668fd0802af0a5d91267de329020a756b0199379ffa5e64c3863f52afb54f1215c41e1360f29f427437068377409eca7c335385e
-  data.tar.gz: f7758eaae28006c2e346ddc95077a874489e74c891bb2e18078848deaf54a60a8f5ad9696df632c7250091673616e87a0087dddc826d9343950a1611efeb7391
+  metadata.gz: 3854963c10a80a9ee649363f8b4530266a2befad8994557060f07385fad0fba45823380eb74c33386a03985f08327df9869b6e503ed3fe16e803e0a770583fc6
+  data.tar.gz: bf11fdb4d48fc87e9a5eb406fc7dd0befe11280d6270df113bd87e69d5edc492703176bbf8cc39c6e5acd9fcce4fc25c7d8500e33fca14cb96196f4b0a54bd8b

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.5.1

data/Changelog.md

@@ -1,3 +1,7 @@
+## 3.0.0
+- Deprecating auto authorize due to changes to login flow by Exact. https://support.exactonline.com/community/s/knowledge-base#All-All-HNO-Concept-general-security-gen-auth-totpc
+- Upgrade Ruby Version.
+
 ## 2.6.0
 - Add main atttribute to bank account (thanks @Korstiaan)
 - Add address object (thanks @chicks)

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) [2015] [Hoppinger]
+Copyright (c) [2018] [Hoppinger]
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -5,11 +5,11 @@
 
 # Elmas
 
-Elmas means diamond, but in this case it's an API wrapper for [Exact Online](https://developers.exactonline.com/). This gem was created by [@Marthyn](https://github.com/marthyn), [Hoppinger](http://www.hoppinger.com) and a few people:
+Elmas means diamond, but in this case it's an API wrapper for [Exact Online](https://developers.exactonline.com/). This gem was created by [@Marthyn](https://github.com/marthyn), [Hoppinger](http://www.hoppinger.com) and a few people.
 
 # DISCLAIMER
 
-Please read the Authorization part of this readme before opening an issue about it and realize it's a functionality that is only intented for debugging purposes really, or to allow App to App communication, but it's really better to CREATE YOUR OWN authentication/refresh/authorization logic for your customers through the normal OAUTH path. The code in the Oauth.rb file could break any time Exact changes their login form for example. 
+__As of 25th of May, 2FA will be mandatory for all Exact Online accounts. Therefor the auto authorize method with which you could simulate and App 2 App connection will not work anymore. Hoppinger is working on a new solution. The methods will stay available but probably won't work and will show a deprecation warning. [Read more about it here](https://support.exactonline.com/community/s/knowledge-base#All-All-HNO-Concept-general-security-gen-auth-totpc)__
 
 ### Contributers
 
@@ -59,48 +59,6 @@ Elmas.configure do |config|
 end
 ```
 
-If you only use the api within your app without exposing it to users you can chose
-to automatically login with your credentials. So this is for example when you have a
-rake task that shoots in invoices.
-Do not use this when you let other users login. Build your own OAUTH flow and then set the access token
-before the api request.
-```ruby
-Elmas.configure do |config|
-  config.access_token = Elmas.authorize(ENV['EXACT_USER_NAME'], ENV['EXACT_PASSWORD']).access_token
-end
-```
-Now you're authorized you can set your current division
-```ruby
-Elmas.configure do |config|
-  config.division = Elmas.authorize_division
-end
-```
-
-So combining all of this results in
-```ruby
-Elmas.configure do |config|
-  config.client_id = ENV['CLIENT_ID']
-  config.client_secret = ENV['CLIENT_SECRET']
-  config.redirect_uri = ENV['REDIRECT_URI']
-  config.access_token = Elmas.authorize(ENV['EXACT_USER_NAME'], ENV['EXACT_PASSWORD']).access_token
-  config.division = Elmas.authorize_division
-end
-```
-
-You should make sure that when you do a request you're authorized. So build in something like the
-following code into your application, that checks wether you're authorized and otherwise authorizes
-again.
-```ruby
-#The client will now be authorized for 10 minutes,
-# if there are requests the time will be reset,
-# otherwise authorization should be called again.
-unless Elmas.authorized?
-  Elmas.configure do |config|
-    config.access_token = Elmas.authorize(ENV['EXACT_USER_NAME'], ENV['EXACT_PASSWORD']).access_token
-  end
-end
-```
-
 ### Logger
 
 The default logger is STDOUT. A custom logger can be be configured.

data/lib/elmas/oauth.rb

@@ -8,10 +8,15 @@ require File.expand_path("../utils", __FILE__)
 require File.expand_path("../response", __FILE__)
 
 # from https://developers.exactonline.com/#Example retrieve access token.html
+
+# This whole class is going to be replaced due to Exact Online's new policies.
+# https://support.exactonline.com/community/s/knowledge-base#All-All-HNO-Concept-general-security-gen-auth-totpc
+
 module Elmas
   # rubocop:disable Metrics/ModuleLength
   module OAuth
     def authorize(user_name, password, options = {})
+      warn "[DEPRECATION] `authorize` is deprecated. Please implement your own authorization methods instead."
       agent = Mechanize.new
 
       login(agent, user_name, password, options)
@@ -22,6 +27,7 @@ module Elmas
     end
 
     def refresh_authorization
+      warn "[DEPRECATION] `refresh_authorization` is deprecated. Please implement your own authorization methods instead."
       OauthResponse.new(get_refresh_token(refresh_token)).tap do |response|
         Elmas.configure do |config|
           config.access_token = response.access_token
@@ -43,6 +49,7 @@ module Elmas
     end
 
     def auto_authorize
+      warn "[DEPRECATION] `auto_authorize` is deprecated. Please implement your own authorization methods instead."
       Elmas.configure do |config|
         config.redirect_uri = ENV["REDIRECT_URI"]
         config.client_id = ENV["CLIENT_ID"]

data/lib/elmas/version.rb

@@ -2,8 +2,8 @@
 
 module Elmas
   class Version
-    MAJOR = 2
-    MINOR = 6
+    MAJOR = 3
+    MINOR = 0
     PATCH = 0
 
     class << self

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elmas
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Marthyn
@@ -350,7 +350,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: API wrapper for Exact Online