elmas 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10abfebcd17a54de33628c1e48170981b30e5345
-  data.tar.gz: 7c67ccf52b8231b059cb44b80f045fd6f343e7f0
+  metadata.gz: 1dab67a65bc9196c76e1536d56b590dd6a2b921f
+  data.tar.gz: 973eee206fdd9512efc410d01b5f7fa5c7725b19
 SHA512:
-  metadata.gz: c20a92ba86f300be0a92861a8bc7e1e96ec415e0829cd86d99e39ade4f7732f3ad6a237379dfadaebf5c06e61b97ec4b12e7f268a91220589ba067bd36911a4e
-  data.tar.gz: 680ef9d45f1140fb40b3ce151ed1a6c9a5af780c641def387039e57b4d7b9865a205315a499de4b49afe5cbf450e40e545ae4e25b2a3063d04931a55f8dcd32b
+  metadata.gz: 607279e3a029d11bff668d3b45ec0ca65f80fc4d414f73abd74ac685120386356a2ea62b79cf27cbe205afa66a4d3f15444019b6680289fffd601e37c59e4441
+  data.tar.gz: 6e5e1a74905fbb2f774c001982abf04a8fd78b64267a38ae8000b7b62e92942d21767fde3600350b685c170f28d90cb73b427cfde1d443a6b4d5b506d2b69bfe

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 rvm:
-  - 2.2.2
+  - 2.2.3
 cache: bundler

data/Changelog.md

@@ -1,3 +1,7 @@
+## 2.2.2
+
+- Fix rubocop issues and specs
+
 ## 2.2.1
 
 - Fix date sanitizing (608883148a367d2388b9daa9b454ac6b2dbbf10d)

data/lib/elmas/api.rb

@@ -6,7 +6,7 @@ module Elmas
   # @private
   class API
     # @private
-    attr_accessor *(Config::VALID_OPTIONS_KEYS)
+    attr_accessor *Config::VALID_OPTIONS_KEYS
 
     # Creates a new API
     def initialize(options = {})

data/lib/elmas/config.rb

@@ -19,9 +19,9 @@ module Elmas
     ].freeze
 
     # By default, don't set a user access token
-    DEFAULT_ACCESS_TOKEN = ""
+    DEFAULT_ACCESS_TOKEN = "".freeze
 
-    DEFAULT_REFRESH_TOKEN = ""
+    DEFAULT_REFRESH_TOKEN = "".freeze
 
     # The adapter that will be used to connect if none is set
     #
@@ -29,27 +29,27 @@ module Elmas
     DEFAULT_ADAPTER = Faraday.default_adapter
 
     # By default, client id should be set in .env
-    DEFAULT_CLIENT_ID = ""
+    DEFAULT_CLIENT_ID = "".freeze
 
     # By default, client secret should be set in .env
-    DEFAULT_CLIENT_SECRET = ""
+    DEFAULT_CLIENT_SECRET = "".freeze
 
     # By default, don't set any connection options
-    DEFAULT_CONNECTION_OPTIONS = {}
+    DEFAULT_CONNECTION_OPTIONS = {}.freeze
 
-    DEFAULT_BASE_URL = "https://start.exactonline.nl"
+    DEFAULT_BASE_URL = "https://start.exactonline.nl".freeze
 
     # The endpoint that will be used to connect if none is set
     DEFAULT_ENDPOINT = "api/v1".freeze
 
     # the division code you want to connect with
-    DEFAULT_DIVISION = ""
+    DEFAULT_DIVISION = "".freeze
 
     # The response format appended to the path and sent in the 'Accept' header if none is set
     #
     DEFAULT_FORMAT = :json
 
-    DEFAULT_REDIRECT_URI = "https://www.getpostman.com/oauth2/callback"
+    DEFAULT_REDIRECT_URI = "https://www.getpostman.com/oauth2/callback".freeze
 
     # By default, don't set user agent
     DEFAULT_USER_AGENT = nil
@@ -58,7 +58,7 @@ module Elmas
     VALID_FORMATS = [:json].freeze
 
     # @private
-    attr_accessor *(VALID_OPTIONS_KEYS)
+    attr_accessor *VALID_OPTIONS_KEYS
 
     # When this module is extended, set all configuration options to their default values
     def self.extended(base)

data/lib/elmas/resource.rb

@@ -63,11 +63,8 @@ module Elmas
     def save
       attributes_to_submit = sanitize
       if valid?
-        if id?
-          return @response = Elmas.put(basic_identifier_uri, params: attributes_to_submit)
-        else
-          return @response = Elmas.post(base_path, params: attributes_to_submit)
-        end
+        return @response = Elmas.post(base_path, params: attributes_to_submit) unless id?
+        return @response = Elmas.put(basic_identifier_uri, params: attributes_to_submit)
       else
         Elmas.error("Invalid Resource #{self.class.name}, attributes: #{@attributes.inspect}")
         Elmas::Response.new(Faraday::Response.new(status: 400, body: "Invalid Request"))

data/lib/elmas/resources/shared_sales_attributes.rb

@@ -5,12 +5,12 @@ module Elmas
       :description, :document, :order_date, :ordered_by_contact_person,
       :tax_schedule, :order_number, :payment_condition, :payment_reference,
       :remarks, :your_ref
-    ]
+    ].freeze
 
     SHARED_LINE_ATTRIBUTES = [
       :discount, :quantity, :amount_FC, :description, :VAT_code, :cost_center,
       :cost_unit, :VAT_percentage, :unit_code, :tax_schedule, :net_price, :notes,
       :pricelist, :project
-    ]
+    ].freeze
   end
 end

data/lib/elmas/response.rb

@@ -49,15 +49,15 @@ module Elmas
 
     SUCCESS_CODES = [
       201, 202, 203, 204, 301, 302, 303, 304
-    ]
+    ].freeze
 
     ERROR_CODES = [
       400, 401, 402, 403, 404, 500, 501, 502, 503
-    ]
+    ].freeze
 
     UNAUTHORIZED_CODES = [
       400, 401, 402, 403
-    ]
+    ].freeze
 
     private
 

data/lib/elmas/result_set.rb

@@ -5,13 +5,13 @@ module Elmas
     def initialize(parsed_response)
       @parsed_response = parsed_response
 
-      if @parsed_response.results
-        @records = @parsed_response.results.map do |attributes|
-          resource_class.send(:new, attributes)
-        end
-      else
-        @records = [resource_class.send(:new, @parsed_response.result)]
-      end
+      @records = if @parsed_response.results
+                   @parsed_response.results.map do |attributes|
+                     resource_class.send(:new, attributes)
+                   end
+                 else
+                   [resource_class.send(:new, @parsed_response.result)]
+                 end
     end
 
     def next_page

data/lib/elmas/sanitizer.rb

@@ -16,7 +16,10 @@ module Elmas
         to_submit
       end
 
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
       def sanitize_relationship(value)
+        # rubocop:disable Style/GuardClause
         if value.is_a?(Elmas::Resource)
           return value.id # Turn relation into ID
         elsif value.is_a?(Array)
@@ -30,7 +33,10 @@ module Elmas
         else
           return value
         end
+        # rubocop:enable Style/GuardClause
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/PerceivedComplexity
 
       def sanitize_date_time(value)
         value.strftime("%Y-%m-%d")

data/lib/elmas/uri.rb

@@ -9,11 +9,11 @@ module Elmas
         options.each do |option|
           send("apply_#{option}".to_sym)
         end
-        if options.include?(:id)
-          uri = URI("#{base_path}(guid'#{id}')")
-        else
-          uri = URI(base_path)
-        end
+        uri = if options.include?(:id)
+                URI("#{base_path}(guid'#{id}')")
+              else
+                URI(base_path)
+              end
         uri.query = URI.encode_www_form(@query)
         uri
       end
@@ -73,7 +73,7 @@ module Elmas
       end
 
       def apply_select
-        @query << ["$select", (@select.map { |s| Utils.camelize(s) }.join(","))] if @select
+        @query << ["$select", @select.map { |s| Utils.camelize(s) }.join(",")] if @select
       end
     end
   end

data/lib/elmas/utils.rb

@@ -41,7 +41,7 @@ module Elmas
     end
 
     def self.parse_key(key)
-      "VATCode" if key.downcase == "vat_code"
+      "VATCode" if key.casecmp "vat_code"
       Utils.camelize(key)
     end
   end

data/lib/elmas/version.rb

@@ -2,7 +2,7 @@ module Elmas
   class Version
     MAJOR = 2
     MINOR = 2
-    PATCH = 1
+    PATCH = 2
 
     class << self
       def to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elmas
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Marthyn