elliptic 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff30ac78fc3b9f3528bec550afdfffc4bdc7c4f7049edf67280ba48150d6ce95
-  data.tar.gz: bb13fa5c43a30149dab2457a7ef78ec3c6478122e80c8fd450b99ed8e6998f31
+  metadata.gz: ef99a20d778ba1cd9c3ea51cfb6869ffe3d120de2be75715805d186014ebf38a
+  data.tar.gz: ac4037e5b01cf28cd46bfcf1d7278382d0d15157da228ed37b2cdf2e55610fc2
 SHA512:
-  metadata.gz: 48c3b6ffda0ee6f94aa43fe31fc963be9228aba19adff661ad63bbfc8737be084d8db2c412cee9fa85e7cb9d8fee97fb6e46eb0d752dfdc2bbf6ba0dcf6d322b
-  data.tar.gz: fb14d75d44756fe762f86b81425d6e13796bca980a3b8a5bbecef824fe363085366d3af51a6fffbd5de28d113af304960de1b6a06289cf3138c89a2e7915dc3c
+  metadata.gz: cca7de548087b2bc5f713f26fa76e405802ad1125d8a22b92577324b13f32086322938993ce3f6c45596f307af9abe835afd713870c87d7acdcfcfe404094576
+  data.tar.gz: 45ff2ebc47de2509e73bdb6c0623e63419a15d0b8294ef12e5f69bc568a0ab99b6afe0adf538e1c6d56a49f53c7da2343087827059d36b3a45e9e2adb641715b

data/README.md

@@ -28,7 +28,7 @@ Maximum value of 2^256-1 =
 ``` ruby
 2**256-1
 #=> 115792089237316195423570985008687907853269984665640564039457584007913129639935
-(2**256-1).to_s.length
+(2**256-1).digits.size           # or to_s.length
 #=> 78
 ```
 
@@ -41,12 +41,12 @@ in hexadecimal (base 16) and binary (base 2) format?
 ``` ruby
 (2**256-1).to_s(16)
 #=> "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
-(2**256-1).to_s(16).length
+(2**256-1).digits(16).size      # or to_s(16).length
 #=> 64
 
 (2**256-1).to_s(2)
 #=> "1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111"
-(2**256-1).to_s(2).length
+(2**256-1).digits(2).size       # or to_s(2).length
 #=> 256
 ```
 
@@ -77,15 +77,17 @@ require 'elliptic'
 private_key = EC::PrivateKey.generate    # by default uses Secp256k1 curve (used in Bitcoin and Ethereum)
 
 private_key.to_i
-#=> 72190737707147846840353520312904745954595478835413056312168022784020322830309
+#=> 29170346885894798724849267297784761178669026868482995474159965944722616190552
+private_key.to_s
+#=> "407dd4ccde53d30f3a9cda74ceccb247f3997466964786b59e4d68e93e8f8658"
 ```
 
 
-### (Auto-)Calculate the Public Key - Enter Elliptic Curve (EC) Cryptography
+### Derive / (Auto-)Calculate the Public Key - Enter Elliptic Curve (EC) Cryptography
 
-The public key are two numbers (that is, a point with the coordinates x and y) computed by multiplying
-the generator point (`G`) of the curve with the private key.
-This is equivalent to adding the generator to itself `private_key` times.
+The public key (`K`) are two numbers (that is, a point with the coordinates x and y) computed by multiplying
+the generator point (`G`) of the curve with the private key (`k`) e.g. `K=k*G`.
+This is equivalent to adding the generator to itself `k` times.
 Magic?
 Let's try:
 
@@ -266,7 +268,7 @@ public_key.to_pem
 
 To export a private or public key to
 the (binary) Distinguished Encoding Rules (DER)
-in ASN.1 format use `to_der`:
+in Abstract Syntax Notation One (ASN.1) format use `to_der`:
 
 ``` ruby
 private_key.to_der
@@ -286,7 +288,7 @@ public_key.to_der
 
 To export a private or public key to
 the Base64-encoded Distinguished Encoding Rules (DER)
-in ASN.1 format use `to_base64`:
+in Abstract Syntax Notation One (ASN.1) format use `to_base64`:
 
 ``` ruby
 private_key.to_base64

data/lib/elliptic.rb

@@ -2,6 +2,8 @@ require 'pp'
 require 'digest'
 require 'base64'
 require 'openssl'
+require 'securerandom'
+
 
 ## our own code
 require 'elliptic/version'    # note: let version always go first
@@ -13,10 +15,11 @@ require 'elliptic/signature'
 
 module EC
 
+  SECP256K1 = Secp256k1 = OpenSSL::PKey::EC::Group.new( 'secp256k1' )
   ## "cached" / available groups for now include:
+  ##  todo/check: change group to curve - why? why not?
   GROUP = {
-    ## todo/check: is there a more direct way to get a group object?
-    'secp256k1' =>  OpenSSL::PKey::EC.new( 'secp256k1' ).group
+    'secp256k1' => SECP256K1,
   }
 
 
@@ -28,6 +31,8 @@ module EC
          @pt = args[0]
 
          ## todo/check: is there a "better" way to get the x/y numbers?
+         ## note: octet_string is just a fancy name (technial term) for
+         ##           byte/binary string (where a byte is 8-bit, thus octet)
          hex = @pt.to_octet_string( :uncompressed ).unpack( 'H*' )[0]
 
          ## todo/fix: check for infinity / 0 !!!!
@@ -38,14 +43,21 @@ module EC
 
          @x = args[0]
          @y = args[1]
-
          ## encoded_point is the octet string representation of the point.
          ## This must be either a String or an OpenSSL::BN
-         hex = '04' + ("%064x" % @x) + ("%064x" % @y)
+         ##   was: ("%064x" % @x) + ("%064x" % @y)
+         hex = '04' +
+               @x.to_s(16).rjust(64, '0') +
+               @y.to_s(16).rjust(64, '0')
          bin = [hex].pack( 'H*' )
 
          ec_group = GROUP[ group || 'secp256k1' ]
          @pt = OpenSSL::PKey::EC::Point.new( ec_group, bin )
+
+         ### or use hex e.g.
+         ## hex = '04fc9702847840aaf195de8442ebecedf5b095cdbb9bc716bda9110971b28a49e0ead8564ff0db22209e0374782c093bb899692d524e9d6a6956e7c5ecbcd68284'
+         ## bn = OpenSSL::BN.new(hex, 16)    # note: 16=Hexadecimal string encoding
+         ## OpenSSL::PKey::EC::Point.new( ec_group, bn )
       end
     end
 

data/lib/elliptic/private_key.rb

@@ -47,9 +47,14 @@ class PrivateKey
 
 
   def to_i()  @pkey.private_key.to_i;           end
+
   ## todo/check/fix: make it always a 32 byte (64 hex chars) string
   ##                    even with leading zeros !!! - why? why not?
-  def to_s()  @pkey.private_key.to_i.to_s(16);  end
+  ##  todo/check - add hex alias - why? why not?
+  def to_s
+     ## todo/fix:  use number of bytes depending on curve (e.g. secp256k1 = 32-byte/256-bit)
+     @pkey.private_key.to_i.to_s(16).rjust(64, '0'); # convert to hex and make sure it's 32 bytes (64 characters)
+  end
 
 
   def to_pem()     @pkey.to_pem; end

data/lib/elliptic/version.rb

@@ -5,7 +5,7 @@ module EC
 
   MAJOR = 1
   MINOR = 0
-  PATCH = 1
+  PATCH = 2
   VERSION = [MAJOR,MINOR,PATCH].join('.')
 
   def self.version

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: elliptic
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Gerald Bauer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-24 00:00:00.000000000 Z
+date: 2021-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc