ellen-github 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9daee4e66e51d6e4a8f8e7faba35609ca088e7ea
-  data.tar.gz: f6dc855d733ecaba80492406a3ef3c23ecd260ed
+  metadata.gz: 840f7c706f1f5332b87c3e9e0ab87df61dab4a41
+  data.tar.gz: 5d9a376a02e562220123eec71a7f38c9179ed5de
 SHA512:
-  metadata.gz: 1e23e91b34ae15f824f162ceadc9e8633adb3d621ca86c1c553c6476094bcb70e879f685e277a98eb5393582bd1bd0022956ccb588ecb1296d09b0fb58688cbc
-  data.tar.gz: 8f47fb7aee9b2990a732fa2f1088cb12a7c3105d6e75ed3355e7b212614837843e2c41856a7905517348d009ea4e9ce0107bbaa823d5c9957b7e8a3b3f0c5584
+  metadata.gz: 23048c0c8fb1fcf8f3839aaf8e52d6be836dd1f05a4417af37e41ffaa49cc8a43ed69c1bbea4ef3f2d9f8c6fa6673674e71e438be7452758999a7ac9673aa13b
+  data.tar.gz: 9617bcf4c983e776b4fe17d7d1a457ae7268540ca4dcdafc5fd5f2d53fe4724587b6f021e37dc16a282917ec1b07564ac8e3fb5969590d308f4eade08fac2db5

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.0.4
+* Add close command
+
 ## 0.0.3
 * Support Ellen v0.2.0
 

data/README.md

@@ -9,6 +9,10 @@ gem "ellen-github"
 
 ## Usage
 ```
+@ellen close issue <username>/<repository>#<number>      - Close an Issue
 @ellen create issue "<title>" on <username>/<repository> - Create a new Issue
 @ellen remember my github token <token>                  - Remember sender's GitHub access token
 ```
+
+## Image
+![](https://raw.githubusercontent.com/r7kamura/ellen-github/master/images/screenshot.png)

data/lib/ellen/github.rb

@@ -1,5 +1,8 @@
+require "octokit"
+
 require "ellen"
 require "ellen/github/actions/base"
+require "ellen/github/actions/close_issue"
 require "ellen/github/actions/create_issue"
 require "ellen/github/actions/remember"
 require "ellen/github/version"

data/lib/ellen/github/actions/base.rb

@@ -21,6 +21,26 @@ module Ellen
         def sender_name
           message.from
         end
+
+        def require_access_token
+          message.reply("I don't know your github access token")
+        end
+
+        def has_access_token?
+          !!access_token
+        end
+
+        def access_token
+          @access_token ||= access_tokens[sender_name]
+        end
+
+        def client
+          Octokit::Client.new(access_token: access_token)
+        end
+
+        def repository
+          message[:repo]
+        end
       end
     end
   end

data/lib/ellen/github/actions/close_issue.rb

@@ -0,0 +1,52 @@
+module Ellen
+  module Github
+    module Actions
+      class CloseIssue < Base
+        def call
+          case
+          when !has_access_token?
+            require_access_token
+          when has_closed_issue_number?
+            reply_already_closed
+          else
+            close
+          end
+        rescue Octokit::Unauthorized
+          message.reply("Failed in authentication (401)")
+        rescue Octokit::NotFound
+          message.reply("Could not find that issue")
+        rescue => exception
+          raise exception
+          message.reply("Failed by #{exception.class}")
+        end
+
+        private
+
+        def close
+          request
+          message.reply("Closed #{issue.html_url}")
+        end
+
+        def request
+          client.close_issue(repository, issue_number)
+        end
+
+        def has_closed_issue_number?
+          issue.state == "closed"
+        end
+
+        def reply_already_closed
+          message.reply("Already closed #{issue.html_url}")
+        end
+
+        def issue
+          @issue ||= client.issue(repository, issue_number)
+        end
+
+        def issue_number
+          message[:number]
+        end
+      end
+    end
+  end
+end

data/lib/ellen/github/actions/create_issue.rb

@@ -14,14 +14,6 @@ module Ellen
 
         private
 
-        def require_access_token
-          message.reply("I don't know your github access token")
-        end
-
-        def created
-          message.reply("Created a new Issue")
-        end
-
         def create
           message.reply("Created #{issue.html_url}")
         rescue Octokit::Unauthorized
@@ -36,22 +28,6 @@ module Ellen
           client.create_issue(repository, title, body)
         end
 
-        def has_access_token?
-          !!access_token
-        end
-
-        def access_token
-          @access_token ||= access_tokens[sender_name]
-        end
-
-        def client
-          Octokit::Client.new(access_token: access_token)
-        end
-
-        def repository
-          message[:repo]
-        end
-
         def title
           message[:title]
         end

data/lib/ellen/github/version.rb

@@ -1,5 +1,5 @@
 module Ellen
   module Github
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/lib/ellen/handlers/github.rb

@@ -1,14 +1,32 @@
 module Ellen
   module Handlers
     class Github < Base
-      on(/create issue "(?<title>.+)" on (?<repo>.+)\z/, name: "create_issue", description: "Create a new issue")
+      on(
+        /create issue "(?<title>.+)" on (?<repo>.+)\z/,
+        name: "create_issue",
+        description: "Create a new issue",
+      )
 
-      on(/remember my github token (?<token>.+)\z/, name: "remember", description: "Remember sender's GitHub access token")
+      on(
+        /remember my github token (?<token>.+)\z/,
+        name: "remember",
+        description: "Remember sender's GitHub access token",
+      )
+
+      on(
+        /close issue (?<repo>.+)#(?<number>\d+)\z/,
+        name: "close_issue",
+        description: "Close an issue",
+      )
 
       def create_issue(message)
         Ellen::Github::Actions::CreateIssue.new(message).call
       end
 
+      def close_issue(message)
+        Ellen::Github::Actions::CloseIssue.new(message).call
+      end
+
       def remember(message)
         Ellen::Github::Actions::Remember.new(message).call
       end

data/spec/ellen/handlers/github_spec.rb

@@ -2,10 +2,18 @@ require "spec_helper"
 require "json"
 
 describe Ellen::Handlers::Github do
+  before do
+    access_tokens.merge!(sender => stored_access_token)
+  end
+
   let(:robot) do
     Ellen::Robot.new
   end
 
+  let(:stored_access_token) do
+    github_access_token
+  end
+
   let(:github_access_token) do
     "dummy"
   end
@@ -18,13 +26,38 @@ describe Ellen::Handlers::Github do
     "#general"
   end
 
+  let(:user) do
+    "alice"
+  end
+
+  let(:repository) do
+    "test"
+  end
+
   let(:access_tokens) do
     robot.brain.data[Ellen::Github::Actions::Base::NAMESPACE] ||= {}
   end
 
+  let(:call) do
+    robot.receive(body: body, from: sender, to: channel)
+  end
+
+  shared_examples_for "requires access token without access token" do
+    context "without access token" do
+      let(:stored_access_token) do
+        nil
+      end
+
+      it "requires access token" do
+        Ellen.logger.should_receive(:info).with("I don't know your github access token")
+        call
+        a_request(:any, //).should_not have_been_made
+      end
+    end
+  end
+
   describe "#create_issue" do
     before do
-      Ellen.logger.stub(:info)
       stub_request(:post, "https://api.github.com/repos/#{user}/#{repository}/issues").
         with(
           body: {
@@ -38,14 +71,6 @@ describe Ellen::Handlers::Github do
         )
     end
 
-    let(:user) do
-      "alice"
-    end
-
-    let(:repository) do
-      "test"
-    end
-
     let(:title) do
       "This is a test issue"
     end
@@ -54,29 +79,72 @@ describe Ellen::Handlers::Github do
       %<ellen create issue "#{title}" on #{user}/#{repository}>
     end
 
-    context "when access token for the sender is remembered" do
-      before do
-        access_tokens.merge!(sender => github_access_token)
-      end
+    include_examples "requires access token without access token"
 
+    context "with access token" do
       it "creates a new issue with given title on given repository" do
-        robot.receive(
-          body: body,
-          from: sender,
-          to: channel,
-        )
+        call
         a_request(:any, //).should have_been_made
       end
     end
+  end
 
-    context "when access token for the sender is not remembered" do
-      it "does not create a new issue" do
-        robot.receive(
-          body: body,
-          from: sender,
-          to: channel,
+  describe "#close_issue" do
+    before do
+      stub_request(:get, "https://api.github.com/repos/#{user}/#{repository}/issues/#{issue_number}").
+        with(
+          headers: {
+            Authorization: "token #{github_access_token}"
+          },
+        ).
+        to_return(
+          body: {
+            state: issue_status,
+            html_url: html_url,
+          }.to_json,
+          headers: {
+            "Content-Type" => "application/json",
+          },
         )
-        a_request(:any, //).should_not have_been_made
+      stub_request(:patch, "https://api.github.com/repos/#{user}/#{repository}/issues/#{issue_number}").
+        with(
+          body: {
+            state: "closed",
+          }.to_json,
+          headers: {
+            Authorization: "token #{github_access_token}"
+          },
+        )
+    end
+
+    let(:html_url) do
+      "http://example.com/#{user}/#{repository}/issues/#{issue_number}"
+    end
+
+    let(:issue_status) do
+      "open"
+    end
+
+    let(:body) do
+      "@ellen close issue #{user}/#{repository}##{issue_number}"
+    end
+
+    let(:issue_number) do
+      1
+    end
+
+    include_examples "requires access token without access token"
+
+    context "with closed issue" do
+      it "replies so" do
+        Ellen.logger.should_receive(:info).with("Closed #{html_url}")
+        call
+      end
+    end
+
+    context "with access token" do
+      it "closes specified issue" do
+        call
       end
     end
   end
@@ -88,11 +156,7 @@ describe Ellen::Handlers::Github do
 
     it "remembers sender's access token in its brain" do
       Ellen.logger.should_receive(:info).with("Remembered #{sender}'s github access token")
-      robot.receive(
-        body: body,
-        from: sender,
-        to: channel,
-      )
+      call
       access_tokens[sender].should == github_access_token
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ellen-github
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ryo Nakamura
@@ -122,8 +122,10 @@ files:
 - README.md
 - Rakefile
 - ellen-github.gemspec
+- images/screenshot.png
 - lib/ellen/github.rb
 - lib/ellen/github/actions/base.rb
+- lib/ellen/github/actions/close_issue.rb
 - lib/ellen/github/actions/create_issue.rb
 - lib/ellen/github/actions/remember.rb
 - lib/ellen/github/version.rb