ellen-github 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c849dc2b74f690e8f9bec2968d5dc257586c968
-  data.tar.gz: fb81891c2819a3a6cca9d89659130890e1494b08
+  metadata.gz: 9daee4e66e51d6e4a8f8e7faba35609ca088e7ea
+  data.tar.gz: f6dc855d733ecaba80492406a3ef3c23ecd260ed
 SHA512:
-  metadata.gz: 564707102b614e9321ccab7e724673f83700efee00a475f435aa886259f6003c3e3dd0d2e9b7e9554784debf06dd01609fcc1b0c4afd245cadb753575fef3b8d
-  data.tar.gz: 40eeb7c04e55da2d1244edfbbcb8419ebf9bd608e1801703ed82a727788374b26e426af7bb828ce651fcc5a852e290b9f2c84008f201b958aa1cd4b6df32863b
+  metadata.gz: 1e23e91b34ae15f824f162ceadc9e8633adb3d621ca86c1c553c6476094bcb70e879f685e277a98eb5393582bd1bd0022956ccb588ecb1296d09b0fb58688cbc
+  data.tar.gz: 8f47fb7aee9b2990a732fa2f1088cb12a7c3105d6e75ed3355e7b212614837843e2c41856a7905517348d009ea4e9ce0107bbaa823d5c9957b7e8a3b3f0c5584

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.0.3
+* Support Ellen v0.2.0
+
 ## 0.0.2
 * Memorize access token and use it to create a new issue
 

data/ellen-github.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "ellen", ">= 0.1.3"
+  spec.add_dependency "ellen", ">= 0.2.0"
   spec.add_dependency "octokit"
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"

data/lib/ellen/github/actions/base.rb

@@ -6,17 +6,16 @@ module Ellen
       class Base
         NAMESPACE = "github"
 
-        attr_reader :message, :robot
+        attr_reader :message
 
-        def initialize(options)
-          @message = options[:message]
-          @robot = options[:robot]
+        def initialize(message)
+          @message = message
         end
 
         private
 
         def access_tokens
-          robot.brain.data[NAMESPACE] ||= {}
+          message.robot.brain.data[NAMESPACE] ||= {}
         end
 
         def sender_name

data/lib/ellen/github/actions/create_issue.rb

@@ -15,21 +15,21 @@ module Ellen
         private
 
         def require_access_token
-          robot.say("I don't know your github access token")
+          message.reply("I don't know your github access token")
         end
 
         def created
-          robot.say("Created a new Issue")
+          message.reply("Created a new Issue")
         end
 
         def create
-          robot.say("Created #{issue.html_url}")
+          message.reply("Created #{issue.html_url}")
         rescue Octokit::Unauthorized
-          robot.say("Failed in authentication (401)")
+          message.reply("Failed in authentication (401)")
         rescue Octokit::NotFound
-          robot.say("Could not find that repository")
+          message.reply("Could not find that repository")
         rescue => exception
-          robot.say("Failed (#{exception.class})")
+          message.reply("Failed by #{exception.class}")
         end
 
         def issue

data/lib/ellen/github/actions/remember.rb

@@ -2,13 +2,6 @@ module Ellen
   module Github
     module Actions
       class Remember < Base
-        attr_reader :message, :robot
-
-        def initialize(options)
-          @message = options[:message]
-          @robot = options[:robot]
-        end
-
         def call
           remember
           report
@@ -17,7 +10,7 @@ module Ellen
         private
 
         def report
-          robot.say("Remembered #{robot.name}'s github access token")
+          message.reply("Remembered #{sender_name}'s github access token")
         end
 
         def remember

data/lib/ellen/github/version.rb

@@ -1,5 +1,5 @@
 module Ellen
   module Github
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/ellen/handlers/github.rb

@@ -6,11 +6,11 @@ module Ellen
       on(/remember my github token (?<token>.+)\z/, name: "remember", description: "Remember sender's GitHub access token")
 
       def create_issue(message)
-        Ellen::Github::Actions::CreateIssue.new(message: message, robot: robot).call
+        Ellen::Github::Actions::CreateIssue.new(message).call
       end
 
       def remember(message)
-        Ellen::Github::Actions::Remember.new(message: message, robot: robot).call
+        Ellen::Github::Actions::Remember.new(message).call
       end
     end
   end

data/spec/ellen/handlers/github_spec.rb

@@ -2,14 +2,6 @@ require "spec_helper"
 require "json"
 
 describe Ellen::Handlers::Github do
-  before do
-    ENV["GITHUB_ACCESS_TOKEN"] = github_access_token
-  end
-
-  after do
-    ENV["GITHUB_ACCESS_TOKEN"] = nil
-  end
-
   let(:robot) do
     Ellen::Robot.new
   end
@@ -18,28 +10,21 @@ describe Ellen::Handlers::Github do
     "dummy"
   end
 
-  describe "#initialize" do
-    context "without GITHUB_ACCESS_TOKEN" do
-      let(:github_access_token) do
-        nil
-      end
+  let(:sender) do
+    "bob"
+  end
 
-      it "dies" do
-        Ellen.should_receive(:die)
-        described_class.new(robot)
-      end
-    end
+  let(:channel) do
+    "#general"
+  end
 
-    context "with GITHUB_ACCESS_TOKEN" do
-      it "does not die" do
-        Ellen.should_not_receive(:die)
-        described_class.new(robot)
-      end
-    end
+  let(:access_tokens) do
+    robot.brain.data[Ellen::Github::Actions::Base::NAMESPACE] ||= {}
   end
 
   describe "#create_issue" do
     before do
+      Ellen.logger.stub(:info)
       stub_request(:post, "https://api.github.com/repos/#{user}/#{repository}/issues").
         with(
           body: {
@@ -65,8 +50,50 @@ describe Ellen::Handlers::Github do
       "This is a test issue"
     end
 
-    it "creates a new issue with given title on given repository" do
-      robot.receive(body: %<ellen create issue "#{title}" on #{user}/#{repository}>)
+    let(:body) do
+      %<ellen create issue "#{title}" on #{user}/#{repository}>
+    end
+
+    context "when access token for the sender is remembered" do
+      before do
+        access_tokens.merge!(sender => github_access_token)
+      end
+
+      it "creates a new issue with given title on given repository" do
+        robot.receive(
+          body: body,
+          from: sender,
+          to: channel,
+        )
+        a_request(:any, //).should have_been_made
+      end
+    end
+
+    context "when access token for the sender is not remembered" do
+      it "does not create a new issue" do
+        robot.receive(
+          body: body,
+          from: sender,
+          to: channel,
+        )
+        a_request(:any, //).should_not have_been_made
+      end
+    end
+  end
+
+  describe "#remember" do
+    let(:body) do
+      "@ellen remember my github token #{github_access_token}"
+    end
+
+    it "remembers sender's access token in its brain" do
+      Ellen.logger.should_receive(:info).with("Remembered #{sender}'s github access token")
+      robot.receive(
+        body: body,
+        from: sender,
+        to: channel,
+      )
+      access_tokens[sender].should == github_access_token
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ellen-github
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2014-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ellen
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.3
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement