elibri_onix 0.2.4 → 0.2.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    elibri_onix (0.2.3)
+    elibri_onix (0.2.4)
       activesupport (>= 2.3.5)
       elibri_onix_dict (>= 0.0.5)
       i18n
@@ -24,7 +24,6 @@ GEM
     mocha (0.11.4)
       metaclass (~> 0.0.1)
     multi_json (1.5.0)
-    nokogiri (1.5.6)
     nokogiri (1.5.6-java)
     pry (0.9.9.6)
       coderay (~> 1.0.5)

data/lib/elibri_onix/hash_id.rb

@@ -1,6 +1,6 @@
 module HashId
   
-  SKIPPED_ATTRIBS = ["@opts", "@default_namespace", "@instance", "@roxml_references"]
+  SKIPPED_ATTRIBS = ["@opts", "@default_namespace", "@instance"]
   SKIPPED_2 = ["@id", "@id_before_type_cast"]
 
   def eid
@@ -34,4 +34,4 @@ module HashId
     return Digest::SHA1.hexdigest(result.join("-"))
   end
 
-end
+end

data/lib/elibri_onix/inspector.rb

@@ -7,19 +7,20 @@ module Inspector
       "#{value[0..50]}...".inspect
     elsif value.is_a?(Date) || value.is_a?(Time)
       %("#{value.to_s(:db)}")
-    #elsif value.is_a?(Array)
-    #  "\n    [" + value.map(&:inspect).join(",\n     ") + "]"
     else
       value.inspect
     end
   end
 
   def inspect
-    include_fields = self.respond_to?(:inspect_include_fields) ? self.inspect_include_fields : []
-    attributes_as_nice_string = (include_fields + self.roxml_references.map { |rr| rr.opts.attr_name }).collect { |name|
-      "#{name}: #{attribute_for_inspect(name)}"
-    }.compact.join(", ")
-    "#<#{self.class} #{attributes_as_nice_string}>"
+    if self.respond_to?(:inspect_include_fields)
+      attributes_as_nice_string = self.inspect_include_fields.collect { |name|
+        "#{name}: #{attribute_for_inspect(name)}"
+      }.compact.join(", ")
+      "#<#{self.class} #{attributes_as_nice_string}>"
+    else
+      super
+    end
   end
 end
 

data/lib/elibri_onix/onix_3_0/audience_range.rb

@@ -8,14 +8,16 @@ module Elibri
         #from ONIX documentation:
         #An optional and repeatable group of data elements which together describe an audience or readership range for which a product
         #is intended.
-        
+ 
+        #:nodoc:       
         ATTRIBUTES = [
           :qualifier, :precision, :value
         ]
         
+        #:nodoc:
         RELATIONS = []
         
-        attr_accessor :qualifier, :precision, :value, :to_xml
+        attr_reader :qualifier, :precision, :value, :to_xml
 
         def initialize(data)
           @old_xml = data.to_s

data/lib/elibri_onix/onix_3_0/product.rb

@@ -6,6 +6,8 @@ module Elibri
       #Niektóre pola mogą pozostać bez wartości - zależy to od formy produktu
       class Product
         
+        include Inspector
+
         #:nodoc:
         ATTRIBUTES =
         [
@@ -32,6 +34,11 @@ module Elibri
           :cover_designers, :inked_or_colored_bys, :editors, :revisors, :translators, :editor_in_chiefs, :read_bys
         ]
 
+        def inspect_include_fields
+          [:record_reference, :full_title, :front_cover, :publisher, :isbn13, :ean, :premiere]
+        end
+
+
         #:doc:
         #wysokość w milimetrach
         attr_reader :height
@@ -76,10 +83,10 @@ module Elibri
         #Wiek czytelnika - do
         attr_reader :reading_age_to
 
-        #Spis treści - jeśli wydawca takowy umieścił
+        #Spis treści - jeśli wydawca takowy umieścił, instancja TextContent
         attr_reader :table_of_contents
 
-        #Opis produktu
+        #Opis produktu, instancja TextContent
         attr_reader :description
 
         #lista serii, w postaci [nazwa serii, numer w serii]
@@ -103,7 +110,7 @@ module Elibri
         #tytuł oryginału
         attr_reader :original_title
 
-        #krótki opis, jeśli wydawca takowy zamieści
+        #krótki opis, jeśli wydawca takowy zamieści, instancja TextContent
         attr_reader :short_description
 
         #id kategorii elibri (1)
@@ -374,31 +381,6 @@ module Elibri
           @identifiers.find_all { |i| i.identifier_type == "proprietary" }.inject({}) { |res, ident| res[ident.type_name] = ident.value; res }
         end
 
-        #:nodoc:
-        def pretty_print_instance_variables
-          (instance_variables - ["@roxml_references", "@measures", "@identifiers", "@notification_type", "@publishing_status",
-                                 "@elibri_dialect", "@product_composition", "@extents", "@publisher", "@imprint",
-                                 "@audience_ranges", "@text_contents", "@collections", "@title_details", "@publishing_date"]).find_all { |varname|
-              instance_variable_get(varname).present?
-          }.sort
-        end
-
-        #:nodoc:
-        def pretty_print(pp)
-          pp.object_address_group(self) {
-            pp.seplist(self.pretty_print_instance_variables, lambda { pp.text ',' }) {|v|
-              pp.breakable
-              v = v.to_s if Symbol === v
-              pp.text v
-              pp.text '='
-              pp.group(1) {
-                pp.breakable ''
-                pp.pp(self.instance_eval(v))
-              }
-            }
-          }
-        end
-        
         #data premiery w postaci listy [rok, miesiąc, dzień], [rok, miesiąc], [rok], lub pustej listy - jeśli data premiery nie jest znana
         #(data premiery może nie być znana w przypadku backlisty)
         def parsed_publishing_date

data/lib/elibri_onix/onix_3_0/publisher.rb

@@ -12,6 +12,9 @@ module Elibri
         #The composite allows additional publishing roles to be introduced without adding new fields.
         #Each occurrence of the composite must carry a publishing role code and either a name identifier code or a name or both.
         
+
+        include Inspector
+
         ATTRIBUTES = [
           :role, :name, :eid
         ]
@@ -30,6 +33,10 @@ module Elibri
             @eid = data.at_xpath('xmlns:PublisherIdentifier').at_xpath('xmlns:IDValue').try(:text).try(:to_i)
           end
         end
+
+        def inspect_include_fields
+          [:eid, :name]
+        end
         
         def id
           Kernel.warn "[DEPRECATION] `id` is deprecated. Please use `eid` instead."

data/lib/elibri_onix/onix_3_0/supporting_resource.rb

@@ -7,6 +7,7 @@ module Elibri
       class SupportingResource
         include ExternalId
         include ExternalTimestamp
+        include Inspector
         
         #from ONIX documentation:
         #An optional and repeatable group of data elements which together describe a supporting resource.

data/lib/elibri_onix/onix_3_0/text_content.rb

@@ -9,11 +9,13 @@ module Elibri
          
         #from ONIX documentation:
         #An optional and repeatable group of data elements which together carry text related to the product.
-      
+  
+        #:nodoc:    
         ATTRIBUTES = [
           :type, :author, :source_title, :text, :source_url, :type_name
         ]
         
+        #:nodoc:
         RELATIONS = [
           :inspect_include_fields
         ]

data/lib/elibri_onix/version.rb

@@ -2,7 +2,7 @@ module Elibri
   module ONIX
     z = $VERBOSE
     $VERBOSE = nil
-    VERSION = "0.2.4"
+    VERSION = "0.2.5"
     Version = VERSION
     $VERBOSE = z
   end

metadata

@@ -2,7 +2,7 @@
 name: elibri_onix
 version: !ruby/object:Gem::Version
   prerelease:
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Marcin Urbanski