elibri_onix 0.1.7 → 0.1.8

data/Gemfile

@@ -3,7 +3,7 @@ source "http://rubygems.org"
 gem 'activesupport', '>= 2.3.5'
 gem 'roxml', '= 3.1.3'
 gem 'i18n'
-gem 'elibri_onix_dict', '0.0.4'
+gem 'elibri_onix_dict', '0.0.5'
 
 group :development do
   gem "pry"

data/Gemfile.lock

@@ -3,7 +3,7 @@ GEM
   specs:
     activesupport (2.3.5)
     coderay (0.9.8)
-    elibri_onix_dict (0.0.4)
+    elibri_onix_dict (0.0.5)
     git (1.2.5)
     i18n (0.6.0)
     jeweler (1.6.4)
@@ -38,7 +38,7 @@ PLATFORMS
 DEPENDENCIES
   activesupport (>= 2.3.5)
   bundler (>= 1.0.0)
-  elibri_onix_dict (= 0.0.4)
+  elibri_onix_dict (= 0.0.5)
   i18n
   jeweler (~> 1.6.2)
   minitest

data/elibri_onix.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{elibri_onix}
-  s.version = "0.1.7"
+  s.version = "0.1.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Marcin Urbanski"]
-  s.date = %q{2011-11-14}
+  s.date = %q{2011-11-21}
   s.description = %q{EDItEUR ONIX format subset implementation used in Elibri publication system}
   s.email = %q{marcin@urbanski.vdl.pl}
   s.extra_rdoc_files = [
@@ -103,7 +103,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/elibri/elibri_onix}
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.6.2}
+  s.rubygems_version = %q{1.5.2}
   s.summary = %q{EDItEUR ONIX format subset implementation used in Elibri publication system}
 
   if s.respond_to? :specification_version then
@@ -113,7 +113,7 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<activesupport>, [">= 2.3.5"])
       s.add_runtime_dependency(%q<roxml>, ["= 3.1.3"])
       s.add_runtime_dependency(%q<i18n>, [">= 0"])
-      s.add_runtime_dependency(%q<elibri_onix_dict>, ["= 0.0.4"])
+      s.add_runtime_dependency(%q<elibri_onix_dict>, ["= 0.0.5"])
       s.add_development_dependency(%q<pry>, [">= 0"])
       s.add_development_dependency(%q<mocha>, [">= 0"])
       s.add_development_dependency(%q<minitest>, [">= 0"])
@@ -124,7 +124,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<activesupport>, [">= 2.3.5"])
       s.add_dependency(%q<roxml>, ["= 3.1.3"])
       s.add_dependency(%q<i18n>, [">= 0"])
-      s.add_dependency(%q<elibri_onix_dict>, ["= 0.0.4"])
+      s.add_dependency(%q<elibri_onix_dict>, ["= 0.0.5"])
       s.add_dependency(%q<pry>, [">= 0"])
       s.add_dependency(%q<mocha>, [">= 0"])
       s.add_dependency(%q<minitest>, [">= 0"])
@@ -136,7 +136,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<activesupport>, [">= 2.3.5"])
     s.add_dependency(%q<roxml>, ["= 3.1.3"])
     s.add_dependency(%q<i18n>, [">= 0"])
-    s.add_dependency(%q<elibri_onix_dict>, ["= 0.0.4"])
+    s.add_dependency(%q<elibri_onix_dict>, ["= 0.0.5"])
     s.add_dependency(%q<pry>, [">= 0"])
     s.add_dependency(%q<mocha>, [">= 0"])
     s.add_dependency(%q<minitest>, [">= 0"])

data/lib/elibri_onix/onix_3_0/product.rb

@@ -77,6 +77,24 @@ module Elibri
           contributors.size == 1 && contributors[0].unnamed_persons.present?
         end
 
+        def authors
+          unnamed_persons? ? ["praca zbiorowa"] : contributors.find_all { |c| c.role_name == "author" }.map(&:person_name)
+        end
+
+        [:ghostwriter, :scenarist, :originator, :illustrator, :photographer, :author_of_preface, :drawer, :cover_designer, 
+         :inked_or_colored_by, :editor, :revisor, :translator, :editor_in_chief, :read_by].each do |role|
+          define_method "#{role}s" do
+            contributors.find_all { |c| c.role_name == role.to_s }.map(&:person_name)
+          end
+        end
+
+        [:announced, :preorder, :published, :out_of_print].each do |state|
+          define_method "#{state}?" do
+            current_state == state
+          end
+        end
+
+
         def front_cover
           supporting_resources.find { |resource| resource.content_type_name == "front_cover" }.try(:link)
         end
@@ -84,6 +102,10 @@ module Elibri
         def series_names
           series.map { |series| series[0] }
         end
+
+        def premiere
+          Date.new(*parsed_publishing_date) if parsed_publishing_date.size == 3
+        end
  
         def proprietary_identifiers 
           identifiers.find_all { |i| i.identifier_type == "proprietary" }.inject({}) { |res, ident| res[ident.type_name] = ident.value; res }
@@ -152,10 +174,13 @@ module Elibri
           @reviews = text_contents.find_all { |t| t.type_name == "review" }.map { |t| [t.text, t.author] }
           @excerpts = text_contents.find_all { |t| t.type_name == "excerpt" }.map { |t| t.text }
           @series = collections.map { |c| [c.title_detail.elements[0].title,  c.title_detail.elements[0].part_number] }
-          @title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE).product_level.try(:title)
-          @subtitle = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE).product_level.try(:subtitle)
-          @collection_title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE).collection_level.try(:title)
-          @collection_part = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE).collection_level.try(:part_number)
+          distinctive_title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE)
+          if distinctive_title
+            @title = distinctive_title.product_level.try(:title)
+            @subtitle = distinctive_title.product_level.try(:subtitle)
+            @collection_title = distinctive_title.collection_level.try(:title)
+            @collection_part = distinctive_title.collection_level.try(:part_number)
+          end
           @full_title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTINCTIVE_TITLE).try(:full_title)
           @original_title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::ORIGINAL_TITLE).try(:full_title)
           @trade_title = find_title(Elibri::ONIX::Dict::Release_3_0::TitleType::DISTRIBUTORS_TITLE).try(:full_title)
@@ -174,7 +199,7 @@ module Elibri
             elsif publishing_status == "07"
               @current_state = :out_of_print
             else
-              raise "cannot determine the state of the product"
+              raise "cannot determine the state of the product #{record_reference}"
             end
           end
         end

data/lib/elibri_onix/version.rb

@@ -4,7 +4,7 @@ module Elibri
     module Version
       MAJOR = 0
       MINOR = 1
-      PATCH = 7
+      PATCH = 8
 
       STRING = [MAJOR, MINOR, PATCH].compact.join('.')
     end

data/test/elibri_audience_range_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse audience attributes supported in Elibri" do
     product = load_fixture("onix_audience_range_example.xml")
 
     assert_equal 7, product.reading_age_from

data/test/elibri_contributors_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse contributors info" do
     product = load_fixture("onix_contributors_example.xml")
 
     assert !product.no_contributor?
@@ -13,23 +13,23 @@ describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
     assert_equal "author", cont1.role_name
     assert_equal "Św. Tomasz z Akwinu", cont1.person_name
+    assert_equal ["Św. Tomasz z Akwinu"], product.authors
     assert cont1.biographical_note.present?
 
     assert_equal "translator", cont2.role_name
     assert_equal "prof. ks. Henryk von Hausswolff OP", cont2.person_name
-
-    #<Elibri::ONIX::Release_3_0::Contributor role_name: "author", number: 1, role: "A01", person_name: "Św. Tomasz z Akwinu", from_language: nil, titles_before_names: nil, names_before_key: "Św.", prefix_to_key: nil, key_names: "Tomasz z Akwinu", names_after_key: nil, biographical_note: "Tomasz z Akwinu, Akwinata, łac. Thoma de Aquino (u...", unnamed_persons: nil>,
-    # #<Elibri::ONIX::Release_3_0::Contributor role_name: "translator", number: 2, role: "B06", person_name: "prof. ks. Henryk von Hausswolff OP", from_language: "lat", titles_before_names: "prof. ks.", names_before_key: "Henryk", prefix_to_key: "von", key_names: "Hausswolff", names_after_key: "OP", biographical_note: nil, unnamed_persons: nil>]
-    #
-
+    assert_equal ["prof. ks. Henryk von Hausswolff OP"], product.translators
+  
     product = load_fixture("onix_no_contributors_example.xml")
     assert product.no_contributor?
     assert !product.unnamed_persons?
+    assert_equal [], product.authors
 
 
     product = load_fixture("onix_collective_work_example.xml")
     assert !product.no_contributor?
     assert product.unnamed_persons?
+    assert_equal ["praca zbiorowa"], product.authors
 
 
   end

data/test/elibri_edition_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse edition number" do
     product = load_fixture("onix_edition_example.xml")
     assert_equal "wyd. 3, poprawione", product.edition_statement
   end

data/test/elibri_extensions_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse elibri extensions" do
     product = load_fixture("onix_elibri_extensions_example.xml")
     
     assert_equal "miękka", product.cover_type

data/test/elibri_extent_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse extent attributes" do
     product = load_fixture("onix_ebook_extent_example.xml")
     assert_equal 150, product.number_of_pages
     assert_equal 12, product.number_of_illustrations

data/test/elibri_languages_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse languages info" do
     product = load_fixture("onix_languages_example.xml")
     assert_equal "polski", product.languages[0].language
     assert_equal "language_of_text", product.languages[0].role_name

data/test/elibri_publisher_info_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse publisher name" do
     product = load_fixture("onix_publisher_info_example.xml")
     assert_equal "G+J Gruner+Jahr Polska", product.publisher_name
     assert_equal "National Geographic", product.imprint_name

data/test/elibri_publishing_status_test.rb

@@ -8,6 +8,7 @@ describe Elibri::ONIX::Release_3_0::ONIXMessage do
     assert_equal "02", product.publishing_status
     assert_equal :announced, product.current_state
     assert_equal [2011], product.parsed_publishing_date
+    assert product.premiere.nil? #nieznana jest dokładna data premiery
     assert !product.sales_restrictions?
   end
 
@@ -17,6 +18,7 @@ describe Elibri::ONIX::Release_3_0::ONIXMessage do
     assert_equal "02", product.publishing_status
     assert_equal :preorder, product.current_state
     assert_equal [2011, 2, 10], product.parsed_publishing_date
+    assert_equal Date.new(2011, 2, 10), product.premiere
     assert !product.sales_restrictions?
   end
 
@@ -26,6 +28,7 @@ describe Elibri::ONIX::Release_3_0::ONIXMessage do
     assert_equal "04", product.publishing_status
     assert_equal :published, product.current_state
     assert_equal [2011, 2], product.parsed_publishing_date
+    assert product.premiere.nil?
     assert !product.sales_restrictions?
   end
 
@@ -35,6 +38,7 @@ describe Elibri::ONIX::Release_3_0::ONIXMessage do
     assert_equal "07", product.publishing_status
     assert_equal :out_of_print, product.current_state
     assert_equal [], product.parsed_publishing_date
+    assert product.premiere.nil?
     assert !product.sales_restrictions?
   end
 

data/test/elibri_record_identifiers_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse record identifiers" do
     product = load_fixture("onix_record_identifiers_example.xml")
     
     assert_equal "fdb8fa072be774d97a97", product.record_reference

data/test/elibri_sale_restrictions_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse information about sales restrictions" do
     product = load_fixture("onix_sale_restrictions_example.xml")
     assert product.sales_restrictions?
     assert_equal [2012, 7, 22], product.parsed_publishing_date #data po wygaśnięciu wyłączności empiku

data/test/elibri_series_memberships_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse series info" do
     product = load_fixture("onix_series_memberships_example.xml")
     assert_equal ["Lektury szkolne", "Dla Bystrzaków"], product.series_names
 

data/test/elibri_supporting_resources_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse attachment informations" do
     product = load_fixture("onix_supporting_resources_example.xml")
     
     assert_equal 2, product.supporting_resources.size

data/test/elibri_texts_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse texts" do
     product = load_fixture("onix_texts_example.xml")
 
     assert_equal 4, product.text_contents.size

data/test/elibri_titles_test.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 describe Elibri::ONIX::Release_3_0::ONIXMessage do
 
-  it "should be able to parse measurement attributes supported in Elibri" do
+  it "should be able to parse titles" do
     product = load_fixture("onix_titles_example.xml")
  
     assert_equal "Nothing to Envy: Ordinary Lives in North Korea", product.original_title

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: elibri_onix
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 11
   prerelease: 
   segments: 
   - 0
   - 1
-  - 7
-  version: 0.1.7
+  - 8
+  version: 0.1.8
 platform: ruby
 authors: 
 - Marcin Urbanski
@@ -15,12 +15,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-11-14 00:00:00 +01:00
+date: 2011-11-21 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  type: :runtime
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  name: activesupport
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -31,12 +31,12 @@ dependencies:
         - 3
         - 5
         version: 2.3.5
-  name: activesupport
-  version_requirements: *id001
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: *id001
+- !ruby/object:Gem::Dependency 
+  name: roxml
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -47,12 +47,12 @@ dependencies:
         - 1
         - 3
         version: 3.1.3
-  name: roxml
-  version_requirements: *id002
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: *id002
+- !ruby/object:Gem::Dependency 
+  name: i18n
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -61,28 +61,28 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: i18n
-  version_requirements: *id003
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: *id003
+- !ruby/object:Gem::Dependency 
+  name: elibri_onix_dict
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 23
+        hash: 21
         segments: 
         - 0
         - 0
-        - 4
-        version: 0.0.4
-  name: elibri_onix_dict
-  version_requirements: *id004
+        - 5
+        version: 0.0.5
   prerelease: false
+  type: :runtime
+  requirement: *id004
 - !ruby/object:Gem::Dependency 
-  type: :development
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  name: pry
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -91,12 +91,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: pry
-  version_requirements: *id005
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: *id005
+- !ruby/object:Gem::Dependency 
+  name: mocha
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -105,12 +105,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: mocha
-  version_requirements: *id006
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: *id006
+- !ruby/object:Gem::Dependency 
+  name: minitest
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -119,12 +119,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: minitest
-  version_requirements: *id007
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: *id007
+- !ruby/object:Gem::Dependency 
+  name: bundler
+  version_requirements: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -135,12 +135,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  name: bundler
-  version_requirements: *id008
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: *id008
+- !ruby/object:Gem::Dependency 
+  name: jeweler
+  version_requirements: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -151,12 +151,12 @@ dependencies:
         - 6
         - 2
         version: 1.6.2
-  name: jeweler
-  version_requirements: *id009
   prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  requirement: *id009
+- !ruby/object:Gem::Dependency 
+  name: rcov
+  version_requirements: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -165,9 +165,9 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: rcov
-  version_requirements: *id010
   prerelease: false
+  type: :development
+  requirement: *id010
 description: EDItEUR ONIX format subset implementation used in Elibri publication system
 email: marcin@urbanski.vdl.pl
 executables: []
@@ -290,7 +290,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: EDItEUR ONIX format subset implementation used in Elibri publication system