elemental_components 1.0.0.rc2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 188ba4f31148a5b63a6bedc1d45471216563c5b50137c575e1846a8a319807fc
-  data.tar.gz: 04a1af8dfe65532e07bdef3cbeb62c1e94faf6c7f9fabb4e940504215e80e3b1
+  metadata.gz: 140e8e6085779745ad5a7bfc3b61aab1f3b0754bd05b90f5c5890176f1fd9934
+  data.tar.gz: 6aeb44e4f571905edff448524738b73b39682907900dc0576dedb114931aa52e
 SHA512:
-  metadata.gz: abd7a702a6030f480b384100a684c8e7cf841c5fcda44314c3d55e75236991c5a20d5c0042721bf446a6fdb3244253322f12aa1a4cd8b52bdc99a0b1dee8bbb4
-  data.tar.gz: f30734ef9349f9baaa9f86b35dc6d865e0bbb64a4a380616db9ca5e9d47a7ace0ccf1aaee3c0943f4f9466be5524a7c48c98508c2680310a3a25937e58d73b6b
+  metadata.gz: 252b44e941c1b6bd10e38c1ef5b4fd217674819ccc818e071b7f32965a74a64aebe36b299997706fa60ed70c0198aa1626c813611133c89b5845dcf40299b4c6
+  data.tar.gz: 1f11fed00fae502454922d217dd9d5c4eff4f5f439744ea745ec855283d6bb1c0aca5b06892227285c1744989a06c53f4464035be4c080a7f5f24efe12f966fb

data/README.md

@@ -1,6 +1,6 @@
 # Elemental Components
 
-Simple view components for Rails 5.1+, designed to go well with [elemental_styleguide](https://github.com/jensljungblad/elemental_styleguide). The two together are inspired by the works of [Brad Frost](http://bradfrost.com) and by the [thoughts behind](http://engineering.lonelyplanet.com/2014/05/18/a-maintainable-styleguide.html) Lonely Planet's style guide [Rizzo](http://rizzo.lonelyplanet.com).
+Simple view components for Rails 7.2+, designed to go well with [elemental_styleguide](https://github.com/jensljungblad/elemental_styleguide). The two together are inspired by the works of [Brad Frost](http://bradfrost.com) and by the [thoughts behind](http://engineering.lonelyplanet.com/2014/05/18/a-maintainable-styleguide.html) Lonely Planet's style guide [Rizzo](http://rizzo.lonelyplanet.com).
 
 ## Installation
 
@@ -34,11 +34,10 @@ app/
     alert/
       _alert.html.erb
       alert.css
-      alert.js
     alert_component.rb
 ```
 
-The generator also takes `--skip-css` and `--skip-js` options.
+The generator also takes `--skip-css` and `--skip-erb` options.
 
 Let's add some markup and CSS:
 
@@ -78,7 +77,9 @@ This component can now be rendered using the `component` helper:
 
 ### Assets
 
-In order to require assets such as CSS, either require them manually in the manifest, e.g. `application.css`:
+The `app/components` directory is automatically added to `Rails.application.config.assets.paths` which means CSS assets can be referenced, regardless if you are using sprockets or propshaft.
+
+If using sprockets, require in i.e. `application.css`:
 
 ```css
 /*
@@ -86,12 +87,10 @@ In order to require assets such as CSS, either require them manually in the mani
  */
 ```
 
-Or require `components`, which will in turn require the assets for all components:
+If using propshaft, import in i.e. `application.css`:
 
 ```css
-/*
- *= require elemental_components
- */
+@import url("alert/alert");
 ```
 
 ### Attributes and content blocks
@@ -316,7 +315,7 @@ Another good use case is a navigation component:
 # app/components/navigation_component.rb %>
 
 class NavigationComponent < ElementalComponents::Component
-  element :items, multiple: true do
+  element :item, multiple: true do
     attribute :label
     attribute :url
     attribute :active, default: false
@@ -331,12 +330,6 @@ end
 <% end %>
 ```
 
-An alternative here is to pass a data structure to the component as an attribute, if no HTML needs to be injected when rendering the component:
-
-```erb
-<%= component "navigation", items: items %>
-```
-
 Elements can have validations, too:
 
 ```ruby

data/app/helpers/elemental_components/component_helper.rb

@@ -2,8 +2,8 @@
 
 module ElementalComponents
   module ComponentHelper
-    def component(name, attrs = nil, &block)
-      "#{name}_component".classify.constantize.new(self, attrs, &block).render
+    def component(name, attrs = nil, &)
+      "#{name}_component".classify.constantize.new(self, attrs, &).render
     end
   end
 end

data/config/routes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 
 ElementalComponents::Engine.routes.draw do
+  # No routes defined
 end

data/lib/elemental_components/element.rb

@@ -58,20 +58,20 @@ module ElementalComponents
     # rubocop:enable Metrics/MethodLength
     # rubocop:enable Metrics/PerceivedComplexity
 
-    def self.define_method_or_raise(method_name, &block)
+    def self.define_method_or_raise(method_name, &)
       if method_defined?(method_name.to_sym)
         raise(ElementalComponents::Error, "Method '#{method_name}' already exists.")
       end
 
-      define_method(method_name, &block)
+      define_method(method_name, &)
     end
     private_class_method :define_method_or_raise
 
-    def initialize(view, attributes = nil, &block)
+    def initialize(view, attributes = nil, &)
       @view = view
       initialize_attributes(attributes || {})
       initialize_elements
-      @yield = block_given? ? @view.capture(self, &block) : nil
+      @yield = block_given? ? @view.capture(self, &) : nil
       validate!
     end
 
@@ -87,10 +87,16 @@ module ElementalComponents
 
     def initialize_attributes(attributes)
       self.class.attributes.each do |name, options|
-        set_instance_variable(name, attributes[name] || (options[:default] && options[:default].dup))
+        set_instance_variable(name, attribute_value(attributes, name, options[:default]))
       end
     end
 
+    def attribute_value(attributes, name, default)
+      return attributes[name] if attributes.key?(name)
+
+      default.dup
+    end
+
     def initialize_elements
       self.class.elements.each do |name, options|
         if (plural_name = options[:multiple])

data/lib/elemental_components/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ElementalComponents
-  VERSION = "1.0.0.rc2"
+  VERSION = "1.0.0"
 end

data/lib/generators/elemental_components/component_generator.rb

@@ -5,7 +5,6 @@ module ElementalComponents
     desc "Generate a component"
     class_option :skip_erb, type: :boolean, default: false
     class_option :skip_css, type: :boolean, default: false
-    class_option :skip_js, type: :boolean, default: false
 
     source_root File.expand_path("templates", __dir__)
 
@@ -25,12 +24,6 @@ module ElementalComponents
       create_file "app/components/#{name}/#{filename}.css"
     end
 
-    def create_js_file
-      return if options["skip_js"]
-
-      create_file "app/components/#{name}/#{filename}.js"
-    end
-
     private
 
     def filename

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: elemental_components
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc2
+  version: 1.0.0
 platform: ruby
 authors:
 - Jens Ljungblad
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-27 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,57 +15,15 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.0
+        version: 7.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.0
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.0
-description: Simple view components for Rails 5.1+
+        version: 7.2.0
+description: Simple view components for Rails 7.2+
 email:
 - jens.ljungblad@gmail.com
 executables: []
@@ -76,9 +33,6 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
-- app/assets/config/elemental_components_manifest.js
-- app/assets/javascripts/elemental_components.js.erb
-- app/assets/stylesheets/elemental_components.css.erb
 - app/helpers/elemental_components/component_helper.rb
 - config/routes.rb
 - lib/elemental_components.rb
@@ -93,8 +47,8 @@ files:
 homepage: https://www.github.com/jensljungblad/elemental_components
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -102,16 +56,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.7.2
 specification_version: 4
-summary: Simple view components for Rails 5.1+
+summary: Simple view components for Rails 7.2+
 test_files: []

data/app/assets/config/elemental_components_manifest.js

@@ -1,2 +0,0 @@
-//= link_directory ../javascripts/elemental_components .js
-//= link_directory ../stylesheets/elemental_components .css

data/app/assets/javascripts/elemental_components.js.erb

@@ -1,7 +0,0 @@
-<% ElementalComponents.component_names.each do |name| %>
-  <% begin %>
-    <% require_asset "#{name}/#{name.split('/')[-1]}" %>
-  <% rescue Sprockets::FileNotFound %>
-    <% Rails.logger.debug "ElementalComponents: JS not found for #{name}" %>
-  <% end %>
-<% end %>

data/app/assets/stylesheets/elemental_components.css.erb

@@ -1,7 +0,0 @@
-<% ElementalComponents.component_names.each do |name| %>
-  <% begin %>
-    <% require_asset "#{name}/#{name.split('/')[-1]}" %>
-  <% rescue Sprockets::FileNotFound %>
-    <% Rails.logger.debug "ElementalComponents: CSS not found for #{name}" %>
-  <% end %>
-<% end %>