electric_slide 0.4.2 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 738ba12a4f2d6f7e957a126897abe3cf360f00f4
-  data.tar.gz: 8fc8b4d809fd3ec91b06e98b253d379528bf496f
+  metadata.gz: 49101ac1f213829f41caab6990cf3183d533f3e1
+  data.tar.gz: 796e9cd5bbee24fcda95e58022cf1f83f8c4f2f0
 SHA512:
-  metadata.gz: 1b0649085afa609d2c7f42b0029ac2967e61c2959e0d2e4d64df13e97748b20d192b729cff419c924fd8891820a93229e87c2a279d76e793338e1cca96bb57f3
-  data.tar.gz: 82eb164c033578acc2367ae0f9ae9a2c6f8e7ba0db7483f9cf4f70a732d1f40acbc2301e0b33328c4c049c28b512ae98fe1ebaddde2736775afeeb5010d1b8fe
+  metadata.gz: 65de89ec11a21d769a14c50c0a359407b2805b096bf87ca35637502030cbc9bbdc0e3199345ecb52cdea49168d652d0ba19559f02e1edcb379789d9e8f032c3f
+  data.tar.gz: 9ba4811599997c2831762642cd0e9b49dc98f9606054ef1de8f00448e9c4fe7dc680b0e173aa2ec3cf284bc245ba16c2b67c7d78474e52055c00cbd08503da3d

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # [develop](https://github.com/adhearsion/electric_slide)
 
+# [0.5.0](https://github.com/adhearsion/electric_slide/compare/v0.4.2...v0.5.0) - [2016-02-12](https://rubygems.org/gems/adhearsion/versions/0.5.0)
+  * API Breakage: Fixed priority strategy now ensures that the same agent cannot be in multiple priorities
+
 # [0.4.2](https://github.com/adhearsion/electric_slide/compare/v0.4.1...v0.4.2) - [2016-02-04](https://rubygems.org/gems/adhearsion/versions/0.4.2)
   * Bugfix: FixedPriority now correctly checks out agents in priority order.
 

data/lib/electric_slide/agent_strategy/fixed_priority.rb

@@ -37,11 +37,15 @@ class ElectricSlide
       end
 
       def <<(agent)
-        # TODO: How aggressively do we check for agents duplicated in multiple priorities?
         raise ArgumentError, "Agents must have a specified priority" unless agent.respond_to?(:priority)
+
         priority = agent.priority || 999999
         @priorities[priority] ||= []
-        @priorities[priority] << agent unless @priorities[priority].include? agent
+
+        unless @priorities[priority].include?(agent)
+          delete(agent)
+          @priorities[priority] << agent
+        end
       end
 
       def delete(agent)

data/lib/electric_slide/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 class ElectricSlide
-  VERSION = '0.4.2'
+  VERSION = '0.5.0'
 end

data/spec/electric_slide/agent_strategy/fixed_priority_spec.rb

@@ -39,4 +39,25 @@ describe ElectricSlide::AgentStrategy::FixedPriority do
     subject.checkout_agent
     expect(subject.agent_available?).to be true
   end
+
+  context 'when agents at different priorities are available' do
+    let(:agent1) { agent1 = OpenStruct.new(id: 101, priority: 1) }
+    let(:agent2) { agent1 = OpenStruct.new(id: 102, priority: 2) }
+
+    before do
+      subject << agent1
+      subject << agent2
+    end
+
+    describe 'and the higher priority agent is added again, but at the lowest priority' do
+      before do
+        agent1.priority = 3
+        subject << agent1
+      end
+
+      it 'moves the agent to the new, lower priority' do
+        expect(subject.checkout_agent).to eq(agent2)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: electric_slide
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
 platform: ruby
 authors:
 - Ben Klang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-04 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adhearsion