electric_slide 0.0.2 → 0.2.0

data/spec/electric_slide_spec.rb

@@ -1 +1,41 @@
 require 'spec_helper'
+
+describe ElectricSlide do
+  context "creating a queue" do
+    after :each do
+      ElectricSlide.shutdown_queue :fake
+    end
+
+    let(:queue_class) { double :fake_queue_class }
+    let(:queue_inst)  { double :fake_queue_instance }
+
+    it "should default to an ElectricSlide::CallQueue if one is not specified" do
+      ElectricSlide.create :fake
+      expect { ElectricSlide.get_queue :fake }.to_not raise_error
+    end
+
+    it "should start the queue upon registration" do
+      expect(queue_class).to receive(:work).once.and_return queue_inst
+      expect(queue_inst).to receive(:terminate).once
+      ElectricSlide.create :fake, queue_class
+    end
+
+    it "should preserve additional queue arguments" do
+      queue = double(:fake_queue)
+      expect(queue_class).to receive(:work).with(:foo, :bar, :baz).once.and_return queue_inst
+      expect(queue_inst).to receive(:terminate).once
+      ElectricSlide.create :fake, queue_class, :foo, :bar, :baz
+    end
+
+    it "should not allow a second queue to be created with the same name" do
+      ElectricSlide.create :fake
+      expect { ElectricSlide.create :fake }.to raise_error
+    end
+  end
+
+  it "should raise if attempting to work with a queue that doesn't exist" do
+    expect { ElectricSlide.get_queue!("does not exist!") }.to raise_error
+    expect { ElectricSlide.shutdown_queue("does not exist!") }.to raise_error
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,25 +1,18 @@
 $:.push File.join(File.dirname(__FILE__), '..', 'lib')
 Thread.abort_on_exception = true
 
-%w{
+%w(
   adhearsion
   electric_slide
-  electric_slide/queued_call
-  electric_slide/queue_strategy
-  electric_slide/round_robin
   rspec/core
-  flexmock
-  flexmock/rspec
-}.each { |r| require r }
+).each { |r| require r }
 
 RSpec.configure do |config|
-  config.mock_framework = :flexmock
-  config.filter_run :focus => true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
-  config.color_enabled = true
 end
 
 def dummy_call
-  Object.new
+  Adhearsion::Call.new
 end
 

metadata

@@ -1,125 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: electric_slide
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Ben Klang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-10 00:00:00.000000000 Z
+date: 2015-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adhearsion
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: countdownlatch
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.5.0
 - !ruby/object:Gem::Dependency
-  name: flexmock
+  name: ci_reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: ci_reporter
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Automatic Call Distributor (ACD) for Adhearsion. Currently implements
@@ -129,21 +143,25 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".rspec"
 - Gemfile
+- Guardfile
 - LICENSE
 - README.markdown
 - Rakefile
 - config/ahn_acd.yml
 - electric_slide.gemspec
 - lib/electric_slide.rb
-- lib/electric_slide/queue_strategy.rb
-- lib/electric_slide/queued_call.rb
-- lib/electric_slide/round_robin.rb
-- lib/electric_slide/round_robin_meetme.rb
-- spec/electric_slide/queue_strategy_spec.rb
-- spec/electric_slide/queued_call_spec.rb
-- spec/electric_slide/round_robin_spec.rb
+- lib/electric_slide/agent.rb
+- lib/electric_slide/agent_strategy/fixed_priority.rb
+- lib/electric_slide/agent_strategy/longest_idle.rb
+- lib/electric_slide/call_queue.rb
+- lib/electric_slide/plugin.rb
+- lib/electric_slide/version.rb
+- spec/electric_slide/agent_spec.rb
+- spec/electric_slide/agent_strategy/fixed_priority_spec.rb
+- spec/electric_slide/call_queue_spec.rb
 - spec/electric_slide_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/adhearsion/electric_slide
@@ -155,19 +173,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 2
 summary: Automatic Call Distributor for Adhearsion
 test_files: []
-has_rdoc: true

data/lib/electric_slide/queue_strategy.rb

@@ -1,18 +0,0 @@
-class ElectricSlide
-  module QueueStrategy
-    def wrap_call(call)
-      call = QueuedCall.new(call) unless call.respond_to?(:queued_time)
-      call
-    end
-
-    def priority_enqueue(call)
-      # TODO: Add this call to the front of the line
-      enqueue call
-    end
-
-    def enqueue(call)
-      call.hold
-    end
-  end
-end
-

data/lib/electric_slide/queued_call.rb

@@ -1,24 +0,0 @@
-require 'countdownlatch'
-
-class ElectricSlide
-  class QueuedCall
-    attr_accessor :call, :queued_time
-
-    def initialize(call)
-      @call = call
-      @queued_time = Time.now
-    end
-
-    def hold
-      call.execute 'StartMusicOnHold'
-      @latch = CountDownLatch.new 1
-      @latch.wait
-      call.execute 'StopMusicOnHold'
-    end
-
-    def make_ready!
-      @latch.countdown!
-    end
-  end
-end
-

data/lib/electric_slide/round_robin.rb

@@ -1,46 +0,0 @@
-require 'thread'
-require 'electric_slide/queue_strategy'
-
-class ElectricSlide
-  class RoundRobin
-    include QueueStrategy
-    attr_reader :queue
-
-    def initialize
-      @queue = []
-      @agents_waiting = []
-      @conditional = ConditionVariable.new
-    end
-
-    def next_call
-      call = nil
-      synchronize do
-        @agents_waiting << Thread.current
-        @conditional.wait(@mutex) if @queue.length == 0
-        @agents_waiting.delete Thread.current
-        call = @queue.shift
-      end
-
-      call.make_ready!
-      call
-    end
-
-    def agents_waiting
-      synchronize do
-        @agents_waiting.dup
-      end
-    end
-
-    # TODO: Add mechanism to add calls with higher priority to the front of the queue.
-
-    def enqueue(call)
-      call = wrap_call(call)
-      synchronize do
-        @queue << call
-        @conditional.signal if @queue.length == 1
-      end
-      super
-    end
-  end
-end
-

data/lib/electric_slide/round_robin_meetme.rb

@@ -1,34 +0,0 @@
-class ElectricSlide
-  class RoundRobinMeetme
-    include QueueStrategy
-
-    def initialize(call)
-      @queue = []
-    end
-
-    def next_call
-      call = synchronize do
-        @queue.pop
-      end
-
-      call.make_ready!
-      call
-    end
-
-    def priority_enqueue(call)
-      call = wrap_call(call)
-
-      synchronize do
-        @queue.unshift call
-      end
-      super
-    end
-
-    def enqueue(call)
-      synchronize do
-        @queue << call
-      end
-    end
-  end
-end
-

data/spec/electric_slide/queue_strategy_spec.rb

@@ -1,16 +0,0 @@
-require 'spec_helper'
-
-describe ElectricSlide::QueueStrategy do
-  include ElectricSlide::QueueStrategy
-
-  describe '#wrap_call' do
-    it 'should pass through a QueuedCall object' do
-      obj = ElectricSlide::QueuedCall.new dummy_call
-      wrap_call(obj).should be obj
-    end
-
-    it 'should wrap any object that does not respond to #queued_time' do
-      wrap_call(dummy_call).should be_a ElectricSlide::QueuedCall
-    end
-  end
-end

data/spec/electric_slide/queued_call_spec.rb

@@ -1,42 +0,0 @@
-require 'spec_helper'
-
-describe ElectricSlide::QueuedCall do
-  it 'should initialize the queued_time to the current time' do
-    now = Time.now
-    flexmock(Time).should_receive(:now).once.and_return now
-    qcall = ElectricSlide::QueuedCall.new dummy_call
-    qcall.instance_variable_get(:@queued_time).should == now
-  end
-
-  it 'should start and stop music on hold when put on hold and released' do
-    # Both tests are combined here so we do not leave too many suspended threads lying about
-    queued_caller = dummy_call
-    flexmock(queued_caller).should_receive(:execute).once.with('StartMusicOnHold')
-    flexmock(queued_caller).should_receive(:execute).once.with('StopMusicOnHold')
-    qcall = ElectricSlide::QueuedCall.new queued_caller
-
-    # Place the call on hold and wait for it to enqueue
-    Thread.new { qcall.hold }
-    sleep 0.5
-
-    # Release the call from being on hold and sleep to ensure we get the Stop MOH signal
-    qcall.make_ready!
-    sleep 0.5
-  end
-
-  it 'should block the call when put on hold' do
-    queued_caller = dummy_call
-    flexmock(queued_caller).should_receive(:execute).once.with('StartMusicOnHold')
-    flexmock(queued_caller).should_receive(:execute).once.with('StopMusicOnHold')
-    qcall = ElectricSlide::QueuedCall.new queued_caller
-
-    hold_thread = Thread.new { qcall.hold }
-
-    # Give the holding thread a chance to block...
-    sleep 0.5
-    hold_thread.status.should == "sleep"
-    qcall.make_ready!
-    sleep 0.5
-    hold_thread.status.should be false
-  end
-end