elastomer-client 3.2.3 → 6.2.1

data/docs/README.md

@@ -1,6 +1,6 @@
-# Elastomer Client in Depth
+# ElastomerClient in Depth
 
-We first started building the Elastomer Client gem when an
+We first started building the ElastomerClient gem when an
 [official client](https://github.com/elasticsearch/elasticsearch-ruby)
 was not yet available from Elasticsearch. We were looking for a client that
 provided a one-to-one mapping of the Elasticsearch APIs and avoided higher level
@@ -16,10 +16,10 @@ To that end we have tried to be as faithful as possible to the Elasticsearch API
 with our implementation. There are a few places where it made sense to wrap the
 Elasticsearch API inside Ruby idioms. One notable location is the
 [scan-scroll](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-scroll.html)
-search type; the Elastomer Client provides a Ruby iterator to work with these
+search type; the ElastomerClient provides a Ruby iterator to work with these
 types of queries.
 
-Below are links to documents describing the various components of the Elastomer
+Below are links to documents describing the various components of the ElastomerClient
 Client library. Start with the core components - specifically the **Client**
 document. All the other components are built atop the client.
 
@@ -30,7 +30,6 @@ document. All the other components are built atop the client.
 * [Documents](docs.md)
 * [Cluster](cluster.md)
 * [Templates](templates.md)
-* [Warmers](warmers.md)
 
 **Bulk Components**
 

data/docs/bulk_indexing.md

@@ -1,3 +1,3 @@
-# Elastomer Bulk Indexing Component
+# ElastomerClient Bulk Indexing Component
 
 ![constructocat](https://octodex.github.com/images/constructocat2.jpg)

data/docs/client.md

@@ -1,10 +1,10 @@
-# Elastomer Client Component
+# ElastomerClient Client Component
 
-All methods in the Elastomer Client gem eventually make an HTTP request to
-Elasticsearch. The [`Elastomer::Client`](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client.rb)
+All methods in the ElastomerClient gem eventually make an HTTP request to
+Elasticsearch. The [`ElastomerClient::Client`](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client.rb)
 class is responsible for connecting to an Elasticsearch instance, making HTTP
 requests, processing the response, and handling errors. Let's look at the
-details of how `Elastomer::Client` handles HTTP communication.
+details of how `ElastomerClient::Client` handles HTTP communication.
 
 ### Connecting
 
@@ -15,36 +15,23 @@ the concept of *middlewares* that operate on the HTTP request and response. We
 use Faraday middleware to encode and decode JSON messages exchanged with
 Elasticsearch.
 
-Without any options the `Elastomer::Client` will connect to the default
+Without any options the `ElastomerClient::Client` will connect to the default
 Elasticsearch URL `http://localhost:9200`. The `Net:HTTP` client from the Ruby
 standard library will be used.
 
 ```ruby
-client = Elastomer::Client.new
+client = ElastomerClient::Client.new
 client.host  #=> 'localhost'
 client.port  #=> 9200
 client.url   #=> 'http://localhost:9200'
 ```
 
-[Boxen](https://boxen.github.com) configures Elasticsearch to listen on port
-`19200` instead of the standard port. We can provide either the full URL or just
-a different port number if Elasticsearch is running on `localhost`.
-
-```ruby
-client = Elastomer::Client.new :port => 19200
-client.host  #=> 'localhost'
-client.port  #=> 19200
-client.url   #=> 'http://localhost:19200'
-
-client = Elastomer::Client.new :url => "http://localhost:19200"
-```
-
 Elasticsearch works best with persistent connections. We can use the
 `Net::HTTP::Persistent` adapter with Faraday.
 
 ```ruby
-client = Elastomer::Client.new \
-  :port    => 19200,
+client = ElastomerClient::Client.new \
+  :port    => 9200,
   :adapter => :net_http_persistent
 ```
 
@@ -58,8 +45,8 @@ The open timeout is configured once when the client is first created. The read
 timeout can be set for each request.
 
 ```ruby
-client = Elastomer::Client.new \
-  :url          => "http://localhost:19200",
+client = ElastomerClient::Client.new \
+  :url          => "http://localhost:9200",
   :adapter      => :net_http_persistent,
   :open_timeout => 1,
   :read_timeout => 5
@@ -77,14 +64,14 @@ Elasticsearch provides an `X-Opaque-Id` request header. Any value set in this
 request header will be returned in the corresponding response header. This
 allows the client to correlate the response from Elasticsearch with the request
 that was submitted. We have written an
-[OpaqueId](https://github.com/github/elastomer-client/blob/master/lib/elastomer/middleware/opaque_id.rb)
+[OpaqueId](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/middleware/opaque_id.rb)
 middleware that will abort any request if the `X-Opaque-Id` headers disagree
 between the request and the response. You can use this feature by setting
 the `:opaque_id` flag.
 
 ```ruby
-client = Elastomer::Client.new \
-  :url       => "http://localhost:19200",
+client = ElastomerClient::Client.new \
+  :url       => "http://localhost:9200",
   :adapter   => :net_http_persistent,
   :opaque_id => true
 ```
@@ -95,7 +82,7 @@ If you are not using persistent connections, then you do not need to worry about
 ### HTTP Methods
 
 The standard HTTP verbs - `head`, `get`, `put`, `post`, `delete` - are exposed
-as methods on the `Elastomer::Client` class. Each method accepts a path and a
+as methods on the `ElastomerClient::Client` class. Each method accepts a path and a
 Hash of parameters. Some parameters are applied as path expansions, some are
 reserved, and the remainder are used as URL parameters. We'll look at the
 reserved parameters first.
@@ -140,11 +127,11 @@ Elasticsearch has responded.
 
 **:action** and **:context**
 
-Each method in the Elastomer client gem has its own `:action` value that is
+Each method in the ElastomerClient gem has its own `:action` value that is
 used in conjunction with the [notifications](notifications.md) layer. The
 `:action` parameter cannot be changed by the user. Instead you can provide a
 `:context` value to each method call. This will be passed unchanged to the
-notifications layer, and it is useful for tracking where an Elastomer client
+notifications layer, and it is useful for tracking where an ElastomerClient
 method is called from within your application.
 
 #### URL Handling
@@ -157,7 +144,7 @@ With the [`Addressable::Template`](https://github.com/sporkmonger/addressable#ur
 a typical search URL takes the form `{/index}{/type}/_search`. The `:index` and
 `:type` values are taken from the parameters Hash and combined with the template
 to generate the URL. The internal
-[`expand_path`](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client.rb#L245)
+[`expand_path`](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client.rb#L245)
 method handles the URL generation.
 
 Here are a few examples to better illustrate the concept.
@@ -212,17 +199,17 @@ client.expand_path("/{index}/{type}/_search", {
 ```
 
 And that is the basic concept of the `expand_path` method. The URL template
-pattern is used extensively in the Elastomer client code, so it is definitely
+pattern is used extensively in the ElastomerClient code, so it is definitely
 worth knowing about.
 
 ### Errors
 
 Invariably things will go wrong where computers and networks are involved. The
-Elastomer client code makes no attempt to retry an operation in the face of an
+ElastomerClient code makes no attempt to retry an operation in the face of an
 error. However, it does classify errors into *fatal* and *retryable* exceptions.
 
 Each class that inherits from
-[`Elastomer::Client::Error`](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client/errors.rb)
+[`ElastomerClient::Client::Error`](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client/errors.rb)
 has a `fatal?` method (and the inverse `retry?` method). If an exception is
 fatal, then the request is fundamentally flawed and should not be retried.
 Passing a malformed search query or trying to search an index that does not

data/docs/cluster.md

@@ -1,17 +1,17 @@
-# Elastomer Cluster Component
+# ElastomerClient Cluster Component
 
 The cluster component deals with commands for managing cluster state and
 monitoring cluster health. All the commands found under the
 [cluster API](https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster.html)
 section of the Elasticsearch documentation are implemented by the
-[`cluster.rb`](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client/cluster.rb)
-module and the [`nodes.rb`](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client/nodes.rb)
+[`cluster.rb`](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client/cluster.rb)
+module and the [`nodes.rb`](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client/nodes.rb)
 module.
 
 ## Cluster
 
 API endpoints dealing with cluster level information and settings are found in
-the [`Cluster`](lib/elastomer/client/cluster.rb) class. Each of these methods
+the [`Cluster`](lib/elastomer_client/client/cluster.rb) class. Each of these methods
 corresponds to an API endpoint described in the Elasticsearch documentation
 (linked to above). The params listed in the documentation can be passed to these
 methods, so we do not take too much trouble to enumerate them all.
@@ -22,8 +22,8 @@ The cluster [health API](https://www.elastic.co/guide/en/elasticsearch/reference
 returns a very simple cluster health status report.
 
 ```ruby
-require 'elastomer/client'
-client = Elastomer::Client.new :port => 19200
+require 'elastomer_client/client'
+client = ElastomerClient::Client.new :port => 9200
 
 # the current health summary
 client.cluster.health
@@ -125,8 +125,8 @@ individual (or multiple) nodes in the cluster. We expose these via the `nodes`
 module in elastomer-client.
 
 ```ruby
-require 'elastomer/client'
-client = Elastomer::Client.new :port => 19200
+require 'elastomer_client/client'
+client = ElastomerClient::Client.new :port => 9200
 
 # gather OS, JVM, and process information from the local node
 client.nodes("_local").info(:info => %w[os jvm process])

data/docs/docs.md

@@ -1,4 +1,4 @@
-# Elastomer Documents Component
+# ElastomerClient Documents Component
 
 The documents components handles all API calls related to
 [indexing documents](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs.html)
@@ -11,8 +11,8 @@ that is the only difference between the two. In the example below, the resulting
 documents components are equivalent.
 
 ```ruby
-require 'elastomer/client'
-client = Elastomer::Client.new :port => 19200
+require 'elastomer_client/client'
+client = ElastomerClient::Client.new :port => 9200
 
 docs1 = client.index("blog").docs("post")
 docs2 = client.docs("blog", "post")
@@ -94,7 +94,7 @@ locations enables you to reconcile documents between the two.
 The `:_id` field is only one of several special fields that control document
 indexing in Elasticsearch. The full list of supported fields are enumerated in
 the `index`
-[method documentation](https://github.com/github/elastomer-client/blob/master/lib/elastomer/client/docs.rb#L45-56).
+[method documentation](https://github.com/github/elastomer-client/blob/main/lib/elastomer_client/client/docs.rb#L45-56).
 
 As a parting note, you can also provide the index name and document type as part
 of the document itself. These fields will be extracted from the document before
@@ -163,7 +163,7 @@ client.docs.search \
 The `search` method returns the query response from Elasticsearch as a ruby
 Hash. All the keys are represented as Strings. The [hashie](https://github.com/intridea/hashie)
 project has some useful transforms and wrappers for working with these result
-sets, but that is left to the user to implement if they so desire. Elastomer
+sets, but that is left to the user to implement if they so desire. ElastomerClient
 client returns only ruby Hashes.
 
 Searches can be executed against multiple indices and multiple types. Again,

data/docs/index.md

@@ -1,9 +1,9 @@
-# Elastomer Index Component
+# ElastomerClient Index Component
 
 The index component provides access to the
 [indices API](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices.html)
 used for index management, settings, mappings, and aliases. Index
-[warmers](warmers.md) and [templates](templates.md) are handled via their own
+[templates](templates.md) are handled via their own
 components. Methods for adding documents to the index and searching those
 documents are found in the [documents](documents.md) component. The index
 component deals solely with management of the indices themselves.
@@ -14,8 +14,8 @@ However, you can omit the index name and pass it along with each API method
 called.
 
 ```ruby
-require 'elastomer/client'
-client = Elastomer::Client.new :port => 19200
+require 'elastomer_client/client'
+client = ElastomerClient::Client.new :port => 9200
 
 # you can provide an index name
 index = client.index "blog"

data/docs/multi_search.md

@@ -1,3 +1,3 @@
-# Elastomer Multi-Search Component
+# ElastomerClient Multi-Search Component
 
 ![constructocat](https://octodex.github.com/images/constructocat2.jpg)

data/docs/notifications.md

@@ -1,7 +1,7 @@
 # Notifications Support
 
-Requiring `elastomer/notifications` enables support for broadcasting
-elastomer events through ActiveSupport::Notifications.
+Requiring `elastomer_client/notifications` enables support for broadcasting
+ElastomerClient events through ActiveSupport::Notifications.
 
 The event namespace is `request.client.elastomer`.
 
@@ -14,7 +14,7 @@ The event namespace is `request.client.elastomer`.
   :action  => "docs.search",
   :context => nil,
   :body    => "{\"query\":{\"match_all\":{}}}",
-  :url     => #<URI::HTTP:0x007fb6f3e98b60 URL:http://localhost:19200/index-test/_search?size=0>,
+  :url     => #<URI::HTTP:0x007fb6f3e98b60 URL:http://localhost:9200/index-test/_search?size=0>,
   :method  => :get,
   :status  => 200
 }

data/docs/scan_scroll.md

@@ -1,3 +1,3 @@
-# Elastomer Scan/Scroll Component
+# ElastomerClient Scan/Scroll Component
 
 ![constructocat](https://octodex.github.com/images/constructocat2.jpg)

data/docs/snapshots.md

@@ -1,3 +1,3 @@
-# Elastomer Snapshot Component
+# ElastomerClient Snapshot Component
 
 ![constructocat](https://octodex.github.com/images/constructocat2.jpg)

data/docs/templates.md

@@ -1,3 +1,3 @@
-# Elastomer Templates Component
+# ElastomerClient Templates Component
 
 ![constructocat](https://octodex.github.com/images/constructocat2.jpg)

data/elastomer-client.gemspec

@@ -1,15 +1,17 @@
 # coding: utf-8
+# frozen_string_literal: true
+
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "elastomer/version"
+require "elastomer_client/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "elastomer-client"
-  spec.version       = Elastomer::VERSION
+  spec.version       = ElastomerClient::VERSION
   spec.authors       = ["Tim Pease", "Grant Rodgers"]
   spec.email         = ["tim.pease@github.com", "grant.rodgers@github.com"]
   spec.summary       = %q{A library for interacting with Elasticsearch}
-  spec.description   = %q{Elastomer is a low level API client for the
+  spec.description   = %q{ElastomerClient is a low level API client for the
                           Elasticsearch HTTP interface.}
   spec.homepage      = "https://github.com/github/elastomer-client"
   spec.license       = "MIT"
@@ -20,19 +22,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "addressable", "~> 2.5"
-  spec.add_dependency "faraday",     "~> 0.8"
-  spec.add_dependency "faraday_middleware", "~> 0.12"
+  spec.add_dependency "faraday",     ">= 0.17"
+  spec.add_dependency "faraday_middleware", ">= 0.14"
   spec.add_dependency "multi_json",  "~> 1.12"
   spec.add_dependency "semantic",    "~> 1.6"
-
-  spec.add_development_dependency "bundler",            "~> 2.0"
-  spec.add_development_dependency "activesupport",      ">= 3.0"
-  spec.add_development_dependency "minitest",           "~> 5.10"
-  spec.add_development_dependency "minitest-fail-fast", "~> 0.1.0"
-  spec.add_development_dependency "minitest-focus",     "~> 1.1", ">= 1.1.2"
-  spec.add_development_dependency "webmock",            "~> 3.5"
-  spec.add_development_dependency "awesome_print",      "~> 1.8"
-  spec.add_development_dependency "pry-byebug",         "~> 3.4"
-  spec.add_development_dependency "spy",                "~> 1.0"
-  spec.add_development_dependency "rake"
 end

data/lib/{elastomer → elastomer_client}/client/bulk.rb

@@ -1,4 +1,6 @@
-module Elastomer
+# frozen_string_literal: true
+
+module ElastomerClient
   class Client
 
     # The `bulk` method can be used in two ways. Without a block the method
@@ -28,7 +30,7 @@ module Elastomer
     #   end
     #
     # Returns the response body as a Hash
-    def bulk( body = nil, params = nil )
+    def bulk(body = nil, params = nil)
       if block_given?
         params, body = (body || {}), nil
         yield bulk_obj = Bulk.new(self, params)
@@ -37,8 +39,10 @@ module Elastomer
       else
         raise "bulk request body cannot be nil" if body.nil?
         params ||= {}
+        updated_params = params.merge(body:, action: "bulk", rest_api: "bulk")
+        updated_params.delete(:type) if version_support.es_version_8_plus?
 
-        response = self.post "{/index}{/type}/_bulk", params.merge(body: body, action: "bulk", rest_api: "bulk")
+        response = self.post "{/index}{/type}/_bulk", updated_params
         response.body
       end
     end
@@ -103,7 +107,7 @@ module Elastomer
     #   #   "failure" => 0
     #   # }
     #
-    #   # sample response item:
+    #   # sample response item for ES5:
     #   # {
     #   #   "delete": {
     #   #     "_index": "foo",
@@ -115,6 +119,17 @@ module Elastomer
     #   #   }
     #   # }
     #
+    #   # sample response item for ES8:
+    #   # {
+    #   #   "delete": {
+    #   #     "_index": "foo",
+    #   #     "_id": "42",
+    #   #     "_version": 3,
+    #   #     "status": 200,
+    #   #     "result": "deleted"
+    #   #   }
+    #   # }
+    #
     # Returns a Hash of stats about items from the responses.
     def bulk_stream_items(ops, params = {})
       stats = {
@@ -158,17 +173,17 @@ module Elastomer
     # immediately.
     #
     class Bulk
-      DEFAULT_REQUEST_SIZE = 10 * 2**20  # 10 MB
+      DEFAULT_REQUEST_SIZE = 2**20 * 10  # 10 MB
 
       # Create a new bulk client for handling some of the details of
       # accumulating documents to index and then formatting them properly for
       # the bulk API command.
       #
-      # client - Elastomer::Client used for HTTP requests to the server
+      # client - ElastomerClient::Client used for HTTP requests to the server
       # params - Parameters Hash to pass to the Client#bulk method
       #   :request_size - the maximum request size in bytes
       #   :action_count - the maximum number of actions
-      def initialize( client, params = {} )
+      def initialize(client, params = {})
         @client  = client
         @params  = params
 
@@ -190,7 +205,7 @@ module Elastomer
       # buffered until the request size is met or exceeded. When this happens a
       # bulk request is issued, queued actions are cleared, and the response
       # from Elasticsearch is returned.
-      def request_size=( value )
+      def request_size=(value)
         if value.nil?
           @request_size = nil
         else
@@ -232,9 +247,9 @@ module Elastomer
       #   index("foo" => "bar", "_id" => 1, "_type" => "foo")
       #
       # Returns the response from the bulk call if one was made or nil.
-      def index( document, params = {} )
+      def index(document, params = {})
         params = prepare_params(document, params)
-        add_to_actions({:index => params}, document)
+        add_to_actions({index: params}, document)
       end
 
       # Add a create action to the list of bulk actions to be performed when
@@ -251,9 +266,9 @@ module Elastomer
       #   create("foo" => "bar", "_id" => 1)
       #
       # Returns the response from the bulk call if one was made or nil.
-      def create( document, params )
+      def create(document, params)
         params = prepare_params(document, params)
-        add_to_actions({:create => params}, document)
+        add_to_actions({create: params}, document)
       end
 
       # Add an update action to the list of bulk actions to be performed when
@@ -265,14 +280,14 @@ module Elastomer
       # params   - Parameters for the update action (as a Hash) (optional)
       #
       # Examples
-      #   update({"foo" => "bar"}, {:_id => 1}
-      #   update({"foo" => "bar"}, {:id => 1}
-      #   update("foo" => "bar", "_id" => 1)
+      #   update({"doc" => {"foo" => "bar"}}, {:_id => 1})
+      #   update({"doc" => {"foo" => "bar"}}, {:id => 1})
+      #   update({"doc" => {"foo" => "bar"}}, "_id" => 1)
       #
       # Returns the response from the bulk call if one was made or nil.
-      def update( document, params )
+      def update(document, params)
         params = prepare_params(document, params)
-        add_to_actions({:update => params}, document)
+        add_to_actions({update: params}, document)
       end
 
       # Add a delete action to the list of bulk actions to be performed when
@@ -284,9 +299,9 @@ module Elastomer
       #   delete(:_id => 1, :_type => 'foo')
       #
       # Returns the response from the bulk call if one was made or nil.
-      def delete( params )
+      def delete(params)
         params = prepare_params(nil, params)
-        add_to_actions({:delete => params})
+        add_to_actions({delete: params})
       end
 
       # Immediately execute a bulk API call with the currently accumulated
@@ -307,37 +322,23 @@ module Elastomer
         @actions.clear
       end
 
-      SPECIAL_KEYS = %w[id type index version version_type routing parent timestamp ttl consistency refresh retry_on_conflict]
-      SPECIAL_KEYS_HASH = SPECIAL_KEYS.inject({}) { |h, k| h[k] = "_#{k}"; h }
+      SPECIAL_KEYS = %w[id type index version version_type routing parent consistency refresh retry_on_conflict]
+      UNPREFIXED_SPECIAL_KEYS = %w[parent retry_on_conflict routing version version_type]
 
       # Internal: convert special key parameters to their wire representation
       # and apply any override document parameters.
       def prepare_params(document, params)
         params = convert_special_keys(params)
-        if document.is_a? Hash
-          params = from_document(document).merge(params)
-        end
+
         params.delete(:_id) if params[:_id].nil? || params[:_id].to_s.empty?
-        params
-      end
+        params.delete("_id") if params["_id"].nil? || params["_id"].to_s.empty?
 
-      # Internal: Extract special keys for bulk indexing from the given
-      # `document`. The keys and their values are returned as a Hash from this
-      # method. If a value is `nil` then it will be ignored.
-      #
-      # document - The document Hash
-      #
-      # Returns extracted key/value pairs as a Hash.
-      def from_document( document )
-        opts = {}
-
-        SPECIAL_KEYS_HASH.values.each do |field|
-          key = field.to_sym
-          opts[key] = document.delete field if document.key? field
-          opts[key] = document.delete key   if document.key? key
+        if client.version_support.es_version_8_plus?
+          params.delete(:_type)
+          params.delete("_type")
         end
 
-        opts
+        params
       end
 
       # Internal: Convert incoming Ruby symbol keys to their special underscore
@@ -353,9 +354,30 @@ module Elastomer
       def convert_special_keys(params)
         new_params = params.dup
 
-        SPECIAL_KEYS_HASH.each do |k1, k2|
-          new_params[k2] = new_params.delete k1 if new_params.key? k1
-          new_params[k2.to_sym] = new_params.delete k1.to_sym if new_params.key? k1.to_sym
+        SPECIAL_KEYS.each do |key|
+          omit_prefix = (
+            client.version_support.es_version_8_plus? &&
+            UNPREFIXED_SPECIAL_KEYS.include?(key)
+          )
+
+          prefixed_key = "_" + key
+          converted_key = (omit_prefix ? "" : "_") + key
+
+          if new_params.key?(prefixed_key)
+            new_params[converted_key] = new_params.delete(prefixed_key)
+          end
+
+          if new_params.key?(prefixed_key.to_sym)
+            new_params[converted_key.to_sym] = new_params.delete(prefixed_key.to_sym)
+          end
+
+          if new_params.key?(key)
+            new_params[converted_key] = new_params.delete(key)
+          end
+
+          if new_params.key?(key.to_sym)
+            new_params[converted_key.to_sym] = new_params.delete(key.to_sym)
+          end
         end
 
         new_params
@@ -375,7 +397,7 @@ module Elastomer
       # Returns the response from the bulk call if one was made or nil.
       # Raises RequestSizeError if the given action is larger than the
       #        configured requst size or the client.max_request_size
-      def add_to_actions( action, document = nil )
+      def add_to_actions(action, document = nil)
         action = MultiJson.dump(action)
         size = action.bytesize
 
@@ -389,6 +411,7 @@ module Elastomer
         response = nil
         begin
           response = call if ready_to_send?(size)
+        # rubocop:disable Lint/UselessRescue
         rescue StandardError => err
           raise err
         ensure
@@ -407,7 +430,7 @@ module Elastomer
       # dispatch the bulk request.
       #
       # Returns `true` of `false`
-      def ready_to_send?( size )
+      def ready_to_send?(size)
         total_request_size = @current_request_size + size
         total_action_count = @current_action_count + 1
 
@@ -417,7 +440,7 @@ module Elastomer
 
       # Internal: Raises a RequestSizeError if the given size is larger than
       # the configured client.max_request_size
-      def check_action_size!( size )
+      def check_action_size!(size)
         return unless size > client.max_request_size
         raise RequestSizeError, "Bulk action of size `#{size}` exceeds the maximum requst size: #{client.max_request_size}"
       end