elastomer-client 3.2.3 → 6.2.0

data/test/client/errors_test.rb

@@ -1,19 +1,24 @@
+# frozen_string_literal: true
+
 require_relative "../test_helper"
 
-describe Elastomer::Client::Error do
+describe ElastomerClient::Client::Error do
 
   it "is instantiated with a simple message" do
-    err = Elastomer::Client::Error.new "something went wrong"
+    err = ElastomerClient::Client::Error.new "something went wrong"
+
     assert_equal "something went wrong", err.message
   end
 
   it "is instantiated from an HTTP response" do
-    response = Faraday::Response.new(:body => "UTF8Error invalid middle-byte")
-    err = Elastomer::Client::Error.new(response)
+    response = Faraday::Response.new(body: "UTF8Error invalid middle-byte")
+    err = ElastomerClient::Client::Error.new(response)
+
     assert_equal "UTF8Error invalid middle-byte", err.message
 
-    response = Faraday::Response.new(:body => {"error" => "IndexMissingException"})
-    err = Elastomer::Client::Error.new(response)
+    response = Faraday::Response.new(body: {"error" => "IndexMissingException"})
+    err = ElastomerClient::Client::Error.new(response)
+
     assert_equal "IndexMissingException", err.message
     assert_equal "IndexMissingException", err.error
 
@@ -34,64 +39,57 @@ describe Elastomer::Client::Error do
       },
      "status" => 404
     }
-    response = Faraday::Response.new(:body => body)
-    err = Elastomer::Client::Error.new(response)
+    response = Faraday::Response.new(body:)
+    err = ElastomerClient::Client::Error.new(response)
+
     assert_equal body["error"].to_s, err.message
     assert_equal body["error"], err.error
   end
 
   it "is instantiated from another exception" do
-    err = Faraday::Error::ConnectionFailed.new "could not connect to host"
+    err = Faraday::ConnectionFailed.new "could not connect to host"
     err.set_backtrace %w[one two three four]
 
-    err = Elastomer::Client::Error.new(err, "POST", "/index/doc")
+    err = ElastomerClient::Client::Error.new(err, "POST", "/index/doc")
+
     assert_equal "could not connect to host :: POST /index/doc", err.message
     assert_equal %w[one two three four], err.backtrace
   end
 
   it "is fatal by default" do
-    assert Elastomer::Client::Error.fatal, "client errors are fatal by default"
+    assert ElastomerClient::Client::Error.fatal, "client errors are fatal by default"
+
+    error = ElastomerClient::Client::Error.new "oops!"
 
-    error = Elastomer::Client::Error.new "oops!"
-    assert !error.retry?, "client errors are not retryable by default"
+    refute_predicate error, :retry?, "client errors are not retryable by default"
   end
 
   it "supports .fatal? alias" do
-    assert Elastomer::Client::Error.fatal?, "client errors support .fatal?"
+    assert_predicate ElastomerClient::Client::Error, :fatal?, "client errors support .fatal?"
   end
 
   it "has some fatal subclasses" do
-    assert Elastomer::Client::ResourceNotFound.fatal, "Resource not found is fatal"
-    assert Elastomer::Client::ParsingError.fatal, "Parsing error is fatal"
-    assert Elastomer::Client::SSLError.fatal, "SSL error is fatal"
-    assert Elastomer::Client::RequestError.fatal, "Request error is fatal"
-    assert Elastomer::Client::DocumentAlreadyExistsError.fatal, "DocumentAlreadyExistsError error is fatal"
+    assert ElastomerClient::Client::ResourceNotFound.fatal, "Resource not found is fatal"
+    assert ElastomerClient::Client::ParsingError.fatal, "Parsing error is fatal"
+    assert ElastomerClient::Client::SSLError.fatal, "SSL error is fatal"
+    assert ElastomerClient::Client::RequestError.fatal, "Request error is fatal"
+    assert ElastomerClient::Client::DocumentAlreadyExistsError.fatal, "DocumentAlreadyExistsError error is fatal"
   end
 
   it "has some non-fatal subclasses" do
-    assert !Elastomer::Client::TimeoutError.fatal, "Timeouts are not fatal"
-    assert !Elastomer::Client::ConnectionFailed.fatal, "Connection failures are not fatal"
-    assert !Elastomer::Client::ServerError.fatal, "Server errors are not fatal"
-    assert !Elastomer::Client::RejectedExecutionError.fatal, "Rejected execution errors are not fatal"
+    refute ElastomerClient::Client::TimeoutError.fatal, "Timeouts are not fatal"
+    refute ElastomerClient::Client::ConnectionFailed.fatal, "Connection failures are not fatal"
+    refute ElastomerClient::Client::ServerError.fatal, "Server errors are not fatal"
+    refute ElastomerClient::Client::RejectedExecutionError.fatal, "Rejected execution errors are not fatal"
   end
 
-  if parameter_validation?
-    it "wraps illegal argument exceptions" do
-      begin
-        $client.get("/_cluster/health?consistency=all")
-        assert false, "IllegalArgument exception was not raised"
-      rescue Elastomer::Client::IllegalArgument => err
-        assert_match(/request \[\/_cluster\/health\] contains unrecognized parameter: \[consistency\]/, err.message)
-      end
-    end
-  else
-    it "does not raise illegal argument exceptions" do
-      begin
-        $client.get("/_cluster/health?consistency=all")
-        assert true, "Exception was not raised"
-      rescue Elastomer::Client::Error => err
-        assert false, "Exception #{err} was raised"
-      end
+  it "wraps illegal argument exceptions" do
+    begin
+      $client.get("/_cluster/health?consistency=all")
+
+      assert false, "IllegalArgument exception was not raised"
+    rescue ElastomerClient::Client::IllegalArgument => err
+      assert_match(/request \[\/_cluster\/health\] contains unrecognized parameter: \[consistency\]/, err.message)
     end
   end
 end