elastictastic 0.5.0 → 0.10.2

data/spec/examples/middleware_spec.rb

@@ -25,68 +25,8 @@ describe Elastictastic::Middleware::LogRequests do
   end
 
   it 'should log body of POST requests to logger' do
-    stub_elasticsearch_create('default', 'post')
+    stub_es_create('default', 'post')
     client.create('default', 'post', nil, {})
     io.string.should == "ElasticSearch POST (3ms) /default/post {}\n"
   end
 end
-
-describe Elastictastic::Middleware::Rotor do
-  let(:config) do
-    Elastictastic::Configuration.new.tap do |config|
-      config.hosts = ['http://es1.local', 'http://es2.local']
-    end
-  end
-  let(:client) { Elastictastic::Client.new(config) }
-  let(:last_request) { FakeWeb.last_request }
-
-  it 'should alternate requests between hosts' do
-    expect do
-      2.times do
-        1.upto 2 do |i|
-          host_status(i => true)
-          client.get('default', 'post', '1')
-        end
-      end
-    end.not_to raise_error # We can't check the hostname of last_request in Fakeweb
-  end
-
-  context 'if one host fails' do
-    let!(:now) { Time.now.tap { |now| Time.stub(:now).and_return(now) }}
-
-    before do
-      host_status(1 => false, 2 => true)
-    end
-
-    it 'should try the next host' do
-      client.get('default', 'post', '1').should == { 'success' => true }
-    end
-  end
-
-  context 'if all hosts fail' do
-    let!(:now) { Time.now.tap { |now| Time.stub(:now).and_return(now) }}
-
-    before do
-      host_status(1 => false, 2 => false)
-    end
-
-    it 'should raise error if no hosts respond' do
-      expect { client.get('default', 'post', '1') }.to(raise_error Elastictastic::NoServerAvailable)
-    end
-  end
-
-  private
-
-  def host_status(statuses)
-    FakeWeb.clean_registry
-    statuses.each_pair do |i, healthy|
-      url = "http://es#{i}.local/default/post/1"
-      if healthy
-        options = { :body => '{"success":true}' }
-      else
-        options = { :exception => Errno::ECONNREFUSED }
-      end
-      FakeWeb.register_uri(:get, url, options)
-    end
-  end
-end

data/spec/examples/multi_get_spec.rb

@@ -0,0 +1,127 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+describe Elastictastic::MultiGet do
+  include Elastictastic::TestHelpers
+
+  let(:last_request_body) { Elastictastic.json_decode(last_request.body) }
+
+  before do
+    stub_es_mget(
+      nil,
+      nil,
+      ['1', 'post', 'default'], ['2', 'post', 'my_index'], ['3', 'post', 'my_index'],
+      ['4', 'post', 'my_index'] => nil
+    )
+  end
+
+  describe 'with no options' do
+    let!(:posts) do
+      Elastictastic.multi_get do |mget|
+        mget.add(Post, 1)
+        mget.add(Post.in_index('my_index'), 2, 3, 4)
+      end
+    end
+
+    it 'should send request to base path' do
+      last_request.path.should == '/_mget'
+    end
+
+    it 'should request ids with type and index' do
+      last_request_body.should == {
+        'docs' => [{
+        '_id' => '1',
+        '_type' => 'post',
+        '_index' => 'default'
+      }, {
+        '_id' => '2',
+        '_type' => 'post',
+        '_index' => 'my_index'
+      }, {
+        '_id' => '3',
+        '_type' => 'post',
+        '_index' => 'my_index'
+      }, {
+        '_id' => '4',
+        '_type' => 'post',
+        '_index' => 'my_index'
+      }]
+      }
+    end
+
+    it 'should return existing docs with IDs' do
+      posts.map(&:id).should == %w(1 2 3)
+    end
+
+    it 'should set proper indices' do
+      posts.map { |post| post.index.name }.should ==
+        %w(default my_index my_index)
+    end
+  end # context 'with no options' 
+
+  context 'with fields specified' do
+    let!(:posts) do
+      Elastictastic.multi_get do |mget|
+        mget.add(Post.fields('title'), '1')
+        mget.add(Post.in_index('my_index').fields('title'), '2', '3')
+      end
+    end
+
+    it 'should inject fields into each identifier' do
+      last_request_body.should == {
+        'docs' => [{
+        '_id' => '1',
+        '_type' => 'post',
+        '_index' => 'default',
+        'fields' => %w(title)
+      }, {
+        '_id' => '2',
+        '_type' => 'post',
+        '_index' => 'my_index',
+        'fields' => %w(title)
+      }, {
+        '_id' => '3',
+        '_type' => 'post',
+        '_index' => 'my_index',
+        'fields' => %w(title)
+      }]
+      }
+    end
+  end
+
+  context 'with routing specified' do
+    let!(:posts) do
+      Elastictastic.multi_get do |mget|
+        mget.add(Post.routing('foo'), '1')
+        mget.add(Post.in_index('my_index').routing('bar'), '2', '3')
+      end
+    end
+
+    it 'should inject fields into each identifier' do
+      last_request_body.should == {
+        'docs' => [{
+        '_id' => '1',
+        '_type' => 'post',
+        '_index' => 'default',
+        'routing' => 'foo'
+      }, {
+        '_id' => '2',
+        '_type' => 'post',
+        '_index' => 'my_index',
+        'routing' => 'bar'
+      }, {
+        '_id' => '3',
+        '_type' => 'post',
+        '_index' => 'my_index',
+        'routing' => 'bar'
+      }]
+      }
+    end
+  end
+
+  context 'with no docspecs given' do
+    it 'should gracefully return nothing' do
+      FakeWeb.clean_registry
+      Elastictastic.multi_get {}.to_a.should == []
+    end
+  end
+end

data/spec/examples/multi_search_spec.rb

@@ -0,0 +1,113 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+describe Elastictastic::MultiSearch do
+  include Elastictastic::TestHelpers
+
+  let(:request_components) do
+    [].tap do |components|
+      FakeWeb.last_request.body.each_line do |line|
+        components << Elastictastic.json_decode(line) unless line.strip.empty?
+      end
+    end
+  end
+
+  describe '::query' do
+    let(:scopes) do
+      [
+        Post.query(:query_string => { :query => 'pizza' }).size(10),
+        Blog.in_index('my_index').query(:term => { 'name' => 'Pasta' }).size(10),
+        Photo.routing('7').query(:query_string => {:query => 'pizza'}).size(10)
+      ]
+    end
+
+    before do
+      stub_es_msearch(
+        Array.new(3) { |i| generate_es_hit('post', :source => { 'title' => "post #{i}" }) },
+        Array.new(5) { |i| generate_es_hit('blog', :source => { 'name' => "blog #{i}" }) },
+        Array.new(2) { |i| generate_es_hit('photo', :source => { 'caption' => "photo #{i}" }) }
+      )
+      Elastictastic::MultiSearch.query(scopes)
+    end
+
+    it 'should send correct type, index, and search_type' do
+      request_components[0].should == { 'index' => 'default', 'type' => 'post', 'search_type' => 'query_then_fetch' }
+      request_components[2].should == { 'index' => 'my_index', 'type' => 'blog', 'search_type' => 'query_then_fetch' }
+      request_components[4].should == { 'index' => 'default', 'type' => 'photo', 'search_type' => 'query_then_fetch', 'routing' => '7' }
+    end
+
+    it 'should send correct scope params' do
+      request_components[1].should == scopes[0].params
+      request_components[3].should == scopes[1].params
+      request_components[5].should == scopes[2].params
+    end
+
+    it 'should populate scopes with results' do
+      scopes.first.each_with_index { |post, i| post.title.should == "post #{i}" }
+    end
+  end
+
+  describe '::count' do
+    let(:scopes) do
+      [
+        Post.query(:query_string => { :query => 'pizza' }).size(10),
+        Blog.in_index('my_index').query(:term => { 'name' => 'Pasta' })
+      ]
+    end
+
+    before do
+      stub_es_msearch_count(3, 5)
+      Elastictastic::MultiSearch.count(scopes)
+    end
+
+    it 'should send count search_type' do
+      request_components[0]['search_type'].should == 'count'
+      request_components[2]['search_type'].should == 'count'
+    end
+
+    it 'should populate counts' do
+      scopes.map { |scope| scope.count }.should == [3, 5]
+    end
+
+    it 'should not populate results' do
+      expect { scopes.first.to_a }.
+        to raise_error(FakeWeb::NetConnectNotAllowedError)
+    end
+  end
+
+  describe 'with no components' do
+    it 'should not attempt request' do
+      expect { Elastictastic::MultiSearch.query([]) }.
+        to_not raise_error(FakeWeb::NetConnectNotAllowedError)
+    end
+  end
+
+  context 'with unbounded scopes' do
+    let(:scopes) do
+      [Post.query(:query_string => { :query => 'pizza' })]
+    end
+
+    it 'should throw an exception' do
+      expect { Elastictastic::MultiSearch.query(scopes) }.
+        to raise_error(ArgumentError)
+    end
+  end
+
+  context 'with error in response' do
+    let(:scopes) do
+      [Post.query(:bogus => {}).size(10)]
+    end
+
+    before do
+      stub_request_json(
+        :post,
+        match_es_path('/_msearch'),
+        'responses' => [{ 'error' => 'SearchPhaseExecutionException[Failed to execute phase [query], total failure; shardFailures {[8A2fuICBTdiry42KTfa7uQ][contact_documents-1-development-0][4]: SearchParseException[[contact_documents-1-development-0][4]: from[-1],size[-1]: Parse Failure [Failed to parse source [{\"query\":{\"bogus\": {}}}]]]; nested: QueryParsingException[[contact_documents-1-development-0] No query registered for [bogus]]; }{[8A2fuICBTdiry42KTfa7uQ][contact_documents-1-development-0][3]: SearchParseException[[contact_documents-1-development-0][3]: from[-1],size[-1]: Parse Failure [Failed to parse source [{\"query\":{\"bogus\": {}}}]]]; nested: QueryParsingException[[contact_documents-1-development-0] No query registered for [bogus]]; }]'}]
+      )
+    end
+
+    it 'should raise error' do
+      expect { Elastictastic::MultiSearch.query(scopes) }.
+        to raise_error(Elastictastic::ServerError::QueryParsingException)
+    end
+  end
+end

data/spec/examples/observing_spec.rb

@@ -12,9 +12,9 @@ describe Elastictastic::Observing do
   end
 
   before do
-    stub_elasticsearch_create('default', 'post')
-    stub_elasticsearch_update('default', 'post', id)
-    stub_elasticsearch_destroy('default', 'post', id)
+    stub_es_create('default', 'post')
+    stub_es_update('default', 'post', id)
+    stub_es_destroy('default', 'post', id)
     Elastictastic.config.observers = [:post_observer]
     Elastictastic.config.instantiate_observers
   end
@@ -59,6 +59,13 @@ describe Elastictastic::Observing do
     end
   end
 
+  context 'on create with observing disabled' do
+    it 'should not run any observers' do
+      post.save(:observers => false)
+      post.observers_that_ran.should be_empty
+    end
+  end
+
   context 'on update' do
     let(:observers) { persisted_post.observers_that_ran }
 
@@ -99,6 +106,13 @@ describe Elastictastic::Observing do
     end
   end
 
+  context 'on update with observers disabled' do
+    it 'should not run any observers' do
+      persisted_post.save(:observers => false)
+      persisted_post.observers_that_ran.should be_empty
+    end
+  end
+
   context 'on destroy' do
     let(:observers) { persisted_post.observers_that_ran }
 
@@ -138,4 +152,11 @@ describe Elastictastic::Observing do
       observers.should include(:after_destroy)
     end
   end
+
+  context 'on destroy with observers disabled' do
+    it 'should not run any observers' do
+      persisted_post.destroy(:observers => false)
+      persisted_post.observers_that_ran.should be_empty
+    end
+  end
 end