elasticsearch_record 5.0.0 → 5.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4f850e5600056256b188825cc8ca7067b4928014a09b05bb18ed37fb648478f
-  data.tar.gz: 19cec69e3a5a67752f8c94a2b22968e29dd5edf7166e4e205903164387e8606f
+  metadata.gz: c40dcd47630a8b238e2aea55c4a1fd11996618606267fac0aeb8ff1f6675cbae
+  data.tar.gz: 6cf4bbabec3588fe3f65b97f10a7fb98cb79d163db044c845cca15d8b467fe35
 SHA512:
-  metadata.gz: 076f2df28822bba0a2148d2e3043cb403cb04d388c5034056eb7e298004694707b2e2b8c003257f8da4dc5d1bea80ae5bce8b851244cd146232b381ecc35543e
-  data.tar.gz: 91a406efac0912da2f2427120b0cf1fdbf1ae78166b9853c3af6099b6e19fd4aa09aebf962840f01345d4b32a523a1fd74706f827f86b0804a0f8ffef2199392
+  metadata.gz: a22d8ee32007b72c6893e0f4a31f7b796f8f231665c7b3f56bb693fbf795e7ff014000105f69fb4c5817e97a985d93061c76c26f76dba877b16c4a5a4f635130
+  data.tar.gz: 2de3a166ea5f5c9e06b96c923475d31e2683fc5c4c12d6e696a08f1efda7c4f100b2b1deb08f80fef2acb2787e78a4bb12126aa4ae4aabfec02d68d1c05c3dec

data/docs/CHANGELOG.md

@@ -1,5 +1,15 @@
 # ElasticsearchRecord - CHANGELOG
 
+## [5.0.2] - 2026-09-17
+* [add] `Arel::Visitors::ElasticsearchQuery#visit_Arel_Nodes_Casted` & `#visit_Arel_Nodes_Quoted` - the value nodes `Arel::Attributes::Attribute#eq` & co. build for plain values
+* [add] specs for `SchemaMigration#delete_version` & `#delete_all_versions`
+* [fix] `Arel::Visitors::ElasticsearchQuery#visit_Arel_Nodes_DeleteStatement` compiles a delete on a plain table _(the `ActiveRecord::SchemaMigration#delete_version` shape)_ into a delete-by-query - rolling a migration back removes its version again instead of raising a `NotImplementedError`
+
+## [5.0.1] - 2026-09-16
+* [add] specs for `Elasticsearch::Column` identity, deduplication & YAML round-trip
+* [fix] `Elasticsearch::Column#==`, `#eql?` & `#hash` also compare `virtual`, `fields`, `properties`, `meta` & `enabled` - same-named columns of different indexes no longer share a single deduplicated object
+* [fix] `Elasticsearch::Column#init_with` & `#encode_with` serialize the elasticsearch-specific attributes
+
 ## [5.0.0] - 2026-09-10
 * [add] **BREAKING**: requires `activerecord ~> 8.1.0`
 * [add] `Relation::ValueMethods#limit!` - keeps the `'__max__'` & `Float::INFINITY` limits, which rails now casts through `Integer()`

data/lib/active_record/connection_adapters/elasticsearch/column.rb

@@ -22,6 +22,53 @@ module ActiveRecord
           meta? && meta['comment']
         end
 
+        def init_with(coder)
+          @virtual    = coder['virtual']
+          @fields     = coder['fields']
+          @properties = coder['properties']
+          @meta       = coder['meta']
+          @enabled    = coder['enabled']
+          super
+        end
+
+        def encode_with(coder)
+          coder['virtual']    = @virtual
+          coder['fields']     = @fields
+          coder['properties'] = @properties
+          coder['meta']       = @meta
+          coder['enabled']    = @enabled
+          super
+        end
+
+        # ActiveRecord deduplicates columns process-wide through +Deduplicable+, which
+        # keys its registry by +#hash+ & +#eql?+ - so columns that only differ in the
+        # elasticsearch-specific attributes must NOT compare equal.
+        # Without this a +keyword+ column with a +analyzed+ sub-field would share the
+        # object of a same-named +keyword+ column without any fields - whichever index
+        # loaded its schema first wins & the other one silently gains or loses its
+        # +fields+ (breaking e.g. +where('code.analyzed' => ...)+).
+        def ==(other)
+          other.is_a?(Column) &&
+            super &&
+            virtual == other.virtual &&
+            fields == other.fields &&
+            properties == other.properties &&
+            meta == other.meta &&
+            enabled == other.enabled
+        end
+
+        alias :eql? :==
+
+        def hash
+          Column.hash ^
+            super.hash ^
+            virtual.hash ^
+            fields.hash ^
+            properties.hash ^
+            meta.hash ^
+            enabled.hash
+        end
+
         # returns true if this column is enabled (= searchable by queries)
         # @return [Boolean]
         def enabled?

data/lib/arel/visitors/elasticsearch_query.rb

@@ -63,9 +63,16 @@ module Arel # :nodoc: all
       end
 
       # DELETE (by query - not a single record...)
+      #
+      # A plain +Arel::Table+ relation is the shape of a +DeleteManager+ built straight on a table -
+      # +ActiveRecord::SchemaMigration#delete_version+ does exactly that to remove a rolled back version.
+      # Elasticsearch has no "delete by column value" apart from a delete-by-query, and a single record
+      # never reaches Arel (see @ ElasticsearchRecord::ModelApi#delete), so the conditions of such a
+      # statement are compiled into a delete-by-query on that index - the same as a relation's +delete_all+.
+      # Without any condition the statement would wipe the whole index, which is not what a delete means.
       def visit_Arel_Nodes_DeleteStatement(o)
-        # switch between updating a single Record or multiple by query
-        if o.relation.is_a?(::Arel::Table)
+        # a plain table without conditions is neither a single record nor a query
+        if o.relation.is_a?(::Arel::Table) && o.wheres.blank?
           raise NotImplementedError, "if you've made it this far, something went wrong ..."
         end
 
@@ -463,6 +470,16 @@ module Arel # :nodoc: all
       alias :visit_String :visit_Struct_Raw
       alias :visit_Arel_Nodes_SqlLiteral :visit_Struct_Raw
 
+      # CASTED / QUOTED values - the nodes +Arel::Attributes::Attribute#eq+ & co. wrap a plain value in
+      # (see @ Arel::Nodes.build_quoted). Returns the database value: the attribute of a model table
+      # type casts it, the attribute of a plain +Arel::Table+ returns the value unchanged.
+      def visit_Arel_Nodes_Casted(o)
+        o.value_for_database
+      end
+
+      # alias for QUOTED returns
+      alias :visit_Arel_Nodes_Quoted :visit_Arel_Nodes_Casted
+
       # used by insert / update statements.
       # does not claim / assign any values!
       # returns a Hash of key => value pairs

data/lib/elasticsearch_record/gem_version.rb

@@ -9,7 +9,7 @@ module ElasticsearchRecord
   module VERSION
     MAJOR = 5
     MINOR = 0
-    TINY  = 0
+    TINY  = 2
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elasticsearch_record
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.2
 platform: ruby
 authors:
 - Tobias Gonsior