elasticsearch_record 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92676fe7f2327036588c1d2e3cb6756cabbc2365ee8984196f1ef1c4a23d8448
-  data.tar.gz: 8c1f329957f4a1909181dde9e9c781a86a41188ee7337a73614eb8d893cae482
+  metadata.gz: 52f19a4a5802d333a04d2c72e4a7a51c3f0bfc501c0b8b379e6afb44d1076aca
+  data.tar.gz: ac2eb76b596b4705feac42612fb0e11d530f684750ee780471c765172a69ea7f
 SHA512:
-  metadata.gz: 9cb4514641f1f26d922f5cb941a677c5cff568641ddcf7243a914481707a982440b6a8967e74734d7900c00c6441128ef69c29a5c3774455df018206932e1b85
-  data.tar.gz: 004b62c74a4b4878c2e0a982a91217beee695a8e58d4509bba4cbd8f7664fdd0a4658cfd8533e1ff5a409f5fee6bce613d46f398ac067ed474324d65ad43406c
+  metadata.gz: 68b0cc2c384b7751c271aa1d3f8b37af778d20af1ca6e42a967b97454ab2121a0606150977690a9153b58567d2172c5e08cfe2adbf7578e3051c60edf0c4a1a4
+  data.tar.gz: bf240b8ccd09364d6237900854c824080068cd6822400f7538dabedd85491cb64dbe45b86725aa353fe9fc598e4e2d4837935775e132af11215ea767daf2b7e1

data/docs/CHANGELOG.md

@@ -1,5 +1,10 @@
 # ElasticsearchRecord - CHANGELOG
 
+## [1.7.1] - 2024-01-09
+* [fix] `ElasticsearchRecord::Relation` calculation methods return with different nodes
+* [ref] `ElasticsearchRecord::Relation#calculate` removes default value of `node`
+* [ref] `ActiveRecord::ConnectionAdapters::ElasticsearchAdapter#api` prevents inaccurate variable interpretation of `log`
+
 ## [1.7.0] - 2024-01-09
 * [add] `ElasticsearchRecord::Relation#boxplot` calculation method
 * [add] `ElasticsearchRecord::Relation#stats` calculation method

data/lib/active_record/connection_adapters/elasticsearch_adapter.rb

@@ -238,7 +238,7 @@ module ActiveRecord # :nodoc:
         # resolve the API target
         target = namespace == :core ? @connection : @connection.__send__(namespace)
 
-        log("#{namespace}.#{action}", arguments, name, async: async, log: log) do
+        __send__(:log, "#{namespace}.#{action}", arguments, name, async: async, log: log) do
           response = ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
             target.__send__(action, arguments)
           end

data/lib/elasticsearch_record/gem_version.rb

@@ -9,7 +9,7 @@ module ElasticsearchRecord
   module VERSION
     MAJOR = 1
     MINOR = 7
-    TINY  = 0
+    TINY  = 1
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

data/lib/elasticsearch_record/relation/calculation_methods.rb

@@ -168,7 +168,7 @@ module ElasticsearchRecord
       # @param [Symbol, String] column_name
       # @param [Array] values
       def percentile_ranks(column_name, values)
-        calculate(:percentiles, column_name, opts: { values: values }, node: :values)
+        calculate(:percentile_ranks, column_name, opts: { values: values }, node: :values)
       end
 
       # Calculates the cardinality on a given column. Returns +0+ if there's no row.
@@ -180,7 +180,7 @@ module ElasticsearchRecord
       #
       # @param [Symbol, String] column_name
       def cardinality(column_name)
-        calculate(:cardinality, column_name)
+        calculate(:cardinality, column_name, node: :value)
       end
 
       # Calculates the average value on a given column. Returns +nil+ if there's no row. See #calculate for examples with options.
@@ -191,7 +191,7 @@ module ElasticsearchRecord
       #
       # @param [Symbol, String] column_name
       def average(column_name)
-        calculate(:avg, column_name)
+        calculate(:avg, column_name, node: :value)
       end
 
       # Calculates the minimum value on a given column. The value is returned
@@ -204,7 +204,7 @@ module ElasticsearchRecord
       #
       # @param [Symbol, String] column_name
       def minimum(column_name)
-        calculate(:min, column_name)
+        calculate(:min, column_name, node: :value)
       end
 
       # Calculates the maximum value on a given column. The value is returned
@@ -217,7 +217,7 @@ module ElasticsearchRecord
       #
       # @param [Symbol, String] column_name
       def maximum(column_name)
-        calculate(:max, column_name)
+        calculate(:max, column_name, node: :value)
       end
 
       # This single-value aggregation approximates the median absolute deviation of its search results.
@@ -247,7 +247,7 @@ module ElasticsearchRecord
       #
       # @param [Symbol, String] column_name (optional)
       def sum(column_name)
-        calculate(:sum, column_name)
+        calculate(:sum, column_name, node: :value)
       end
 
       # creates a aggregation with the provided metric (e.g. :sum) and columns.
@@ -255,8 +255,8 @@ module ElasticsearchRecord
       # @param [Symbol, String] metric
       # @param [Array<Symbol|String>] columns
       # @param [Hash] opts - additional arguments that get merged with the metric definition
-      # @param [Symbol] node (default :value)
-      def calculate(metric, *columns, opts: {}, node: :value)
+      # @param [Symbol] node (default: nil)
+      def calculate(metric, *columns, opts: {}, node: nil)
         metric_key = "calculate_#{metric}"
 
         # spawn a new aggregation and return the aggs
@@ -266,7 +266,11 @@ module ElasticsearchRecord
                      aggregate(metric_key, { metric => { fields: columns }.merge(opts) }).aggregations
                    end
 
-        response[metric_key][node]
+        if node.present?
+          response[metric_key][node]
+        else
+          response[metric_key]
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elasticsearch_record
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Tobias Gonsior