elasticsearch-persistence 5.0.2 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 16991935a6a92bf65079ff6dcfe91e1893846421
-  data.tar.gz: 6d831835f08f046e32f4255e0f2eb91ee25ce100
+SHA256:
+  metadata.gz: dad7450ff0696099a095419ee12da5d4ea875646ad591545f95bae8fc2408ce2
+  data.tar.gz: 339a759ce92884321d4adbb7fa63f4ee3a155958d97e5ea3ee8c55b60cd21e8a
 SHA512:
-  metadata.gz: fc4df80b6eda6510e42c7a4d5f9111328efd1ca6aede2053d342061b3b2bb5b675fd326168b9252528cc86bcf62fe6e369433467b8b98410d940fdeba335466e
-  data.tar.gz: dbce37f333f0b0becb3e62b0907305a325e4f36518e466891ff81e66832ed84a0fad6fb1a87e1c7caec9521634c06d2092818aa42a2ae994c15471a6b7109d17
+  metadata.gz: 8a1477b512b7cdbb812866c7b582e1417871713689c165d876b49df44e7d8095d08d7b5993110b23071d784f9c9c19db6d58a771bd0b1627d1f9c75bd75586ed
+  data.tar.gz: 7eb56ed82336e9648a0fe3a3288c854621811f13b07ee6402138086c4dfe28fd78b4f283b4a0ea1a140678d8f625794c6aad3c386cfa346eec017b92ee007a06

data/README.md

@@ -445,6 +445,9 @@ and demonstrates a rich set of features:
 
 ### The ActiveRecord Pattern
 
+Please note that this pattern is deprecated and will be removed in version 6.0.
+The [Repository Pattern](#the-repository-pattern) is recommended instead.
+
 The `Elasticsearch::Persistence::Model` module provides an implementation of the
 active record [pattern](http://www.martinfowler.com/eaaCatalog/activeRecord.html),
 with a familiar interface for using Elasticsearch as a persistence layer in

data/lib/elasticsearch/persistence/model.rb

@@ -66,6 +66,22 @@ module Elasticsearch
               @gateway
             end
 
+            DEPRECATION_WARNING = "This (ActiveRecord) persistence pattern is deprecated. It will be removed in " +
+              "version 6.0 in favor of the Repository pattern. Please see the ReadMe for " +
+              "details on the alternative pattern.\n" +
+              "https://github.com/elastic/elasticsearch-rails/tree/master/elasticsearch-persistence" +
+              "#the-repository-pattern".freeze
+
+            # Warn that this ActiveRecord persistence pattern is deprecated.
+            #
+            def raise_deprecation_warning!
+              if STDERR.tty?
+                Kernel.warn("\e[31;1m#{DEPRECATION_WARNING}\e[0m")
+              else
+                Kernel.warn(DEPRECATION_WARNING)
+              end
+            end
+
             # Delegate methods to repository
             #
             delegate :settings,
@@ -126,6 +142,8 @@ module Elasticsearch
           attribute :updated_at, Time, default: lambda { |o,a| Time.now.utc }
 
           attr_reader :hit
+
+          raise_deprecation_warning!
         end
 
       end

data/lib/elasticsearch/persistence/version.rb

@@ -1,5 +1,5 @@
 module Elasticsearch
   module Persistence
-    VERSION = "5.0.2"
+    VERSION = "5.1.0"
   end
 end

data/test/integration/model/model_basic_test.rb

@@ -33,6 +33,11 @@ module Elasticsearch
           Person.create_index! force: true
         end
 
+        should "warn that the ActiveRecord persistence pattern is deprecated" do
+          Kernel.expects(:warn).at_least_once
+          class ShouldWarn; include Elasticsearch::Persistence::Model; end
+        end
+
         should "save the object with custom ID" do
           person = Person.new id: 1, name: 'Number One'
           person.save

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: elasticsearch-persistence
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 5.1.0
 platform: ruby
 authors:
 - Karel Minarik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-04 00:00:00.000000000 Z
+date: 2018-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: elasticsearch
@@ -412,7 +412,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Persistence layer for Ruby models and Elasticsearch.