eitje_s3 1.0.2 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d33b9a4100b9da596c8144c2a7a568f0afdb93157c5ab16e734fbdd3bd1d0648
-  data.tar.gz: 83e8c75c8cb6f91b4277b2bd23dcaf9186c771f342c60d95d9c31960a6d14f2e
+  metadata.gz: 71fa767da62f09f63fe6a2d3da4d3b05d88002dffb1c1163af0e4b6be9fabb82
+  data.tar.gz: 5e14301d327038d95a7439c53eb2e3d1393a9ff7d59f75dfaa87ac66895a0ddb
 SHA512:
-  metadata.gz: 3b8abb2833763749a92555cd4453bb732f11df97f13a466310bb3f0fced1ca4f7c930062f354b6e234fea9161ecf9ad2f770d14136093ebec3093bd0732b0eab
-  data.tar.gz: 7ef3fe024ca91e1a8ceef0e62d21d6066baed5fe52717a75eabcaec9562681bfd4520ab372ab2308e96b29048e152f2d52c9f3455b974cc1890b082eecfd7432
+  metadata.gz: fe8c94a7707711d185dfa43b1dc63647ec67f1573faea4739c86cb0cb3eaba6bed226f7c6ff4f661b1406e74ea4d192928eabb5c78fb803966355478d9995257
+  data.tar.gz: 0f7afb80b297bf439d0487e2847ac405fd711f0da7eb16db3de1ed85086986bf33305f1abd93f57c76cbe7ae220bc8fee5470e3c1bc213433d728181b06bedf1

data/app/services/s3/new_deleted_records_service.rb

@@ -1,13 +1,7 @@
 module S3::NewDeletedRecordsService
   class << self
 
-   DB_TABLES = %w$ shifts teams users contracts infos posts $
-
-    def test(table)
-      S3::NewDeletedRecordsService.get_records(
-        db_table: table, start_date: '2021-03-28', end_date: '2021-04-3', env_id: 513
-      )
-    end
+   DB_TABLES = %w$ shifts teams users contracts infos posts topics $
 
     def get_records(db_table:, start_date:, end_date:, env_id:)    
       @date_range = Date.parse(start_date)..Date.parse(end_date)
@@ -32,7 +26,13 @@ module S3::NewDeletedRecordsService
     end
 
     def query_records    
-      file     = @s3.get_object(bucket: 'eitje-deleted-jurr', key: @file_name)
+
+      # Previously (before adding 'topics') the request bucket was 'eitje-deleted-jurr'
+      # but somehow topics break if we dont request the bucket '-2'. Now for other tables
+      # the original returns waaaaay many records, so probably does not filter by date or
+      # something. Change for now and investigate if shit goes BG.
+
+      file     = @s3.get_object(bucket: 'eitje-deleted-jurr-2', key: @file_name)
       @records = JSON.parse(file.body.read.as_json).map(&:symbolize_keys)
     end
 

data/app/services/s3/old_deleted_records_service.rb

@@ -3,8 +3,6 @@ module S3::OldDeletedRecordsService
 
    DB_TABLES = %w$ shifts teams users contracts infos posts topics $
 
-   # S3::OldDeletedRecordsService.get_records(env_id: 307, env_name: 'Kua - Den Haag', db_table: 'verlofverzoeks', start_date: '2021-02-01', end_date: '2021-04-01')
-
     def get_records(db_table:, start_date:, end_date:, env_id:, env_name:)
 
       # validate_args(db_table)
@@ -20,7 +18,6 @@ module S3::OldDeletedRecordsService
       @file_names_filtered_by_date  = filter_by_date
 
       read_all_files
-
     end
 
     # validations
@@ -36,7 +33,15 @@ module S3::OldDeletedRecordsService
         
         @file_name = file_name
         @file      = request_object 
-        @db_table == 'users' ? filter_users_table_by_env : filter_file_by_env
+
+        case @db_table
+        when 'users'
+          filter_users_table_by_env
+        when 'topics'
+          filter_topics_table_by_env
+        else
+          filter_file_by_env
+        end
 
       end.flatten
     end
@@ -59,6 +64,10 @@ module S3::OldDeletedRecordsService
       @file.select { |row| row[:envs].include? @env_name }
     end
 
+    def filter_topics_table_by_env
+      @file.select { |row| row[:environment_ids]&.include?(@env_id) }
+    end
+
     def filter_by_date   
       @file_names_filtered_by_table.select { |file_name| @date_range.include?(get_date(file_name)) }
     end

data/app/services/s3/transform_deleted_files_service.rb

@@ -22,15 +22,23 @@ module S3::TransformDeletedFilesService
       set_tables.each do |table|  
         object  = s3.get_object(bucket: 'eitje-backups', key: "#{table}/#{start_date.strftime("%Y-%m-%d")}.json")
         json    = JSON.parse(object.body.read.as_json).map(&:symbolize_keys)
-        env_ids = json.map {|row| row[:env]}.uniq.map { |name| Environment.find_by(naam: name)&.id }
+        
+        if table == 'topics'
+          env_ids = json.map {|row| row[:environment_ids]}.flatten.compact.uniq
+        else
+          env_ids = json.map {|row| row[:env]}.uniq.map { |name| Environment.find_by(naam: name)&.id }
+        end
+
         envs_to_migrate << env_ids
-      rescue 
+      rescue => e
         # in case the file does not exist on S3, cause there are no deleted 
         # records, skip to next table
         next
       end
+
+      envs_to_migrate = envs_to_migrate.flatten.uniq.compact
       
-      envs_to_migrate.flatten.uniq.each { |env_id| migrate_files_single_env(env_id, start_date: start_date, skip_setters: true) }
+      envs_to_migrate.each { |env_id| migrate_files_single_env(env_id, start_date: start_date, skip_setters: true) }
     end
 
     def migrate_files_single_env(environment_id, start_date: Date.yesterday, skip_setters: false)
@@ -100,7 +108,8 @@ module S3::TransformDeletedFilesService
 
       (@records += @existing_records) if @existing_records
       set_json
-      upload_file  
+      upload_file
+
       rescue => e
         @logger.error "Error for env #{@env.naam} (##{@env.id}) with table '#{@table}' => #{e.class}: #{e.message}.\n\nBacktrace:#{e.backtrace}\n"
     end

data/lib/s3/version.rb

@@ -1,3 +1,3 @@
 module S3
-  VERSION = '1.0.2'
+  VERSION = '1.1.1'
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: eitje_s3
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.1
 platform: ruby
 authors:
 - Jurriaan Schrofer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-20 00:00:00.000000000 Z
+date: 2021-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.3
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
   requirement: !ruby/object:Gem::Requirement
@@ -93,7 +93,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.9
 signing_key:
 specification_version: 4
 summary: S3