einvoicing 0.9.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f41193fc67e566fb4f03b91fcbb9666e81540c72411d03535ac58fe92d3573a2
-  data.tar.gz: 3d36fab9deb25fb3f25cadde7e435c5227a20f37e9011d3c22977659e1058bb2
+  metadata.gz: ebdccf05d23870723b8c45634ecfa3f19f587c8e2bf4b3f1e3652b84a2874b13
+  data.tar.gz: f329a5f6d4a3c2ba2d7bfce7c935d81964208158f43e4760c8723d1606a3f9c5
 SHA512:
-  metadata.gz: 98d84a972f5dc4eaa604ca1360d741a916ceac43f54ec824f6dfd25143706c793cb27c5376d2e959cf919e61805fef9eb64066d839a3da3c875a638db9927261
-  data.tar.gz: fa99bcf35ebdbf90bb4ede4a031406201899fc4c288093a634df8126b0b738830340ba1894027b932c84397c232c3f4b8dab7f0cbd208a7a3148fcff1c499cc5
+  metadata.gz: 035345b680196da8a9daf0ad6d603c7bc5da458f75ee9939d491e6a3812ef0e01d4feb492474b0ff083c129c2e5d751dcfaddd8104c0b428b057980c01347f53
+  data.tar.gz: da8d6e8c4d27a445caa3159bb866242c2da2b206421959ee32083c40e88d480a55138224aeb8bbc9f32adfbec235662338f6d019aa34c2fa4bc94462be33b2f8

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.2] - 2026-08-06
+
+### Fixed
+- CII announced a SIRET under `schemeID="0002"`, which is SIRENE — the nine-digit SIREN. A fourteen-digit SIRET now goes out as `0009`, the ISO 6523 code that actually labels it. Neither the XSD nor the EN 16931 Schematron catches the mismatch, because both values are just strings to them; a Plateforme Agréée checks it, and refuses the document. Chorus Pro keeps the literal `SIRET` scheme it predates the codelist with
+
+## [0.9.1] - 2026-08-06
+
+### Added
+- Link to the online Factur-X validator in the README — runs entirely client-side with no upload required
+
+### Fixed
+- CII no longer emits an empty `ram:BuyerReference` when no payment reference is set. It falls back to the invoice number, as UBL already did — the two formats produced different documents for the same invoice, and an empty BT-10 is rejected by Chorus Pro, which requires it
+- French VAT numbers are now checked against their control key, not just their shape. `FR83552032534` has the right form and the right SIREN but the wrong key (it is 27), and the validator accepted it — a number that VIES and any tax administration rejects. The key is derived as `(12 + 3 × (SIREN mod 97)) mod 97` and the embedded SIREN must pass Luhn
+- The official French structure is `FR` + 2 characters + 9 digits, and those two characters may be alphanumeric. Only a numeric key follows the published formula, so an alphanumeric one is still accepted on its shape and its SIREN — refusing it would reject valid invoices
+- Every French identifier used in the test fixtures, the sample scripts and the documented examples was regenerated: all but one carried an invalid check key or a SIREN failing Luhn, which is precisely why the gap went unnoticed
+
 ## [0.9.0] - 2026-08-05
 
 Everything here comes from a batch of 15 deliberately hostile Factur-X invoices

data/README.md

@@ -19,7 +19,7 @@ This gem gives you a clean Ruby API to build compliant invoices, validate them a
 - Generate **UBL 2.1** XML (Peppol BIS Billing 3.0)
 - Generate **CII D16B** XML (EN 16931 / ZUGFeRD)
 - Full EN 16931 **VAT category set** (S, Z, E, AE, K, G, O) with exemption reasons (BT-120 / BT-121)
-- Validate French B2B requirements: SIREN, SIRET (Luhn), EU VAT number formats, French VAT rates including the DOM and Corsican ones
+- Validate French B2B requirements: SIREN, SIRET (Luhn), EU VAT number formats with the French check key verified, French VAT rates including the DOM and Corsican ones
 - Structured error reporting: `{ field:, error:, message: }` with i18n support (EN + FR)
 - Payment means: IBAN, BIC/SWIFT, UNCL4461 type codes
 - **Rails concern** (`Einvoicing::Invoiceable`) for ActiveRecord models
@@ -61,7 +61,7 @@ buyer = Einvoicing::Party.new(
   postal_code:  "75001",
   country_code: "FR",
   siren:        "552032534",
-  vat_number:   "FR83552032534"
+  vat_number:   "FR27552032534"
 )
 
 lines = [
@@ -145,6 +145,16 @@ errors = Einvoicing::Validators::FR.validate(invoice)
 # => [{ field: :seller_siren, error: :siren_invalid, message: "Le numéro SIREN est invalide" }]
 ```
 
+### Check a generated file online
+
+Drop a Factur-X PDF into our free validator for a report on the PDF/A-3
+container, the embedded XML, the official XSD and the EN 16931 business rules.
+It runs entirely in the browser — the invoice never leaves your machine, and
+there is no account to create.
+
+- English — https://www.sxnlabs.com/en/factur-x-validator/
+- Français — https://www.sxnlabs.com/verifier-facture-electronique/
+
 ## Formats
 
 ### Factur-X (PDF/A-3 + CII)

data/config/locales/einvoicing.en.yml

@@ -17,12 +17,12 @@ en:
         name_missing: "Seller name is required"
         siren_invalid: "Seller SIREN must be 9 digits (Luhn check failed)"
         siret_invalid: "Seller SIRET must be 14 digits (Luhn check failed)"
-        vat_number_invalid: "Seller VAT number format is invalid for its country prefix"
+        vat_number_invalid: "Seller VAT number is invalid for its country (format, or check key for France)"
       buyer:
         name_missing: "Buyer name is required"
         siren_invalid: "Buyer SIREN must be 9 digits (Luhn check failed)"
         siret_invalid: "Buyer SIRET must be 14 digits (Luhn check failed)"
-        vat_number_invalid: "Buyer VAT number format is invalid for its country prefix"
+        vat_number_invalid: "Buyer VAT number is invalid for its country (format, or check key for France)"
       line:
         description_missing: "Line %{index}: description is required"
         quantity_invalid: "Line %{index}: quantity must be positive"

data/config/locales/einvoicing.fr.yml

@@ -17,12 +17,12 @@ fr:
         name_missing: "Le nom du vendeur est requis"
         siren_invalid: "Le SIREN du vendeur doit comporter 9 chiffres (vérification Luhn échouée)"
         siret_invalid: "Le SIRET du vendeur doit comporter 14 chiffres (vérification Luhn échouée)"
-        vat_number_invalid: "Le format du numéro de TVA du vendeur est invalide pour son préfixe pays"
+        vat_number_invalid: "Le numéro de TVA du vendeur est invalide pour son pays (format, ou clé de contrôle pour la France)"
       buyer:
         name_missing: "Le nom de l'acheteur est requis"
         siren_invalid: "Le SIREN de l'acheteur doit comporter 9 chiffres (vérification Luhn échouée)"
         siret_invalid: "Le SIRET de l'acheteur doit comporter 14 chiffres (vérification Luhn échouée)"
-        vat_number_invalid: "Le format du numéro de TVA de l'acheteur est invalide pour son préfixe pays"
+        vat_number_invalid: "Le numéro de TVA de l'acheteur est invalide pour son pays (format, ou clé de contrôle pour la France)"
       line:
         description_missing: "Ligne %{index} : la description est requise"
         quantity_invalid: "Ligne %{index} : la quantité doit être positive"

data/lib/einvoicing/formats/cii.rb

@@ -116,20 +116,36 @@ module Einvoicing
       def self.header_trade_agreement(b, invoice, profile)
         b.tag("ram:ApplicableHeaderTradeAgreement") do
           # BuyerReference must be first in the sequence (EN 16931 BR-10 / XSD order).
-          b.text("ram:BuyerReference", invoice.payment_reference || "")
+          # Falls back to the invoice number like UBL does: an empty element is
+          # worse than either value, and BT-10 is mandatory for Chorus Pro.
+          b.text("ram:BuyerReference", invoice.payment_reference || invoice.invoice_number)
           b.tag("ram:SellerTradeParty") { party_xml(b, invoice.seller, profile) }
           b.tag("ram:BuyerTradeParty")  { party_xml(b, invoice.buyer, profile) }
         end
       end
       private_class_method :header_trade_agreement
 
+      # ISO 6523 identifier scheme for a French legal registration (BT-30 /
+      # BT-47). The code has to match the *length* of the number it labels:
+      # 0002 is SIRENE, which is the 9-digit SIREN, and a 14-digit SIRET
+      # announced as 0002 is what a Plateforme Agréée rejects the document for.
+      # Chorus Pro predates the codelist and wants the literal word instead.
+      SIREN_SCHEME = "0002"
+      SIRET_SCHEME = "0009"
+
+      def self.legal_id_scheme(party, profile)
+        return "SIRET" if profile == :chorus_pro && party.siret
+
+        party.siret ? SIRET_SCHEME : SIREN_SCHEME
+      end
+      private_class_method :legal_id_scheme
+
       def self.party_xml(b, party, profile)
         b.text("ram:Name", party.name)
         legal_id = party.siret || party.siren
         if legal_id
           b.tag("ram:SpecifiedLegalOrganization") do
-            scheme = (profile == :chorus_pro && party.siret) ? "SIRET" : "0002"
-            b.text("ram:ID", legal_id, "schemeID" => scheme)
+            b.text("ram:ID", legal_id, "schemeID" => legal_id_scheme(party, profile))
           end
         end
         b.tag("ram:PostalTradeAddress") do

data/lib/einvoicing/invoice.rb

@@ -7,8 +7,8 @@ module Einvoicing
   # Core invoice model. All monetary values are in the invoice currency.
   #
   # @example
-  #   seller = Einvoicing::Party.new(name: "Acme SAS", siren: "123456789", vat_number: "FR12123456789")
-  #   buyer  = Einvoicing::Party.new(name: "Client SA", siren: "987654321")
+  #   seller = Einvoicing::Party.new(name: "Acme SAS", siren: "123456782", vat_number: "FR11123456782")
+  #   buyer  = Einvoicing::Party.new(name: "Client SA", siren: "987654316")
   #   line   = Einvoicing::LineItem.new(description: "Consulting", quantity: 1, unit_price: 1000.00)
   #
   #   invoice = Einvoicing::Invoice.new(

data/lib/einvoicing/party.rb

@@ -10,8 +10,8 @@ module Einvoicing
   #     city: "Paris",
   #     postal_code: "75001",
   #     country_code: "FR",
-  #     siren: "123456789",
-  #     vat_number: "FR12123456789"
+  #     siren: "123456782",
+  #     vat_number: "FR11123456782"
   #   )
   Party = Data.define(:name, :street, :city, :postal_code, :country_code,
                       :siren, :siret, :vat_number, :email,

data/lib/einvoicing/validators/fr.rb

@@ -103,15 +103,38 @@ module Einvoicing
       # Validate a VAT number against the format of the country it belongs to.
       # The party's own country wins when known, so a French party still has to
       # carry an FR number; otherwise the number's own prefix decides.
-      # @param vat [String] e.g. "FR12123456789", "DE811907980"
+      # @param vat [String] e.g. "FR11123456782", "DE811907980"
       # @param country_code [String, nil] the party's country (BT-40 / BT-55)
       # @return [Boolean]
       def self.valid_vat_number?(vat, country_code: nil)
         str = vat.to_s.gsub(/\s/, "").upcase
-        pattern = EU_VAT_PATTERNS[country_code.to_s.upcase] || EU_VAT_PATTERNS[str[0, 2]]
-        return str.match?(pattern) if pattern
+        country = country_code.to_s.upcase
+        country = str[0, 2].to_s unless EU_VAT_PATTERNS.key?(country)
 
-        str.match?(NON_EU_VAT_RE)
+        pattern = EU_VAT_PATTERNS[country]
+        return str.match?(NON_EU_VAT_RE) unless pattern
+        return false unless str.match?(pattern)
+
+        country == "FR" ? valid_fr_vat_number?(str) : true
+      end
+
+      # A French VAT number carries a check key over its SIREN, so a typo that
+      # keeps the shape still has to be caught: FR83552032534 looks right and
+      # is not (the key for that SIREN is 27).
+      #
+      # The official structure is "FR" + 2 characters + 9 digits, and those two
+      # characters may be alphanumeric. Only a numeric key comes from the
+      # published formula, so an alphanumeric one is checked on its shape and
+      # on its SIREN alone — rejecting it would refuse valid invoices.
+      # @param vat [String] already stripped and upcased, matching VAT_RE
+      # @return [Boolean]
+      def self.valid_fr_vat_number?(vat)
+        key   = vat[2, 2]
+        siren = vat[4, 9]
+        return false unless valid_siren?(siren)
+        return true unless key.match?(/\A\d{2}\z/)
+
+        key.to_i == (12 + (3 * (siren.to_i % 97))) % 97
       end
 
       # A known French VAT rate, including the DOM and Corsican rates that the

data/lib/einvoicing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Einvoicing
-  VERSION = "0.9.0"
+  VERSION = "0.9.2"
 end

data/lib/einvoicing.rb

@@ -37,7 +37,7 @@ end
 # SIRET, TVA). Provides a Rails concern for ActiveRecord models.
 #
 # @example Quick start
-#   seller = Einvoicing::Party.new(name: "Acme SAS", siren: "356000000", vat_number: "FR83356000000")
+#   seller = Einvoicing::Party.new(name: "Acme SAS", siren: "356000000", vat_number: "FR39356000000")
 #   buyer  = Einvoicing::Party.new(name: "Client SA", siren: "552032534")
 #   line   = Einvoicing::LineItem.new(description: "Consulting", quantity: 1, unit_price: 1000.00)
 #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: einvoicing
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Nathan Le Ray