einvoice 1.4.0 → 1.5.0

data/lib/einvoice/provider.rb

@@ -1,7 +1,6 @@
 module Einvoice
   class Provider
-    attr_accessor *Configuration::VALID_OPTIONS_KEYS
-    attr_accessor :provider
+    attr_accessor(*Configuration::VALID_OPTIONS_KEYS)
 
     def initialize(options={})
       options = Einvoice.options.merge(options)

data/lib/einvoice/tradevan/model/issue_data.rb

@@ -52,7 +52,7 @@ module Einvoice
           :itemList
         ].freeze
 
-        attr_accessor *VALID_OPTIONS_KEYS
+        attr_accessor(*VALID_OPTIONS_KEYS)
 
         validates :companyUn, presence: true, length: { is: 8 }
         validates :orgId, presence: true, length: { is: 5 }
@@ -121,7 +121,7 @@ module Einvoice
         validates :invoiceType, allow_blank: true, length: { is: 2 }, inclusion: { in: %w(07 08) }, if: proc { self.type == 'G' }
 
         def payload
-          serializable_hash(except: [:errors, :validation_context], include: [:itemList])
+          serializable_hash(except: [:errors, :validation_context, :context_for_validation], include: [:itemList])
         end
       end
     end

data/lib/einvoice/tradevan/model/issue_item.rb

@@ -19,7 +19,7 @@ module Einvoice
           :description
         ]
 
-        attr_accessor *VALID_OPTIONS_KEYS
+        attr_accessor(*VALID_OPTIONS_KEYS)
 
         validates :saleIdentifier, presence: true, length: { maximum: 100 }
         validates :serialNumber, presence: true, length: { is: 4 }, numericality: true

data/lib/einvoice/tradevan/model/void_data.rb

@@ -12,7 +12,7 @@ module Einvoice
           :companyUn
         ].freeze
 
-        attr_accessor *VALID_OPTIONS_KEYS
+        attr_accessor(*VALID_OPTIONS_KEYS)
 
         validates :type, presence: true, length: { is: 1 }, inclusion: { in: %w(C I A) }
 
@@ -27,7 +27,7 @@ module Einvoice
         validates :allowancePaperReturned, presence: true, length: { is: 1 }, inclusion: { in: %w(Y N) }, if: proc { self.type == 'A' }
 
         def payload
-          serializable_hash(except: [:errors, :validation_context, :itemList])
+          serializable_hash(except: [:errors, :validation_context, :context_for_validation, :itemList])
         end
       end
     end

data/lib/einvoice/tradevan/provider.rb

@@ -1,7 +1,6 @@
 require 'base64'
 require 'openssl'
 
-require "einvoice/utils"
 
 require "einvoice/tradevan/model/base"
 require "einvoice/tradevan/model/issue_data"

data/lib/einvoice/version.rb

@@ -1,3 +1,3 @@
 module Einvoice
-  VERSION = "1.4.0"
+  VERSION = "1.5.0"
 end

data/lib/einvoice.rb

@@ -5,7 +5,6 @@ require "einvoice/configuration"
 require "einvoice/connection"
 require "einvoice/provider"
 require "einvoice/result"
-require "einvoice/utils"
 require "einvoice/version"
 
 require "einvoice/tradevan/provider"

data/lib/faraday/response/decode_tradevan.rb

@@ -1,12 +1,11 @@
+require 'base64'
+require 'json'
+require 'openssl'
+
 require 'faraday'
 
 module Faraday
   class Response::DecodeTradevan < Faraday::Middleware
-    dependency do
-      require 'base64' unless defined?(::Base64)
-      require 'openssl' unless defined?(::OpenSSL)
-    end
-
     def initialize(app, key)
       super(app)
       @key = key

data/lib/faraday/response/parse_xml.rb

@@ -0,0 +1,14 @@
+require 'faraday'
+require 'multi_xml'
+
+module Faraday
+  class Response::ParseXml < Faraday::Middleware
+    def on_complete(env)
+      return unless env[:body].is_a?(String) && !env[:body].strip.empty?
+
+      env[:body] = ::MultiXml.parse(env[:body])
+    end
+  end
+end
+
+Faraday::Response.register_middleware xml: Faraday::Response::ParseXml

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: einvoice
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - David Yun
@@ -13,30 +13,16 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: faraday_middleware
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: multi_xml
   requirement: !ruby/object:Gem::Requirement
@@ -79,20 +65,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: gyoku
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -113,14 +85,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -211,6 +183,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".coderabbit.yaml"
 - ".github/workflows/build.yml"
 - ".github/workflows/cron.yml"
 - ".gitignore"
@@ -239,13 +212,17 @@ files:
 - lib/einvoice/tradevan/provider.rb
 - lib/einvoice/tradevan/result.rb
 - lib/einvoice/tradevan/validator/issue_data_validator.rb
-- lib/einvoice/utils.rb
 - lib/einvoice/version.rb
 - lib/faraday/response/decode_tradevan.rb
+- lib/faraday/response/parse_xml.rb
 homepage: https://github.com/abookyun/einvoice
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/abookyun/einvoice
+  changelog_uri: https://github.com/abookyun/einvoice/blob/main/CHANGELOG.md
+  bug_tracker_uri: https://github.com/abookyun/einvoice/issues
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -253,14 +230,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.17
+rubygems_version: 4.0.20
 specification_version: 4
-summary: A API wrapper for Taiwan e-invoice services.
+summary: An API wrapper for Taiwan e-invoice services.
 test_files: []

data/lib/einvoice/utils.rb

@@ -1,13 +0,0 @@
-require "gyoku"
-
-module Einvoice
-  module Utils
-    def camelize(hash)
-      hash.deep_transform_keys { |k| k.to_s.camelize }
-    end
-
-    def encode_xml(hash)
-      ::Gyoku.xml(hash, key_converter: :none)
-    end
-  end
-end