eight_ball 3.3.3 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bfc17cd0254babae1c44b36250b03b7d03c9dd1bd0f694b4e502e8c38fb7f24
-  data.tar.gz: e9a30c977f05d0e2827092942e827582d61cd8d2972744125d548b4689ae965a
+  metadata.gz: f7013714e1fab00bbf56af0703c7212800aa3d664ebf34f6f296353c9f5e2c42
+  data.tar.gz: d670e0a056df163ad933f1afa757fb80ba2640bd728349ec830103f40ef921a9
 SHA512:
-  metadata.gz: e304c3d496a393cfb98728aee14093f6fb67cdf4d07c90e8a18b51616f48025460be8e006287cc192f756b647ea35995059055ba195fdb22a5fa16fe916d3988
-  data.tar.gz: e0f69c67ed4b8e53d9501174b49b46a75148b137bb06a4601a3fe3ef090172ec7504a348d56f6a995b6770d8f3bbafe2e65a8039ae5d6816b92e8e902b4bea45
+  metadata.gz: 2b86c9cd885352a5e60b6e1b699edfb476654eed89c21a1900f6220b45d2ce7bbd541062eab89599140de35c003770a8aacfe17f37180b56262321b4b1cb94f1
+  data.tar.gz: cd12202dda5daa1d284e501c9c4a3a5a214f5fd0dd6908aacc521e69e67713eb82494f62418141715b4cd8b953182a721dd705064baaf120a0a81319aee0a600

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [3.4.0]
+
+- Add an opt-in `coerce` boolean to the `list` condition. When `true`, values and the tested input are compared as strings, so a list authored with integers matches a string caller (and vice versa). Defaults to exact-type matching, so existing definitions are unchanged; the flag is serialized only when enabled.
+
 ## [3.3.3]
 
 - Add `.compact` before each `.map(&:to_wire)` so stray nil conditions are

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    eight_ball (3.3.3)
+    eight_ball (3.4.0)
       awrence (~> 1.1)
       logger (~> 1.7)
       plissken (~> 1.2)

data/README.md

@@ -83,6 +83,12 @@ A Condition must either be `true` or `false`. It describes when a Feature is ena
 - [Range](lib/eight_ball/conditions/range.rb): This condition is satisfied if the given value is within the specified range (inclusive).
 - [Percentage](lib/eight_ball/conditions/percentage.rb): This condition is satisfied for a deterministic, sticky subset of subjects sized to `percentage` percent. Bucketing is salted by the flag name so a subject is decorrelated across flags. Wire form: `{"type":"percentage","parameter":"account_id","percentage":<0..100>}`.
 
+#### List value coercion
+
+By default a `list` matches by exact type, so an integer value never matches a string (and vice versa). Set `coerce: true` on a list to compare both sides as strings, so an integer-authored list matches a string caller. The default stays exact, and the field is serialized only when enabled. Wire form: `{"type":"list","parameter":"account_id","values":[2,3],"coerce":true}`.
+
+Coercion is exact string comparison (`value.to_s`), not numeric or fuzzy: `1.0` does not match a `[1]` list, and `nil`/`""` share a string form. It is intended for scalar id/name lists. Cross-version note: a reader on a pre-`coerce` gem ignores the field and matches exactly, so a `coerce:true` flag can evaluate differently across gem versions until every reader is upgraded.
+
 #### Sticky percentage bucketing
 
 The `percentage` condition buckets a subject deterministically:

data/lib/eight_ball/conditions/list.rb

@@ -4,7 +4,7 @@ module EightBall::Conditions
   # The List Condition describes a list of acceptable values.
   # These can be strings, integers, etc.
   class List < Base
-    attr_reader :values
+    attr_reader :values, :coerce
 
     # Creates a new instance of a List Condition.
     #
@@ -16,30 +16,44 @@ module EightBall::Conditions
     #   The name of the parameter this Condition was created for (eg. "account_id").
     #   This value is only used by calling classes as a way to know what to pass
     #   into {satisfied?}.
+    # @option options [Boolean] :coerce
+    #   When true, compare values and the tested input as strings so that, eg.,
+    #   an integer list matches a string caller. Defaults to exact-type matching.
     def initialize(options = {})
       options ||= {}
 
       @values = Array(options[:values])
+      # Store a canonical true/nil so the wire never carries a stray non-boolean.
+      @coerce = options[:coerce] ? true : nil
       self.parameter = options[:parameter]
     end
 
     # @example
-    #   condition = new EightBall::Conditions::List.new [1, 'a']
+    #   condition = EightBall::Conditions::List.new(values: [1, 'a'])
     #   condition.satisfied? 1 => true
     #   condition.satisfied? 2 => false
     #   condition.satisfied? 'a' => true
     def satisfied?(value)
+      if @coerce
+        string_value = value.to_s
+        return values.any? { |v| v.to_s == string_value }
+      end
+
       values.include? value
     end
 
     def wire_fields
-      %i[values parameter]
+      # coerce before parameter so the wire key order matches the eight-ball-ts
+      # port (whose parameter is always emitted last), keeping the two byte-identical.
+      %i[values coerce parameter]
     end
 
     protected
 
     def state
-      super + [@values.sort]
+      # sort_by(&:to_s) so a mixed-type list (eg. the int/string values coerce
+      # is built for) does not raise ArgumentError in ==/hash.
+      super + [@values.sort_by(&:to_s), @coerce]
     end
   end
 end

data/lib/eight_ball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EightBall
-  VERSION = '3.3.3'
+  VERSION = '3.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eight_ball
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.4.0
 platform: ruby
 authors:
 - Rewind.io