ehsso 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78474617434e6d24addeef20df5cea2f193f858c233d80c06c9a5dcf43891536
-  data.tar.gz: 5b5a20eb87f5059234028faed9508f86fbadf4fb061e1ddf048b110041959b5e
+  metadata.gz: 208742122ef1e438a89f71a9b42fdade0b41156ef23ece58d63d74efd92abd4c
+  data.tar.gz: 1384cee640caab6534e660cb502ffd7ae6a35a305d9f5d45bf0fe14efb1c9a5e
 SHA512:
-  metadata.gz: 648fb5f32db29fe8f7694adc49b1ddc01307956eeabed1b7a86396b49828b5a82c4f161df027aea0265e2cf88199c8645e1d9f6cba6b2549e011ff1fa67944a3
-  data.tar.gz: df834d5550a94636da051dfce6ef88f89bf1abf4800c6803238358f7ff53fa33353f71a3acf59af8852c7a3ac4733a4556887d4ab8b1f312c8942aa292f8bd39
+  metadata.gz: e194bdceb811f29a4c11582fee77d69b855480d5e0a82efeef4fea45dd0a04b819ebf7fa170d39e82509b4e4e4f35674e2a1232e508364dad9f7fb483ae0fce7
+  data.tar.gz: f37a33ec3e472fd979df10c2da3e71165df52027301f1ee4a05025d3119cbf954e60b51391fb44c0ef5695709ea18658364ccbc0b155bd5774f17b1e01097466

data/.github/workflows/01_test.yml

@@ -25,7 +25,7 @@ jobs:
 
     name: Ruby ${{ matrix.ruby }}
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
 
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1

data/.github/workflows/02_release.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
     - name: Checkout current code
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
 
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog of ehsso
 
+## 0.8.0 / 2026-06-10
+
+* Strip whitespace from HTTP_NIBR* header values (reference, first name, last name, email)
+* Reject whitespace-only reference header as invalid
+* Use end_with? for role method checking in method_missing and respond_to_missing?
+* Fix typo in error message ("porperties" -> "properties")
+
 ## 0.7.1 / 2025-11-09
 
 * Enable Trusted Publishing

data/ehsso.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 3.1"
 
-  spec.add_development_dependency "bundler", "~> 2.3"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.12"
   spec.add_development_dependency "rails", ">= 6.1"
@@ -31,5 +30,5 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency("typhoeus", "~> 1.5")
   spec.add_runtime_dependency("logger", "~> 1.7")
-  spec.add_runtime_dependency("bigdecimal", "~> 3.2")
+  spec.add_runtime_dependency("bigdecimal", "~> 4.0")
 end

data/lib/ehsso/person.rb

@@ -32,13 +32,11 @@ module Ehsso
 
     # you can use methods like guest?, user?, operator?, administrator? etc.
     def method_missing(method)
-      raise "Method [#{method}] not defined or allowed" unless method[-1] == "?"
+      raise "Method [#{method}] not defined or allowed" unless method.end_with?("?")
       @roles.include?(method[0..-2].upcase)
     end
 
-    def respond_to_missing?(method, include_private = false)
-      true if method[-1] == "?"
-    end
+    def respond_to_missing?(method, include_private = false) = method.end_with?("?")
 
     def full_name
       return nil if last_name.nil? && first_name.nil?
@@ -49,19 +47,23 @@ module Ehsso
       person = Ehsso::Person.new
 
       # reference (mandatory)
-      if header["HTTP_NIBR521"].nil? || header["HTTP_NIBR521"].size == 0
-        person.last_error_message = "Unable to extract HTTP_NIBR* porperties from request header"
+      # to_s save in case of nil,
+      # strip removes spaces around the string
+      reference_value = header["HTTP_NIBR521"].to_s.strip
+      if reference_value.empty?
+        person.last_error_message = "Unable to extract HTTP_NIBR* properties from request header"
         return person
       end
 
-      person.reference = header["HTTP_NIBR521"].downcase
+      person.reference = reference_value.downcase
 
       [
         [:first_name=, "HTTP_NIBRFIRST"],
         [:last_name=, "HTTP_NIBRLAST"],
         [:email=, "HTTP_NIBREMAIL"]
       ].each do |method, key|
-        person.send(method, header[key]) if header[key] && header[key].strip.size > 0
+        value = header[key].to_s.strip
+        person.send(method, value) unless value.empty?
       end
 
       person

data/lib/ehsso/version.rb

@@ -1,3 +1,3 @@
 module Ehsso
-  VERSION = "0.7.1"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ehsso
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Thomas Steiner
@@ -9,20 +9,6 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -127,14 +113,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
 description: EH Single Sign On
 email:
 - thomas.steiner@ikey.ch