ehpt 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fb8d4c1fb9c87fd89ae55444f3f8cd7f3a7bc83e6de0924b91f0d1930ee8908
-  data.tar.gz: 5a5c317ffd25042a9aeede1dc8fe1f8122188f1e8a41ecd5245a1ae620ce6990
+  metadata.gz: 278b527d924ee5cef6328be96682e18250fa30d449cec2a8f9aa3abe4ec35603
+  data.tar.gz: 65736a6878779bda11a0d3a33d979855058a2035666b810cfa262ebbb13f8c4d
 SHA512:
-  metadata.gz: 89956c440258c42310af997979c343152222469cc01f801fbf53558edee233d5a1cc976a80a2c6c013dd4cd52705553bc8ae7fa038dd953be51ba7a9fd00a7b1
-  data.tar.gz: b41201119b1f05296d1c9ed1a2e84de882b523d3512c6c157fd97eefa5e5159f2475d378eeea003b2547eb966a1d16042e43e4b3b641a8d32e3994b23d3a7c96
+  metadata.gz: 2849d58b9de11b409b8b0e4adc251f8d6894c5fb3472f9db448234a5922c77bf9cad5f1ba4e42136c45cc423b8ea308033a55f1367e9e5ba58e7d2fac3ff0c9e
+  data.tar.gz: fbb28dd01aa013215d0fdd3defa1ae7313395725ab7455dca5f02285dd93856ec9a78b1bdca5abe0c47f381a3f0847c9b33ee4778232f92b0d565c9a9fed2664

data/lib/ehpt.rb

@@ -3,24 +3,25 @@ require 'ehpt/get_project'
 require 'ehpt/create_stories'
 
 class Ehpt
-  attr_reader :csv_content, :project
+  attr_reader :csv_file, :project
 
   def initialize(csv_file, token, project_id)
-    @csv_content = File.read(csv_file)
-    @project = get_project(token, project_id)
+    @csv_file = csv_file
+    @project = get_project_by(token, project_id)
   end
 
   def call
-    stories_creator = Ehpt::CreateStories.new(csv_content, project)
+    stories_creator = Ehpt::CreateStories.new(csv_file, project)
     stories_creator.call
+    puts "Done"
     if stories_creator.error?
-      raise StandardError, stories_creator.errors
+      puts "Errors: #{stories_creator.errors}"
     end
   end
 
   private
 
-  def get_project(token, project_id)
+  def get_project_by(token, project_id)
     project_getter = Ehpt::GetProject.new(token, project_id)
     project_getter.call
 
@@ -28,7 +29,7 @@ class Ehpt
       raise StandardError, project_getter.errors
     end
 
-    puts "Found project #{project_getter.data.name}"
+    puts "Found project: #{project_getter.data.name}"
     project_getter.data
   end
 end

data/lib/ehpt/create_stories.rb

@@ -4,7 +4,7 @@ require 'ehpt/create_story'
 
 class Ehpt
   class CreateStories < Base
-    attr_reader :csv_content, :project
+    attr_reader :csv_file, :project
 
     ARRAY_TYPE_ATTRIBUTES = %w[ labels tasks pull_requests branches blockers comments reviews ]
 
@@ -14,35 +14,34 @@ class Ehpt
 
     FLOAT_TYPE_ATTRIBUES = %w[ estimate ]
 
-    def initialize(csv_content, project)
-      @csv_content = csv_content
+    def initialize(csv_file, project)
+      @csv_file = csv_file
       @project = project
       super
     end
 
     def call
-      validate_csv_content!
+      validate_csv_file!
       create_stories unless error?
-      puts "Done"
     rescue StandardError => e
       errors << e.message
     end
 
     private
 
-    def validate_csv_content!
-      if csv_content.blank?
-        @errors << 'CSV content is empty'
-      end
-      puts "Read CSV done"
+    def validate_csv_file!
+      @errors << 'Input file must be a csv file' if File.extname(csv_file) != '.csv'
+      @errors << 'CSV content is empty' if File.zero?(csv_file)
     end
 
     def create_stories
-      CSV.parse(csv_content, headers: true) do |row|
+      CSV.foreach(csv_file, headers: true) do |row|
         story_attrs = create_story_attributes(row)
         story_creator = Ehpt::CreateStory.new(project, story_attrs)
         story_creator.call
-        if story_creator.error?
+        if story_creator.success?
+          puts "Created story: #{story_creator.data.name}"
+        else
           @errors = @errors.concat(story_creator.errors)
         end
       end

data/lib/ehpt/create_story.rb

@@ -13,7 +13,6 @@ class Ehpt
     def call
       create_story
       prefix_story_name_with_id
-      puts "Created story: #{@story.name}"
     rescue StandardError => e
       errors << e.message
     end
@@ -21,12 +20,12 @@ class Ehpt
     private
 
     def create_story
-      @story = project.create_story(story_attrs)
+      @data = project.create_story(story_attrs)
     end
 
     def prefix_story_name_with_id
-      @story.name = [@story.id.to_s.split(//).last(3).join, @story.name].join(' - ')
-      @story.save
+      @data.name = [@data.id.to_s.split(//).last(3).join, @data.name].join(' - ')
+      @data.save
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ehpt
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - phamhoaivu911