egree 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98bec1b0ecfa88f62e76834ca60a944db74a6050
-  data.tar.gz: 45bb21a233e1b39a713a5028e3a62d098a80cbaf
+  metadata.gz: a0f2d7c80d917dd99f8e55c4e15384dcee04eccb
+  data.tar.gz: d0655650a9da89c3812b73e8700ef321a5ab7a3b
 SHA512:
-  metadata.gz: 6eed8cb22da3db1d3c632c27014b665bef0e35fe881ae47b282a6cdd7984c5513997876530c73c1947cbe4d3e4297f09d81eeb1e678d8dfdfd93bf1ae8c98900
-  data.tar.gz: f01926797af2159b14fdc571a8187c6aa07e05b5658f8a19c185626682cece3c4103d89493f5ab8828bb18871aab4d5e718a28da0b0544f24d52d082cab9b586
+  metadata.gz: 4d61499c6c2280e750e57045b9bc9b58445347f5cf6a64e51b66a2cafd1f993176b3390b57c04063b342d3e763de6a1589b0ece507e1b179f9e007b8ad701a25
+  data.tar.gz: 035356b9a7955d67d5d8e037c7c7c745854e4924715b0f5072d1ca8a1c41ae9d09ddb5e97ba4996f2d56c0de42fca91ca18e53b530dae74ad682e3507f5834f7

data/README.md

@@ -1,6 +1,6 @@
-[![Build Status](https://travis-ci.org/joeljunstrom/egree-ruby.svg?branch=master)](https://travis-ci.org/joeljunstrom/egree-ruby)
-[![Code Climate](https://codeclimate.com/github/joeljunstrom/egree-ruby/badges/gpa.svg)](https://codeclimate.com/github/joeljunstrom/egree-ruby)
-[![Test Coverage](https://codeclimate.com/github/joeljunstrom/egree-ruby/badges/coverage.svg)](https://codeclimate.com/github/joeljunstrom/egree-ruby)
+[![Build Status](https://travis-ci.org/Oktavilla/egree-ruby.svg?branch=master)](https://travis-ci.org/Oktavilla/egree-ruby)
+[![Code Climate](https://codeclimate.com/github/Oktavilla/egree-ruby/badges/gpa.svg)](https://codeclimate.com/github/Oktavilla/egree-ruby)
+[![Test Coverage](https://codeclimate.com/github/Oktavilla/egree-ruby/badges/coverage.svg)](https://codeclimate.com/github/Oktavilla/egree-ruby)
 [![Gem Version](https://badge.fury.io/rb/egree.svg)](http://badge.fury.io/rb/egree)
 
 # Egree
@@ -25,11 +25,18 @@ signature_case.add_party Egree::Party.new_with_attributes({
 signature_case.add_document Egree::Document.new "/some/path/file.pdf"
 
 result = egree.create_case(signature_case, {
+  # Egree sends a POST with the signed case as the JSON body when the signing process is finished.
   postback_url: "https://example.com/my-endpoint",
   continue: {
+    # user ends up here after finishing the signing process
     url: "http://example.com/user-endpoint",
     auto: true
-  }
+  },
+  # User ends up here when cancelling, at the moment there is no cancel callback
+  cancel_url: "http://example.com/user-canceled",
+  # Procedure can be ”default” or ”form”, this changes some copy in the Egree interface.
+  # defaults to ”default”
+  procedure: "form"
 })
 
 if result.success?

data/egree.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Joel Junström"]
   spec.email         = ["joel.junstrom@oktavilla.se"]
   spec.summary       = %q{Client for the Egree API}
-  spec.homepage      = "https://github.com/joeljunstrom/egree-ruby"
+  spec.homepage      = "https://github.com/Oktavilla/egree-ruby"
   spec.license       = "MIT"
 
   spec.required_ruby_version = "~> 2.0"

data/lib/egree/api_mappers/case_options_mapper.rb

@@ -36,6 +36,8 @@ module Egree
       def self.mappers
         {
           postback_url: "CaseFinishedCallbackUrl",
+          cancel_url: "CancelUrl",
+          procedure: "Procedure",
           locale: ->(value) {
             { "Culture" => LOCALES.call(value) }
           },

data/lib/egree/document.rb

@@ -5,16 +5,17 @@ module Egree
   end
 
   class Document
-    attr_reader :path, :username, :password
+    attr_reader :path, :filename, :username, :password
 
-    def initialize path, username: nil, password: nil
+    def initialize path, filename: nil, username: nil, password: nil
       @path = path
+      @filename = filename
       @username = username
       @password = password
     end
 
     def filename
-      File.basename path
+      @filename || File.basename(path)
     end
 
     def size

data/lib/egree/version.rb

@@ -1,3 +1,3 @@
 module Egree
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/egree/api_mappers/case_options_mapper_spec.rb

@@ -11,6 +11,18 @@ module Egree
           })
         end
 
+        it "translates cancel_url to CancelUrl" do
+          expect(CaseOptionsMapper.to_api(cancel_url: "http://example.com")).to eq({
+            "CancelUrl" => "http://example.com"
+          })
+        end
+
+        it "translates procedure to Procedure" do
+          expect(CaseOptionsMapper.to_api(procedure: "form")).to eq({
+            "Procedure" => "form"
+          })
+        end
+
         describe "locale" do
           it "translates locale to Culture allowing sv, fi and en" do
             { "sv" => "sv-SE", "fi" => "fi-FI", "en" => "en-US" }.each do |key, locale|

data/spec/egree/client/create_case_spec.rb

@@ -43,6 +43,8 @@ module Egree
               url: "http://example.com/thanks",
               auto: true
             },
+            cancel_url: "http://example.com/sorry",
+            procedure: "form",
             locale: "sv"
           })
 

data/spec/egree/document_spec.rb

@@ -7,13 +7,26 @@ module Egree
       File.join(Dir.pwd, "spec/fixtures/agreement.pdf")
     end
 
+    let :fixture_contents do
+      File.read(fixture_path)
+    end
+
+
     describe "with a local file" do
       let :document do
         Document.new fixture_path
       end
 
-      specify "#filename" do
-        expect(document.filename).to eq "agreement.pdf"
+      describe "#filename" do
+        it "defaults to the file's basename" do
+          expect(document.filename).to eq "agreement.pdf"
+        end
+
+        it "can be set in the constructor" do
+          document = Document.new fixture_path, filename: "special-agreement.pdf"
+
+          expect(document.filename).to eq "special-agreement.pdf"
+        end
       end
 
       specify "#size" do
@@ -30,14 +43,6 @@ module Egree
     end
 
     describe "#with an url" do
-      let :fixture_path do
-        File.join(Dir.pwd, "spec/fixtures/agreement.pdf")
-      end
-
-      let :fixture_contents do
-        File.read(fixture_path)
-      end
-
       before do
         stub_request(:get, "http://example.com/files/remote_agreement.pdf").to_return({
           status: 200,
@@ -62,7 +67,6 @@ module Egree
       end
 
       it "has the file data encoded as base64" do
-        fixture_path = File.join(Dir.pwd, "spec/fixtures/agreement.pdf")
         expect(document.data).to eq Base64.encode64(fixture_contents)
       end
 
@@ -109,7 +113,7 @@ module Egree
     end
 
     it "adds form fields"  do
-      document = Document.new fixture_path
+      document = Document.new fixture_contents
       form_field = double "FormField", name: "FieldName", value: "Some Value"
 
       document.add_form_field form_field

data/spec/fixtures/cassettes/Egree_Client/_create_case/valid_case.yml

@@ -23,17 +23,19 @@ http_interactions:
             {
               "Name": "First Last",
               "EmailAddress": "name@example.com",
-              "SocialSecurityNumber": "5212172760"
+              "SocialSecurityNumber": "6907183385"
             }
           ],
           "AllowedSignatureTypes": [
             "touch"
           ],
-          "CaseReferenceId": "238c0cc3-8c66-4ff4-bf75-65ee264b1001",
+          "CaseReferenceId": "bc5db0db-f9eb-4eaf-9e9a-28bd388d6709",
           "CaseFinishedCallbackUrl": "http://example.com/postback",
           "ContinueName": "Back to the site",
           "ContinueUrl": "http://example.com/thanks",
           "ContinueAuto": true,
+          "CancelUrl": "http://example.com/sorry",
+          "Procedure": "form",
           "Culture": "sv-SE"
         }
     headers:
@@ -57,16 +59,16 @@ http_interactions:
       Strict-Transport-Security:
       - max-age=31536000
       Set-Cookie:
-      - ASP.NET_SessionId=xlsxyoeej5dfrorj3uwk2tzc; path=/; HttpOnly
+      - ASP.NET_SessionId=zfvvwbympf0ovrovwd1cru1t; path=/; HttpOnly
       X-Aspnet-Version:
       - 4.0.30319
       Date:
-      - Fri, 03 Oct 2014 09:12:40 GMT
+      - Mon, 17 Nov 2014 14:56:25 GMT
       Content-Length:
       - '0'
     body:
       encoding: UTF-8
       string: ''
     http_version: 
-  recorded_at: Fri, 03 Oct 2014 09:13:19 GMT
+  recorded_at: Mon, 17 Nov 2014 14:56:44 GMT
 recorded_with: VCR 2.9.2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: egree
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Joel Junström
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-03 00:00:00.000000000 Z
+date: 2014-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -177,7 +177,7 @@ files:
 - spec/fixtures/cassettes/Egree_Client/_get_case_url/case_exists.yml
 - spec/fixtures/cassettes/Egree_Client/_get_case_url/case_missing.yml
 - spec/spec_helper.rb
-homepage: https://github.com/joeljunstrom/egree-ruby
+homepage: https://github.com/Oktavilla/egree-ruby
 licenses:
 - MIT
 metadata: {}
@@ -197,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Client for the Egree API