egn 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a86c041349bc20394ea046da1a9d4a777dde322b
-  data.tar.gz: 69a89c71ad2e3d9df349b22af0c0fe6ca0867a71
+  metadata.gz: 8cec4b145317730625a2ecf4a0697138901a586d
+  data.tar.gz: 68bda640e1e48d67e1d306b172ec08d1e1f42a55
 SHA512:
-  metadata.gz: 99c8f0cc69329cc40f4b0898953898554b5ac16614abee4563ffddd6fa6eb9a1e4948a0e72b9f1e944ea054afee2f8fea4c38a4e5165b6a8a487a3d3ef1c9d68
-  data.tar.gz: 210c8a9827e4bd59e8df12020283642f4d032e69eec08e9e9f0e9df7735fa7ed727024cae1996832fe2d08e726f4d747d598e099098ad6cae25df3d2604ca553
+  metadata.gz: 7e20300f2867147ee57fbf0a4a5208e47b2e159f75666df2d800c643fc4b1b737634cfc709c2e9754f9358242c3a8bfe7802d1f8ba31a352fc32c9b06ab843bf
+  data.tar.gz: 821ef286a560a0e97ddd3cfe6696725d0747be5ccb20181c266938792bf8ebcc09b84d62ebd22aedacffee88722c96b19bd3fd974550814a958bb5b0094e5b21

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 rvm:
-  - "1.9.3"
-  - "2.0.0"
-  - "2.1.0"
+  - "2.2.7"
+  - "2.3.4"
+  - "2.4.1"
 script: bundle exec rspec spec

data/README.md

@@ -10,9 +10,9 @@ information.
 ## Installation
 
 Add this line to your application's Gemfile:
-
-    gem 'egn'
-
+```ruby
+gem 'egn'
+```
 And then execute:
 
     $ bundle
@@ -23,51 +23,53 @@ Or install it yourself as:
 
 ## Usage
 
-    require 'egn'
+```ruby
+require 'egn'
 
-    # Quickly generate a random number
-    Egn.generate
-    => '6101047500'
+# Quickly generate a random number
+Egn.generate
+=> '6101047500'
 
-    # Validate a given number
-    Egn.validate('6101047500')
-    => true
+# Validate a given number
+Egn.validate('6101047500')
+=> true
 
-    # Create an new EGN object with a random number
-    egn = Egn::Egn.new
-    => 9212094524
+# Create an new EGN object with a random number
+egn = Egn::Egn.new
+=> 9212094524
 
-    # OR generate EGN for a specific date
-    egn = Egn::Egn.new(year: 1945, month: 5, day: 8)
-    => 4505085346
+# OR generate EGN for a specific date
+egn = Egn::Egn.new(year: 1945, month: 5, day: 8)
+=> 4505085346
 
-    # OR parse an existing one
-    egn = Egn.parse('6101047500')
-    => 6101047500
+# OR parse an existing one
+egn = Egn.parse('6101047500')
+=> 6101047500
 
-    egn.birth_date
-    => #<Date: 1961-01-04 ((2437304j,0s,0n),+0s,2299161j)>
+egn.birth_date
+=> #<Date: 1961-01-04 ((2437304j,0s,0n),+0s,2299161j)>
 
-    egn.year
-    => 1961
+egn.year
+=> 1961
 
-    egn.month
-    => 1
+egn.month
+=> 1
 
-    egn.day
-    => 10
+egn.day
+=> 10
 
-    egn.gender # egn.sex can also be used
-    => :male
+egn.gender # egn.sex can also be used
+=> :male
 
-    egn.gender(format: :char)
-    => 'm'
+egn.gender(format: :char)
+=> 'm'
 
-    egn.gender(format: :number)
-    => 1
+egn.gender(format: :number)
+=> 1
 
-    egn.valid?
-    => true
+egn.valid?
+=> true
+```
 
 ## Contributing
 

data/lib/egn/util.rb

@@ -7,8 +7,8 @@ module Egn
     # be determined by examining the month.
     # The rules are as follows:
     # * For people born in 1900..1999 the month does not change
-    # * For people born in 1800..1899 the month increases by 20 (e.g January is 21)
-    # * For people born in 2000..2099 the month increases by 40 (e.g December is 52)
+    # * For people born in 1800..1899 the month is increased by 20 (e.g January is 21)
+    # * For people born in 2000..2099 the month is increased by 40 (e.g December is 52)
     def self.determine_date(year, month)
       case month
       when (1..12)
@@ -24,7 +24,7 @@ module Egn
       [year.to_i, month]
     end
 
-    # More information on the formula: http://www.grao.bg/esgraon.html
+    # More information on the formula: http://www.grao.bg/esgraon.html#section2
     def self.egn_checksum(egn)
       sum = egn.chars.map(&:to_i).zip(WEIGHTS).map { |n| n.reduce(:*) }.reduce(:+)
 

data/lib/egn/validator.rb

@@ -17,6 +17,10 @@ module Egn
     def validate
       return false unless @egn.length == 10
       return false unless Date.valid_date?(@year, @month, @day)
+      
+      # Gregorian calendar adoption in 1916 in Bulgaria
+      # 31/03/1916 > +13 days > 14/04/1916
+      return false if @year == 1916 && @month == 4 && @day <= 13
 
       # Calculate the checksum and check if the given one is correct
       checksum = Util.egn_checksum(@egn[0, 9])

data/lib/egn/version.rb

@@ -1,3 +1,3 @@
 module Egn
-  VERSION = '1.3.3'
+  VERSION = '1.3.4'
 end

data/spec/egn/validator_spec.rb

@@ -10,6 +10,10 @@ describe Egn::Validator do
     it 'fails for incorrect dates' do
       expect(Egn::Validator.validate('6101347500')).to be_false
     end
+    
+    it 'fails for dates during gregorian calendar adoption' do
+      expect(Egn::Validator.validate('1604010886')).to be_false
+    end
 
     it 'checks 10 000 of the generated numbers' do
       Array.new(10_000) { |_| Egn.generate }.each do |egn|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: egn
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - gmitrev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-28 00:00:00.000000000 Z
+date: 2017-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: An easy way to generate and validate EGN numbers and parse them for useful