efo_nelfo 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 894a44091085c1483965076057f66f3d3a8ed7fe
-  data.tar.gz: 1d26149077017f057cb31df8c8029c7ee226cd26
+  metadata.gz: 78ab950b02b7049200da1e0e5de3b2e652dafd54
+  data.tar.gz: 179c82aa18e4812ac7850cdcf368bad9dfa66b43
 SHA512:
-  metadata.gz: dacd19af0a3f6ef369a723820d03c7787ff2989f946e89e3ece4900c97818fd8fa0c485c94b476e92ab3757ebf8d594d2b7c1590de4e4a84249cbb0344129848
-  data.tar.gz: 70e158b44c968e0f2056adfbccf27b1e8e8d6338dc6d1f99e9b9e462a55469ad634a23407896f4f674768e0d65ad9a9f87e72df2d748654f5b8ef16db183566a
+  metadata.gz: a0d8371775eed749b0f1ee7351f4cdb03fffa79d4d9bc806394e034e9f7b623d980aa535b37c55aa21472743915b73e34b65c14023d94f3518de6d0699b40f31
+  data.tar.gz: d18f93c56c3b188942a84ee39a6b5b7269f38fe732c53f799f0c00c2fe6463d8bc828e646afa30fe4a5241bf05c6b42a2f3dab6d5b1d4d2b8a96b520025d8487

data/lib/efo_nelfo/post_type.rb

@@ -35,10 +35,18 @@ module EfoNelfo
         self.for(hash[:post_type], hash[:version]).new(hash)
       end
 
+      def parse(csv)
+        new EfoNelfo::Reader::CSV.new(data: csv).first
+      end
+
     end
 
     def initialize(*args)
-      initialize_attributes(*args)
+      if args && args.first.is_a?(Array)
+        initialize_attributes Hash[properties.keys.zip(args.first)]
+      else
+        initialize_attributes(*args)
+      end
     end
 
     def post_type

data/lib/efo_nelfo/reader/csv.rb

@@ -29,7 +29,7 @@ module EfoNelfo
 
       def parse
         # Create the head object based on the first row
-        head = parse_head csv.first
+        head = parse_head first
         head.source = @data
 
         # Read rest of the file and add them to the head
@@ -38,28 +38,23 @@ module EfoNelfo
           klass = EfoNelfo::PostType.for row[0], head.version
           next if klass.nil?
 
-          line = initialize_object_with_properties klass, row
-          head.add line
+          head.add klass.new(row)
         end
 
         head
       end
 
+      # Returns the first row of the csv file
+      def first
+        csv.first
+      end
+
       private
 
       def parse_head(row)
         klass = EfoNelfo::PostType.for row[0], row[2]
         raise EfoNelfo::UnsupportedPostType.new("Don't know how to handle v#{row[2]} of #{row[0]}") if klass.nil?
-
-        initialize_object_with_properties klass, row
-      end
-
-      def initialize_object_with_properties(klass, columns)
-        object = klass.new
-        object.class.properties.each_with_index do |property, i|
-          object.send "#{property.first}=", columns[i]
-        end
-        object
+        klass.new row
       end
 
     end

data/lib/efo_nelfo/version.rb

@@ -1,3 +1,3 @@
 module EfoNelfo
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

data/spec/spec_helper.rb

@@ -15,3 +15,16 @@ end
 def csv(filename)
   File.expand_path("../samples/#{filename}", __FILE__)
 end
+
+# Add 'its' to minitest - copied from https://github.com/agileanimal/its-minitest (gem doesn't work)
+class MiniTest::Spec
+  def self.its attribute, &block
+    describe "verify subject.#{attribute} for"  do
+      let(:inner_subject) { subject.send(attribute) }
+
+      it "verify subject.#{attribute} for" do
+        inner_subject.instance_eval &block
+      end
+    end
+  end
+end

data/spec/vl_spec.rb

@@ -4,6 +4,31 @@ describe EfoNelfo::V40::VL do
 
   let(:vl) { EfoNelfo::V40::VL.new }
 
+  describe '.parse' do
+    let(:csv) { "VL;4;9455483;10-13 AF-2 Armaflex rull/krt.;35 mtr/krt. Cellegummi;2;MTR;METER;3500;10000;20130401;2;;P94551;ARMACELL G;;J;;;B" }
+    subject   { EfoNelfo::V40::VL.parse csv }
+
+    it { subject.must_be_instance_of EfoNelfo::V40::VL }
+
+    its(:product_type) { must_equal 4 }
+    its(:post_type) { must_equal "VL" }
+    its(:product_type) { must_equal 4 }
+    its(:product_number) { must_equal "9455483" }
+    its(:name) { must_equal "10-13 AF-2 Armaflex rull/krt." }
+    its(:description) { must_equal "35 mtr/krt. Cellegummi" }
+    its(:unit) { must_equal 2 }
+    its(:price_unit) { must_equal "MTR" }
+    its(:price_unit_desc) { must_equal "METER" }
+    its(:price) { must_equal 3500 }
+    its(:amount) { must_equal 10000 }
+    its(:price_date) { must_equal Date.new(2013,4,1) }
+    its(:status) { must_equal 2 }
+    its(:block_number) { must_be_nil }
+    its(:discount_group) { must_equal "P94551" }
+    its(:fabrication) { must_equal "ARMACELL G" }
+    its(:type) { must_be_nil }
+  end
+
   it "#weight returns the weight in gram" do
     vl.info << { field: 'VEKT', value: 250 }
     vl.weight.must_equal 250

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: efo_nelfo
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Gudleik Rasch