effective_test_bot 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b4f8b032c99230c6fcee477b0b80ace59c6d2bfae02936c1e4b0e3c6b366233
-  data.tar.gz: 2826d465044bdd27544a4d8dc4be38f2ce78109fafabc953d9c6541b6e6f5e07
+  metadata.gz: 914a9df1a597575ab9150aeed63569eb8d76066822f8cdb746a7204f1235d5fe
+  data.tar.gz: 240e22997753bf272671a9ceb8709b863052d3039f55b84fe673cdc7b029f2dc
 SHA512:
-  metadata.gz: 16cea9eb462395b662a10005cd577a305c67b2f405801cd5ed48d0e6478d4a5a30f72cb662ab7f9d9e71e22df614a971cdf4e5cc5e0f62519f501ba4316355b7
-  data.tar.gz: 8fdac06110cdde7a0e7ef41eb24e4f67156c1afad7c82856e1c15b0c36c2eaf2d9abba2df7a49a189c0d9f3a4ab8bbeac16f4486a4083eb46179701b5dd62d3e
+  metadata.gz: 62624653851827706582229b697e9cfeb7644e3a11372c832432c96acccd1de929ef6dd676b023c540c004d376b4cceb08d936f2bfcd2631a4e0fac5a04e3cdf
+  data.tar.gz: 5054abd3cfe3d42acca6b467349365d41221afe0381112939839e6847725d27ad905b1a44b1ef9c312d86acffe427521ad0c827a003ac943476bdbd2847b6a0e

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.7.0'.freeze
+  VERSION = '1.7.1'.freeze
 end

data/test/support/effective_test_bot_form_helper.rb

@@ -19,17 +19,24 @@ module EffectiveTestBotFormHelper
     true
   end
 
-  def submit_page(label = nil, last: false, assert_path_changed: true, debug: false)
-    submit_form(label, last: last, assert_path_changed: assert_path_changed, debug: debug)
+  def submit_page(label = nil, last: false, assert_path_changed: true, wait: true, debug: false)
+    submit_form(label, last: last, assert_path_changed: assert_path_changed, wait: wait, debug: debug)
+  end
+
+  def submit_ajax_form(label = nil, last: false, assert_path_changed: false, wait: false, debug: false)
+    submit_form(label, last: last, assert_path_changed: assert_path_changed, wait: wait, debug: debug)
   end
 
   # This submits the form, while checking for html5 form validation errors and unpermitted params
-  def submit_form(label = nil, last: false, assert_path_changed: false, debug: false)
+  def submit_form(label = nil, last: false, assert_path_changed: false, wait: true, debug: false)
     assert_no_html5_form_validation_errors unless test_bot_skip?(:no_html5_form_validation_errors)
     assert_jquery_ujs_disable_with(label) unless test_bot_skip?(:jquery_ujs_disable_with)
 
-    # Add a unique class to the body before submission
-    page.execute_script("document.body.classList.add('effective-test-bot-submitting-form');")
+    # Add a div to track form submission
+    if wait
+      page.execute_script("$('body').prepend($('<div id=\"effective-test-bot-submitting-form\"></div>'));")
+      page.assert_selector(:xpath, '//div[@id="effective-test-bot-submitting-form"]')
+    end
 
     before_path = page.current_path
     before_path = 'ignore' unless assert_path_changed
@@ -42,10 +49,23 @@ module EffectiveTestBotFormHelper
 
     assert_no_assigns_errors unless test_bot_skip?(:no_assigns_errors)
 
-    # Make sure the page has fully loaded afer submission
-    assert_no_selector('body.effective-test-bot-submitting-form', wait: Capybara.default_max_wait_time * 10)
     assert_no_current_path(before_path.to_s, wait: Capybara.default_max_wait_time * 10)
 
+    # Wait for form-submitting div to disappear via JS (not Capybara element)
+    if wait
+      begin
+        Timeout.timeout(Capybara.default_max_wait_time * 10) do
+          loop do
+            gone = page.evaluate_script("document.querySelector('#effective-test-bot-submitting-form') === null")
+            break if gone
+            sleep 0.1
+          end
+        end
+      rescue Timeout::Error
+        raise Timeout::Error, "Form submission did not disappear after #{Capybara.default_max_wait_time * 10} seconds. The form submission may have stalled or failed."
+      end
+    end
+
     assert_no_exceptions unless test_bot_skip?(:exceptions)
     assert_authorization unless test_bot_skip?(:authorization)
     assert_page_status unless test_bot_skip?(:page_status)
@@ -193,11 +213,14 @@ module EffectiveTestBotFormHelper
     elsif submit['data-confirm']
       page.accept_confirm { submit.click }
     else
-      submit.click
+      begin
+        submit.click
+      rescue => e
+        submit.click
+      end
     end
 
-    synchronize ? synchronize! : sleep(2)
-
+    synchronize! if synchronize
     save_test_bot_screenshot if EffectiveTestBot.screenshots?
 
     true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Code and Effect