effective_test_bot 1.1.23 → 1.1.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c5680e555e47bbf34f48eb0b94cde7030ea3620b89086ce240ef1ca26f2c104
-  data.tar.gz: 512d0f243668ccca14b34382cdf1f3f678a90a21ef35dfc5469351a7d4c76787
+  metadata.gz: 5590f0c1b7be5d9eae672f585d6171c64bc9a49a809b7deb63c3cb77c6d26180
+  data.tar.gz: bb8d8cea77300a83004d96d206a8f8ed8a11f96b7ddad4b71b71da7179f11f5b
 SHA512:
-  metadata.gz: eb95d66b4f2f04facf6e8c077ee21457dbece6cd811270483e41172af4bab60c7129c17b46a4bea2572dbbdf4b81142d913569d4598044b098aeaad3841d4601
-  data.tar.gz: 2724eed26fc9907c1153aa3b0f5a74100a63c554275d968d47e7ece8c2b1b5522255a11492aac9b899e5c14232b73eb4d614bdb57a702f1155cad716932bcf4c
+  metadata.gz: ebe2ca7bff109d9d3a844e734ab1d29112e0c88aca0c9bc7d0efc3324fb2a7c04a3947d90bb160195379d24a9f828aa9bf2483d7f2b8d6744a2da058841023b8
+  data.tar.gz: '09d8abd2735e66d95ece47b509022cfed74372faaca8543d7c202eaa602407eb69528ed5dad2178ee5aff2bcc6bca54797897b81395cbf918f823c4c3d721cc4'

data/config/test_helper.rb

@@ -2,6 +2,7 @@ ENV['RAILS_ENV'] ||= 'test'
 require_relative '../config/environment'
 
 require 'rails/test_help'
+require 'minitest/mock'
 require 'minitest/spec'
 require 'minitest/reporters'
 require 'minitest/fail_fast' if EffectiveTestBot.fail_fast?
@@ -10,6 +11,8 @@ class ActiveSupport::TestCase
   # Run tests in parallel with specified workers
   # parallelize(workers: :number_of_processors) if respond_to?(:parallelize)
 
+  include EffectiveTestBot::DSL
+
   fixtures :all               # Loads all fixtures in test/fixtures/*.yml
   extend Minitest::Spec::DSL  # For the let syntax
 end

data/lib/effective_test_bot.rb

@@ -66,7 +66,7 @@ module EffectiveTestBot
   end
 
   def self.gifs?
-    image_processing_class.present?
+    screenshots? && image_processing_class.present?
   end
 
   def self.image_processing_class
@@ -97,7 +97,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ENV['TOUR'].to_s != 'false'
     else
-      screenshots? && (tour_mode != false)
+      gifs? && (tour_mode != false)
     end
   end
 
@@ -106,7 +106,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ['extreme', 'debug'].include?(ENV['TOUR'].to_s.downcase)
     else
-      screenshots? && ['extreme', 'debug'].include?(tour_mode.to_s)
+      gifs? && ['extreme', 'debug'].include?(tour_mode.to_s)
     end
   end
 

data/lib/effective_test_bot/dsl.rb

@@ -3,6 +3,7 @@ module EffectiveTestBot
     extend ActiveSupport::Concern
 
     included do
+      # test/support/
       include EffectiveTestBotAssertions
       include EffectiveTestBotFormFaker
       include EffectiveTestBotFormFiller
@@ -12,6 +13,8 @@ module EffectiveTestBot
       include EffectiveTestBotScreenshotsHelper
       include EffectiveTestBotTestHelper
 
+      BasicObject.send :include, EffectiveTestBotMocks
+
       # test/test_botable/
       include BaseTest
       include CrudTest

data/lib/effective_test_bot/engine.rb

@@ -3,14 +3,14 @@ module EffectiveTestBot
     engine_name 'effective_test_bot'
 
     config.autoload_paths += Dir[
-      "#{config.root}/test/test_botable/", 
-      "#{config.root}/test/concerns/", 
+      "#{config.root}/test/test_botable/",
+      "#{config.root}/test/concerns/",
       "#{config.root}/test/support/"
     ]
 
     config.eager_load_paths += Dir[
-      "#{config.root}/test/test_botable/", 
-      "#{config.root}/test/concerns/", 
+      "#{config.root}/test/test_botable/",
+      "#{config.root}/test/concerns/",
       "#{config.root}/test/support/"
     ]
 

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.23'.freeze
+  VERSION = '1.1.28'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -123,6 +123,8 @@ module EffectiveTestBotAssertions
       error = page.driver.browser.manage.logs.get(:browser).first # headless_chrome
     rescue NotImplementedError
       return
+    rescue => e
+      return
     end
 
     if strict == false

data/test/support/effective_test_bot_form_faker.rb

@@ -5,6 +5,8 @@ require 'faker'
 module EffectiveTestBotFormFaker
   DIGITS = ('1'..'9').to_a
   LETTERS = %w(A B C E G H J K L M N P R S T V X Y) # valid letters of a canadian postal code, eh?
+  TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON']
+  FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF']
 
   # Generates an appropriately pseudo-random value for the given field
   # Pass in a Hash of fills to define pre-selected values
@@ -124,6 +126,9 @@ module EffectiveTestBotFormFaker
     when 'textarea', 'textarea_textarea'
       Faker::Lorem.paragraph
 
+    when 'input_hidden'
+      Faker::Lorem.paragraph
+
     when 'input_submit', 'input_search', 'input_button'
       nil
 
@@ -269,19 +274,11 @@ module EffectiveTestBotFormFaker
   end
 
   def truthy?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(value)
-    else
-      ActiveRecord::Type::Boolean.new.cast(value)
-    end
+    TRUE_VALUES.include?(value)
   end
 
   def falsey?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.include?(value)
-    else
-      ::ActiveRecord::Type::Boolean.new.cast(value) == false
-    end
+    FALSE_VALUES.include?(value)
   end
 
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -71,7 +71,9 @@ module EffectiveTestBotFormFiller
       end
 
       # Fill all fields now
-      fields = all('input,select,textarea', visible: false).reject { |field| seen[field_key(field)] }
+      fields = all('input,select,textarea', visible: false).reject do |field|
+        (seen[field_key(field)] rescue true)
+      end
 
       break unless fields.present?
 
@@ -113,6 +115,8 @@ module EffectiveTestBotFormFiller
           fill_input_file(field, value)
         when 'input_submit', 'input_search', 'input_button'
           skip_field_screenshot = true # Do nothing
+        when 'input_hidden'
+          fill_action_text_input(field, value)
         else
           raise "unsupported field type #{field_name}"
         end
@@ -130,6 +134,7 @@ module EffectiveTestBotFormFiller
     @filled_country_fields = nil
 
     save_test_bot_screenshot
+    true
   end
 
   def fill_input_text(field, value)
@@ -173,6 +178,15 @@ module EffectiveTestBotFormFiller
     end
   end
 
+  def fill_action_text_input(field, value)
+    return unless action_text_input?(field)
+
+    trix_id = field['id'].to_s.split('_trix_input_form').first
+    return unless trix_id.present?
+
+    try_script "document.querySelector(\"##{trix_id}\").editor.insertString(\"#{value}\")"
+  end
+
   def fill_input_select(field, value)
     if EffectiveTestBot.tour_mode_extreme? && select2_input?(field)
       try_script "$('select##{field['id']}').select2('open')"
@@ -273,6 +287,10 @@ module EffectiveTestBotFormFiller
     (field['class'].to_s.include?('ckeditor') || all("span[id='cke_#{field['id']}']", wait: false).present?)
   end
 
+  def action_text_input?(field)
+    field.tag_name == 'input' && field['type'] == 'hidden' && field['id'].to_s.include?('trix_input_form')
+  end
+
   def custom_control_input?(field) # Bootstrap 4 radios and checks
     field['class'].to_s.include?('custom-control-input')
   end
@@ -291,16 +309,25 @@ module EffectiveTestBotFormFiller
 
   def skip_form_field?(field)
     field.reload # Handle a field changing visibility/disabled state from previous form field manipulations
-
     field_id = field['id'].to_s
 
-    field_id.start_with?('datatable_') ||
-    field_id.start_with?('filters_scope_') ||
-    field_id.start_with?('filters_') && field['name'].blank? ||
-    (field.disabled? rescue true) || # Selenium::WebDriver::Error::StaleElementReferenceError: stale element reference: element is not attached to the page document
-    (!field.visible? && !ckeditor_text_area?(field) && !custom_control_input?(field) && !file_input?(field)) ||
-    ['true', true, 1].include?(field['data-test-bot-skip']) ||
-    (@test_bot_excluded_fields_xpath.present? && field.path.include?(@test_bot_excluded_fields_xpath))
+    return true if field_id.start_with?('datatable_')
+    return true if field_id.start_with?('filters_scope_')
+    return true if field_id.start_with?('filters_') && field['name'].blank?
+    return true if field['type'] == 'button'
+    return true if (field.disabled? rescue true) # Selenium::WebDriver::Error::StaleElementReferenceError: stale element reference: element is not attached to the page document
+    return true if ['true', true, 1].include?(field['data-test-bot-skip'])
+    return true if @test_bot_excluded_fields_xpath.present? && field.path.include?(@test_bot_excluded_fields_xpath)
+
+    if !field.visible?
+      return false if ckeditor_text_area?(field)
+      return false if custom_control_input?(field)
+      return false if file_input?(field)
+      return false if action_text_input?(field)
+      return true
+    end
+
+    false
   end
 
   def field_key(field)

data/test/support/effective_test_bot_mocks.rb

@@ -0,0 +1,31 @@
+# https://github.com/codeodor/minitest-stub_any_instance
+
+# included on BasicObject when test_helper calls include EffectiveTestBot::DSL
+module EffectiveTestBotMocks
+  def stub_any_instance(name, val_or_callable = nil, &block)
+    new_name = "__minitest_any_instance_stub__#{name}"
+    owns_method = instance_method(name).owner == self
+
+    class_eval do
+      alias_method new_name, name if owns_method
+
+      define_method(name) do |*args|
+        if val_or_callable.respond_to? :call then
+          instance_exec(*args, &val_or_callable)
+        else
+          val_or_callable
+        end
+      end
+    end
+
+    yield
+  ensure
+    class_eval do
+      remove_method name
+      if owns_method
+        alias_method name, new_name
+        remove_method new_name
+      end
+    end
+  end
+end

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -7,17 +7,15 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_screenshot
-    return unless EffectiveTestBot.screenshots?
-    return unless page.current_path.present?
-    
+    return unless EffectiveTestBot.gifs?
+    return unless (page.current_path rescue false).present?
+
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")
     true
   end
 
   def save_test_bot_failure_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
-
     return unless save_test_bot_screenshot
 
     Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
@@ -28,7 +26,6 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_tour_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
     return unless (@test_bot_screenshot_id || 0) > 0
 
@@ -42,9 +39,12 @@ module EffectiveTestBotScreenshotsHelper
   def without_screenshots(&block)
     original = EffectiveTestBot.screenshots
 
-    EffectiveTestBot.screenshots = false
-    yield
-    EffectiveTestBot.screenshots = original
+    begin
+      EffectiveTestBot.screenshots = false
+      yield
+    ensure
+      EffectiveTestBot.screenshots = original
+    end
   end
 
   protected

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.23
+  version: 1.1.28
 platform: ruby
 authors:
 - Code and Effect
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-21 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -160,6 +160,7 @@ files:
 - test/support/effective_test_bot_form_helper.rb
 - test/support/effective_test_bot_login_helper.rb
 - test/support/effective_test_bot_minitest_helper.rb
+- test/support/effective_test_bot_mocks.rb
 - test/support/effective_test_bot_screenshots_helper.rb
 - test/support/effective_test_bot_test_helper.rb
 - test/test_bot/system/application_test.rb
@@ -190,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: A shared library of rails model & system tests that should pass in every