effective_test_bot 1.1.20 → 1.1.25

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3b08d9844b09467fa3cf52e22b6f222eb9fea70ea191c74b8dde0551eeb7ff9
-  data.tar.gz: ecaba06f8fc693177a64d40e07a1e889f0778f47e2c95c91fd01af79b399819a
+  metadata.gz: c93ee6cbc4a6f2d015c6862cc56cb1fbf1c0a56eab77931996bf1f59d771196b
+  data.tar.gz: 27a906d8cc6eed02996b0d98297a0bd832af9f0f6199029eafb94bcc4eb8d26d
 SHA512:
-  metadata.gz: 046a7cfef56def1f21c26f6eabc2ffe2f5bda06fc338450e48f255344e02b9831d2bcb035d914ec5408ad0c8bd65ffe6db48d70a0015a0a7090d123ba2b5f310
-  data.tar.gz: b1da96c09ef212306805e9319830137bfea31f53cef631b216d30d7b0cb2af1b809d69ae247c9d5e1bf1b5167254faf3ee5a856748505839a3ae89bbda2c16f4
+  metadata.gz: 3243af9fc54f6f92a7e6a34f9690a97aac9b2c2b94b6deaf37bb2981a4bbadd26620900717e2de6ca88be90447c9558c944ac9dfd0e0944e7bcb440298fd2005
+  data.tar.gz: 71476e8e08e018a8a4111daabd9c1025fa14003f1079a190b35f8487103b9bbfaaa9990793515b559404993a74bd0fa24fc6728c6294155a1900ad942464b03e

data/config/test_helper.rb

@@ -2,6 +2,7 @@ ENV['RAILS_ENV'] ||= 'test'
 require_relative '../config/environment'
 
 require 'rails/test_help'
+require 'minitest/mock'
 require 'minitest/spec'
 require 'minitest/reporters'
 require 'minitest/fail_fast' if EffectiveTestBot.fail_fast?
@@ -10,6 +11,8 @@ class ActiveSupport::TestCase
   # Run tests in parallel with specified workers
   # parallelize(workers: :number_of_processors) if respond_to?(:parallelize)
 
+  include EffectiveTestBot::DSL
+
   fixtures :all               # Loads all fixtures in test/fixtures/*.yml
   extend Minitest::Spec::DSL  # For the let syntax
 end

data/lib/effective_test_bot.rb

@@ -66,7 +66,7 @@ module EffectiveTestBot
   end
 
   def self.gifs?
-    image_processing_class.present?
+    screenshots? && image_processing_class.present?
   end
 
   def self.image_processing_class
@@ -97,7 +97,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ENV['TOUR'].to_s != 'false'
     else
-      screenshots? && (tour_mode != false)
+      gifs? && (tour_mode != false)
     end
   end
 
@@ -106,7 +106,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ['extreme', 'debug'].include?(ENV['TOUR'].to_s.downcase)
     else
-      screenshots? && ['extreme', 'debug'].include?(tour_mode.to_s)
+      gifs? && ['extreme', 'debug'].include?(tour_mode.to_s)
     end
   end
 

data/lib/effective_test_bot/dsl.rb

@@ -3,6 +3,7 @@ module EffectiveTestBot
     extend ActiveSupport::Concern
 
     included do
+      # test/support/
       include EffectiveTestBotAssertions
       include EffectiveTestBotFormFaker
       include EffectiveTestBotFormFiller
@@ -12,6 +13,10 @@ module EffectiveTestBot
       include EffectiveTestBotScreenshotsHelper
       include EffectiveTestBotTestHelper
 
+      class BasicObject
+        include EffectiveTestBotMocks
+      end
+
       # test/test_botable/
       include BaseTest
       include CrudTest

data/lib/effective_test_bot/engine.rb

@@ -2,10 +2,17 @@ module EffectiveTestBot
   class Engine < ::Rails::Engine
     engine_name 'effective_test_bot'
 
-    config.autoload_paths += Dir["#{config.root}/test/test_botable/", "#{config.root}/test/concerns/", "#{config.root}/test/support/"]
-    # config.autoload_paths += Dir["#{config.root}/test/test_botable/**/"]
-    # config.autoload_paths += Dir["#{config.root}/test/concerns/**/"]
-    # config.autoload_paths += Dir["#{config.root}/test/support/**/"]
+    config.autoload_paths += Dir[
+      "#{config.root}/test/test_botable/",
+      "#{config.root}/test/concerns/",
+      "#{config.root}/test/support/"
+    ]
+
+    config.eager_load_paths += Dir[
+      "#{config.root}/test/test_botable/",
+      "#{config.root}/test/concerns/",
+      "#{config.root}/test/support/"
+    ]
 
     # Set up our default configuration options.
     initializer 'effective_test_bot.defaults', before: :load_config_initializers do |app|

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.20'.freeze
+  VERSION = '1.1.25'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -218,7 +218,15 @@ module EffectiveTestBotAssertions
   # assert_email :new_user_sign_up
   # assert_email :new_user_sign_up, to: 'newuser@example.com'
   # assert_email from: 'admin@example.com'
-  def assert_email(action = nil, to: nil, from: nil, subject: nil, body: nil, message: nil)
+  def assert_email(action = nil, to: nil, from: nil, subject: nil, body: nil, message: nil, &block)
+    if block_given?
+      before = ActionMailer::Base.deliveries.length
+      yield
+      after = ActionMailer::Base.deliveries.length
+
+      assert (after - before == 1), "(assert_email) Expected one email to have been delivered"
+    end
+
     if (action || to || from || subject || body).nil?
       assert ActionMailer::Base.deliveries.present?, message || "(assert_email) Expected email to have been delivered"
       return

data/test/support/effective_test_bot_form_faker.rb

@@ -5,6 +5,8 @@ require 'faker'
 module EffectiveTestBotFormFaker
   DIGITS = ('1'..'9').to_a
   LETTERS = %w(A B C E G H J K L M N P R S T V X Y) # valid letters of a canadian postal code, eh?
+  TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON']
+  FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF']
 
   # Generates an appropriately pseudo-random value for the given field
   # Pass in a Hash of fills to define pre-selected values
@@ -269,19 +271,11 @@ module EffectiveTestBotFormFaker
   end
 
   def truthy?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(value)
-    else
-      ActiveRecord::Type::Boolean.new.cast(value)
-    end
+    TRUE_VALUES.include?(value)
   end
 
   def falsey?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.include?(value)
-    else
-      ::ActiveRecord::Type::Boolean.new.cast(value) == false
-    end
+    FALSE_VALUES.include?(value)
   end
 
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -19,7 +19,8 @@ module EffectiveTestBotFormFiller
     active_tab = all("li.active > a[data-toggle='tab']", wait: false).first
 
     tab_content = if active_tab && active_tab['href'].present?
-      find('div' + active_tab['href']).find(:xpath, '..')
+      tab_href = '#' + active_tab['href'].split('#').last
+      find('div' + tab_href).find(:xpath, '..')
     end
 
     excluding_fields_with_parent(tab_content) { fill_form_fields(fills) }
@@ -129,6 +130,7 @@ module EffectiveTestBotFormFiller
     @filled_country_fields = nil
 
     save_test_bot_screenshot
+    true
   end
 
   def fill_input_text(field, value)

data/test/support/effective_test_bot_mocks.rb

@@ -0,0 +1,31 @@
+# https://github.com/codeodor/minitest-stub_any_instance
+
+# included on BasicObject when test_helper calls include EffectiveTestBot::DSL
+module EffectiveTestBotMocks
+  def stub_any_instance(name, val_or_callable = nil, &block)
+    new_name = "__minitest_any_instance_stub__#{name}"
+    owns_method = instance_method(name).owner == self
+
+    class_eval do
+      alias_method new_name, name if owns_method
+
+      define_method(name) do |*args|
+        if val_or_callable.respond_to? :call then
+          instance_exec(*args, &val_or_callable)
+        else
+          val_or_callable
+        end
+      end
+    end
+
+    yield
+  ensure
+    class_eval do
+      remove_method name
+      if owns_method
+        alias_method name, new_name
+        remove_method new_name
+      end
+    end
+  end
+end

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -7,17 +7,15 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_screenshot
-    return unless EffectiveTestBot.screenshots?
+    return unless EffectiveTestBot.gifs?
     return unless page.current_path.present?
-    
+
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")
     true
   end
 
   def save_test_bot_failure_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
-
     return unless save_test_bot_screenshot
 
     Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
@@ -28,7 +26,6 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_tour_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
     return unless (@test_bot_screenshot_id || 0) > 0
 
@@ -42,9 +39,12 @@ module EffectiveTestBotScreenshotsHelper
   def without_screenshots(&block)
     original = EffectiveTestBot.screenshots
 
-    EffectiveTestBot.screenshots = false
-    yield
-    EffectiveTestBot.screenshots = original
+    begin
+      EffectiveTestBot.screenshots = false
+      yield
+    ensure
+      EffectiveTestBot.screenshots = original
+    end
   end
 
   protected

data/test/test_botable/wizard_test.rb

@@ -24,7 +24,7 @@ module WizardTest
       # to click the last submit button on the page
       last = (paths[index-1] == page.current_path)
 
-      fills = (defined?(:fills) && respond_to?(:fills)) ? fills : {}
+      fills = (defined?(:fills) && respond_to?(:fills)) ? self.fills : {}
 
       if defined?(within_form) && respond_to?(:within_form)
         within(within_form) { fill_form(fills); submit_form(last: last); }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.20
+  version: 1.1.25
 platform: ruby
 authors:
 - Code and Effect
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-08 00:00:00.000000000 Z
+date: 2020-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -160,6 +160,7 @@ files:
 - test/support/effective_test_bot_form_helper.rb
 - test/support/effective_test_bot_login_helper.rb
 - test/support/effective_test_bot_minitest_helper.rb
+- test/support/effective_test_bot_mocks.rb
 - test/support/effective_test_bot_screenshots_helper.rb
 - test/support/effective_test_bot_test_helper.rb
 - test/test_bot/system/application_test.rb
@@ -175,7 +176,7 @@ homepage: https://github.com/code-and-effect/effective_test_bot
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -190,8 +191,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A shared library of rails model & system tests that should pass in every
   Rails application.