effective_test_bot 1.1.19 → 1.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 116adaca4228be8533d337f92a96fcdf4d28fddc776a150fe559b8eb4281beb3
-  data.tar.gz: af5084bcea6618b5d6406f83f9af3fb7987bafc833589f21859104020012bb6a
+  metadata.gz: eccff959a9793ba3408242d0ce772d74ffec74b5e814052ee6ee27086d934491
+  data.tar.gz: 631e4aca51755e878e549edc85547297bd630c199996b0a67ca34f36ed215e75
 SHA512:
-  metadata.gz: 69040edaa53da1a219372d6bfbd355c6b9aa691e18b71aa8c3d4fc6b9eb8e0864590b67b1ba8731097e0f5b6ef2b3c0459bf25019651c95797f759e22651fa91
-  data.tar.gz: d9158385fed96c09559d4e0954d1e5a274556789ab61cd2c09310892444beb17a4430a4bc9e448694d3fc8eb3da741d7f36f653f537c45e650a9ad433a76c31d
+  metadata.gz: db5b468dbb02f65c4e2050a77168c1559f30ec12e6d2f046a014e1a815b78450a93d3816956f3500b969fb8ec5cb6e0065f1040eef4649f4a7be780f4e1930cd
+  data.tar.gz: 7c997a7afa4c1875a44e32c4f8de06713f589d6b5e3a51ffa3e3a04c8c37b999d3d24feadae466d1d2f170e93be3666c1f4448f1f9d7ab5d6167a3c53c4227d1

data/lib/effective_test_bot.rb

@@ -66,7 +66,7 @@ module EffectiveTestBot
   end
 
   def self.gifs?
-    image_processing_class.present?
+    screenshots? && image_processing_class.present?
   end
 
   def self.image_processing_class
@@ -97,7 +97,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ENV['TOUR'].to_s != 'false'
     else
-      screenshots? && (tour_mode != false)
+      gifs? && (tour_mode != false)
     end
   end
 
@@ -106,7 +106,7 @@ module EffectiveTestBot
     if ENV['TOUR'].present?
       ['extreme', 'debug'].include?(ENV['TOUR'].to_s.downcase)
     else
-      screenshots? && ['extreme', 'debug'].include?(tour_mode.to_s)
+      gifs? && ['extreme', 'debug'].include?(tour_mode.to_s)
     end
   end
 

data/lib/effective_test_bot/engine.rb

@@ -2,10 +2,17 @@ module EffectiveTestBot
   class Engine < ::Rails::Engine
     engine_name 'effective_test_bot'
 
-    config.autoload_paths += Dir["#{config.root}/test/test_botable/", "#{config.root}/test/concerns/", "#{config.root}/test/support/"]
-    # config.autoload_paths += Dir["#{config.root}/test/test_botable/**/"]
-    # config.autoload_paths += Dir["#{config.root}/test/concerns/**/"]
-    # config.autoload_paths += Dir["#{config.root}/test/support/**/"]
+    config.autoload_paths += Dir[
+      "#{config.root}/test/test_botable/", 
+      "#{config.root}/test/concerns/", 
+      "#{config.root}/test/support/"
+    ]
+
+    config.eager_load_paths += Dir[
+      "#{config.root}/test/test_botable/", 
+      "#{config.root}/test/concerns/", 
+      "#{config.root}/test/support/"
+    ]
 
     # Set up our default configuration options.
     initializer 'effective_test_bot.defaults', before: :load_config_initializers do |app|

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.19'.freeze
+  VERSION = '1.1.24'.freeze
 end

data/test/support/effective_test_bot_assertions.rb

@@ -218,7 +218,15 @@ module EffectiveTestBotAssertions
   # assert_email :new_user_sign_up
   # assert_email :new_user_sign_up, to: 'newuser@example.com'
   # assert_email from: 'admin@example.com'
-  def assert_email(action = nil, to: nil, from: nil, subject: nil, body: nil, message: nil)
+  def assert_email(action = nil, to: nil, from: nil, subject: nil, body: nil, message: nil, &block)
+    if block_given?
+      before = ActionMailer::Base.deliveries.length
+      yield
+      after = ActionMailer::Base.deliveries.length
+
+      assert (after - before == 1), "(assert_email) Expected one email to have been delivered"
+    end
+
     if (action || to || from || subject || body).nil?
       assert ActionMailer::Base.deliveries.present?, message || "(assert_email) Expected email to have been delivered"
       return

data/test/support/effective_test_bot_form_faker.rb

@@ -5,6 +5,8 @@ require 'faker'
 module EffectiveTestBotFormFaker
   DIGITS = ('1'..'9').to_a
   LETTERS = %w(A B C E G H J K L M N P R S T V X Y) # valid letters of a canadian postal code, eh?
+  TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON']
+  FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF']
 
   # Generates an appropriately pseudo-random value for the given field
   # Pass in a Hash of fills to define pre-selected values
@@ -269,19 +271,11 @@ module EffectiveTestBotFormFaker
   end
 
   def truthy?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(value)
-    else
-      ActiveRecord::Type::Boolean.new.cast(value)
-    end
+    TRUE_VALUES.include?(value)
   end
 
   def falsey?(value)
-    if defined?(::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES)  # Rails 5
-      ::ActiveRecord::ConnectionAdapters::Column::FALSE_VALUES.include?(value)
-    else
-      ::ActiveRecord::Type::Boolean.new.cast(value) == false
-    end
+    FALSE_VALUES.include?(value)
   end
 
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -19,7 +19,8 @@ module EffectiveTestBotFormFiller
     active_tab = all("li.active > a[data-toggle='tab']", wait: false).first
 
     tab_content = if active_tab && active_tab['href'].present?
-      find('div' + active_tab['href']).find(:xpath, '..')
+      tab_href = '#' + active_tab['href'].split('#').last
+      find('div' + tab_href).find(:xpath, '..')
     end
 
     excluding_fields_with_parent(tab_content) { fill_form_fields(fills) }
@@ -129,6 +130,7 @@ module EffectiveTestBotFormFiller
     @filled_country_fields = nil
 
     save_test_bot_screenshot
+    true
   end
 
   def fill_input_text(field, value)

data/test/support/effective_test_bot_form_helper.rb

@@ -44,13 +44,14 @@ module EffectiveTestBotFormHelper
     true
   end
 
-  def fill_stripe(mm: '01')
+  # Fills in the Stripe Elements form
+  def fill_stripe(card_number: '4242 4242 4242 4242', mm: '01')
     stripe_iframe = find("iframe[src^='https://js.stripe.com/v3']")
     assert stripe_iframe.present?, 'unable to find stripe iframe'
 
     within_frame(stripe_iframe) do
-      fill_in('Card number', with: '4242424242424242')
-      fill_in('MM / YY', with: mm.to_s + (Time.zone.now.year + 1).to_s.last(2))
+      card_number.to_s.chars.each { |key| find_field('Card number').send_keys(key) }
+      fill_in('MM / YY', with: mm.to_s + (Time.zone.now.year + 2).to_s.last(2))
       fill_in('CVC', with: '123')
       fill_in('ZIP', with: '90210')
     end

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -7,17 +7,15 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_screenshot
-    return unless EffectiveTestBot.screenshots?
+    return unless EffectiveTestBot.gifs?
     return unless page.current_path.present?
-    
+
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")
     true
   end
 
   def save_test_bot_failure_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
-
     return unless save_test_bot_screenshot
 
     Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
@@ -28,7 +26,6 @@ module EffectiveTestBotScreenshotsHelper
   end
 
   def save_test_bot_tour_gif
-    return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
     return unless (@test_bot_screenshot_id || 0) > 0
 
@@ -42,9 +39,12 @@ module EffectiveTestBotScreenshotsHelper
   def without_screenshots(&block)
     original = EffectiveTestBot.screenshots
 
-    EffectiveTestBot.screenshots = false
-    yield
-    EffectiveTestBot.screenshots = original
+    begin
+      EffectiveTestBot.screenshots = false
+      yield
+    ensure
+      EffectiveTestBot.screenshots = original
+    end
   end
 
   protected

data/test/test_botable/wizard_test.rb

@@ -24,7 +24,7 @@ module WizardTest
       # to click the last submit button on the page
       last = (paths[index-1] == page.current_path)
 
-      fills = (defined?(:fills) && respond_to?(:fills)) ? fills : {}
+      fills = (defined?(:fills) && respond_to?(:fills)) ? self.fills : {}
 
       if defined?(within_form) && respond_to?(:within_form)
         within(within_form) { fill_form(fills); submit_form(last: last); }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.19
+  version: 1.1.24
 platform: ruby
 authors:
 - Code and Effect
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-07 00:00:00.000000000 Z
+date: 2020-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -175,7 +175,7 @@ homepage: https://github.com/code-and-effect/effective_test_bot
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -190,8 +190,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A shared library of rails model & system tests that should pass in every
   Rails application.