effective_test_bot 0.6.7 → 0.6.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e70c529e79a56be7660a51e42e6361514392f0d
-  data.tar.gz: 01331f562aa1b86336b63ef417c7077c26207fe6
+  metadata.gz: addba6a7997e4a369e13125bc2a58ee7daef0e60
+  data.tar.gz: 29f2ed1a40d36625bfb8a010e1a5653abece76f4
 SHA512:
-  metadata.gz: 058341e8cf7ea0321deeb5d9cfe64105ba66d797785594fb92f24a64598f1a5541dab8263d834c913c334eb45a0aff106c24f4c390155549340dd131c0179b71
-  data.tar.gz: 9dc78159d70bc057c883ef4b79ba1ec6b13766fa183e1320ee14d289009a49ad6c22a6e4b9c7006d2767d1a8383bc98552a1f8236544084a747c8943f8f8dce7
+  metadata.gz: ad4ffb7d07438ce61c84212f199c0539ca027d66f1ffc4a4176e07cbe0276b5b4038b8bdf2befcccd088d551b3d0520a4e9d2afa6039136ed647c4527770426a
+  data.tar.gz: b40772c6a5989f299db717109fa0fe35b402ba7f38dbbcc56bef3c299a6f0f107d14ab0dee887042b7b2324d514592ba6e32cc1f5311a250b7b6930ee9a25d17

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.6.7'.freeze
+  VERSION = '0.6.8'.freeze
 end

data/test/support/effective_test_bot_form_filler.rb

@@ -78,12 +78,14 @@ module EffectiveTestBotFormFiller
         value = value_for_field(field, fills)
         ckeditor_text_area?(field) ? fill_ckeditor_text_area(field, value) : field.set(value)
       when 'select'
+        value = value_for_field(field, fills)
+
         if EffectiveTestBot.tour_mode_extreme? && field['class'].to_s.include?('select2') # select2
           page.execute_script("try { $('select##{field['id']}').select2('open'); } catch(e) {};")
           save_test_bot_screenshot
         end
 
-        field.select(value_for_field(field, fills), match: :first)
+        field.select(value, match: :first) unless value == :unselect
 
         if EffectiveTestBot.tour_mode_extreme? && field['class'].to_s.include?('select2')
           page.execute_script("try { $('select##{field['id']}').select2('close'); } catch(e) {};")
@@ -101,6 +103,8 @@ module EffectiveTestBotFormFiller
         raise "unsupported field type #{[field.tag_name, field['type']].compact.join('_')}"
       end
 
+      wait_for_ajax
+
       if EffectiveTestBot.tour_mode_extreme?
         save_test_bot_screenshot unless skip_field_screenshot
       end
@@ -125,7 +129,7 @@ module EffectiveTestBotFormFiller
     attributes = field['name'].to_s.gsub(']', '').split('[') # user[something_attributes][last_name] => ['user', 'something_attributes', 'last_name']
     attribute = attributes.last.to_s
 
-    fill_value = fill_value_for_field(fills, attributes, field['value'])
+    fill_value = fill_value_for_field(fills, attributes, field['value'], field_name)
 
     # If there is a predefined fill value for this field return it now
     # except for select, checkbox and radio fields which we want to match by value or label
@@ -219,6 +223,8 @@ module EffectiveTestBotFormFiller
       value_for_input_radio_field(field, fill_value)
 
     when 'select'
+      return fill_value if fill_value == :unselect
+
       if fill_value.present? # accept a value or text
         field.all('option:enabled').each do |option|
           if (option.text == fill_value || option.value.to_s == fill_value)
@@ -388,12 +394,14 @@ module EffectiveTestBotFormFiller
 
   private
 
-  def fill_value_for_field(fills, attributes, value)
+  def fill_value_for_field(fills, attributes, value, field_name)
     return if fills.blank? || (attributes.blank? && value.blank?)
 
     key = nil
     attributes.reverse_each do |name|  # match last_name, then something_attributes.last_name, then user.something_attributes.last_name
       key = (key.present? ? "#{name}.#{key}" : name) # builds up the string as we go along
+
+      return :unselect if field_name == 'select' && fills.key?(key) && [nil, ''].include?(fills[key])
       return fills[key].to_s if fills.key?(key)
     end
 

data/test/support/effective_test_bot_form_helper.rb

@@ -80,6 +80,9 @@ module EffectiveTestBotFormHelper
 
     submit.click
     synchronize!
+
+    save_test_bot_screenshot if EffectiveTestBot.screenshots? && page.current_path.present?
+
     true
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.6.7
+  version: 0.6.8
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-05 00:00:00.000000000 Z
+date: 2017-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails