effective_test_bot 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a39eb4dbe99bb9e9e190dcdea42b98217e899fbb
-  data.tar.gz: f3de18d8e670326b43977a17eaec8abc1bc9afc1
+  metadata.gz: 533f4dfe9d458e6c298b9da728e511cc2346e466
+  data.tar.gz: 92e5aad66b7f4d7ef653324412c45b5cc6b445e9
 SHA512:
-  metadata.gz: 6602fcc1c63846384499ff4c3d20109dc113f20ed8e3d18f804e7a960da289dd15ab3700f7de6c45ea186963af1397627d7062abba896008bc1a00882e0259b4
-  data.tar.gz: 430925ce013e377568e84a0e12295694adb9fe13355f7cb8129c0191f2c1b0db44f302af128d412c70f3310af2af111db8530cbf394e9cd40b8f535f8ff2da77
+  metadata.gz: afec0dac31e2002a83206d087e4b3706b6966addfc8e63b5ec58461da5d020bd9f9d28ec4181c68e356758c6134fe4bb319a7b316548437989ca8f5cb4b71f6c
+  data.tar.gz: 328fcf108174c8348c251da7a5eaab777453b35bee4604ec36e997271e138e5bae4323f0fb1524147eec83847f505170be8c19254e818cbf0ea67e8a31f01d10

data/README.md

@@ -105,6 +105,7 @@ The following assertions are added for use in any integration test:
 
 - `assert_assigns` asserts a given rails view_assigns object is present.
 - `assert_assigns_errors` use after an intentionally invalid form submit to make sure your assigned rails object has errors, or a specific error.
+- `assert_authorization` checks for a 403 Access Denied error.  Add `assign_test_bot_access_denied_exception(exception)` to your ApplicationController's `rescue_from` block to generate more information.
 - `assert_no_assigns_errors` should be used after any form submit to make sure your assigned rails object has no errors.  Prints out any errors if they exist.
 - `assert_current_path(path)` asserts the current page path.
 - `assert_email(action)` asserts an email with the given action name was sent. Also supports `assert_email(to: email)` type syntax with to, from, subject, body.
@@ -253,10 +254,10 @@ There are a few variations on the one-liner method:
 ```ruby
 class PostsTest < Capybara::Rails::TestCase
   # Runs all 9 crud_action tests against /posts
-  crud_test(resource: Post, user: User.first)
+  crud_test(resource: Post)
 
   # Runs all 9 crud_action tests against /posts and use this Post's attributes when calling fill_form.
-  crud_test(resource: Post.new(title: 'my first post'), user: User.first)
+  crud_test(resource: Post.new(title: 'my first post'))
 
   # Runs all 9 crud_action tests against /admin/posts controller as a previously seeded or fixtured admin user
   crud_test(resource: 'admin/posts', user: User.where(admin: true).first)

data/app/helpers/effective_test_bot_controller_helper.rb

@@ -30,4 +30,23 @@ module EffectiveTestBotControllerHelper
       response.headers['Test-Bot-Unpermitted-Params'] = Base64.encode64(exception.params.to_json)
     end
   end
+
+  def assign_test_bot_access_denied_exception(exception)
+    return unless Rails.env.test?
+
+    response.headers['Test-Bot-Access-Denied'] = Base64.encode64({
+      exception: exception,
+      action: exception.action,
+      subject: (
+        if exception.subject.kind_of?(Symbol)
+          ":#{exception.subject}"
+        elsif exception.subject.class == Class
+          exception.subject.name
+        else
+          exception.subject.class.name
+        end
+      )
+    }.to_json)
+  end
+
 end

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.6.3'.freeze
+  VERSION = '0.6.4'.freeze
 end

data/test/concerns/test_botable/base_dsl.rb

@@ -116,6 +116,7 @@ module TestBotable
     end
 
     # Instance Methods
+    protected
 
     def test_bot_user(test_name)
       return @test_bot_user if @test_bot_user

data/test/support/effective_test_bot_assertions.rb

@@ -54,6 +54,21 @@ module EffectiveTestBotAssertions
     assert all("input[type='submit'],button[type='submit']").present?, message
   end
 
+  def assert_authorization(message = '(authorization) Expected authorized access')
+    if page.status_code == 403
+      exception = access_denied_exception
+
+      info = [
+        "Encountered a 403 Access Denied",
+        ("(cannot :#{exception['action']}, #{exception['subject']})" if exception.present?),
+        "on #{page.current_path} as user #{user || 'no user'}.",
+        ("\nAdd assign_test_bot_access_denied_exception(exception) to your ApplicationController's rescue_from block to gather more information." unless exception.present?),
+      ].compact.join(' ')
+
+      assert false, "#{message}.\n#{info}"
+    end
+  end
+
   def assert_page_status(status = 200, message = '(page_status) Expected :status: HTTP status code')
     assert_equal status, page.status_code, message.sub(':status:', status.to_s)
   end

data/test/support/effective_test_bot_form_helper.rb

@@ -30,6 +30,7 @@ module EffectiveTestBotFormHelper
     assert_no_unpermitted_params unless test_bot_skip?(:no_unpermitted_params)
     assert_no_assigns_errors unless test_bot_skip?(:no_assigns_errors)
     assert_no_exceptions unless test_bot_skip?(:exceptions)
+    assert_authorization unless test_bot_skip?(:authorization)
     assert_page_status unless test_bot_skip?(:page_status)
 
     true
@@ -45,7 +46,7 @@ module EffectiveTestBotFormHelper
   def clear_form
     all('input,select,textarea').each do |field|
       if field.tag_name == 'select' && field['class'].to_s.include?('select2') # effective_select
-        within(field.parent) { first(:css, '.select2-selection__clear').try(:click) }
+        within(field.query_scope) { first(:css, '.select2-selection__clear').try(:click) }
       end
 
       begin

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -95,7 +95,7 @@ module EffectiveTestBotScreenshotsHelper
 
   def current_test_failure_filename
     # Match Capybara-screenshots format-ish
-    "#{current_test_name.parameterize}_failure_#{Time.now.strftime('%Y-%m-%d-%H-%M-%S')}.gif"
+    "#{current_test_name.parameterize}-failure-#{Time.now.strftime('%Y-%m-%d-%H-%M-%S')}.gif"
   end
 
   # Where the tour animated gif ends up

data/test/support/effective_test_bot_test_helper.rb

@@ -69,8 +69,8 @@ module EffectiveTestBotTestHelper
     (JSON.parse(Base64.decode64(page.response_headers['Test-Bot-Unpermitted-Params'])) rescue [])
   end
 
-  def exceptions
-    (JSON.parse(Base64.decode64(page.response_headers['Test-Bot-Exceptions'])) rescue [])
+  def access_denied_exception
+    (JSON.parse(Base64.decode64(page.response_headers['Test-Bot-Access-Denied'])) rescue {})
   end
 
 end

data/test/test_botable/base_test.rb

@@ -8,6 +8,7 @@ module BaseTest
     return if test_bot_skip?(:normal)
 
     assert_no_exceptions unless test_bot_skip?(:exceptions)
+    assert_authorization unless test_bot_skip?(:authorization)
     assert_page_status unless test_bot_skip?(:page_status)
     assert_no_js_errors unless test_bot_skip?(:no_js_errors)
     assert_page_title unless (test_bot_skip?(:page_title) || all('head').blank? || was_download?)
@@ -51,7 +52,9 @@ module BaseTest
       assert(new_path.present?, "TestBotError: Generated polymorphic route new_#{[*controller_namespace, resource_name].compact.join('_')}_path is undefined. #{hint}")
 
       visit(new_path)
+
       assert_no_exceptions
+      assert_authorization(hint)
       assert_page_status
 
       assert_form("form#new_#{resource_name}", "TestBotError: Failed to find form#new_#{resource_name}. #{hint}") unless test_bot_skip?(:form)
@@ -63,6 +66,7 @@ module BaseTest
         submit_novalidate_form
 
         assert_no_exceptions
+        assert_authorization(hint)
         assert_page_status
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-03 00:00:00.000000000 Z
+date: 2017-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails