effective_test_bot 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 17d73d440defe13b300db9a9e3c40f2a53db6070
-  data.tar.gz: 500b99c205884123bf7b9ce81e62f824d246f9b8
+  metadata.gz: cc1ac662d4557b9818bec29117d6abc40cb11f96
+  data.tar.gz: 618b01ed2c8c6e6496917361a78e01f3b6a2e7c6
 SHA512:
-  metadata.gz: ad2a4c20896abdd48fdee19c8667dbd56fe636912f71dc4dd53bcb973540bf6d57926ebe3db010a5b7e05fe58615395ccd875d736dc03fcdbd49b0f973373917
-  data.tar.gz: a5233b7717d68155472fe8abd6cce85bd4b1e1e5a26bb312f1aaa169d0d8599e62c628b0c43557244bc8780ee85d892482c9d7be7b287063ad8b22cdbee4a859
+  metadata.gz: fd55d7c1210338f1075cba3e763c935cf31171656a72e96a5a58c22f0091693085cb134ff40896a44c849b70833b9afc368ba4c95aa10a95d074110a19be5196
+  data.tar.gz: 538c9f722ca137ec5ab14fb255a12ab6440d998a08fd738bdc73f845028291e810d02292273c832196766043ee21bb7e58ced10074703fa736d16956496afb45

data/lib/effective_test_bot.rb

@@ -117,6 +117,8 @@ module EffectiveTestBot
   def self.save_passed_test(name)
     EffectiveTestBot.passed_tests[name] = true
 
+    Dir.mkdir(passed_tests_path) unless File.exists?(passed_tests_path)
+
     File.open(passed_tests_filename, 'w') do |file|
       passed_tests.each { |test_name, _| file.puts(test_name) }
     end
@@ -167,8 +169,12 @@ module EffectiveTestBot
     end.compact.sort
   end
 
+  def self.passed_tests_path
+    "#{Rails.root}/tmp/test_bot"
+  end
+
   def self.passed_tests_filename
-    "#{Rails.root}/tmp/test_bot/passed_tests.txt"
+    "#{passed_tests_path}/passed_tests.txt"
   end
 
 end

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '0.5.5'.freeze
+  VERSION = '0.5.6'.freeze
 end

data/lib/generators/templates/effective_test_bot.rb

@@ -18,11 +18,11 @@ if Rails.env.test?
     # ]
 
     # Exits immediately if there is a test failure
-    config.fail_fast = true
+    config.fail_fast = false
 
     # Fill form fields with these values
     # Based on the input name
-    # :email => 'somethign@soneone.com', 'user.last_name' => 'hlwerewr'
+    # :email => 'j.smith@example.com', 'user.last_name' => 'Smith'
     config.form_fills = {}
 
     # Should capybara generate a series of *.png screenshots as it goes through the test?

data/test/concerns/test_botable/devise_dsl.rb

@@ -18,12 +18,13 @@ module TestBotable
 
       def devise_test(label: nil, **options)
         [:sign_up, :sign_in_valid, :sign_in_invalid].each do |test|
-          options[:current_test] = label || test
-          next if EffectiveTestBot.skip?(options[:current_test])
+          options_for_method = options.dup
+          options_for_method[:current_test] = label || test
+          next if EffectiveTestBot.skip?(options_for_method[:current_test])
 
-          method_name = test_bot_method_name('devise_test', options[:current_test])
+          method_name = test_bot_method_name('devise_test', options_for_method[:current_test])
 
-          define_method(method_name) { devise_action_test(test: test, **options) }
+          define_method(method_name) { devise_action_test(test: test, **options_for_method) }
         end
       end
 

data/test/test_botable/base_test.rb

@@ -38,26 +38,32 @@ module BaseTest
 
     # It doesn't exist, so lets go to the new page and submit a form to build one
     without_screenshots do
-      new_resource_paths = [  # TODO: enumerate all controller namespaces instead of just admin
-        (new_resource_path rescue nil),
-        (new_polymorphic_path(resource) rescue nil),
-        (new_polymorphic_path([:admin, resource]) rescue nil),
-        (new_polymorphic_path([:members, resource]) rescue nil)
-      ].compact
+      # TODO: enumerate all controller namespaces instead of just admin and members
+      new_path = (new_resource_path rescue nil)
+      new_path ||= (new_polymorphic_path(resource) rescue nil)
+      new_path ||= (new_polymorphic_path([:admin, resource]) rescue nil)
+      new_path ||= (new_polymorphic_path([:members, resource]) rescue nil)
 
-      hint = "Unable to find_or_create_resource!\nEither fixture/seed an instance of #{resource_class} or ensure that submitting form#new_#{resource_name} on #{(new_resource_paths.first rescue nil) || 'the resource new page'} creates a new #{resource_name}"
+      hint = "Unable to find_or_create_resource!\n"
+      hint += "Either fixture/seed an instance of #{resource_class} or ensure that submitting form#new_#{resource_name} "
+      hint += "on #{(new_path rescue nil) || 'the resource new page'} creates a new #{resource_name}"
 
-      assert(new_resource_paths.present?, "TestBotError: Generated polymorphic route new_#{[*controller_namespace, resource_name].compact.join('_')}_path is undefined. #{hint}")
+      assert(new_path.present?, "TestBotError: Generated polymorphic route new_#{[*controller_namespace, resource_name].compact.join('_')}_path is undefined. #{hint}")
 
-      visit(new_resource_paths.first)
+      visit(new_path)
+      assert_no_exceptions
+      assert_page_status
 
       assert_form("form#new_#{resource_name}", "TestBotError: Failed to find form#new_#{resource_name}. #{hint}") unless test_bot_skip?(:form)
 
       within_if("form#new_#{resource_name}", !test_bot_skip?(:form)) do
-        fill_form(resource_attributes)
+        assert_submit_input("TestBotError: Failed to find a visible input[type='submit'] on #{page.current_path}. #{hint}")
 
-        assert_submit_input "TestBotError: Failed to find a visible input[type='submit'] on #{page.current_path}. #{hint}"
+        fill_form(resource_attributes)
         submit_novalidate_form
+
+        assert_no_exceptions
+        assert_page_status
       end
 
       obj = resource_class.last

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.6
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-03 00:00:00.000000000 Z
+date: 2016-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails